From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web08.6825.1619166227842259676 for ; Fri, 23 Apr 2021 01:23:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=PHL/Nr9i; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0747fe8539=daniel.schaefer@hpe.com) Received: from pps.filterd (m0148663.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13N8IfOZ030057; Fri, 23 Apr 2021 08:23:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pps0720; bh=ao0CZ5rtJcLHgzCPzO8Ckk+jEAe4tHL1Z5+bqfaRQNQ=; b=PHL/Nr9iQZ4rvkZeXsng1z/dT9ev3ZET+EjKATOLISB7U95Kt9HIgnT2jAiYW2sdiE8m 59iWDbiBy+QZWUrP3MTGLuQn7AxI/Vv+nKhKGBVT3qZletvoOTSJtT+Vg1WyLqqw5CXm k+kXwCl3eYS9+O4zNxSm9AfA5p2NVfPwk8nRox6ywdEM9AhgN8BQpa4OX1xNahIeeRyD geWcJL87bR72c+jYoL1StoaB2XGv4jiHTJNm0rc02FRb7WzSma5bqIpYtFZu3ejrqM1D qWRU0jGyyymg7PR8Vj4z9sOvHyyXSvlTe1maEzgPEceS/Ud/Qt2x4Q8XY203YxsV1jSD sg== Received: from g4t3426.houston.hpe.com (g4t3426.houston.hpe.com [15.241.140.75]) by mx0a-002e3701.pphosted.com with ESMTP id 3836etsuaj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Apr 2021 08:23:42 +0000 Received: from G2W6310.americas.hpqcorp.net (g2w6310.austin.hp.com [16.197.64.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3426.houston.hpe.com (Postfix) with ESMTPS id 6B9BC4F; Fri, 23 Apr 2021 08:23:41 +0000 (UTC) Received: from G4W9120.americas.hpqcorp.net (2002:10d2:150f::10d2:150f) by G2W6310.americas.hpqcorp.net (2002:10c5:4034::10c5:4034) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 23 Apr 2021 08:22:14 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (15.241.52.10) by G4W9120.americas.hpqcorp.net (16.210.21.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 23 Apr 2021 08:22:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZHfh3wXp5nHgTYG8ZTZpu0fqtuoRnNM8Zh2blw6sNqRuWLVPvhNQQb/kdrZJuOniMxiFEakm1tB/VJYFnw2D7bz15+OP4WqADr/r6PlS7slWgC4WU/WwSB8oPJEFEIK0GruKWgq3QtCoMN1xmd4jeX4OLg+WzdP5zpFhw3jcpPRLwVQpiL9RjGSXuk5X7QvQmLeKOcRNWkf9VPRRDpKRlXyTw5ahoj0pvHO2SvhTpPZYiI0uzHIixRCXstIqcQsH0EodVQpkcfvRgklZwLHZrrH2fEhopypKnPRP+1kCHBNByUlJSyUJu6rwqETivaA15zNw23GoOfkHMTb6dF5SPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/Eh3iAGswBxlOqWddMtjqJ7hE7dqaBSVchDJYvhia/k=; b=mj+b49kUPyMMcdfVbJJB380FBBIm/f/k2KS8jNjJedbiH6tDJJRKObyEwCde1Ftsa+27cKli0MroNagnInXWVa7t+C7r4+3B31eRmR5BSCL4aYqMui+y6jkZcT7Q4rY9KmSLhXiaBWPgwcz73ZJkQhQrmMZajS6pGAs8mwx5kf7YzEDNCbeklw6I0cCVCYN4jNOayVZMq9C28rfdAPKCLfd1mZjK0ffQyXJd+mIp7bJC9r5cioHNHWrsXZy+Ry3OOSa9I3jGmivQ4hfJCoVl1edhAoTd9oFtIML6gbeLUlR1l/7C5+neIHWaj7GiDLFTS1ndcIFuYR8up+objO3uPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::23) by DF4PR8401MB1194.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7611::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.18; Fri, 23 Apr 2021 08:22:11 +0000 Received: from DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM ([fe80::1055:761b:7ee6:52ca]) by DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM ([fe80::1055:761b:7ee6:52ca%11]) with mapi id 15.20.4042.024; Fri, 23 Apr 2021 08:22:11 +0000 From: "Daniel Schaefer" To: "Feng, Bob C" , "devel@edk2.groups.io" , "Schaefer, Daniel" CC: Liming Gao , "Chen, Christine" , "Lin, Derek (HPS SW)" Subject: Re: [edk2-devel] [PATCH v1 1/2] BaseTools: Make undefined VFR macro an error (GCC) Thread-Topic: [edk2-devel] [PATCH v1 1/2] BaseTools: Make undefined VFR macro an error (GCC) Thread-Index: AQHXDz0k2a1YuR3iFEml6teeqJ/Obap5T8qAgAArzriASJlG0Q== Date: Fri, 23 Apr 2021 08:22:11 +0000 Message-ID: References: <20210302082150.15478-1-daniel.schaefer@hpe.com> <20210302082150.15478-2-daniel.schaefer@hpe.com>,,<166A41333DA0F959.3944@groups.io> In-Reply-To: <166A41333DA0F959.3944@groups.io> Accept-Language: en-US, de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [15.195.185.81] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: df05bfb9-42c6-4e5c-1b15-08d90630e4d3 x-ms-traffictypediagnostic: DF4PR8401MB1194: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NG0Sqd4CjVuiCrmUrfhMR0UhmFcG7eL51jb26hVLdGcMVLzeVRtG76TOSbnH1glIE4fL9irfvas6xQRqNhg4/eU/23vB5d3M8BpwRnI62H3CiPRNULYIh3LIxcjjgAjCNNJEYEnew1zTHH2OqNGvpoGrnDbtvsUGKuKRvMDtGHWf0Bv/g2Rqs84sRgdizB5qWzHeXQ4MKha/XgBd6TdIdCGh+zEInyKaUc9wt3R71XUpOkOO9OzRi0nKva2+7oBoqb2mXosbl4NHI/8oeVd2z21FW9DKSflrjdunITY+fMaZX5ITiNGSr8riJav97drWAZsxaZ4QlR7MAwuxY4tpPzVoKyRtkBbNFNLKPjksgIVbH0SHrCS60kkJZy56uZMs2cum/SZcaRRP/ggURDYmvsWmVruMbV50OlmtrmkCHNvjLfsMruXzURrfK2venAzhejWTk/5rhOirahdGTXhq3FvQo7GEPIjGNK5G18WBXrpDrJHuP+AaAUkwzZ8v9vhBT0vaZwp4DcPqDxkTIiq4YdLopUO2sy7UtzWyQRpJvZYf/Dj/p4FOsa30VNJhikxvSYmpnXP5oQ4tyrGWcFHFOq+dtZUtv3mqjSNQ6+e5atQ+wSlYXazs5bVEIoiKax3WCYkIzhHMS+XMwkrtHAMe2KxirhwxSCR7BAQFIRr1Y2zS6b243BxBREL3Ag4rNlMH x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(396003)(376002)(346002)(366004)(39860400002)(136003)(60390400001)(33656002)(52536014)(2906002)(26005)(76236003)(316002)(66556008)(54906003)(55016002)(53546011)(186003)(110136005)(8676002)(71200400001)(8936002)(9686003)(83380400001)(66446008)(91956017)(64756008)(7696005)(4326008)(76116006)(45080400002)(86362001)(66946007)(5660300002)(122000001)(38100700002)(19627405001)(6506007)(166002)(66476007)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?UCIDYqYdYWxi6/dP0ax2P/SekPO0hEXPXa/bAlQmAGaLRM3YDJYJTfmZNdoz?= =?us-ascii?Q?I4FpuVdC8EmPFGvYsO32NKpjKh7LRs9AnMpmiaFwma+EjdF37+wcaqSmPNTu?= =?us-ascii?Q?hJ3Yodtt5pv2JlE9tcMwHUgiiZNaH7sRcfEejybITa7K6mv/WfR7+sGx2DYV?= =?us-ascii?Q?xddi3Mj+LCPuOgPg6Qm7NI0lXbSzI3fufM8OAi85rrtq9DrcuGLhNeKwwEag?= =?us-ascii?Q?K8YRgvKxRQDtVC1fvmWNSfrUj6e1QXTwEdXYuTCL0ERYgdaRXaKFuErNCQT3?= =?us-ascii?Q?UlK3P4kRjj0wju9qLy8nNjVvLw2fAJU01NSVKqZp3QLWHdOR0Rsg2a8DV5L+?= =?us-ascii?Q?yAkLZYzDmx3tHr10rlJqp/bj9s4fq9DoxHd4prpcm9afwClYL4TRJGnMT4kz?= =?us-ascii?Q?gTLoG7B7a+wk13Q5FT+iBlk5Gf3aJ8nlD5t/mVCQbBLJbXkjJLUXRTGHnDoN?= =?us-ascii?Q?jfuzzQ6DLP7WlahOx2Q6T6NjV0J9otn5HRchPG7yWWJuW1+rWQCsw1r9xZLV?= =?us-ascii?Q?FbrNgMK8vVUk/0qea4VB6ODAs8brX6U7NOLfTsIjucEbvzJyHyjbNyv7hvUo?= =?us-ascii?Q?w6QBBu6WVjNs+sH0He6kKUbEWC3+IyAV85TXXN2tdsP0fdkGKoKpu4zWnsXR?= =?us-ascii?Q?6T364EeDf4dDcPfnmEXN9phj0YqS+z1tjGQQZJTBW0+//MRvewdbMwwbrtZq?= =?us-ascii?Q?OpCB2CLftTY0xwM9Jwx4zcA7g+IBM9br+KkX9PNJE+ay8kGNWGzA+iyRkTkN?= =?us-ascii?Q?1Ec42VbJMome0tzqHHUGruv2AXpsV2rgtQgwf2agd3E4jF2ODgd6hPRbgyTl?= =?us-ascii?Q?GvyzBUOouSE+S8DLoCUCC8kTuu/X4fLBDjffqYZFiYklJqGBlPgCjpn7PcvQ?= =?us-ascii?Q?BnlPs57Gnjh/jvfylfaEWPlxMAM7414XKwdf3/RBRei+sis8D35NV0INmeVh?= =?us-ascii?Q?2tTYcI/4uQHa5RzwIp/4lLxdYX+fiK7sylRuykaMmt12JWicnztwXuEdS3uo?= =?us-ascii?Q?BNt8d4GMOgAadW28Cm3b4leSyRD9EoZTSsI/fDFD9yFN1fiIN1FnNTNem9Cs?= =?us-ascii?Q?HkMUX9M5VaV4YADuayfSPixehX6yFqHEzQr58idkOOMPt8GCHapv932kVwgY?= =?us-ascii?Q?oRplHImhyyGDn+4J2aakyl/BDyMFCT+GwBYdrHNoIe7eMWmnTn890F+a/R6J?= =?us-ascii?Q?QwjWkUhSJCuz6COx1Kvo86FuXy4d3ZvAQ4fdkbgufks/seMdTI7i4xWpYafh?= =?us-ascii?Q?VvYLsnqj9MOAgmCLmUo1oSFuwNPB+fWjK8qmC1uZmetjGb8bDN/lt7tBMlm0?= =?us-ascii?Q?rlm6YOoH0wc/5Ny++tYlcNeF?= X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: df05bfb9-42c6-4e5c-1b15-08d90630e4d3 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2021 08:22:11.5143 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mEilams0MjLaxhFXE2qGgGhJFvWVin9xymCkmePAHRqTwneZAPAySzU07uGLgTCAyPrOZoXouaELaXuRSflKSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB1194 X-OriginatorOrg: hpe.com X-Proofpoint-GUID: khCknSNg4x13JXajZvFET4Sow4CUThkM X-Proofpoint-ORIG-GUID: khCknSNg4x13JXajZvFET4Sow4CUThkM X-Proofpoint-UnRewURL: 10 URL's were un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-04-22_15:2021-04-22,2021-04-22 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 suspectscore=0 malwarescore=0 adultscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 mlxlogscore=999 bulkscore=0 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104230051 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DF4PR8401MB0444B3ED7E9B68951D8CBB07E0459DF4PR8401MB0444_" --_000_DF4PR8401MB0444B3ED7E9B68951D8CBB07E0459DF4PR8401MB0444_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ok sure, let's make only undef an error, not all other warnings. Then the b= ehaviour will also be the same as on MSVC. ________________________________ From: devel@edk2.groups.io on behalf of Daniel Scha= efer Sent: Monday, March 8, 2021 11:44 To: Feng, Bob C ; devel@edk2.groups.io Cc: Liming Gao ; Chen, Christine ; Lin, Derek (HPS SW) Subject: Re: [edk2-devel] [PATCH v1 1/2] BaseTools: Make undefined VFR mac= ro an error (GCC) It didn't cause any other errors for the huge HPE codebase. Only undefined= macros. I don't believe the preprocessor has so many warnings anyways. So -Werror should be fine. ________________________________ From: Feng, Bob C Sent: Monday, March 8, 2021 09:05 To: devel@edk2.groups.io ; Schaefer, Daniel Cc: Liming Gao ; Chen, Christine ; Lin, Derek (HPS SW) Subject: RE: [edk2-devel] [PATCH v1 1/2] BaseTools: Make undefined VFR mac= ro an error (GCC) Hi Derek, -Werror. Make all warnings into errors. Should here be that only treat undef warning as error? Thanks, Bob -----Original Message----- From: devel@edk2.groups.io On Behalf Of Daniel Scha= efer Sent: Tuesday, March 2, 2021 4:22 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao ; Chen, Christine ; Derek Lin Subject: [edk2-devel] [PATCH v1 1/2] BaseTools: Make undefined VFR macro a= n error (GCC) VFR successfully compiles if we forget to include a header that defines a = macro. In that case the HII option was hidden when it shouldn't be just bec= ause the macro was used but not defined. The behaviour is totally intended by the C/PP standard. When a macro is un= defined it evaluates to 0. GCC, MSVC and Clang have warnings to catch this type of mistake. With this= commit we enable this warning and make it a compiler error. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: Derek Lin --- BaseTools/Conf/tools_def.template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.= template index 933b3160fd2b..728c1d3119e4 100755 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tools_def.template @@ -3,7 +3,7 @@ # Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved. # Portions copyright (c) 2011 - 2019, ARM Ltd. All rights reserved.
= # Copyright (c) 2015, Hewlett-Packard Development Company, L.P.
-# = (C) Copyright 2020, Hewlett Packard Enterprise Development LP
+# (C) Copyright 2020-2021, Hewlett Packard Enterprise Development +LP
# Copyright (c) Microsoft Corporation # # SPDX-License-Identifier: BSD-2-Clause-Patent @@ -1938,7 +1938,7 @@ DEF= INE GCC_AARCH64_ASLDLINK_FLAGS =3D DEF(GCC_AARCH64_DLINK_FLAGS) -Wl,--entr= y,Re DEFINE GCC_IA32_X64_DLINK_FLAGS =3D DEF(GCC_IA32_X64_DLINK_COMMON) --e= ntry _$(IMAGE_ENTRY_POINT) --file-alignment 0x20 --section-alignment 0x20 -= Map $(DEST_DIR_DEBUG)/$(BASE_NAME).map DEFINE GCC_ASM_FLAGS =3D -c -x assembler -imacros AutoGen.h DEFINE GCC_PP_FLAGS =3D -E -x assembler-with-cpp -include = AutoGen.h -DEFINE GCC_VFRPP_FLAGS =3D -x c -E -P -DVFRCOMPILE --include = $(MODULE_NAME)StrDefs.h +DEFINE GCC_VFRPP_FLAGS =3D -x c -E -P -DVFRCOMPILE --include = $(MODULE_NAME)StrDefs.h -Wundef -Werror DEFINE GCC_ASLPP_FLAGS =3D -x c -E -include AutoGen.h DEFINE GCC_ASLCC_FLAGS =3D -x c DEFINE GCC_WINDRES_FLAGS =3D -J rc -O coff -- 2.30.0 --_000_DF4PR8401MB0444B3ED7E9B68951D8CBB07E0459DF4PR8401MB0444_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Ok sure, let's make only undef an error, not all other warnings. Then the = behaviour will also be the same as on MSVC.
From: devel@edk2.groups.io= <devel@edk2.groups.io> on behalf of Daniel Schaefer <daniel.schae= fer@hpe.com>
Sent: Monday, March 8, 2021 11:44
To: Feng, Bob C <bob.c.feng@intel.com>; devel@edk2.groups.io = <devel@edk2.groups.io>
Cc: Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine &l= t;yuwei.chen@intel.com>; Lin, Derek (HPS SW) <derek.lin2@hpe.com><= br> Subject: Re: [edk2-devel] [PATCH v1 1/2] BaseTools: Make undefined = VFR macro an error (GCC)
 
It didn't cause any other errors for the huge HPE codebase. Only unde= fined macros. I don't believe the preprocessor has so many warnings anyways= .
So -Werror should be fine.

From: Feng, Bob C <bo= b.c.feng@intel.com>
Sent: Monday, March 8, 2021 09:05
To: devel@edk2.groups.io <devel@edk2.groups.io>; Schaefer, Da= niel <daniel.schaefer@hpe.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine &l= t;yuwei.chen@intel.com>; Lin, Derek (HPS SW) <derek.lin2@hpe.com><= br> Subject: RE: [edk2-devel] [PATCH v1 1/2] BaseTools: Make undefined = VFR macro an error (GCC)
 
Hi Derek,

-Werror.  Make all warnings into errors.

Should here be that only treat undef warning as error?

Thanks,
Bob

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Danie= l Schaefer
Sent: Tuesday, March 2, 2021 4:22 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byo= soft.com.cn>; Chen, Christine <yuwei.chen@intel.com>; Derek Lin &l= t;derek.lin2@hpe.com>
Subject: [edk2-devel] [PATCH v1 1/2] BaseTools: Make undefined VFR macro a= n error (GCC)

VFR successfully compiles if we forget to include a header that defines a = macro. In that case the HII option was hidden when it shouldn't be just bec= ause the macro was used but not defined.

The behaviour is totally intended by the C/PP standard. When a macro is un= defined it evaluates to 0.
GCC, MSVC and Clang have warnings to catch this type of mistake. With this= commit we enable this warning and make it a compiler error.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Cc: Derek Lin <derek.lin2@hpe.com>
---
 BaseTools/Conf/tools_def.template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.= template
index 933b3160fd2b..728c1d3119e4 100755
--- a/BaseTools/Conf/tools_def.template
+++ b/BaseTools/Conf/tools_def.template
@@ -3,7 +3,7 @@
 #  Portions copyright (c) 2008 - 2009, Apple Inc. All rights re= served.<BR>  #  Portions copyright (c) 2011 - 2019, ARM Ltd= . All rights reserved.<BR>  #  Copyright (c) 2015, Hewlett-= Packard Development Company, L.P.<BR> -#  (C) Copyright 2020, He= wlett Packard Enterprise Development LP<BR>
+#  (C) Copyright 2020-2021, Hewlett Packard Enterprise Development <= br> +LP<BR>
 #  Copyright (c) Microsoft Corporation
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent @@ -1938,7 +193= 8,7 @@ DEFINE GCC_AARCH64_ASLDLINK_FLAGS  =3D DEF(GCC_AARCH64_DLINK_FL= AGS) -Wl,--entry,Re
 DEFINE GCC_IA32_X64_DLINK_FLAGS    =3D DEF(GCC_IA32_X= 64_DLINK_COMMON) --entry _$(IMAGE_ENTRY_POINT) --file-alignment 0x20 --sect= ion-alignment 0x20 -Map $(DEST_DIR_DEBUG)/$(BASE_NAME).map
 DEFINE GCC_ASM_FLAGS        =        =3D -c -x assembler -imacros AutoGen.h=
 DEFINE GCC_PP_FLAGS        &= nbsp;       =3D -E -x assembler-with-cpp -inc= lude AutoGen.h
-DEFINE GCC_VFRPP_FLAGS        &nb= sp;    =3D -x c -E -P -DVFRCOMPILE --include $(MODULE_NAME)S= trDefs.h
+DEFINE GCC_VFRPP_FLAGS        &nb= sp;    =3D -x c -E -P -DVFRCOMPILE --include $(MODULE_NAME)S= trDefs.h -Wundef -Werror
 DEFINE GCC_ASLPP_FLAGS       &nbs= p;     =3D -x c -E -include AutoGen.h
 DEFINE GCC_ASLCC_FLAGS       &nbs= p;     =3D -x c
 DEFINE GCC_WINDRES_FLAGS       &n= bsp;   =3D -J rc -O coff
--
2.30.0






--_000_DF4PR8401MB0444B3ED7E9B68951D8CBB07E0459DF4PR8401MB0444_--