Re: [edk2-devel] [edk2-platforms PATCH v4 11/12] RISC-V Platforms: add SecureBootVariableLib class resolution

["Daniel Schaefer" <daniel.schaefer@hpe.com>]

[-- Attachment #1: Type: text/plain, Size: 5097 bytes --]

Reviewed-by: Daniel Schaefer <daniel.schaefer@hpe.com>
________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Abner Chang <abner.chang@hpe.com>
Sent: Thursday, July 1, 2021 11:50
To: devel@edk2.groups.io <devel@edk2.groups.io>; gjb@semihalf.com <gjb@semihalf.com>
Cc: leif@nuviainc.com <leif@nuviainc.com>; ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>; Samer.El-Haj-Mahmoud@arm.com <Samer.El-Haj-Mahmoud@arm.com>; sunny.Wang@arm.com <sunny.Wang@arm.com>; mw@semihalf.com <mw@semihalf.com>; upstream@semihalf.com <upstream@semihalf.com>; jiewen.yao@intel.com <jiewen.yao@intel.com>; jian.j.wang@intel.com <jian.j.wang@intel.com>; min.m.xu@intel.com <min.m.xu@intel.com>; lersek@redhat.com <lersek@redhat.com>; sami.mujawar@arm.com <sami.mujawar@arm.com>; afish@apple.com <afish@apple.com>; ray.ni@intel.com <ray.ni@intel.com>; jordan.l.justen@intel.com <jordan.l.justen@intel.com>; rebecca@bsdio.com <rebecca@bsdio.com>; grehan@freebsd.org <grehan@freebsd.org>; thomas.abraham@arm.com <thomas.abraham@arm.com>; chasel.chiu@intel.com <chasel.chiu@intel.com>; nathaniel.l.desimone@intel.com <nathaniel.l.desimone@intel.com>; gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; eric.dong@intel.com <eric.dong@intel.com>; michael.d.kinney@intel.com <michael.d.kinney@intel.com>; zailiang.sun@intel.com <zailiang.sun@intel.com>; yi.qian@intel.com <yi.qian@intel.com>; graeme@nuviainc.com <graeme@nuviainc.com>; rad@semihalf.com <rad@semihalf.com>; pete@akeo.ie <pete@akeo.ie>
Subject: Re: [edk2-devel] [edk2-platforms PATCH v4 11/12] RISC-V Platforms: add SecureBootVariableLib class resolution

Reviewed-by: Abner Chang <abner.chang@hpe.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Grzegorz Bernacki
> Sent: Wednesday, June 30, 2021 8:34 PM
> To: devel@edk2.groups.io
> Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Samer.El-Haj-
> Mahmoud@arm.com; sunny.Wang@arm.com; mw@semihalf.com;
> upstream@semihalf.com; jiewen.yao@intel.com; jian.j.wang@intel.com;
> min.m.xu@intel.com; lersek@redhat.com; sami.mujawar@arm.com;
> afish@apple.com; ray.ni@intel.com; jordan.l.justen@intel.com;
> rebecca@bsdio.com; grehan@freebsd.org; thomas.abraham@arm.com;
> chasel.chiu@intel.com; nathaniel.l.desimone@intel.com;
> gaoliming@byosoft.com.cn; eric.dong@intel.com;
> michael.d.kinney@intel.com; zailiang.sun@intel.com; yi.qian@intel.com;
> graeme@nuviainc.com; rad@semihalf.com; pete@akeo.ie; Grzegorz
> Bernacki <gjb@semihalf.com>
> Subject: [edk2-devel] [edk2-platforms PATCH v4 11/12] RISC-V Platforms:
> add SecureBootVariableLib class resolution
>
> The edk2 patch
>   SecurityPkg: Create library for setting Secure Boot variables.
>
> removes generic functions from SecureBootConfigDxe and places
> them into SecureBootVariableLib. This patch adds SecureBootVariableLib
> mapping for each RICS-V platform which uses SecureBootConfigDxe.
>
> Signed-off-by: Grzegorz Bernacki <gjb@semihalf.com>
> ---
>  Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc           | 1 +
>
> Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
> | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> index b91823ceeb..fc5ba2a07f 100644
> --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> @@ -122,6 +122,7 @@
>    OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
>
> TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTp
> mMeasurementLib.inf
>    AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
> +
> SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureB
> ootVariableLib.inf
>  !else
>
> TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/Tp
> mMeasurementLibNull.inf
>
> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableL
> ibNull.inf
> diff --git
> a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d
> sc
> b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.
> dsc
> index 0eafe29880..71add8ff9a 100644
> ---
> a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d
> sc
> +++
> b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.
> dsc
> @@ -122,6 +122,7 @@
>    OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
>
> TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTp
> mMeasurementLib.inf
>    AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
> +
> SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureB
> ootVariableLib.inf
>  !else
>
> TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/Tp
> mMeasurementLibNull.inf
>
> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableL
> ibNull.inf
> --
> 2.25.1
>
>
>
>
>







[-- Attachment #2: Type: text/html, Size: 6944 bytes --]