From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web10.3274.1625118215175630409 for ; Wed, 30 Jun 2021 22:43:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=kpNR5Vz3; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0816b21464=daniel.schaefer@hpe.com) Received: from pps.filterd (m0134422.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 1615goak025629; Thu, 1 Jul 2021 05:43:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pps0720; bh=ISOTitz0o7Qzs0lOgWJbWDdlEx97wh9eL+AX21VCwyg=; b=kpNR5Vz3SKaiE3v/fhSe83+u8QpOwLr/YJWi4SUxWO9TviyO4wDzFSz1FE71/aThWbPi iTIG9XDDLUiGr6qWbVfea0SkQbF5f6FyysGzJZueiLBEHQyd2xXHoV3ZP+cJo+hdzS16 AIIBoxeSkvaH4T7+3y729jiaCOsXW4Kkio4+ju4X1LeXW6IJPsg9PDAbQgNzdMzHzONu JTAN/2FjjNJv3IWKxpHB91x31YS4PEeIyz7lm+EsE7HF9YDzpC045hHchhZTnQXDyJ1U bSakD0+7dPmrjEO6STyS9oQTlPDuk6mifdnJCTY4HeLExSZCgPCNGgJEaDb01rabVo4x Ig== Received: from g9t5009.houston.hpe.com (g9t5009.houston.hpe.com [15.241.48.73]) by mx0b-002e3701.pphosted.com with ESMTP id 39gv7359ux-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Jul 2021 05:43:05 +0000 Received: from G2W6311.americas.hpqcorp.net (g2w6311.austin.hp.com [16.197.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5009.houston.hpe.com (Postfix) with ESMTPS id 4446463; Thu, 1 Jul 2021 05:43:04 +0000 (UTC) Received: from G4W9335.americas.hpqcorp.net (16.208.33.85) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Thu, 1 Jul 2021 05:43:04 +0000 Received: from G9W9209.americas.hpqcorp.net (2002:10dc:429c::10dc:429c) by G4W9335.americas.hpqcorp.net (2002:10d0:2155::10d0:2155) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Thu, 1 Jul 2021 05:43:03 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (15.241.52.12) by G9W9209.americas.hpqcorp.net (16.220.66.156) with Microsoft SMTP Server (TLS) id 15.0.1497.18 via Frontend Transport; Thu, 1 Jul 2021 05:43:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c4zwY4nMf+pVccXZLJ9hiGznhDCKi87tMkMj9XL6flgJHb/iZIGwTJJGGBY8wPo5jjzZpTzgy3A8mReBxmNizP6Y6cqoV+OjWQYQ1E8hBpvQxQxFfQurELYM3VY+PPr1KAuOv6qBQNNFznBQGFnPdb7RZIcl9x8NgCfSfbje5MGyDUksDxdBJmcdb/F+0jDzDWY9FO2AjjlZNpnZzRXvDsV33PGPQn/HWGoxG+IAkMyliDP7+mPLdyPiR2cNfNwQRqkBEDvepO4oArfaQoiMQU7/+NrSL6UXpe2MRnzGoV57vDXkBXDK40C0BPF8DxnMejk9k9LDcLEI1nf9hYaAuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cCFwZyyMDU/QaAuu2qUsSIR9PkWumMMZ3GsT+1x44gM=; b=PjWxJ8aM/iy62lGCJK047N/GHPFMafEX699RjPUkOLcGbFLDXby84uGnmRlth3LA2e1e+HzWd8EIR4HdXb8Fpx2Ds6K4iLXSjSBG5IvSNdlg/gYmodYGtdSa51MwuzLb4CQtIWGmukUHxyQqGFF3EKPFhgR1GxfqIRKiKVBfZASju3T0OM9WoF3A1hdpyh3G8nGnklO13Atx2pRKpw71l9H2pWOFQ8sDZtgs+wB0w52CHHjZ5tAWSbzTcS6N1xH/rbHOOUvD7t8NpjGSsr5IvM/eO48vzXtz05H1cDt0zc8aI6mLbcYFwr2Bl11EnKAXBsUh9nUuoX6iHaAgrM2D7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::23) by DF4PR8401MB0346.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.23; Thu, 1 Jul 2021 05:43:01 +0000 Received: from DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c804:b24:831b:272a]) by DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c804:b24:831b:272a%5]) with mapi id 15.20.4287.023; Thu, 1 Jul 2021 05:43:01 +0000 From: "Daniel Schaefer" To: "devel@edk2.groups.io" , "gjb@semihalf.com" , "Chang, Abner (HPS SW/FW Technologist)" CC: "leif@nuviainc.com" , "ardb+tianocore@kernel.org" , "Samer.El-Haj-Mahmoud@arm.com" , "sunny.Wang@arm.com" , "mw@semihalf.com" , "upstream@semihalf.com" , "jiewen.yao@intel.com" , "jian.j.wang@intel.com" , "min.m.xu@intel.com" , "lersek@redhat.com" , "sami.mujawar@arm.com" , "afish@apple.com" , "ray.ni@intel.com" , "jordan.l.justen@intel.com" , "rebecca@bsdio.com" , "grehan@freebsd.org" , "thomas.abraham@arm.com" , "chasel.chiu@intel.com" , "nathaniel.l.desimone@intel.com" , "gaoliming@byosoft.com.cn" , "eric.dong@intel.com" , "michael.d.kinney@intel.com" , "zailiang.sun@intel.com" , "yi.qian@intel.com" , "graeme@nuviainc.com" , "rad@semihalf.com" , "pete@akeo.ie" Subject: Re: [edk2-devel] [edk2-platforms PATCH v4 11/12] RISC-V Platforms: add SecureBootVariableLib class resolution Thread-Topic: [edk2-devel] [edk2-platforms PATCH v4 11/12] RISC-V Platforms: add SecureBootVariableLib class resolution Thread-Index: AQHXbayJM8/0g/po5EabDrKlvlaC06stfT4AgAAXj5w= Date: Thu, 1 Jul 2021 05:43:01 +0000 Message-ID: References: <20210630123412.996158-1-gjb@semihalf.com> <20210630123412.996158-12-gjb@semihalf.com>, In-Reply-To: Accept-Language: en-US, de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=hpe.com; x-originating-ip: [123.193.59.220] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1f797e7f-70be-4eea-7c79-08d93c5316f0 x-ms-traffictypediagnostic: DF4PR8401MB0346: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:913; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9gF0zIWWz6fscv+dvWlJCR0/qLUS27AuRIkDi3bUdz58JiHPg6PGS2O6aRPjl/E+hScePycbi2+CMcLFcq+V2oDqzgRLRhGhlsnFblGpW8PQHvj6NPHvOyLuaIBXSmQCsNHR3c/kZQmR8/fevjt0tzLpfi6elzi//XXa0ARKm36WiGcsuq7OCiu4n9193AM01OqUeQAEW43n9fFHTm2PGb5GDTc8j8shj2d5IB/axF9O0pf0mgV4WZTn5SQLPMv7fzAGVo/ymiEieTN/jWTXqHvazYyP/amIo33wyxYcX2CThwzuG177yrDaNFjCSseJlPqgCtZeLBpiKPTAysLo5pVFizaUqBo+anr+kBbkUYatjE31aI1vUS0/tEwDzWkxhZrHGKj9V4TVKBYz8eVrUdMr/sD3jkT0k23KRfoDODsSmq3ZwuBoXpnJqJFL8uIUuWgeiWZlp1YRdk1s85m13dfMR32SK0fS3rPQbnzdzi6ILl/6IwBamZk/F9RzZ4xmjpSIQUhHfQW0I1b/S9dyPYD2fxk7O9do6aUvqcIHq7KBOzFdjBfKfZjCKaQkg+KG08EUyQTgev00/svsdC69Rp/9Hl6tZGahT6dWYFBIPVWDyYCpgM1OKUayBf3R4FMj7qzo8YqFLpeIOsZIJs7Q1zY9eA3pODWSDmL6zPR/0Et7ADvhHAZKe6Jf0hPGPOCjecRAlY98R+H5EEY9XYZujLJTrBRt+696/A6qBkOho4NxHqFkM9TlY+FqeFAQf8V/i/KpPEs5MOjeZo3CJrDm0zWrEdVOPWKYWlG+lBqLM5sSoqg1H0TnGLMyQXyzbWLl x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(396003)(136003)(346002)(39860400002)(366004)(376002)(52536014)(186003)(71200400001)(8936002)(26005)(9686003)(8676002)(6636002)(4326008)(55016002)(316002)(7416002)(19627405001)(86362001)(966005)(5660300002)(478600001)(54906003)(110136005)(53546011)(6506007)(122000001)(83380400001)(66446008)(38100700002)(91956017)(76116006)(7696005)(166002)(66946007)(66476007)(66556008)(64756008)(2906002)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4ym9Qh+4g5Ms8kNNKfWjgmrRVv85Hf3qwxXzCF6fG12hoUN8KQh9A7CO06xk?= =?us-ascii?Q?3gmdsDArAugfqnFxJjHHSoF9PKIrf04uwdRl9us5Bh1swN3zLdD9UIBG0Gvr?= =?us-ascii?Q?c1qNKc1AjLy4KU+ihvSh26IH42IhogyXgIAX9k9ecrA1wgn80cyZzuhhgl40?= =?us-ascii?Q?lMpSd3nsfcm+JJrqakxZJfp9ioFqiR5HdwEQohIxXco57akTY8+Hp9sseg41?= =?us-ascii?Q?+RXKc+LLOE02jOZxt7vNBytGvW/8QKFxuA2yXKxlVzi381iK0SkA0CcwQK1h?= =?us-ascii?Q?7CNzejSorlzPlhifAvaITrYZWJdwILStgFJeWDgo6MyJHoppzajXPsxAHPp/?= =?us-ascii?Q?HkzVuwA+NcaIJD4qx2Bq0oOXAoYivL4SKrsbqCX3iGG/BfQa6HQnFHUYkT0Y?= =?us-ascii?Q?l8YVfmZuGFj5c8Qk8Qx6kN0UUNXnZRuuXm5sZBUT5s5q5T5BebHf0cd7hKeo?= =?us-ascii?Q?m4U20FlIh9shetWDrpyYzcUtDDaetIWmCyb2PE5e+HptC9gvvEr/ewPtwoFg?= =?us-ascii?Q?+Bjy4whpdF9kr+kxR7y73J7I8q+wYvzC83cZpYO3Wq4qbKw7ddWSOIW8LJNr?= =?us-ascii?Q?07l13Uusc57KjpTbmT1fxuIRpo86Ye7btt4dFhkH2QzND053kUaFUPa9n3Ov?= =?us-ascii?Q?jEM6R5o7xWtaef8j7XxUQO5LGMPFQKWyIXBhwyf3vcStGJiM/f2+AwygjLhw?= =?us-ascii?Q?mqXngxHNSU8sJx/PkLOQjDr15+34EasiAzbKA5rxloxD8iAvt+/WcNkGAjBY?= =?us-ascii?Q?UGeiyYSGe+VLBpquZs7QF3Wczx3QBwB8X1YV01GI/0egm6hl3H1geuafPVNw?= =?us-ascii?Q?iP/yM1j/kBB9C4aVzuihM7wkB0cnLFkaAPEFXWVdwhVtar7lueTYmGkFYw4q?= =?us-ascii?Q?xylZK9nzxmWnAZZt2ErFrwvbScsbJHuPrgP7ehqgYY8MmEMwrV0yEfIsD+8S?= =?us-ascii?Q?S/Hw1rnBkZGFVHoNrmFo3mjDy8zCe/KAW/neEJa2uZC/68I0HPiBu7o1Nbnk?= =?us-ascii?Q?OkLHkMVnwX79q+XzXHaII9rV0R72myJLiZAFRKTbjBJSDXkMwm7xKYrH3QFh?= =?us-ascii?Q?Y4txbAQ3+xu6i6bcs2bBqWa1kFfkBBp1L6cvUiZnJuhOpZ+3wlV3L/thv4mo?= =?us-ascii?Q?Kw/XnJ7nAptFu/5xbRsJi6T9Wftfe+KMdxBPDQl8rVawuxCUnW5gRGwT8bDy?= =?us-ascii?Q?9IgsUL7z1GJFlghEMkNsmE5nCruE0YAQVwH7E4CfB2aVdPVaKvT9dvyhLFps?= =?us-ascii?Q?7TUdSNculc6Xpp+rXMAZHo9AmumabycLL55uxTNN+MJFzwPR/Y2rjxNNfUUM?= =?us-ascii?Q?mWNrGVbH3465Im9w4Q0uFz61?= X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 1f797e7f-70be-4eea-7c79-08d93c5316f0 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2021 05:43:01.2947 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uY0Y16lSbSVeAi4+LXX9+fehtclnV3rIA8oXE+8orBvZ0/3uGxkWxuu8jaLBz/dtCYAqv8le/Ev7Z3Fl6XzJsw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0346 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: 4z6gspNgAND9TOx_MRVOn6lDXEwsOrcP X-Proofpoint-GUID: 4z6gspNgAND9TOx_MRVOn6lDXEwsOrcP X-Proofpoint-UnRewURL: 12 URL's were un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-07-01_01:2021-06-30,2021-07-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 suspectscore=0 impostorscore=0 malwarescore=0 mlxscore=0 priorityscore=1501 adultscore=0 mlxlogscore=999 bulkscore=0 clxscore=1011 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107010039 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DF4PR8401MB0444D14B419248EE5AC42A4AE0009DF4PR8401MB0444_" --_000_DF4PR8401MB0444D14B419248EE5AC42A4AE0009DF4PR8401MB0444_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Daniel Schaefer ________________________________ From: devel@edk2.groups.io on behalf of Abner Chang= Sent: Thursday, July 1, 2021 11:50 To: devel@edk2.groups.io ; gjb@semihalf.com Cc: leif@nuviainc.com ; ardb+tianocore@kernel.org ; Samer.El-Haj-Mahmoud@arm.com ; sunny.Wang@arm.com ; mw@semihalf.com ; upstream@semihalf.com ; jiewen.yao@intel.= com ; jian.j.wang@intel.com ; = min.m.xu@intel.com ; lersek@redhat.com ; sami.mujawar@arm.com ; afish@apple.com ; ray.ni@intel.com ; jordan.l.justen@intel.com ; rebecca@bsdio.com ; grehan@fr= eebsd.org ; thomas.abraham@arm.com ; chasel.chiu@intel.com ; nathaniel.l.desimone@i= ntel.com ; gaoliming@byosoft.com.cn ; eric.dong@intel.com ; michael.d.k= inney@intel.com ; zailiang.sun@intel.com ; yi.qian@intel.com ; graeme@nuviainc.= com ; rad@semihalf.com ; pete@akeo.i= e Subject: Re: [edk2-devel] [edk2-platforms PATCH v4 11/12] RISC-V Platforms= : add SecureBootVariableLib class resolution Reviewed-by: Abner Chang > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Grzegorz Bernacki > Sent: Wednesday, June 30, 2021 8:34 PM > To: devel@edk2.groups.io > Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Samer.El-Haj- > Mahmoud@arm.com; sunny.Wang@arm.com; mw@semihalf.com; > upstream@semihalf.com; jiewen.yao@intel.com; jian.j.wang@intel.com; > min.m.xu@intel.com; lersek@redhat.com; sami.mujawar@arm.com; > afish@apple.com; ray.ni@intel.com; jordan.l.justen@intel.com; > rebecca@bsdio.com; grehan@freebsd.org; thomas.abraham@arm.com; > chasel.chiu@intel.com; nathaniel.l.desimone@intel.com; > gaoliming@byosoft.com.cn; eric.dong@intel.com; > michael.d.kinney@intel.com; zailiang.sun@intel.com; yi.qian@intel.com; > graeme@nuviainc.com; rad@semihalf.com; pete@akeo.ie; Grzegorz > Bernacki > Subject: [edk2-devel] [edk2-platforms PATCH v4 11/12] RISC-V Platforms: > add SecureBootVariableLib class resolution > > The edk2 patch > SecurityPkg: Create library for setting Secure Boot variables. > > removes generic functions from SecureBootConfigDxe and places > them into SecureBootVariableLib. This patch adds SecureBootVariableLib > mapping for each RICS-V platform which uses SecureBootConfigDxe. > > Signed-off-by: Grzegorz Bernacki > --- > Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | = 1 + > > Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc > | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > index b91823ceeb..fc5ba2a07f 100644 > --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > @@ -122,6 +122,7 @@ > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > > TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTp > mMeasurementLib.inf > AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.i= nf > + > SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureB > ootVariableLib.inf > !else > > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/Tp > mMeasurementLibNull.inf > > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableL > ibNull.inf > diff --git > a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d > sc > b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540. > dsc > index 0eafe29880..71add8ff9a 100644 > --- > a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d > sc > +++ > b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540. > dsc > @@ -122,6 +122,7 @@ > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > > TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTp > mMeasurementLib.inf > AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.i= nf > + > SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureB > ootVariableLib.inf > !else > > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/Tp > mMeasurementLibNull.inf > > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableL > ibNull.inf > -- > 2.25.1 > > > > > --_000_DF4PR8401MB0444D14B419248EE5AC42A4AE0009DF4PR8401MB0444_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Daniel Schaef= er <daniel.schaefer@hpe.com>
From: devel@edk2.groups.io= <devel@edk2.groups.io> on behalf of Abner Chang <abner.chang@hpe.= com>
Sent: Thursday, July 1, 2021 11:50
To: devel@edk2.groups.io <devel@edk2.groups.io>; gjb@semihalf= .com <gjb@semihalf.com>
Cc: leif@nuviainc.com <leif@nuviainc.com>; ardb+tianocore@ker= nel.org <ardb+tianocore@kernel.org>; Samer.El-Haj-Mahmoud@arm.com <= ;Samer.El-Haj-Mahmoud@arm.com>; sunny.Wang@arm.com <sunny.Wang@arm.co= m>; mw@semihalf.com <mw@semihalf.com>; upstream@semihalf.com <upstream@semihalf.com>; jiewen.yao@intel.com <jiewen.yao@intel.= com>; jian.j.wang@intel.com <jian.j.wang@intel.com>; min.m.xu@inte= l.com <min.m.xu@intel.com>; lersek@redhat.com <lersek@redhat.com&g= t;; sami.mujawar@arm.com <sami.mujawar@arm.com>; afish@apple.com <afish@apple.com>; ray.ni@intel.com <ray.ni@intel.com>; jorda= n.l.justen@intel.com <jordan.l.justen@intel.com>; rebecca@bsdio.com &= lt;rebecca@bsdio.com>; grehan@freebsd.org <grehan@freebsd.org>; th= omas.abraham@arm.com <thomas.abraham@arm.com>; chasel.chiu@intel.com <chasel.chiu@intel.com>; nathaniel.l.desimone@intel.com <nathani= el.l.desimone@intel.com>; gaoliming@byosoft.com.cn <gaoliming@byosoft= .com.cn>; eric.dong@intel.com <eric.dong@intel.com>; michael.d.kin= ney@intel.com <michael.d.kinney@intel.com>; zailiang.sun@intel.com <zailiang.sun@intel.com>; yi.qian@intel.com <yi.qian@intel.com&g= t;; graeme@nuviainc.com <graeme@nuviainc.com>; rad@semihalf.com <r= ad@semihalf.com>; pete@akeo.ie <pete@akeo.ie>
Subject: Re: [edk2-devel] [edk2-platforms PATCH v4 11/12] RISC-V Pl= atforms: add SecureBootVariableLib class resolution
 
Reviewed-by: Abner Chang <abner.chang@hpe.com&= gt;

> -----Original Message-----
> From: devel@edk2.groups.io [m= ailto:devel@edk2.groups.io] On Behalf Of
> Grzegorz Bernacki
> Sent: Wednesday, June 30, 2021 8:34 PM
> To: devel@edk2.groups.io
> Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Samer.El-Haj-
> Mahmoud@arm.com; sunny.Wang@arm.com; mw@semihalf.com;
> upstream@semihalf.com; jiewen.yao@intel.com; jian.j.wang@intel.com; > min.m.xu@intel.com; lersek@redhat.com; sami.mujawar@arm.com;
> afish@apple.com; ray.ni@intel.com; jordan.l.justen@intel.com;
> rebecca@bsdio.com; grehan@freebsd.org; thomas.abraham@arm.com;
> chasel.chiu@intel.com; nathaniel.l.desimone@intel.com;
> gaoliming@byosoft.com.cn; eric.dong@intel.com;
> michael.d.kinney@intel.com; zailiang.sun@intel.com; yi.qian@intel.com= ;
> graeme@nuviainc.com; rad@semihalf.com; pete@akeo.ie; Grzegorz
> Bernacki <gjb@semihalf.com>
> Subject: [edk2-devel] [edk2-platforms PATCH v4 11/12] RISC-V Platform= s:
> add SecureBootVariableLib class resolution
>
> The edk2 patch
>   SecurityPkg: Create library for setting Secure Boot varia= bles.
>
> removes generic functions from SecureBootConfigDxe and places
> them into SecureBootVariableLib. This patch adds SecureBootVariableLi= b
> mapping for each RICS-V platform which uses SecureBootConfigDxe.
>
> Signed-off-by: Grzegorz Bernacki <gjb@semihalf.com>
> ---
>  Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc = ;          | 1 +
>
> Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc<= br> > | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.d= sc
> b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> index b91823ceeb..fc5ba2a07f 100644
> --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> @@ -122,6 +122,7 @@
>    OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.= inf
>
> TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTp
> mMeasurementLib.inf
>    AuthVariableLib|SecurityPkg/Library/AuthVariableLib= /AuthVariableLib.inf
> +
> SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/Secur= eB
> ootVariableLib.inf
>  !else
>
> TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/Tp
> mMeasurementLibNull.inf
>
> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariable= L
> ibNull.inf
> diff --git
> a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d<= br> > sc
> b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540. > dsc
> index 0eafe29880..71add8ff9a 100644
> ---
> a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d<= br> > sc
> +++
> b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540. > dsc
> @@ -122,6 +122,7 @@
>    OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.= inf
>
> TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTp
> mMeasurementLib.inf
>    AuthVariableLib|SecurityPkg/Library/AuthVariableLib= /AuthVariableLib.inf
> +
> SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/Secur= eB
> ootVariableLib.inf
>  !else
>
> TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/Tp
> mMeasurementLibNull.inf
>
> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariable= L
> ibNull.inf
> --
> 2.25.1
>
>
>
>
>






--_000_DF4PR8401MB0444D14B419248EE5AC42A4AE0009DF4PR8401MB0444_--