From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web09.7058.1612344728962113134 for ; Wed, 03 Feb 2021 01:32:09 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=WH/w5l3s; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=0668ba8256=sunnywang@hpe.com) Received: from pps.filterd (m0134424.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 1139U6ro016810; Wed, 3 Feb 2021 09:32:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=OG2VII42lR3TccUPDXVf2OhR8eQTjWoetd/CbxgolJg=; b=WH/w5l3slDLZ1OXzWie+4TXHCWyrdgxeX/u7CJiDtC5Lsxjzh1rwAGPeyhrbaQKYZI7C dt92dsLKLcVh+OFC7Mi2PJNSb+eOVSE0HX2vZmOsfM0jFlLlhPprsvwCpQ0F1Co+wOB1 RCy+V1da17vqle12bZdQaWIH0nu8opcmIZWz6Xtizpsy7x79UFYzTUAvAGv6UERc4EeT TC7FNHawZmIYxnSo/AKHZLr9qxh5fYbAXNHTAtvG68amnwGjjFZ+PBFWa8vlsMSAtSU0 Urf8nTgTL4YTP/Ca9RufP0XepMoMIpFsfwPnJ3JOtPaDgFTvGIA/tY2uEPsdE9XZPcfs QA== Received: from g2t2353.austin.hpe.com (g2t2353.austin.hpe.com [15.233.44.26]) by mx0b-002e3701.pphosted.com with ESMTP id 36fs8k00k8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 03 Feb 2021 09:32:07 +0000 Received: from G1W8108.americas.hpqcorp.net (g1w8108.austin.hp.com [16.193.72.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2353.austin.hpe.com (Postfix) with ESMTPS id 0268386; Wed, 3 Feb 2021 09:32:06 +0000 (UTC) Received: from G4W9119.americas.hpqcorp.net (2002:10d2:14d6::10d2:14d6) by G1W8108.americas.hpqcorp.net (2002:10c1:483c::10c1:483c) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 3 Feb 2021 09:32:06 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (15.241.52.10) by G4W9119.americas.hpqcorp.net (16.210.20.214) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 3 Feb 2021 09:32:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m2saKYsPS2pfqGWzN0JvPEq5k2tKYuWYJ2RyApqvlL1KM4NLqb89zJ2LicIbc9kngZVsGiiIBEvmMpjpmmBhOeXHGopJURolH02SHFXRfOwqdSDree5DF5ktvUgF4CrsGqR2+BsyacZTPWXSsNkspiZ80oV+1iJ+bAl280xUsYLg+paLfXhzI8w8kZlFwtyKjf/ifHhQhuXofLqR9Igeg/aFRbcpayBaQAbfqt/jAnqQ/DfGBKaNco4Gp25vbO7b0s67Fut5iATBKsTJ+jCOfTnXVgwlbmDEX6ls1mB/2CkIuNwi4aPJLIcuItI0sFLi4+9wX9LeAhmhqgQ8IRJVZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RjMaC6BUBalGWbcLA33Ka3eebfSlLzr6RfKzJNj8Nys=; b=l9Tc3Vn85eiOUI7cAFoyitZA8eUBVxx/mSiD79uZLSDiv+be5bj8+ii5Lm7FfJVIid3DAwe3gc93G86tyM4f6ZgJWj1/41aTe/jH3shGNXSRzUhF0DHFuR5Bp7MjrdgiN+HipL/bWuGqcwd7G1MB1nWep3poH5kBOZXBvmbvVqUybqfo3jUzY5pAzbKqWdSnlglbGze1zNUw1XhO5iRuRO/TSk9vRGbZH5H8nKC4bRZCUNgudgWZqjk0jV8RX7RrArgZD14U8YN3Xoqo4C32/bQZdK1w8RNW8dnTZ8cGh/q9bAJ+4uNnKg4iOQY9koMxjcEsGW33+rWxYCNaEujLyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from DF4PR8401MB0585.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7609::21) by DF4PR8401MB0826.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.19; Wed, 3 Feb 2021 09:32:04 +0000 Received: from DF4PR8401MB0585.NAMPRD84.PROD.OUTLOOK.COM ([fe80::49dc:20b6:1bf3:b73b]) by DF4PR8401MB0585.NAMPRD84.PROD.OUTLOOK.COM ([fe80::49dc:20b6:1bf3:b73b%4]) with mapi id 15.20.3805.027; Wed, 3 Feb 2021 09:32:04 +0000 From: "Wang, Sunny (HPS SW)" To: "devel@edk2.groups.io" , "patrick.rudolph@9elements.com" CC: "aiden.park@intel.com" , "benjamin.you@intel.com" , "philipp.deppenwiese@9elements.com" , "maurice.ma@intel.com" , "guo.dong@intel.com" , "Wang, Sunny (HPS SW)" Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/PlatformBootManager: Connect console after EndOfDxe Thread-Topic: [edk2-devel] [PATCH] UefiPayloadPkg/PlatformBootManager: Connect console after EndOfDxe Thread-Index: AQHW+T4sXNUA3lyjgUCa2FEj8Ylz36pGKcRA Date: Wed, 3 Feb 2021 09:32:04 +0000 Message-ID: References: <20210202083352.581971-1-patrick.rudolph@9elements.com> In-Reply-To: <20210202083352.581971-1-patrick.rudolph@9elements.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=hpe.com; x-originating-ip: [36.226.218.154] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 917d3bc4-6cec-4b1d-9c80-08d8c8269157 x-ms-traffictypediagnostic: DF4PR8401MB0826: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:378; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 42ASb6DBabl8iGfhds6pU35MTMxKbguYdcraz1+zfbi9PlAfGGKqGTlkWUMU9b1UJa5zlygyMExQxP7NyEsWlL+vy46xrDe7GD8LdH0MSDzM+GBo9S8uIPuCbMkyBLWyZWrPN+atihOD4G+4mdQZlFQhqG38r95FEKBKNQiU/eK2Jgw4sI7brLNkwkiN2SpaNIIqUd4kcZl8mgn/PR8zNw9P6RG/eMyDmq30RxWtI2taPgMzBmOXfRcDYAw9JKdtkFdn6xgnSBIoEDrWM/G7+6dnq/w6601y4lJjeutTVQlXhpLEfhEiSlevErLvjw5gsoGjupaiy3dDYkceZnwsypMcNPyIcVGHroRKOOX3boBeHKy+BbtPELOHL8Jx5sg1gpdK+TkEUiiafI+IqPndWIPOgZRAeoJ/9Cp8g6Kw72DGp/03I32JYqn22fcm2G7N2xpKxe2Sgb4annl9kZbOv/QcSyypMBOyjG5bzttEyE3Reahf94v9cDdem/DA04swSOf0NTgWiQpASoWkPDGqbp8RcRbDwQ7prQnUkUvvfiz+fEJfdcic8VR2n9EO2fPlEcjNj9FLUK59I0oByImLwqX5h9Aoi2GtG7bndkIeUlk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DF4PR8401MB0585.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(6029001)(346002)(396003)(136003)(376002)(39860400002)(366004)(4326008)(8676002)(478600001)(186003)(66946007)(66446008)(86362001)(53546011)(6506007)(66476007)(66556008)(7696005)(5660300002)(64756008)(2906002)(9686003)(966005)(26005)(33656002)(8936002)(55016002)(54906003)(316002)(110136005)(76116006)(83380400001)(71200400001)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?b1zm+5AAV4BWN3jF8uriEDSFtlwqE/ZurA9q41cwTF65pmqDDcUgTRzK4oSf?= =?us-ascii?Q?rrgprBL1OdGVfs+ikSY5ISi3bdoEqkaDEPKG1Yh5GWa42n9TDBmwJIOIzvE5?= =?us-ascii?Q?paXvSNiqK4GSAUykl+107i0NMCn/K0Dc5N8SpNT2P/y+U7qmm3m9d9Jxhkw/?= =?us-ascii?Q?Ah7RAD1hG46LPF9dfsiNjZMBdSGH4j48JwFLhOKwlKX25TdIqdRp3Dkd7hAI?= =?us-ascii?Q?IUIK9oYEBbZiStNLIWROZD26bsVhQsDR6SchyxZ5QldmY6hMXaZrMrzbtjX5?= =?us-ascii?Q?5JVa733bqlvsoNVz2P+FboAEgvSYQhbXrllk6U28hXRjqL/LX6BkmlkH/u8w?= =?us-ascii?Q?TKL8hYhmMiIxN6NEBmg5ouJCUp1Fd5uja6trgPQOnz5H+5WrgQLGOwJMdKyB?= =?us-ascii?Q?YvoUjzw8x8QJrS+6zhSMaO0iMlVfH+xh0GEoR2tarqC7VX1p6b9pKi6VQaOg?= =?us-ascii?Q?J59ad/Y4vLu/Lnr45iWW8ytpESxhpa2GagdFbR8LzslN1RvRoHiPK0+Opdwd?= =?us-ascii?Q?Ao4oaeQieW6OQn1vYxzn68zFCriaNx7hJaS2nKSQ8kUpgGuLuIoc9U9QWtOG?= =?us-ascii?Q?8NueytQchoBR5R63hHFokLCeMrlSfDq6uBMp/qa75R9WUMI/F4DZsjcC7jof?= =?us-ascii?Q?DXbPBthofZl+ei0iwIV0lCACQmw5dwqjfi57TPuCWPGUujpxgHeFiP/I4PX0?= =?us-ascii?Q?UF3ZDnqvYMDMkr8eu7sEh1wbD3iGe+nArefiUTv1mipPIAm6m1ITqMAPimbK?= =?us-ascii?Q?fXGkmR1jkpaVASKbOgyfdObctBhocEWrDhtxeufSlj/H4cIK7Dm+pydNI7Ey?= =?us-ascii?Q?EqtN49cfmKXBuGD3GhE0+YkMrdhoYbG7vtmM8GI3boG/6dv1g6rb9Xty60M0?= =?us-ascii?Q?Ep67Sw4xCKuQQlPwV43Qc/gPJtpdPRyI8CJH5Qf+3J/+jEJD1u1VZgva9Pte?= =?us-ascii?Q?0qvC/6SaOWae9szKnd3VW0PztCSEnXLvc/rSqwEpfQLA61nDfFIwwwO7afca?= =?us-ascii?Q?qS/vl9RGrqvbH5LVy/BPm4b3W+eZa2eQsU11JoLFyzWm+buss56LFwpj1SPR?= =?us-ascii?Q?j68QbKuF?= X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DF4PR8401MB0585.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 917d3bc4-6cec-4b1d-9c80-08d8c8269157 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2021 09:32:04.4736 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HA98Lpq2guShUIcCKum00uWBdCnRWpPGaE3mQmPrGne4dzQbMhdnCdw1m0oR0ch99lLOhzq/apUXDmFFiLgFJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0826 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 3 URL's were un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737 definitions=2021-02-03_04:2021-02-02,2021-02-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 priorityscore=1501 clxscore=1011 bulkscore=0 adultscore=0 mlxscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102030060 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Patrick, I'm not familiar with UefiPayloadPkg. However, since we may want to enable= the trusted console as earlier as possible, you may still need to keep the= PlatformConsoleInit() call at the beginning of PlatformBootManagerBeforeCo= nsole() to support the platform that has trusted/on-board Consoles. =20 Regards, Sunny Wang -----Original Message----- From: devel@edk2.groups.io On Behalf Of Patrick Rud= olph Sent: Tuesday, February 2, 2021 4:34 PM To: devel@edk2.groups.io Cc: aiden.park@intel.com; benjamin.you@intel.com; philipp.deppenwiese@9ele= ments.com; maurice.ma@intel.com; guo.dong@intel.com Subject: [edk2-devel] [PATCH] UefiPayloadPkg/PlatformBootManager: Connect = console after EndOfDxe Currently the console is connected before EndOfDxe causing OptionsROMs to = be loaded, but their drivers aren't used and thus no GOP is installed. To make use of 3rdparty OptionROMs connect the console after EndOfDxe. Tested on Intel CFL board using Nvidia Quadro GPU. Signed-off-by: Patrick Rudolph --- UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c | 4 += +-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootMan= ager.c b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.= c index c5c6af0abc..7fa3a048b7 100644 --- a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c +++ b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager. +++ c @@ -157,8 +157,6 @@ PlatformBootManagerBeforeConsole ( EFI_INPUT_KEY Down; EFI_BOOT_MANAGER_LOAD_OPTION BootOption; =20 - PlatformConsoleInit (); - // // Register ENTER as CONTINUE key // @@ -192,6 +190,8 @@ PlatformBootManagerBeforeConsole ( // Dispatch deferred images after EndOfDxe event and ReadyToLock instal= lation. // EfiBootManagerDispatchDeferredImages (); + + PlatformConsoleInit (); } =20 /** -- 2.26.2