From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web11.23391.1581347635079884342 for ; Mon, 10 Feb 2020 07:13:55 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=0309d70a5c=daniel.schaefer@hpe.com) Received: from pps.filterd (m0150244.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01AFDVWp032026; Mon, 10 Feb 2020 15:13:46 GMT Received: from g2t2352.austin.hpe.com (g2t2352.austin.hpe.com [15.233.44.25]) by mx0b-002e3701.pphosted.com with ESMTP id 2y37599cwr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Feb 2020 15:13:46 +0000 Received: from G9W8455.americas.hpqcorp.net (g9w8455.houston.hp.com [16.216.161.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2352.austin.hpe.com (Postfix) with ESMTPS id 22590A1; Mon, 10 Feb 2020 15:13:45 +0000 (UTC) Received: from G9W8453.americas.hpqcorp.net (2002:10d8:a0d3::10d8:a0d3) by G9W8455.americas.hpqcorp.net (2002:10d8:a15e::10d8:a15e) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 10 Feb 2020 15:13:03 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (15.241.52.12) by G9W8453.americas.hpqcorp.net (16.216.160.211) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 10 Feb 2020 15:13:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M39fMZIrpL91gMwwVwjutTs3ZoTWYOACw+KTDJknGOnHXmVVm0tOUYFg8rfFPOpjWfqfSldGHg4PKDa/Y8+Ios+qnq7flzrN3q3iU0aeNngB0SkfSkpeg0TRnzi3cE18mpEwWVptrWvWfm2sKJExGak568HXbBJBLmthiaYQ13CzxNOtVKbW8RCrhtyQtzuCI41u7GuTjUcYeBEk9McMQskJDne50d2VSzKvVNb3VCE24FBSo6wLZFwx8Ao/s/cw2/sifQuigm+5JG7pDQrf2aPcKd/hFOywrI1Hu787KLCXq3pFktoFdp6Bn12nogiTaIceWlFkHZXRrU4Oxn2lwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zo2EqyGtTazJe+mdpAvmMhHa+jUB3VqP8SEuvcaik98=; b=dA7cQunn6bCOKU9a3gQlvGTBXLozFoO1buKe9td/Dx3wSi2pWhEA8jVpSS/R9IMIZy3YCZnp/4Y1DiaL10LntK653EvWkvl+aU9RRA05JlMcZIBGe/Ez6jgcpZVG91XvPIyhuPygK2dkqBuC1HE3UY0h3VzTlEigSySvtbtbDTvkmJayPlc/UrYx2Yi1iShBmK9M12lZitfgoVkEpurJAx4M1+jDPp4FFrw/lsGdmjgvCE5tFXU2QY5jMKyGAhLGkrKa14fHgCbCccMsfSOf9awn482xFBmDXaACN2unShyft6YWqqM9B6GLpY7FzDFJiNbQOeq1ZPYZUNIgjBfQeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from DF4PR8401MB0777.NAMPRD84.PROD.OUTLOOK.COM (10.169.84.141) by DF4PR8401MB0476.NAMPRD84.PROD.OUTLOOK.COM (10.169.82.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.21; Mon, 10 Feb 2020 15:13:02 +0000 Received: from DF4PR8401MB0777.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c9a:2a02:1da1:9fcd]) by DF4PR8401MB0777.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c9a:2a02:1da1:9fcd%6]) with mapi id 15.20.2707.030; Mon, 10 Feb 2020 15:13:02 +0000 From: daniel.schaefer@hpe.com To: Rebecca Cran CC: "Chang, Abner (HPS SW/FW Technologist)" , "Chen, Gilbert" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [staging/RISC-V-V2]: Need to bump opensbi submodule to get sbi_hfence.S etc. Thread-Topic: [edk2-devel] [staging/RISC-V-V2]: Need to bump opensbi submodule to get sbi_hfence.S etc. Thread-Index: AQHV33xBwg7AF7RV9USeT6WkQ0yE2agTjjQAgAAZP3CAAOHHUg== Date: Mon, 10 Feb 2020 15:13:02 +0000 Message-ID: References: <28f9f325-3106-1f3a-096d-d3aebc6fcc85@bsdio.com> , In-Reply-To: Accept-Language: en-US, de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.211.140] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 36949536-97e6-4abc-7784-08d7ae3bb8ee x-ms-traffictypediagnostic: DF4PR8401MB0476: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:608; x-forefront-prvs: 03094A4065 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(136003)(366004)(346002)(376002)(396003)(189003)(199004)(478600001)(8676002)(81156014)(81166006)(186003)(33656002)(19627405001)(66446008)(8936002)(66946007)(26005)(66556008)(316002)(64756008)(66476007)(54906003)(55016002)(6916009)(9686003)(52536014)(7696005)(76116006)(86362001)(5660300002)(6506007)(4326008)(53546011)(2906002)(966005)(71200400001);DIR:OUT;SFP:1102;SCL:1;SRVR:DF4PR8401MB0476;H:DF4PR8401MB0777.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8GITAs2u90s0qF0QKCtaurYURztHzdnLCqJXQ4BDamd2MbjMZzge6GLrjlFqUzrZ2fVrh011kGuQtAEF5vD+hLLt3eR0mCp78eAR34LwXg5HclOX4C52ZlBJStN27tnr81F4cu0yGXGm0Jv7Ifr+zv+3XLyM3mjwizCZDNeO0e7cvtrte1uPmMxTO3IDEJ/B9J4EhPOpUws4O9ZLPGpHDecXmdluw6iDXC8+c4vPrTn2lhKsxEisqcWFel0Dfo0JHsTH485K9pURnMBcj6ihT1HAa8EZsHIAuqzVbYf8r5dJBK29mD5m7DIRpu27JKoIQ2LaHzTF91Vf47OCBkuDPyNIImlAroTUCpPWmajheKGdVu9GErwBLhOTQ48i34ICc+1/UxMNeqXnwCLvuDIKc0kpO28i2Z5ngz1MxiPGoLqLGVC/gAecQt9yX50gVvMCLj7PJsaSzj7f06FzL9NelmHK2xa5CEMwshdJLco8fdeS8V1ib6Y8zW8+rosAcQ7W0sGm3TasA3aL1kjkmSBulQ== x-ms-exchange-antispam-messagedata: oAk2HrFhh22o7oCRE1jAYRJXks5QmSla46PryzZABfChzU3pnU2/sIXPzzVliQLUM9Kz6C++WfRao0bRGDnsrEOB/fjPOHHsKlQRJ/+B2ONk92O3iKTrBIrsnYMbtX5hm65Pj9toB2sruiHSIx5iUA== X-MS-Exchange-CrossTenant-Network-Message-Id: 36949536-97e6-4abc-7784-08d7ae3bb8ee X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2020 15:13:02.3904 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s+EEPgzc/ygm5yJ57dlE1su0PNuuum2Kwl1qMY3nVPN2K6TeLZFrC6fzutp6jkvjEI249sy1RLCnnMp9dBgaKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0476 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 6 URL's were un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-02-10_05:2020-02-10,2020-02-10 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=999 clxscore=1011 bulkscore=0 malwarescore=0 mlxscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002100117 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DF4PR8401MB07776DE2760A48A1362FCDBDE0190DF4PR8401MB0777_" --_000_DF4PR8401MB07776DE2760A48A1362FCDBDE0190DF4PR8401MB0777_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Rebecca, if you want to update to opensbi master, please apply this patch. Since opensbi 0.6 hasn't been released yet, we haven't pushed the fixes ye= t. Atish said it will be out soon. diff --git a/RiscVPkg/Include/OpensbiTypes.h b/RiscVPkg/Include/OpensbiTyp= es.h index 800f97759a..c77dbdec11 100644 --- a/RiscVPkg/Include/OpensbiTypes.h +++ b/RiscVPkg/Include/OpensbiTypes.h @@ -46,6 +46,17 @@ typedef UINT64 physical_size_t; #define likely(x) __builtin_expect((x), 1) #define unlikely(x) __builtin_expect((x), 0) +#undef offsetof +#ifdef __compiler_offsetof +#define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE,MEMBER) +#else +#define offsetof(TYPE, MEMBER) ((size_t) &((TYPE *)0)->MEMBER) +#endif + +#define container_of(ptr, type, member) ({ \ + const typeof(((type *)0)->member) * __mptr =3D (ptr); \ + (type *)((char *)__mptr - offsetof(type, member)); }) + #define CLAMP(a, lo, hi) MIN(MAX(a, lo), hi) #define ROUNDUP(a, b) ((((a)-1) / (b) + 1) * (b)) #define ROUNDDOWN(a, b) ((a) / (b) * (b)) diff --git a/RiscVPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf b/RiscVP= kg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf index a5e59463f1..d966330818 100644 --- a/RiscVPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf +++ b/RiscVPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf @@ -22,6 +22,10 @@ opensbi/lib/sbi/riscv_locks.c opensbi/lib/sbi/sbi_console.c opensbi/lib/sbi/sbi_ecall.c + opensbi/lib/sbi/sbi_ecall_vendor.c + opensbi/lib/sbi/sbi_ecall_replace.c + opensbi/lib/sbi/sbi_ecall_legacy.c + opensbi/lib/sbi/sbi_ecall_base.c opensbi/lib/sbi/sbi_emulate_csr.c opensbi/lib/sbi/sbi_fifo.c opensbi/lib/sbi/sbi_hart.c diff --git a/RiscVPkg/Library/RiscVOpensbiLib/opensbi b/RiscVPkg/Library/R= iscVOpensbiLib/opensbi index be92da280d..ec29e1cf73 160000 --- a/RiscVPkg/Library/RiscVOpensbiLib/opensbi +++ b/RiscVPkg/Library/RiscVOpensbiLib/opensbi @@ -1 +1 @@ -Subproject commit be92da280d87c38a2e0adc5d3f43bab7b5468f09 +Subproject commit ec29e1cf73ffe96a646daa7c2b288aa280e4be37 Cheers, Daniel ________________________________ From: devel@edk2.groups.io on behalf of Abner Chang= Sent: Monday, February 10, 2020 02:53 To: Rebecca Cran ; devel@edk2.groups.io ; Chen, Gilbert Subject: Re: [edk2-devel] [staging/RISC-V-V2]: Need to bump opensbi submod= ule to get sbi_hfence.S etc. Hi Rebecca, The RISC-V code on edk2-staging has the corresponding changes in order to = incorporate with opensbi tag v0.6, however opensbi tag v0.6 is not released= yet (supposed to release in weeks ago). Our changes were made based on ope= nsbi tag v0.6 though. Please stay in tune with my email send to edk2 mail list for the RISC-V ed= k2 port readiness. Opensbi changes often, that is expected we get build error with the master= . So I will make sure everything is good once 0.6 is released. Thanks Abner > -----Original Message----- > From: Rebecca Cran [mailto:rebecca@bsdio.com] > Sent: Monday, February 10, 2020 8:11 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > ; Chen, Gilbert > Subject: Re: [staging/RISC-V-V2]: Need to bump opensbi submodule to get > sbi_hfence.S etc. > > On 2020-02-09 12:07, Rebecca Cran wrote: > > I recently got a HiFive Unleashed board, and am interested in trying > > out RISCV EDK2 firmware either on it or in Qemu. > > > > It looks like the opensbi submodule in > > edk2-staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi needs updated > > though: the commit currently used - > > be92da280d87c38a2e0adc5d3f43bab7b5468f09 - is missing files such as > > sbi_hfence.S mentioned in > > RiscVPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf . > > > After updating the opensbi submodule to master, I now get a compile erro= r: > > > /home/bcran/workspace/edk2- > staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c: > In function 'sbi_ecall_find_extension': > /home/bcran/workspace/edk2- > staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:32:= 11: > error: implicit declaration of function 'container_of' > [-Werror=3Dimplicit-function-declaration] > sbi_list_for_each_entry(t, &ecall_exts_list, head) { > ^~~~~~~~~~~~ > /home/bcran/workspace/edk2- > staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:32:= 50: > error: expected expression before 'typeof' > sbi_list_for_each_entry(t, &ecall_exts_list, head) { > ^~~~ > /home/bcran/workspace/edk2- > staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:32:= 132: > error: expected expression before 'typeof' > sbi_list_for_each_entry(t, &ecall_exts_list, head) { > > ^ > /home/bcran/workspace/edk2- > staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c: > In function 'sbi_ecall_unregister_extension': > /home/bcran/workspace/edk2- > staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:64:= 50: > error: expected expression before 'typeof' > sbi_list_for_each_entry(t, &ecall_exts_list, head) { > ^~~~ > /home/bcran/workspace/edk2- > staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:64:= 132: > error: expected expression before 'typeof' > sbi_list_for_each_entry(t, &ecall_exts_list, head) { > > ^ > cc1: all warnings being treated as errors > > -- > Rebecca Cran > --_000_DF4PR8401MB07776DE2760A48A1362FCDBDE0190DF4PR8401MB0777_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi Rebecca,

if you want to update to opensbi master, please apply this patch.
Since opensbi 0.6 hasn't been released yet, we haven't pushed the fixes ye= t.
Atish said it will be out soon.

diff --git a/RiscVPkg/Include/OpensbiTypes.h b/RiscVPkg/Include/Opens=
biTypes.h
index 800f97759a..c77dbdec11 100644
--- a/RiscVPkg/Include/OpensbiTypes.h
+++ b/RiscVPkg/Include/OpensbiTypes.h
@@ -46,6 +46,17 @@ typedef UINT64   physical_size_t;
 #define likely(x) __builtin_expect((x), 1)
 #define unlikely(x) __builtin_expect((x), 0)
=20
+#undef offsetof
+#ifdef __compiler_offsetof
+#define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE,MEMBER)
+#else
+#define offsetof(TYPE, MEMBER) ((size_t) &((TYPE *)0)->MEMBER)
+#endif
+
+#define container_of(ptr, type, member) ({            \
+  const typeof(((type *)0)->member) * __mptr =3D (ptr); \
+  (type *)((char *)__mptr - offsetof(type, member)); })
+
 #define CLAMP(a, lo, hi) MIN(MAX(a, lo), hi)
 #define ROUNDUP(a, b) ((((a)-1) / (b) + 1) * (b))
 #define ROUNDDOWN(a, b) ((a) / (b) * (b))
diff --git a/RiscVPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf b/RiscVP=
kg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf
index a5e59463f1..d966330818 100644
--- a/RiscVPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf
+++ b/RiscVPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf
@@ -22,6 +22,10 @@
   opensbi/lib/sbi/riscv_locks.c
   opensbi/lib/sbi/sbi_console.c
   opensbi/lib/sbi/sbi_ecall.c
+  opensbi/lib/sbi/sbi_ecall_vendor.c
+  opensbi/lib/sbi/sbi_ecall_replace.c
+  opensbi/lib/sbi/sbi_ecall_legacy.c
+  opensbi/lib/sbi/sbi_ecall_base.c
   opensbi/lib/sbi/sbi_emulate_csr.c
   opensbi/lib/sbi/sbi_fifo.c
   opensbi/lib/sbi/sbi_hart.c
diff --git a/RiscVPkg/Library/RiscVOpensbiLib/opensbi b/RiscVPkg/Library/R=
iscVOpensbiLib/opensbi
index be92da280d..ec29e1cf73 160000
--- a/RiscVPkg/Library/RiscVOpensbiLib/opensbi
+++ b/RiscVPkg/Library/RiscVOpensbiLib/opensbi
@@ -1 +1 @@
-Subproject commit be92da280d87c38a2e0adc5d3f43bab7b5468f09
+Subproject commit ec29e1cf73ffe96a646daa7c2b288aa280e4be37

Cheers,
Daniel
From: devel@edk2.groups.io= <devel@edk2.groups.io> on behalf of Abner Chang <abner.chang@hpe.= com>
Sent: Monday, February 10, 2020 02:53
To: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io &l= t;devel@edk2.groups.io>; Chen, Gilbert <gilbert.chen@hpe.com>
Subject: Re: [edk2-devel] [staging/RISC-V-V2]: Need to bump opensbi= submodule to get sbi_hfence.S etc.
 
Hi Rebecca,
The RISC-V code on edk2-staging has the corresponding changes in order to = incorporate with opensbi tag v0.6, however opensbi tag v0.6 is not released= yet (supposed to release in weeks ago). Our changes were made based on ope= nsbi tag v0.6 though.
Please stay in tune with my email send to edk2 mail list for the RISC-V ed= k2 port readiness.
Opensbi changes often, that is expected we get build error with the master= . So I will make sure everything is good once 0.6 is released.

Thanks
Abner
 

> -----Original Message-----
> From: Rebecca Cran [mailto:rebec= ca@bsdio.com]
> Sent: Monday, February 10, 2020 8:11 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>; Chen, Gilbert <gilbert.chen@hpe.com&g= t;
> Subject: Re: [staging/RISC-V-V2]: Need to bump opensbi submodule to g= et
> sbi_hfence.S etc.
>
> On 2020-02-09 12:07, Rebecca Cran wrote:
> > I recently got a HiFive Unleashed board, and am interested in tr= ying
> > out RISCV EDK2 firmware either on it or in Qemu.
> >
> > It looks like the opensbi submodule in
> > edk2-staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi needs upda= ted
> > though: the commit currently used -
> > be92da280d87c38a2e0adc5d3f43bab7b5468f09 - is missing files such= as
> > sbi_hfence.S mentioned in
> > RiscVPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf .
>
>
> After updating the opensbi submodule to master, I now get a compile e= rror:
>
>
> /home/bcran/workspace/edk2-
> staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:=
> In function 'sbi_ecall_find_extension':
> /home/bcran/workspace/edk2-
> staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:= 32:11:
> error: implicit declaration of function 'container_of'
> [-Werror=3Dimplicit-function-declaration]
>   sbi_list_for_each_entry(t, &ecall_exts_list, head) {
>            ^~~~~~~~= ~~~~
> /home/bcran/workspace/edk2-
> staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:= 32:50:
> error: expected expression before 'typeof'
>   sbi_list_for_each_entry(t, &ecall_exts_list, head) {
>            &nb= sp;            =             &nb= sp;            = ^~~~
> /home/bcran/workspace/edk2-
> staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:= 32:132:
> error: expected expression before 'typeof'
>   sbi_list_for_each_entry(t, &ecall_exts_list, head) {
>
> ^
> /home/bcran/workspace/edk2-
> staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:=
> In function 'sbi_ecall_unregister_extension':
> /home/bcran/workspace/edk2-
> staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:= 64:50:
> error: expected expression before 'typeof'
>   sbi_list_for_each_entry(t, &ecall_exts_list, head) {
>            &nb= sp;            =             &nb= sp;            = ^~~~
> /home/bcran/workspace/edk2-
> staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:= 64:132:
> error: expected expression before 'typeof'
>   sbi_list_for_each_entry(t, &ecall_exts_list, head) {
>
> ^
> cc1: all warnings being treated as errors
>
> --
> Rebecca Cran
>




--_000_DF4PR8401MB07776DE2760A48A1362FCDBDE0190DF4PR8401MB0777_--