From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web09.4681.1603951676681173793 for ; Wed, 28 Oct 2020 23:07:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=I7aPDIRp; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=057147ffc3=nickle.wang@hpe.com) Received: from pps.filterd (m0134422.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 09T67l1w012408 for ; Thu, 29 Oct 2020 06:07:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=lmAVN49lBSc/qVqlHGan7xRNJgmlgIIIObkgL/kvTPY=; b=I7aPDIRpofy5RY+NCDe4l5PM0Q0fCDn8GTfBYlWzyqrExgdNBZg/68fPuhSuPR5NSP5z 8DIt6l9mfsCvXP2ybsBshFGtq3FC6UNrq2xXTx8JqiEgyOvMRp0QxElekKi9lPVpn4z1 Xq8JRGDQri4tFDEx2+99ZWZv31aBZ6lrfIXDbssohanKc6QH5ZRGAB476GmHrZ+x+ZMO NxyG8y67y5oDGecJ4zvYybq7QMR/qQ58vt30FY3hZMJCto7ePCFdIBQiUhFGnhpRZ85f Ht3IBY4bpsGJ4lT8sp8Q8Sj2eeMyOjMqe7jjOonNxPDa5vLuiFjtMRsHbP560qkMPZ+S Kw== Received: from g4t3425.houston.hpe.com (g4t3425.houston.hpe.com [15.241.140.78]) by mx0b-002e3701.pphosted.com with ESMTP id 34fan1p4da-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 29 Oct 2020 06:07:55 +0000 Received: from G1W8107.americas.hpqcorp.net (g1w8107.austin.hp.com [16.193.72.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3425.houston.hpe.com (Postfix) with ESMTPS id DE5EBAA for ; Thu, 29 Oct 2020 06:07:54 +0000 (UTC) Received: from G9W8454.americas.hpqcorp.net (2002:10d8:a104::10d8:a104) by G1W8107.americas.hpqcorp.net (2002:10c1:483b::10c1:483b) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 29 Oct 2020 06:07:54 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (15.241.52.13) by G9W8454.americas.hpqcorp.net (16.216.161.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 29 Oct 2020 06:07:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iFZXOR4oyEU11Olk4UHke7qkG5j26p9dEmeyG66CVCPA62jc48NnMyABnYVfP9ixegPiOvCXoL828mj+qda9/Z7oUgnyvXCAxS2RLbXW/NYWNQnEHqixTKuujas1PV2n3QYQvKywjEvS+mHvHoo9Mt/0yT8yIwFwz/hSNqvYDNupQKCJfSUVANHduB/SatTu3yQJjzqiBJ8teFs4FWK8Hg/xIpqPDypKsrJQqLM+d12yqf+8naZWZzu1y07Wu32fG88PzMZdQOyVlt0AcuYX74G4+EiokEVPgv+LghU5gYbXnuGO180xqv64qgX0zSNoNfl2mNaSOSDtjH+FPUn/Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lmAVN49lBSc/qVqlHGan7xRNJgmlgIIIObkgL/kvTPY=; b=FQmoT9eX9Bi186j+uyG3jqEgACib6jdl80jGyUE5c4EvynQj1Y91pyd17GY0kDoOg5niYQbDySiiwKjN2mjr2Gxf/7sADtklQjXVtM/OGgKlO7GB8t9KFXjU+CSQGI/tXtGoYzioYJA6YxZpLu+IKHRnPpfWraZdRgIrTcOr5ovwi/fvMYLt1hwZ9A6cllEjsTeKOrhbLJ97ZT4+E21CZYimo9k3UHtG0Zu17KRyQ+eObr8cyNTO2FicyAesRAVnpUpTPzgvHjWTtEpGxhuZy5t6bcGyF4FTxCkpiFZPNOU0JfTB0PPZGCmvHSbuLldkQ+mqpYGzfk9NSE6vy9TBvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::7) by DF4PR8401MB0393.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7605::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.22; Thu, 29 Oct 2020 06:07:53 +0000 Received: from DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c9cf:9c73:a8a5:331b]) by DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c9cf:9c73:a8a5:331b%12]) with mapi id 15.20.3499.018; Thu, 29 Oct 2020 06:07:53 +0000 From: "Nickle Wang" To: "Chang, Abner (HPS SW/FW Technologist)" , "devel@edk2.groups.io" CC: Jiaxin Wu , Siyuan Fu , Fan Wang , Jiewen Yao Subject: Re: [EFI Redfish Host Interface PATCH 1/5] RedfishPkg/Include: Definitions of SMBIOS Redfish Host Interface Thread-Topic: [EFI Redfish Host Interface PATCH 1/5] RedfishPkg/Include: Definitions of SMBIOS Redfish Host Interface Thread-Index: AQHWoRywUNTaEy2H6UW3tUuMKKu3jamuMVRg Date: Thu, 29 Oct 2020 06:07:53 +0000 Message-ID: References: <20201013040805.20523-1-abner.chang@hpe.com> <20201013040805.20523-2-abner.chang@hpe.com> In-Reply-To: <20201013040805.20523-2-abner.chang@hpe.com> Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: hpe.com; dkim=none (message not signed) header.d=none;hpe.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [36.224.251.48] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: db4195b3-8391-484e-a148-08d87bd0f8ed x-ms-traffictypediagnostic: DF4PR8401MB0393: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: t3hXPLvJPP+jK0ydGMZpg5xXj9MFTP6RoeDnNFz7vHb8wWv7ZKD0hTb54sLEW2BvpVQDuxgVju6TRFfi/g13HWJJDZVwlO0w0sepb/z49wX0tEWvjh8CS4870CjVlWAJzc25zZFEP+Mae2BxMx0PBERZxRyZdkPnz8dbKs2tSdDIX4q4HLgQZszIvFw4VmwgZhHkcEeavyHpJF6zDYUPOnI+7JvqtCJm/Eddz0rh1h9U9gx8yUTv4vFg5CFPKcZK8WMXIBPsYjM8wqaKTsRSUwP09JO0keSilb7el84rjLOJWvSHUax/lphQp4ykrBXWtdDdhmZcw3apSSWpYWCzSA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(366004)(396003)(346002)(136003)(39860400002)(376002)(8936002)(2906002)(5660300002)(55016002)(4326008)(9686003)(52536014)(33656002)(86362001)(71200400001)(186003)(8676002)(66556008)(83380400001)(478600001)(66446008)(110136005)(66476007)(54906003)(6506007)(66946007)(76116006)(316002)(26005)(64756008)(7696005)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: cXk/eHi82LpsgE/ODw+ZVufKZLrHkm+jKE+wZxRZlTIryd/PoANE7JXBlQK021tOxsvBPeb4fSKlndRj83TJg2pwpNUkWb0TVzE/qX4Rr1xfDH6q0HZVinhTC/UJE8pbzKHmI6CNyjr5WQTC/A5kVZn49tPUlTINEob9c+Qh30lAItL4Ch9Sm0NBZbRXaSG1cZKEHGr78QXliKAAKMgiAnrydtMRrgvwsUq2bB/N4LsuodJnNr48+Povr11JYGFEHgMPcyXYzr4APPvKALPCIbdRN7PkpEM0myoQXlfRc6QYTRayEAbseT11hKi1pEyodHDUzI5woaoPb9dQiMw7V4bsgQA5fiok9gFmVw6hvIc5V883YeO6wVvzMQPghUUc7RjXyDn773a2BgmjrI+UDNc3KX2NJua8omubHykdorKfPdSPEodcCtHyOAaej07IDHqUxqGpKWyZ400JZa2na7qHfeFgFL1qCcjLPS50gcrXz8DP31C368igt7C3MLBnGKISWzJ905KUGA3vAEBzU8hPhAs137CvrIlpZfFif/JlYOGZL6MhT6WA6n2aIz7ljtUQ3XhVzRHnfekPc2OsW/Z+YDT7z+vt45CQ1gkeVxnN/uI6H56E16kc68JtUZ9cu98qELUaQziWgyuHUS+DpA== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: db4195b3-8391-484e-a148-08d87bd0f8ed X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2020 06:07:53.1402 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FYLDmdDJxTeUmHio+ltTRYAuob8YM54iFpYriqQPgHEc8P/U9gehFdl36RrBjiMm/eTCyj+e+KErZL5AJjiC2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0393 X-OriginatorOrg: hpe.com X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-10-29_01:2020-10-29,2020-10-29 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 phishscore=0 suspectscore=0 clxscore=1011 impostorscore=0 mlxscore=0 malwarescore=0 bulkscore=0 spamscore=0 mlxlogscore=999 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010290045 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nickle Wang > -----Original Message----- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Tuesday, October 13, 2020 12:08 PM > To: devel@edk2.groups.io > Cc: Jiaxin Wu ; Siyuan Fu ; Fan > Wang ; Jiewen Yao ; Wang, > Nickle (HPS SW) > Subject: [EFI Redfish Host Interface PATCH 1/5] RedfishPkg/Include: > Definitions of SMBIOS Redfish Host Interface >=20 > Add definitions of SMBIOS Type 42 Host Interface. >=20 > Signed-off-by: Jiaxin Wu > Signed-off-by: Siyuan Fu > Signed-off-by: Fan Wang > Signed-off-by: Abner Chang >=20 > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Fan Wang > Cc: Jiewen Yao > Cc: Nickle Wang > --- > .../IndustryStandard/RedfishHostInterface.h | 165 ++++++++++++++++++ > RedfishPkg/RedfishPkg.dec | 3 + > 2 files changed, 168 insertions(+) > create mode 100644 > RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h >=20 > diff --git a/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h > b/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h > new file mode 100644 > index 0000000000..981f8a0cfb > --- /dev/null > +++ b/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h > @@ -0,0 +1,165 @@ > +/** @file > + This file defines the Redfish Interface Specific Data. > + > + Copyright (c) 2019, Intel Corporation. All rights reserved.
> + (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > +**/ > + > +#ifndef REDFISH_HOST_INTERFACE_ > +#define REDFISH_HOST_INTERFACE_ > + > +#include > + > +#define REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB 0x02 // We > don't support this type of interface. > + // Use > REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2 instead. > +#define REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE 0x03 // We > don't support this type of interface. > + // Use > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2 instead. > +#define REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2 0x04 > +#define REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2 0x05 > + > +#define > REDFISH_HOST_INTERFACE_HOST_IP_ASSIGNMENT_TYPE_UNKNOWN > 0x00 > +#define REDFISH_HOST_INTERFACE_HOST_IP_ASSIGNMENT_TYPE_STATIC > 0x01 > +#define REDFISH_HOST_INTERFACE_HOST_IP_ASSIGNMENT_TYPE_DHCP > 0x02 > +#define > REDFISH_HOST_INTERFACE_HOST_IP_ASSIGNMENT_TYPE_AUTO_CONFIGU > RE 0x03 > +#define > REDFISH_HOST_INTERFACE_HOST_IP_ASSIGNMENT_TYPE_HOST_SELECTED > 0x04 > + > +#define > REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_UNKNOWN > 0x00 > +#define REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP4 > 0x01 > +#define REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP6 > 0x02 > + > +#pragma pack(1) > +/// > +/// Structure definitions of Host Interface device type 04h (USB Network > Interface V2) > +/// > +typedef struct { > + UINT8 Length; ///< Length of the structure,= including Device > Type > + ///< and Length fields. > + UINT16 IdVendor; ///< The Vendor ID of the dev= ice, as read > from the > + ///< idVendor field of the US= B descriptor. > + UINT16 IdProduct; ///< The Product ID of the de= vice, as read > from the > + ///< idProduct field of the U= SB descriptor. > + UINT8 SecialNumberStr; ///< The string number for th= e Serial > Number of the > + ///< device. The string data = is read from the > + ///< iSerialNumber.bDescripto= rType field of the USB > + ///< descriptor, and is conve= rted from Unicode to > ASCII > + ///< and is NULL terminated. > + UINT8 MacAddress [6]; ///< The MAC address of the P= CI/PCIe > network device. > +} USB_INTERFACE_DEVICE_DESCRIPTOR_V2; > + > +// > +// Structure definitions of Host Interface device type 05h (PCI/PCIE V2) > +// > +typedef struct { > + UINT8 Length; ///< Length of the struc= ture, including > Device Type and Length fields. > + UINT16 VendorId; ///< The Vendor ID of th= e PCI/PCIe > device. > + UINT16 DeviceId; ///< The Device ID of th= e PCI/PCIe device. > + UINT16 SubsystemVendorId; ///< The Subsystem Vendo= r ID of > the PCI/PCIe device. > + UINT16 SubsystemId; ///< The Subsystem ID of= the PCI/PCIe > device. > + UINT8 MacAddress [6]; ///< The MAC address of = the PCI/PCIe > network device. > + UINT16 SegmemtGroupNumber; ///< The Segment Group > Number of the PCI/PCIe. > + UINT8 BusNumber; ///< The Bus Number of t= he PCI/PCIe > device. > + UINT8 DeviceFunctionNumber; ///< The Device/Function= Number > of the PCI/PCIe. > +} PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2; > + > +/// > +/// Structure definitions of Host Interface device type 80-FFh (OEM) > +/// > +typedef struct { > + UINT32 VendorIana; ///< The IANA code for th= e vendor (MSB > first). > + UINT8 OemDefinedData[1]; ///< OEM defined data. > +} OEM_DEVICE_DESCRIPTOR; > + > +/// > +/// Interface Specific Data starts at offset 06h of the SMBIOS Type 42 = struct. > +/// This table defines the Interface Specific data for Interface Type 4= 0h. > There > +/// are 3 types of Device Descriptor3 defined , however only 1 may be u= sed > in > +/// specific Tape 42 table. > +/// > +typedef struct { > + UINT8 DeviceType; ///< The Device Type of the interface. > + union { > + USB_INTERFACE_DEVICE_DESCRIPTOR_V2 UsbDeviceV2; ///< > Device type USB V2 device discriptor. > + PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2 PciPcieDeviceV2; > ///< Device type PCI/PCIe V2 device discriptor. > + OEM_DEVICE_DESCRIPTOR OemDevice; ///< OE= M type > device discriptor. > + } DeviceDescriptor; /// Device descriptor data formated based on Devic= e > Type. > + > +} REDFISH_INTERFACE_DATA; > + > +// > +// the protocol-specific data for the "Redfish Over IP" protocol > +// > +typedef struct { > + EFI_GUID ServiceUuid; //same as Redfish Service UUID in Re= dfish > Service Root resource > + > + // > + // Unknown=3D00h, > + // Static=3D01h, > + // DHCP=3D02h, > + // AutoConfigure=3D03h, > + // HostSelected=3D04h, > + // other values reserved > + // > + UINT8 HostIpAssignmentType; > + > + // > + // Unknown=3D00h, > + // Ipv4=3D01h, > + // Ipv6=3D02h, > + // other values reserved > + // > + UINT8 HostIpAddressFormat; > + > + // > + // Used for Static and AutoConfigure. > + // For IPV4, use the first 4 Bytes and zero fill the remaining bytes. > + // > + UINT8 HostIpAddress[16]; > + > + // > + // Used for Static and AutoConfigure. > + // For IPV4, use the first 4 Bytes and zero fill the remaining bytes. > + // > + UINT8 HostIpMask[16]; > + > + // > + // Unknown=3D00h, > + // Static=3D01h, > + // DHCP=3D02h, > + // AutoConfigure=3D03h, > + // HostSelected=3D04h, > + // other values reserved > + // > + UINT8 RedfishServiceIpDiscoveryType; > + > + // > + // Unknown=3D00h, > + // Ipv4=3D01h, > + // Ipv6=3D02h, > + // other values reserved > + // > + UINT8 RedfishServiceIpAddressFormat; > + > + // > + // Used for Static and AutoConfigure. > + // For IPV4, use the first 4 Bytes and zero fill the remaining bytes. > + // > + UINT8 RedfishServiceIpAddress[16]; > + > + // > + // Used for Static and AutoConfigure. > + // For IPV4, use the first 4 Bytes and zero fill the remaining bytes. > + // > + UINT8 RedfishServiceIpMask[16]; > + > + UINT16 RedfishServiceIpPort; // Used for Static and Auto= Configure. > + UINT32 RedfishServiceVlanId; // Used for Static and Auto= Configure. > + UINT8 RedfishServiceHostnameLength; // length of the f= ollowing > hostname string > + UINT8 RedfishServiceHostname[1]; // hostname of Redfish= Service > +} REDFISH_OVER_IP_PROTOCOL_DATA; > + > +#pragma pack() > + > +#endif > + > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec > index e95ec5fe10..de3611252e 100644 > --- a/RedfishPkg/RedfishPkg.dec > +++ b/RedfishPkg/RedfishPkg.dec > @@ -13,6 +13,9 @@ > PACKAGE_GUID =3D c432b76e-5232-11e7-9010-005056c00008 > PACKAGE_VERSION =3D 1.0 >=20 > +[Includes] > + Include > + > [Guids] > gEfiRedfishPkgTokenSpaceGuid =3D { 0x4fdbccb7, 0xe829, 0x4b4c, { = 0x88, > 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }} >=20 > -- > 2.17.1