public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nickle Wang" <nickle.wang@hpe.com>
To: "Chang, Abner (HPS SW/FW Technologist)" <abner.chang@hpe.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>,
	Fan Wang <fan.wang@intel.com>, Jiewen Yao <jiewen.yao@intel.com>
Subject: Re: [EFI Redfish Host Interface PATCH v2 3/6] RedfishPkg/PlatformHostInterfaceLib: Platform NULL lib
Date: Mon, 2 Nov 2020 03:51:10 +0000	[thread overview]
Message-ID: <DF4PR8401MB081241A2FA863D438BE62A00FF100@DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20201030100209.9954-4-abner.chang@hpe.com>

Reviewed-by: Nickle Wang <nickle.wang@hpe.com>

> -----Original Message-----
> From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
> Sent: Friday, October 30, 2020 6:02 PM
> To: devel@edk2.groups.io
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>; Siyuan Fu <siyuan.fu@intel.com>; Fan
> Wang <fan.wang@intel.com>; Jiewen Yao <jiewen.yao@intel.com>; Wang,
> Nickle (HPS SW) <nickle.wang@hpe.com>
> Subject: [EFI Redfish Host Interface PATCH v2 3/6]
> RedfishPkg/PlatformHostInterfaceLib: Platform NULL lib
> 
> NULL instance of PlatformHostInterfaceLib.
> 
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> 
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Fan Wang <fan.wang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> ---
>  .../PlatformHostInterfaceLibNull.c            | 52 +++++++++++++++++++
>  .../PlatformHostInterfaceLibNull.inf          | 33 ++++++++++++
>  2 files changed, 85 insertions(+)
>  create mode 100644
> RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceLibN
> ull.c
>  create mode 100644
> RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceLibN
> ull.inf
> 
> diff --git
> a/RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceLi
> bNull.c
> b/RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceLi
> bNull.c
> new file mode 100644
> index 0000000000..5c93a003e3
> --- /dev/null
> +++ b/RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterf
> +++ aceLibNull.c
> @@ -0,0 +1,52 @@
> +/** @file
> +  NULL instace of RedfishPlatformHostInterfaceLib
> +
> +  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> +
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +#include <Uefi.h>
> +#include <Library/BaseLib.h>
> +#include <Library/RedfishHostInterfaceLib.h>
> +#include <Library/UefiLib.h>
> +
> +/**
> +  Get platform Redfish host interface device descriptor.
> +
> +  @param[in] DeviceType         Pointer to retrieve device type.
> +  @param[out] DeviceDescriptor  Pointer to retrieve
> REDFISH_INTERFACE_DATA, caller has to free
> +                                this memory using FreePool().
> +
> +  @retval EFI_NOT_FOUND   No Redfish host interface descriptor provided
> on this platform.
> +
> +**/
> +EFI_STATUS
> +RedfishPlatformHostInterfaceDeviceDescriptor (
> +  IN UINT8 *DeviceType,
> +  OUT REDFISH_INTERFACE_DATA  **DeviceDescriptor
> +)
> +{
> +  return EFI_NOT_FOUND;
> +}
> +/**
> +  Get platform Redfish host interface protocol data.
> +  Caller should pass NULL in ProtocolRecord to retrive the first protocol
> record.
> +  Then continuously pass previous ProtocolRecord for retrieving the next
> ProtocolRecord.
> +
> +  @param[in, out] ProtocolRecord  Pointer to retrieve the first or the next
> protocol record.
> +                                  caller has to free the new protocol record returned from
> +                                  this function using FreePool().
> +  @param[in] IndexOfProtocolData  The index of protocol data.
> +
> +  @retval EFI_NOT_FOUND   No more protocol records.
> +
> +**/
> +EFI_STATUS
> +RedfishPlatformHostInterfaceProtocolData (
> +  IN OUT MC_HOST_INTERFACE_PROTOCOL_RECORD **ProtocolRecord,
> +  IN UINT8  IndexOfProtocolData
> +)
> +{
> +  return EFI_NOT_FOUND;
> +}
> diff --git
> a/RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceLi
> bNull.inf
> b/RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceLi
> bNull.inf
> new file mode 100644
> index 0000000000..b42e5335ee
> --- /dev/null
> +++ b/RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterf
> +++ aceLibNull.inf
> @@ -0,0 +1,33 @@
> +## @file
> +#  NULL instance of RedfishPlatformHostInterfaceLib # #  (C) Copyright
> +2020 Hewlett Packard Enterprise Development LP<BR> # #
> +SPDX-License-Identifier: BSD-2-Clause-Patent # ##
> +
> +[Defines]
> +  INF_VERSION                    = 0x0001000b
> +  BASE_NAME                      = RedfishPlatformHostInterfaceLibNull
> +  FILE_GUID                      = 851229BF-4D8B-30F3-DD0D-20AFAF99A77B
> +  MODULE_TYPE                    = DXE_DRIVER
> +  VERSION_STRING                 = 1.0
> +  LIBRARY_CLASS                  = RedfishPlatformHostInterfaceLib
> +
> +#
> +#  VALID_ARCHITECTURES           = IA32 X64 ARM AARCH64 RISCV64
> +#
> +
> +[Sources]
> +  PlatformHostInterfaceLibNull.c
> +
> +[Packages]
> +  MdePkg/MdePkg.dec
> +  MdeModulePkg/MdeModulePkg.dec
> +  RedfishPkg/RedfishPkg.dec
> +
> +[LibraryClasses]
> +  UefiLib
> +  BaseLib
> +
> --
> 2.17.1


  reply	other threads:[~2020-11-02  3:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30 10:02 [EFI Redfish Host Interface PATCH v2 0/6] Create SMBIOS type 42 record Abner Chang
2020-10-30 10:02 ` [EFI Redfish Host Interface PATCH v2 1/6] RedfishPkg/Include: Definitions of SMBIOS Redfish Host Interface Abner Chang
2020-10-30 10:02 ` [EFI Redfish Host Interface PATCH v2 2/6] RedfishPkg/Include: PlatformHostInterfaceLib header file Abner Chang
2020-11-02  3:51   ` Nickle Wang
2020-10-30 10:02 ` [EFI Redfish Host Interface PATCH v2 3/6] RedfishPkg/PlatformHostInterfaceLib: Platform NULL lib Abner Chang
2020-11-02  3:51   ` Nickle Wang [this message]
2020-10-30 10:02 ` [EFI Redfish Host Interface PATCH v2 4/6] RedfishPkg/RedfishHostInterfaceDxe: Create SMBIOS type 42 record Abner Chang
2020-10-30 10:02 ` [EFI Redfish Host Interface PATCH v2 5/6] RedfishPkg: Add RedfishHostInterfaceDxe to RedfishPkg Abner Chang
2020-11-02  3:52   ` Nickle Wang
2020-10-30 10:02 ` [EFI Redfish Host Interface PATCH v2 6/6] RedfishPkg: Changes on RedfishPkg for CI test Abner Chang
2020-11-02  3:52   ` Nickle Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DF4PR8401MB081241A2FA863D438BE62A00FF100@DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox