From: "Nickle Wang" <nickle.wang@hpe.com>
To: "Chang, Abner (HPS SW/FW Technologist)" <abner.chang@hpe.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "O'Hanley, Peter (EXL)" <peter.ohanley@hpe.com>
Subject: Re: [PATCH v5 5/6] RedfishPkg: Add EDK2 port of jansson library to build
Date: Thu, 10 Dec 2020 02:59:03 +0000 [thread overview]
Message-ID: <DF4PR8401MB081241E2ED5BB87CC55EC668FFCB0@DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20201208021048.9104-6-abner.chang@hpe.com>
Reviewed-by: Nickle Wang <nickle.wang@hpe.com>
> -----Original Message-----
> From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
> Sent: Tuesday, December 8, 2020 10:11 AM
> To: devel@edk2.groups.io
> Cc: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; O'Hanley, Peter (EXL)
> <peter.ohanley@hpe.com>
> Subject: [PATCH v5 5/6] RedfishPkg: Add EDK2 port of jansson library to build
>
> Add EDK2 port jansson library (JsonLib) to RedfishPkg
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Peter O'Hanley <peter.ohanley@hpe.com>
> ---
> RedfishPkg/RedfishLibs.dsc.inc | 2 ++
> RedfishPkg/RedfishPkg.dec | 11 +++++++++++
> RedfishPkg/RedfishPkg.dsc | 2 ++
> 3 files changed, 15 insertions(+)
>
> diff --git a/RedfishPkg/RedfishLibs.dsc.inc b/RedfishPkg/RedfishLibs.dsc.inc
> index d4c08e18ac..bc036a33e8 100644
> --- a/RedfishPkg/RedfishLibs.dsc.inc
> +++ b/RedfishPkg/RedfishLibs.dsc.inc
> @@ -12,5 +12,7 @@
> ##
> !if $(REDFISH_ENABLE) == TRUE
> Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
> + CrtLib|RedfishPkg/Library/CrtLib/CrtLib.inf
> + JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf
> !endif
>
> diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec
> index aecc1f4a3a..c21657e349 100644
> --- a/RedfishPkg/RedfishPkg.dec
> +++ b/RedfishPkg/RedfishPkg.dec
> @@ -25,6 +25,17 @@
> #
> Ucs2Utf8Lib|Include/Library/BaseUcs2Utf8Lib.h
>
> + ## @libraryclass Provides the C runtime library functions
> + # CRT library is currently used by edk2 JsonLib (open source
> + # jansson project) and edk2 RedfishLib (libredfish open source
> + # project).
> + CrtLib|Include/Library/CrtLib.h
> +
> + ## @libraryclass Provides the library functions based on third party
> + # jansson library to manipulate JSON data structure.
> + #
> + JsonLib|Include/Library/JsonLib.h
> +
> [Protocols]
> ## Include/Protocol/RedfishDiscover.h
> gEfiRedfishDiscoverProtocolGuid = { 0x5db12509, 0x4550, 0x4347, { 0x96,
> 0xb3, 0x73, 0xc0, 0xff, 0x6e, 0x86, 0x9f }}
> diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc
> index d198a94b73..515e453c00 100644
> --- a/RedfishPkg/RedfishPkg.dsc
> +++ b/RedfishPkg/RedfishPkg.dsc
> @@ -44,5 +44,7 @@
> [Components]
>
> RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceLibN
> ull.inf
> RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
> + RedfishPkg/Library/JsonLib/JsonLib.inf
> + RedfishPkg/Library/CrtLib/CrtLib.inf
>
> !include RedfishPkg/Redfish.dsc.inc
> --
> 2.17.1
next prev parent reply other threads:[~2020-12-10 2:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 2:10 [PATCH v5 0/6] jansson edk2 port Abner Chang
2020-12-08 2:10 ` [PATCH v5 1/6] RedfishPkg/Ucs2Utf8lib: UCS2 to UFT8 manipulation library Abner Chang
2020-12-10 2:48 ` Nickle Wang
2020-12-10 13:49 ` [edk2-devel] " Samer El-Haj-Mahmoud
2020-12-10 14:27 ` Abner Chang
2020-12-10 16:43 ` Samer El-Haj-Mahmoud
2020-12-11 0:37 ` Abner Chang
2020-12-08 2:10 ` [PATCH v5 2/6] edk2: jansson submodule for edk2 JSON library Abner Chang
2020-12-10 2:50 ` Nickle Wang
2020-12-08 2:10 ` [PATCH v5 3/6] RedfishPkg/CrtLib: C runtime library Abner Chang
2020-12-10 2:54 ` Nickle Wang
2020-12-08 2:10 ` [PATCH v5 4/6] RedfishPkg/library: EDK2 port of jansson library Abner Chang
2020-12-10 2:58 ` Nickle Wang
2020-12-08 2:10 ` [PATCH v5 5/6] RedfishPkg: Add EDK2 port of jansson library to build Abner Chang
2020-12-10 2:59 ` Nickle Wang [this message]
2020-12-08 2:10 ` [PATCH v5 6/6] .pytool: Add required submodule for JsonLib Abner Chang
2020-12-08 6:39 ` 回复: [edk2-devel] [PATCH v5 0/6] jansson edk2 port gaoliming
2020-12-10 2:13 ` Abner Chang
2020-12-10 2:33 ` Michael D Kinney
2020-12-10 4:02 ` Abner Chang
2020-12-11 19:22 ` Michael D Kinney
2020-12-13 4:01 ` Abner Chang
2020-12-14 1:29 ` 回复: " gaoliming
2020-12-14 1:58 ` Abner Chang
2020-12-16 2:08 ` Abner Chang
2020-12-16 2:57 ` Michael D Kinney
2020-12-16 15:04 ` Abner Chang
2020-12-14 16:10 ` Abner Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DF4PR8401MB081241E2ED5BB87CC55EC668FFCB0@DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox