public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nickle Wang" <nickle.wang@hpe.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Chang, Abner (HPS SW/FW Technologist)" <abner.chang@hpe.com>
Cc: "O'Hanley, Peter (EXL)" <peter.ohanley@hpe.com>
Subject: Re: [edk2-devel] [Platform Redfish Host Interface PATCH 1/6] RedfishPkg: Add PCD definition to RedfishPkg
Date: Mon, 9 Nov 2020 04:24:55 +0000	[thread overview]
Message-ID: <DF4PR8401MB081266651F082F59A2563116FFEA0@DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20201105143853.2180-2-abner.chang@hpe.com>

Reviewed-by: Nickle Wang <nickle.wang@hpe.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner
> Chang
> Sent: Thursday, November 5, 2020 10:39 PM
> To: devel@edk2.groups.io
> Cc: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; O'Hanley, Peter (EXL)
> <peter.ohanley@hpe.com>
> Subject: [edk2-devel] [Platform Redfish Host Interface PATCH 1/6]
> RedfishPkg: Add PCD definition to RedfishPkg
> 
> This PCD is the UEFI device path which is used as the Redfish host interface.
> 
> Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
> Signed-off-by: Ting Ye <ting.ye@intel.com>
> Signed-off-by: Siyuan Fu <siyuan.fu@intel.com>
> Signed-off-by: Fan Wang <fan.wang@intel.com>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> 
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Peter O'Hanley <peter.ohanley@hpe.com>
> ---
>  RedfishPkg/RedfishPkg.dec | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec index
> f12f83526c..b38e9b4789 100644
> --- a/RedfishPkg/RedfishPkg.dec
> +++ b/RedfishPkg/RedfishPkg.dec
> @@ -28,3 +28,25 @@
>  [Guids]
>    gEfiRedfishPkgTokenSpaceGuid      = { 0x4fdbccb7, 0xe829, 0x4b4c, { 0x88,
> 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }}
> 
> +[PcdsFixedAtBuild, PcdsPatchableInModule]
> +  #
> +  # This PCD is the UEFI device path which is used as the Redfish host
> interface.
> +  #
> +
> +gEfiRedfishPkgTokenSpaceGuid.PcdRedfishRestExServiceDevicePath|{0x0}
> |RE
> +ST_EX_SERVICE_DEVICE_PATH_DATA|0x00001000 {
> +  <HeaderFiles>
> +    Pcd/RestExServiceDevicePath.h
> +  <Packages>
> +    MdePkg/MdePkg.dec
> +    MdeModulePkg/MdeModulePkg.dec
> +    RedfishPkg/RedfishPkg.dec
> +  }
> +  #
> +  # This PCD indicates the EFI REST EX access mode to Redfish service.
> +  # Default is set to out of band access.
> +  #
> +
> +gEfiRedfishPkgTokenSpaceGuid.PcdRedfishRestExServiceAccessModeInBa
> nd|FA
> +LSE|BOOLEAN|0x00001001
> +  #
> +  # This PCD indicates the access mode EFI Discover protocol uses to
> +look for the proper EFI REST EX
> +  # protocol instance.
> +  #
> +
> +gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDiscoverAccessModeInBand|FA
> LSE|B
> +OOLEAN|0x00001002
> --
> 2.17.1
> 
> 
> 
> 
> 


  reply	other threads:[~2020-11-09  4:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-05 14:38 [Platform Redfish Host Interface PATCH 0/6] Enable Platform Redfish Abner Chang
2020-11-05 14:38 ` [Platform Redfish Host Interface PATCH 1/6] RedfishPkg: Add PCD definition to RedfishPkg Abner Chang
2020-11-09  4:24   ` Nickle Wang [this message]
2020-11-05 14:38 ` [Platform Redfish Host Interface PATCH 2/6] RedfishPkg: DSC and FDF include files for enabling EFI Redfish support Abner Chang
2020-11-09  4:26   ` [edk2-devel] " Nickle Wang
2020-11-05 14:38 ` [Platform Redfish Host Interface PATCH 3/6] EmulatorPkg/RedfishPlatformHostInterfaceLib library Abner Chang
2020-11-05 14:38 ` [Platform Redfish Host Interface PATCH 4/6] EmulatorPkg/Application: Publish Redfish Host Interface Record Abner Chang
2020-11-05 14:38 ` [Platform Redfish Host Interface PATCH 5/6] EmulatorPkg: Add allowable dependency Abner Chang
2020-11-05 14:38 ` [Platform Redfish Host Interface PATCH 6/6] EmulatorPkg: Redfish related changes on EmulatorPkg Abner Chang
     [not found] ` <1644A5FDFD825A04.31306@groups.io>
2020-11-24  9:24   ` [edk2-devel] [Platform Redfish Host Interface PATCH 3/6] EmulatorPkg/RedfishPlatformHostInterfaceLib library Ni, Ray
     [not found] ` <1644A5FE6C306DA9.32447@groups.io>
2020-11-24  9:24   ` [edk2-devel] [Platform Redfish Host Interface PATCH 5/6] EmulatorPkg: Add allowable dependency Ni, Ray
     [not found] ` <1644A5FF1778E4F7.31306@groups.io>
2020-11-24  9:24   ` [edk2-devel] [Platform Redfish Host Interface PATCH 6/6] EmulatorPkg: Redfish related changes on EmulatorPkg Ni, Ray
     [not found] ` <1644A5FE1ACD3DCB.8528@groups.io>
2020-12-03  5:25   ` [edk2-devel] [Platform Redfish Host Interface PATCH 4/6] EmulatorPkg/Application: Publish Redfish Host Interface Record Ni, Ray
2020-12-03  5:41     ` Abner Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DF4PR8401MB081266651F082F59A2563116FFEA0@DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox