From: "Nickle Wang" <nickle.wang@hpe.com>
To: "Chang, Abner (HPS SW/FW Technologist)" <abner.chang@hpe.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [PATCH V2] RedfishPkg/RefishCrtLib: Public RefishCrtLib
Date: Wed, 11 Aug 2021 04:03:48 +0000 [thread overview]
Message-ID: <DF4PR8401MB081297618EF0B21761A7094DFFF89@DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20210811030112.7330-1-abner.chang@hpe.com>
Reviewed-by: Nickle Wang <nickle.wang@hpe.com>
Thanks,
Nickle
-----Original Message-----
From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
Sent: Wednesday, August 11, 2021 11:01 AM
To: devel@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
Subject: [PATCH V2] RedfishPkg/RefishCrtLib: Public RefishCrtLib
Public the header file, move RefishCrtLib.h from PrivateInclude/ to Include/.
RefishCrtLib.lib will be public later. (Moved out from PrivateLibrary/)
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Reviewed-by: Nickle Wang <nickle.wang@hpe.com>
---
RedfishPkg/{PrivateInclude => Include}/Library/RedfishCrtLib.h | 2 +-
.../RedfishLib/edk2libredfish/include/redfishPayload.h | 2 +-
.../RedfishLib/edk2libredfish/include/redfishService.h | 2 +-
.../PrivateLibrary/RedfishLib/edk2libredfish/include/redpath.h | 2 +-
RedfishPkg/RedfishPkg.ci.yaml | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-) rename RedfishPkg/{PrivateInclude => Include}/Library/RedfishCrtLib.h (96%)
diff --git a/RedfishPkg/PrivateInclude/Library/RedfishCrtLib.h b/RedfishPkg/Include/Library/RedfishCrtLib.h
similarity index 96%
rename from RedfishPkg/PrivateInclude/Library/RedfishCrtLib.h
rename to RedfishPkg/Include/Library/RedfishCrtLib.h
index 28a493d782..5e15768938 100644
--- a/RedfishPkg/PrivateInclude/Library/RedfishCrtLib.h
+++ b/RedfishPkg/Include/Library/RedfishCrtLib.h
@@ -2,7 +2,7 @@
Redfish CRT wrapper functions.
Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
- (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
+ (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishPayload.h b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishPayload.h
index 03380d9394..43149f3c89 100644
--- a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishPayload.h
+++ b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfis
+++ hPayload.h
@@ -17,7 +17,7 @@
#ifndef LIBREDFISH_REDFISH_PAYLOAD_H_
#define LIBREDFISH_REDFISH_PAYLOAD_H_
-#include <PrivateInclude/Library/RedfishCrtLib.h>
+#include <Include/Library/RedfishCrtLib.h>
#include <jansson.h>
#include <redfishService.h>
diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishService.h b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishService.h
index 5bcb381c05..0215caccfc 100644
--- a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishService.h
+++ b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfis
+++ hService.h
@@ -30,7 +30,7 @@
#include <Library/UefiRuntimeServicesTableLib.h>
#include <Library/UefiBootServicesTableLib.h>
-#include <PrivateInclude/Library/RedfishCrtLib.h>
+#include <Include/Library/RedfishCrtLib.h>
#include <Protocol/EdkIIRedfishConfigHandler.h>
#include <Protocol/RestEx.h>
diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redpath.h b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redpath.h
index bdec6098e5..24413a648a 100644
--- a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redpath.h
+++ b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redpat
+++ h.h
@@ -17,7 +17,7 @@
#ifndef LIBREDFISH_REDPATH_H_
#define LIBREDFISH_REDPATH_H_
-#include <PrivateInclude/Library/RedfishCrtLib.h>
+#include <Include/Library/RedfishCrtLib.h>
#include <jansson.h>
diff --git a/RedfishPkg/RedfishPkg.ci.yaml b/RedfishPkg/RedfishPkg.ci.yaml index 1fe9bdb8d1..96133f8c28 100644
--- a/RedfishPkg/RedfishPkg.ci.yaml
+++ b/RedfishPkg/RedfishPkg.ci.yaml
@@ -34,8 +34,8 @@
"PrivateInclude/Crt/stdlib.h",
"PrivateInclude/Crt/string.h",
"PrivateInclude/Crt/time.h",
- "PrivateInclude/Library/RedfishCrtLib.h",
"PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c",
+ "Include/Library/RedfishCrtLib.h",
##
## For jansson library open source
## load.c is overrided from open source.
--
2.17.1
prev parent reply other threads:[~2021-08-11 4:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 3:01 [PATCH V2] RedfishPkg/RefishCrtLib: Public RefishCrtLib Abner Chang
2021-08-11 4:03 ` Nickle Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DF4PR8401MB081297618EF0B21761A7094DFFF89@DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox