From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web09.4797.1603952826413095518 for ; Wed, 28 Oct 2020 23:27:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=Ia8TGW4K; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=057147ffc3=nickle.wang@hpe.com) Received: from pps.filterd (m0148664.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 09T6QZKJ005452 for ; Thu, 29 Oct 2020 06:27:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=Hv5k3Dr08Rz/HRybE05Kzb4hdjZmO5dxVBdpYY5WQG8=; b=Ia8TGW4Kd0NOKg71rZrMed0SknxAq8m91VEtD8z5MbsgmwBE8bLKSsICrnnYOE0n4L7e l9JxUMrGk8c2MfHxYEEKtaJb+VGMIqoGAlJ8rqS4sMEa6EuwoO/3zxll3IEUzozGHWVC c5xuVq2pCKv2n9ro8g+kLXKQHa/IVB5j9o+MZWx+K83Q7DXOx2iY3rUDI1OLeiXNKaSp e4gD3h1BvI6k1MZFQGZUiLyYEwRhwuAyNlyvWhM6Nt8H0IxvG0qmI4DdRLSSSxLvkdzs ZHcaFKWe0cxC4geFsEcMdnGoKW2zfUay39nvDHXM/Ff5VnsgwmSjkP2Q6ZOVAHjxZcwc Fg== Received: from g4t3425.houston.hpe.com (g4t3425.houston.hpe.com [15.241.140.78]) by mx0b-002e3701.pphosted.com with ESMTP id 34ep7erf9n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 29 Oct 2020 06:27:05 +0000 Received: from G9W8453.americas.hpqcorp.net (g9w8453.houston.hp.com [16.216.160.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3425.houston.hpe.com (Postfix) with ESMTPS id 0CFB29D for ; Thu, 29 Oct 2020 06:27:05 +0000 (UTC) Received: from G9W8453.americas.hpqcorp.net (2002:10d8:a0d3::10d8:a0d3) by G9W8453.americas.hpqcorp.net (2002:10d8:a0d3::10d8:a0d3) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 29 Oct 2020 06:27:04 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (15.241.52.10) by G9W8453.americas.hpqcorp.net (16.216.160.211) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 29 Oct 2020 06:27:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R1I8uuXTtKEYQ6dz8fQZJtUhgDendwTSvrD+ZIf3QVIWpyqZT0HtXjOGWf+t2ooK0BudlKI7mYuumewGFHxS7hLRMUNqT9J+soWRGbyR7Gr/WUj1glXOR/9FScSD7bRYAF/ngx4JxhGczQDd08JrlRSw1PSwH2Mp+z6m4sWj1HJbgFSoOscdldz2wxNsSKlYu7jRYtpaHvryMRZdpUCZiFmJp8cxyjwhHBOgQu0pZhUXJ5c21IR3ueaMKZJBXypOfYZuM5z9fhL6mkkoLCrLXWSh2z89FnYE1Pr45HF/oOqKmvevKporkyRODadW+S5dZVYAFT05h9b3Serx3e7X5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hv5k3Dr08Rz/HRybE05Kzb4hdjZmO5dxVBdpYY5WQG8=; b=UuMQc4XN2wGuCiG3RFj77v6qfzTo0Hbn3DEsXY9JyEZBXU2X20y2o1H3qqa1fY421YJCRSJ/6lNpUI2tz0FeBWGGg31s4TeFFQawcp21tTPWn95/klfFwzj6v7EuJRGkrp2Ly9r9Jt8RD3R6S0w316ftzIqTHGFurUavLKt3qsyILSiCWm8DIA3sCr1DRlKGXeoXUbTyGjpbOn0yfPtWoJA9hN+v3AxsPtsWhGafROXtOhwHzpmTZFhCi7l19EAUmKTmQXWhgjqFmq6dcrGuUIx21fX6a+o2aoKiKvQo1m1SUErKchKYkHJB25GBwrrk1jUn05vzylyZwoDJmrb2gA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::7) by DF4PR8401MB0955.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21; Thu, 29 Oct 2020 06:27:03 +0000 Received: from DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c9cf:9c73:a8a5:331b]) by DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c9cf:9c73:a8a5:331b%12]) with mapi id 15.20.3499.018; Thu, 29 Oct 2020 06:27:03 +0000 From: "Nickle Wang" To: "Chang, Abner (HPS SW/FW Technologist)" , "devel@edk2.groups.io" CC: Jiaxin Wu , Siyuan Fu , Fan Wang , Jiewen Yao Subject: Re: [EFI Redfish Host Interface PATCH 3/5] RedfishPkg/PlatformHostInterfaceLib: Platform NULL lib Thread-Topic: [EFI Redfish Host Interface PATCH 3/5] RedfishPkg/PlatformHostInterfaceLib: Platform NULL lib Thread-Index: AQHWoRy2DxyAJLoBMEie9XSGDPmonqmuNn/A Date: Thu, 29 Oct 2020 06:27:03 +0000 Message-ID: References: <20201013040805.20523-1-abner.chang@hpe.com> <20201013040805.20523-4-abner.chang@hpe.com> In-Reply-To: <20201013040805.20523-4-abner.chang@hpe.com> Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: hpe.com; dkim=none (message not signed) header.d=none;hpe.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [36.224.251.48] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9f3c447a-6c4a-423c-e2ce-08d87bd3a669 x-ms-traffictypediagnostic: DF4PR8401MB0955: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:125; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +Ey1e+t/7aQQFWWpmzWz9wyUFoEzKMGJ6VPZylj3KwXRVeTgq7zUy5YxVR8neeib9ARZCBfuw41K44YB0xjceNaG7qhg26UmHiRfMMXlSG6VRd5vkjIHhuo4kdkgw1wQcXqPruc/Fz7Fio4O78AkTfFfZ6YmkBgovOkLlgUkoMh/2nfsPVCaW1DA8nyQ5GpWQ2LD9AEMM652fc10vrcnbwd3lX9xly3c3yOLZfV8iMskmjw1YMUjjGiP285rmXA3/MpV9gZvJEVKObOcR7CwJXZ7wSAIpUbrRuV0mCmLYCiQVbpF/gHYMvlTjDy4tShFfKHXkhNIUz22Q/47DSZ4dA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(346002)(376002)(39860400002)(366004)(136003)(396003)(66946007)(76116006)(478600001)(55016002)(7696005)(53546011)(26005)(86362001)(33656002)(66556008)(4326008)(83380400001)(66446008)(64756008)(52536014)(5660300002)(8676002)(66476007)(6506007)(2906002)(110136005)(316002)(71200400001)(54906003)(186003)(8936002)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: DXQeRAGeEjuzoF1+WE4MA04VFtx1QNLbujaSzhbL+9l0UD/cNlzS1a1OUVDyUohIRM/hhu6fubkAwCEZAHxYoMIlxNunRKAECwpoPENWw16YdJqRdOq9MR+/zy0mm60sSefr6qBU6UtvMcSYQI5yBwr9Xda1C2eJbDe9s51jowZuXP7nFkJi59pDUNwv+tB5D99JP7q934qFYEk7dsUEEt3aAO2dXBGSmJoPtgJjCXo24M/OMWwBlksjmhXX5OWy4Ar0OJ4h5JopEICjGrLmCpOchctUHw0HKR7hvKMB2/JP+SXxLo6VwMSa/mk/qMY3x0lazC1/oBXa0H8kx6dD/97lEeW3/Y+M8QYVyXU1B44Cbk76ghodLNJVrSQbO3YH2uEaOTsXEr9ND4gQbyWE1EoGegVNKzd6oSeqSptYjQnSgY4H9OzC86nIMQdk91CIjAMq0fIW3v19QQyJohYKSL1YpyvuBriIYeti8eG9VJAauDcB82cCdFGiyMHTiBdYzcOwrnCXLMvKabkg/z/wkmJk/CJLG1iQR1uhNL0EaMnm9RTLEzOcMj8IKMQ0WfUiCrpQmJcxmuYI6H405Eq7TDBWNSn3kCLYO3mowy0gAvOkU0wL0WvGgCTpaQ8SPHRKNMCReevVAifpwwz3rD18Gw== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 9f3c447a-6c4a-423c-e2ce-08d87bd3a669 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2020 06:27:03.1529 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4n4oCj/S2YR2PHlealg4lpOMyI+K4vhCoY6dC9K+GAmbbIntbPh06bb+DTYutTkYhHVfy3dVWCb6u3vveIiJLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0955 X-OriginatorOrg: hpe.com X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-10-29_01:2020-10-29,2020-10-29 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 lowpriorityscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 impostorscore=0 phishscore=0 adultscore=0 bulkscore=0 spamscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010290046 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Abner, I do not see any usage of DEBUG macro in this NULL library so maybe "DebugL= ib" could be removed from INF file. Thanks, Nickle > -----Original Message----- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Tuesday, October 13, 2020 12:08 PM > To: devel@edk2.groups.io > Cc: Jiaxin Wu ; Siyuan Fu ; Fan > Wang ; Jiewen Yao ; Wang, > Nickle (HPS SW) > Subject: [EFI Redfish Host Interface PATCH 3/5] > RedfishPkg/PlatformHostInterfaceLib: Platform NULL lib >=20 > NULL instance of PlatformHostInterfaceLib. >=20 > Signed-off-by: Abner Chang >=20 > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Fan Wang > Cc: Jiewen Yao > Cc: Nickle Wang > --- > .../PlatformHostInterfaceLibNull.c | 53 +++++++++++++++++++ > .../PlatformHostInterfaceLibNull.inf | 34 ++++++++++++ > 2 files changed, 87 insertions(+) > create mode 100644 > RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceLibN > ull.c > create mode 100644 > RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceLibN > ull.inf >=20 > diff --git > a/RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceLi > bNull.c > b/RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceLi > bNull.c > new file mode 100644 > index 0000000000..7653f22d25 > --- /dev/null > +++ > b/RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceLi > bNull.c > @@ -0,0 +1,53 @@ > +/** @file > + NULL instace of RedfishPlatformHostInterfaceLib > + > + (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > +#include > +#include > +#include > +#include > + > +/** > + Get platform Redfish host interface device descriptor. > + > + @param[out] DeviceType Pointer to retrieve device type. > + @param[out] DeviceDescriptor Pointer to retrieve > REDFISH_INTERFACE_DATA, caller has to free > + this memory using FreePool(). > + @retval EFI_SUCCESS Device descriptor is returned successfully in > DeviceDescriptor. > + @retval EFI_NOT_FOUND No Redfish host interface descriptor provided > on this platform. > + @retval Others Fail to get device descriptor. > +**/ > +EFI_STATUS > +RedfishPlatformHostInterfaceDeviceDescriptor ( > + IN UINT8 *DeviceType, > + IN REDFISH_INTERFACE_DATA **DeviceDescriptor > +) > +{ > + return EFI_NOT_FOUND; > +} > +/** > + Get platform Redfish host interface protocol data. > + Caller should pass NULL in ProtocolRecord to retrive the first protoco= l > record. > + Then continuously pass previous ProtocolRecord for retrieving the next > ProtocolRecord. > + > + @param[in, out] ProtocolRecord Pointer to retrieve the first or the n= ext > protocol record. > + caller has to free the new protocol re= cord returned from > + this function using FreePool(). > + param[in] IndexOfProtocolData The index of protocol data. > + > + @retval EFI_SUCESS Protocol records are all returned. > + @retval EFI_NOT_FOUND No more protocol records. > + @retval Others Fail to get protocol records. > +**/ > +EFI_STATUS > +RedfishPlatformHostInterfaceProtocolData ( > + IN MC_HOST_INTERFACE_PROTOCOL_RECORD **ProtocolRecord, > + IN UINT8 IndexOfProtocolData > +) > +{ > + return EFI_NOT_FOUND; > +} > diff --git > a/RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceLi > bNull.inf > b/RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceLi > bNull.inf > new file mode 100644 > index 0000000000..bb840ce3cb > --- /dev/null > +++ > b/RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceLi > bNull.inf > @@ -0,0 +1,34 @@ > +## @file > +# NULL instance of RedfishPlatformHostInterfaceLib > +# > +# (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > + INF_VERSION =3D 0x0001000b > + BASE_NAME =3D RedfishPlatformHostInterfaceLibNull > + FILE_GUID =3D 851229BF-4D8B-30F3-DD0D-20AFAF99A77= B > + MODULE_TYPE =3D DXE_DRIVER > + VERSION_STRING =3D 1.0 > + LIBRARY_CLASS =3D RedfishPlatformHostInterfaceLib > + > +# > +# VALID_ARCHITECTURES =3D IA32 X64 ARM AARCH64 > +# > + > +[Sources] > + PlatformHostInterfaceLibNull.c > + > +[Packages] > + MdePkg/MdePkg.dec > + MdeModulePkg/MdeModulePkg.dec > + RedfishPkg/RedfishPkg.dec > + > +[LibraryClasses] > + UefiLib > + BaseLib > + DebugLib > + > -- > 2.17.1