From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web08.974.1605165207884192126 for ; Wed, 11 Nov 2020 23:13:27 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=F+2v5VjL; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=05857eff65=nickle.wang@hpe.com) Received: from pps.filterd (m0148663.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0AC77rWN008944 for ; Thu, 12 Nov 2020 07:13:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=U5rLHsScoJVUikYyDnaM3zGjXI9O8pjOqNA6Nq9kZn0=; b=F+2v5VjLzvOpILY6Z5auMvm9F+xyIpFmHzLuAxPMjJ4ex2rGvgKXY9ZYWq07xibnjBaD ocKI2CHHormFVzNv9lXfhob34Ucrg/IhBD7yVJcZT3QjF+OhFVKqcrRNXOo8YzAdV730 EeJbQgepvNkUh6fHhAYls6mDDWHz2j5mv0KF5awZV9fKABFZcVzo04Q4TxroziuIuWiU gDfdKUqqHdNURpwa9uzyLn43QI/vsOw+SYmKc0Gyec++2aQeSquPOQ/Dn9LOYLhmigzJ jCytEoVFq/3Crw31qF1G2vVGuUvyvYxbOq6SmrgNO/Nlsp5sJ8Ru1AQ43RV5ZF7io/jW pg== Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0a-002e3701.pphosted.com with ESMTP id 34retq73v6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 12 Nov 2020 07:13:27 +0000 Received: from G9W8454.americas.hpqcorp.net (exchangepmrr1.us.hpecorp.net [16.216.161.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id D765D5E for ; Thu, 12 Nov 2020 07:13:26 +0000 (UTC) Received: from G4W9119.americas.hpqcorp.net (2002:10d2:14d6::10d2:14d6) by G9W8454.americas.hpqcorp.net (2002:10d8:a104::10d8:a104) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 12 Nov 2020 07:13:26 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (15.241.52.12) by G4W9119.americas.hpqcorp.net (16.210.20.214) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 12 Nov 2020 07:13:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jXBRRr9Gi1xijlLZ4UDdKgiGS9n1KQ27LzYfXHHCz/uAMrdLsae9vVGKjkZWyfdMIAv3Bbi1ecbIFQISIQ4c7dDJPxkOneIE2CiKqgSbUbR3+orRIore17Cb5YXbxPdARLA2H97e5VaDv2dHen/p4bZAX5RrCEBWenSlQBHoemZJAtdACfpJwdRD/mpcwVNq2NyzKRZXScgnyLI7ki1PfLHgEXWA0L8md/Dp7owNWCF0Cqw2edMcZIQXROPQw0+PxwFQ67oQoiyU++2yR17ofSdfeqpLMhOcSGCNUUsT5yYJ8T7DISvDTVo2yNM4ihHQ3Hut+D5XZD+z2x7odtmHIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ppIfOpXYxrM9C47O1uC+/laF29TiuSBM689zsuyQ2Sw=; b=I8bFWkpYJzk2IYjKOy8l8LG9B22VyYn/3kLWRKWeKLhHOioZB4Y1q0V84exw/lFfZAemSCcMmIh0QlJvGoJcV72EZ0biD0LnJykzdKrdBZ5ZOURayz0CEEC+u8lpKz1GcQ9IKLxKNzquQfV8F12JNmiUyw8c8LjcL0OegcdXkMDXpO2fz8lcj+iBFOXKhoDHiMwmOjk/t+PFKEBgh2uMYTNh5k7zOBF21QC/MGnKCOPaNZhEsISBeWbS/a1WsVcbJhDmgWNPvledhUscunMa2lHucqbWlAopTF0NZxGZC6G4xY93JV+kYya+dgJk0Vmf2iGexKth+doBhOFJ8Dm2mA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::7) by DF4PR8401MB0857.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.23; Thu, 12 Nov 2020 07:13:25 +0000 Received: from DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM ([fe80::e475:6a2b:ed1c:a060]) by DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM ([fe80::e475:6a2b:ed1c:a060%11]) with mapi id 15.20.3541.025; Thu, 12 Nov 2020 07:13:25 +0000 From: "Nickle Wang" To: "devel@edk2.groups.io" , "Chang, Abner (HPS SW/FW Technologist)" CC: "O'Hanley, Peter (EXL)" Subject: Re: [edk2-devel] [PATCH] RedfishPkg: Use DSC include file Thread-Topic: [edk2-devel] [PATCH] RedfishPkg: Use DSC include file Thread-Index: AQHWuJNYEzAHUeTyWkq8s9YY1xmeXqnEFWuA Date: Thu, 12 Nov 2020 07:13:25 +0000 Message-ID: References: <20201112004403.6331-1-abner.chang@hpe.com> In-Reply-To: <20201112004403.6331-1-abner.chang@hpe.com> Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=hpe.com; x-originating-ip: [118.161.157.79] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 1b017d02-f02e-4ebb-562d-08d886da7261 x-ms-traffictypediagnostic: DF4PR8401MB0857: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:61; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Fc4E6Iv1Y0PJV20ks7jXB+tcK8z9EvaDa7IgI4iuiGzfE8h3gE1YVdBspWccQ0bYoKHlOvqXS/MLaH0t2VQ77fCkGCfJfz9FX9GOiTf0K6ljhKYQiSYBV/F0l9hkqiIWSe5zJ00sIM53vnUqQNF5aZSWsSL/0a9xB29DOGeOCA5qtcd/GoN8sGBjJi5uUOszEfnIwgev63w8iybmRRJVve3JFrK57fp+9jhh05bTX/mq+afb6gjHLViqaSSjDfQkouZMIhXBwtRgYR0CnZwlFJYFTSvWL5aO4NRhO/v2MDnz2AXt72u/8RlY62vSq1FMJ6g6VH8ykEScpW3V+jYDzNKCVBMrhQffdeC4SemKQk6js6O1sxGbUvUDsxnZYL/mUHF+1KCVmsjhWvMuZ9nfBQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(346002)(136003)(376002)(366004)(396003)(39860400002)(19627235002)(6636002)(8676002)(86362001)(55236004)(4326008)(66946007)(64756008)(2906002)(83380400001)(316002)(66476007)(8936002)(33656002)(9686003)(76116006)(7696005)(53546011)(66556008)(52536014)(110136005)(71200400001)(55016002)(66446008)(186003)(966005)(26005)(5660300002)(478600001)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: IL3aeDf188p91OvFFe9EN0xnbNhajgNc8Iuh9mIkb7yvADZgBaWQb/+1Qham4z/uGRHzGy1W2PfiEL9dchk8Yd9RkTBfhsPHWbkev1JUvJuDlg1qKb/2fywdBC8xFV2eSgAgtwMVF07KV1RdCz8krVQRECj+ixPYjFHBpeKvxR11TWX/67LPT5bPsWnih6mtk1sZdhLTUaoVP7pIA+Zi1Mk7y6w8VitbFXSJxyEKJ8I7WdMGoi6Bq5JmNnwV4j2XMt1IebIVKPdVqtK23rNGS6wQ9C0saORE1n1UddQ8zkgQyBYCmYrKJlLg6mWi830/pkTl0SNKk1qVwFWILMgtNFNfvQsFj6hhVvVVG7ws3CLAVXW9rcrlc+QIbjbxTcLm6PLCINF2HXqIe/xWAevvW2ZsxSlrkjBByeGN7RY2UUhwxrq60x4HYkQFhNGoNSlAB13L27C148rozHd83dnSz+sV/G2omGDxYyq9jua/aIPFag8sbQRuRJ/Pj3jUCXE1ZBqiKL2wdR0VkD0zBmVAnekrvABrvSNMn0iKdp3rICtij1Shf8YIhoh95WDbL3bULzxnFRYPgNoHB90mNz8650nqif0w2bjwHYDX9OaD2L1Aa2aXOKdfY1S3ky6dGQcF7ft6nn5BqLhkCgcwgKDIu2MreJ2sGpp4bsTI2VEGwpoN2ZeCYAHwZlbeYNIUarC5lCZ1uKZfGdqL4lesQtOi1gtZFWamYcrfxdDqHlF9ohhS3XwZ0K/ZdHHWlB/9H7h61piCZC1wOJiyZD5Nk1OPXgD9oF+HcQs2Jd9KZYQlr6oDhRJcgW10eib9aQNGhiil8ZBPudWB1DAN3+1MMqf+V0AgnlXac+Xrdn9QLkXk6UdgjHDdz1hWOOCCRTi4MP/jYfUQuwFRPsUC8f3/rJyMUg== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 1b017d02-f02e-4ebb-562d-08d886da7261 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Nov 2020 07:13:25.1470 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MIk3YGvLQ0FQ7P1mImTJc9MvRT6Rq18frNokfU9LRmZ9BKekanvHXLC580aOIuNJjNJjbv5ALpIkRfLV8nSxVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0857 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-11-11_12:2020-11-10,2020-11-11 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 clxscore=1015 malwarescore=0 mlxscore=0 phishscore=0 spamscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011120041 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nickle Wang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Abner > Chang > Sent: Thursday, November 12, 2020 8:44 AM > To: devel@edk2.groups.io > Cc: Wang, Nickle (HPS SW) ; O'Hanley, Peter (EXL) > > Subject: [edk2-devel] [PATCH] RedfishPkg: Use DSC include file >=20 > - Include Redfish.dsc.inc in RedfishPkg.dsc. which > consolidates the necessary components in Redfish.dsc.inc. > - Remove unnecessary library instances from RedfishPkg.dsc. > - Add build option in RedfishPkg.yaml. >=20 > Signed-off-by: Abner Chang > Cc: Nickle Wang > Cc: Peter O'Hanley > --- > RedfishPkg/RedfishPkg.ci.yaml | 3 ++- > RedfishPkg/RedfishPkg.dsc | 10 +--------- > 2 files changed, 3 insertions(+), 10 deletions(-) >=20 > diff --git a/RedfishPkg/RedfishPkg.ci.yaml b/RedfishPkg/RedfishPkg.ci.ya= ml > index bb3b8b6746..20c297ad22 100644 > --- a/RedfishPkg/RedfishPkg.ci.yaml > +++ b/RedfishPkg/RedfishPkg.ci.yaml > @@ -63,6 +63,7 @@ > }, >=20 > "Defines": { > - "BLD_*_CONTINUOUS_INTEGRATION": "TRUE" > + "BLD_*_CONTINUOUS_INTEGRATION": "TRUE", > + "BLD_*_REDFISH_ENABLE": "TRUE" > } > } > diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc > index c6e79f5645..94e7127bc6 100644 > --- a/RedfishPkg/RedfishPkg.dsc > +++ b/RedfishPkg/RedfishPkg.dsc > @@ -23,21 +23,14 @@ >=20 > UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBo > otServicesTableLib.inf > UefiLib|MdePkg/Library/UefiLib/UefiLib.inf >=20 > UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib > /UefiRuntimeServicesTableLib.inf > - UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf >=20 > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemo > ryAllocationLib.inf > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > - > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchroniz > ationLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf >=20 > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/Bas > eDebugPrintErrorLevelLib.inf > - > PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPort > 80.inf > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > - > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Base > PeCoffGetEntryPointLib.inf > - > DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTabl > eLib.inf > - DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > - > ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/Dx > eReportStatusCodeLib.inf >=20 > RedfishPlatformHostInterfaceLib|RedfishPkg/Library/PlatformHostInterface > LibNull/PlatformHostInterfaceLibNull.inf >=20 > [LibraryClasses.ARM, LibraryClasses.AARCH64] > @@ -51,5 +44,4 @@ > [Components] >=20 > RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceLib= N > ull.inf >=20 > - RedfishPkg/RestJsonStructureDxe/RestJsonStructureDxe.inf > - RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.inf > + !include RedfishPkg/Redfish.dsc.inc > -- > 2.17.1 >=20 >=20 >=20 >=20 >=20