From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web08.2185.1613619210923607002 for ; Wed, 17 Feb 2021 19:33:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=ZWfEzbeI; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0683f2d0c2=nickle.wang@hpe.com) Received: from pps.filterd (m0134422.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 11I3RrHt030648; Thu, 18 Feb 2021 03:33:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=Au7TnQKJaCnLdhW/MX5HO1lKyycMhRGXVShIHRcemhU=; b=ZWfEzbeIIOscfaB5hggMJZCXXvbLuqVIgVgI/gyCB0iDqlrcW7qm5BfcOHs4kZTpPjiG NCt3xhvtsW6aM4f4jlwoKkblUw+qw98GhN3UabWhm0WieBVXWkkzQNmb96j4e6SW1moZ I6wfJ4qxAECS8voJrknF5KhDayNYLuLa2MZOhchry0GJsW9P3tLcjDt9FJ8uM/T6cO4S wxKoovdSPxZQkmpARYCDotkyQmKj+NzCT1LdED5eaXOJEVpC599q0W2l1j824ZbrwlZa /BDEqURfhhOJ6fklwDqf6mi3cS93v9UMt8Y7pA2G7YNkL97DJ2npLW0O3WIHCDUG45mZ gQ== Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0b-002e3701.pphosted.com with ESMTP id 36rhrdudgg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 Feb 2021 03:33:30 +0000 Received: from G9W9209.americas.hpqcorp.net (g9w9209.houston.hpecorp.net [16.220.66.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id BC3795C; Thu, 18 Feb 2021 03:33:29 +0000 (UTC) Received: from G9W9210.americas.hpqcorp.net (2002:10dc:429b::10dc:429b) by G9W9209.americas.hpqcorp.net (2002:10dc:429c::10dc:429c) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 18 Feb 2021 03:33:29 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (15.241.52.11) by G9W9210.americas.hpqcorp.net (16.220.66.155) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 18 Feb 2021 03:33:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jIfH1FPEwZdFNjJ9s2rc1hmRb/HKTQfPKnxt/5QFy22E8H9Ho1SgbtZSU2AYcw+3lSN7lvfcwShIVtcicKrVCgsujF+itb5OjxcbQVzCA8GVnYvMZCyiwnbhvAfZVDP3rgKgruwxRj+fdpt8vAV8jbyegEywlG3r8tyEII8MllJ5TzDwIj9vijv426j1uzH7jHyFi7hNyLXUO//POQ2E+G1WuS4CX17dNiYwxzXnwUTxmDrZKjZAbPzP0BFcCnA6quZiWLCGlkuRQ/f/WI1dpAtQ5Ydh7VGupOC5+WDrwR1VhExgPfZEdZGh5tya5ypIpFNgjWBHvyCPLQMQqU6vPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Au7TnQKJaCnLdhW/MX5HO1lKyycMhRGXVShIHRcemhU=; b=MWy1rhzDE2OAZftER6RdRaSMzmzNlyBW1vkXK8a42NF8ZzNRQlIitXvoYefsuBiyBGoa6zL6yC6cHHn0UnVoM5XFjitkmSaHQv6PZu20RnX5PRTvvZOc4rBZ9AZwIE8vgxPpiBIBrtZyk6A2fabU+8+2Xx0il296rorxVnaYVJBpozTzC3YVIkKqLlaSPUsEDQ2Y0b2BFsmBcVJz5S9JakxgODQRfpQPMM5UdF199vMWKskzDemauAG5fZYp83TImxy1DlFSJoK/06sTwbdf0C7/9QZPeN6Wpkn8T9Md4GiqRoSnlTlznyk5XTnerBX4J3Ooe0XYpADlI9GsfKBtUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::7) by DF4PR8401MB0394.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7606::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.27; Thu, 18 Feb 2021 03:33:27 +0000 Received: from DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c1ae:b73d:dbaa:9a6e]) by DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c1ae:b73d:dbaa:9a6e%9]) with mapi id 15.20.3846.042; Thu, 18 Feb 2021 03:33:27 +0000 From: "Nickle Wang" To: "Chang, Abner (HPS SW/FW Technologist)" , "devel@edk2.groups.io" CC: Leif Lindholm , Michael D Kinney Subject: Re: [PATCH] RedfishPkg/JsonLib: Fix the mistake of removing code by a accident Thread-Topic: [PATCH] RedfishPkg/JsonLib: Fix the mistake of removing code by a accident Thread-Index: AQHW9fzQ1o/TyjXncUusObsU6efRMKpdYaDA Date: Thu, 18 Feb 2021 03:33:27 +0000 Message-ID: References: <20210129041954.20623-1-abner.chang@hpe.com> In-Reply-To: <20210129041954.20623-1-abner.chang@hpe.com> Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: hpe.com; dkim=none (message not signed) header.d=none;hpe.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [16.242.247.139] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 20d6ed4d-f26f-4320-fde2-08d8d3bdf44e x-ms-traffictypediagnostic: DF4PR8401MB0394: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3PczoFh2iEWW0Cip7/jttRMwHwGwtJYxWlH+CEGPzttQ/4uo1E9C0aFdIi1zGU5bgp8BBh4zuo0MvmAShMJg4nHRJZkDXIteZ8NavxsmGuAsvT9tia3tQoB6VKz30hqK8ETkHx1ao2A6b2gadhvPnc0tzu/bemf7sSTMKUQ+EAoXAqfbzdPojM0BbevyoxAAQUDHxtWUpMgULTLDmtDENOKUqe4TmnvUkkH85T4mO+hIWMw+CvwRXlf5QoYQYa4bFtzvKQiyoCSOnRk8VYrMPU78kAdCMWTNEkzZVeQXGjtN7563yvK9TSXnPU0Vi/y5d7aFfNEfN18USRNm0MiMCKgOAuErTRRM4oG1TvS28VFyqilrUki7Q23c2dSQMhASQyD4LEyhj1nEt37YETRdW4qa3aX704SRrfA8wxZUqD8o8F55EAlINUR7iisdAlPvMfLkLvQqMacwFQzEMX4RkW5ZIbV4kl21sosUuAL2gqryZ3uVErCEvfZu/ZEr50kTYNOa0c1JuR/gR2QvOrKQ5w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(346002)(376002)(366004)(39860400002)(396003)(136003)(8936002)(76116006)(66556008)(66946007)(2906002)(66476007)(66446008)(64756008)(8676002)(71200400001)(52536014)(5660300002)(478600001)(9686003)(33656002)(7696005)(316002)(54906003)(110136005)(55016002)(86362001)(6506007)(26005)(186003)(83380400001)(53546011)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?9Fka8f8uOrbcXqE+VCRA1k1kIyrhTFtS6Ee4+tgOjLGg61Ux7QlVmA5EeuKc?= =?us-ascii?Q?eUMCH9xR54CldpE/5Q+lE5V6q19tVBNltQiBnuLd9U0VhrYjbs1zLiXZKMDP?= =?us-ascii?Q?IwH3+eZlfGauAgcRKsqz0gVD88xIJyYSNbjN1lMN9prtguy98P5SalH2nEjI?= =?us-ascii?Q?9dahgq4D6udkm2POfJotJQszW3v8RcI2DijYtyyzIxAAHO1aT/8jFIHX3itb?= =?us-ascii?Q?Fbpwxme6gSEYvP1M/1583gg9FZsEskJzgbvO5JljhJajgNBqt8HOwvrHs+/z?= =?us-ascii?Q?9MdOia1X6DgBTGE32SZNdSMDe3sV62uWgqtHJR4NvEyLBnhu/DSO0MN5HYVo?= =?us-ascii?Q?Sxa1htCsd9J4ytZaUgqWGhqON76+QKqIPofvRJrD736gP1v3/CrWtbx00T/z?= =?us-ascii?Q?4k+O68XEnxCRWmXYSeSS0C2F3i1bON9HZUwyFzc1BlhdvpiIbLexeMpJ/XV9?= =?us-ascii?Q?6muAUFjk+EXUYrulieRtW6dINH2ESDPNwkhI+vM5NqmbaAOX33tK1Glk/dUt?= =?us-ascii?Q?+6iq6CD9Lh4iTRhkjwWBYoDJ/K0Gq8SLgG25VrVRCBsqYvRXFNzEVv5NBnX1?= =?us-ascii?Q?YcnyhInPJUVpgghXNEIPGyiruJAsixN6YbyighV8yd++9ReXAGFt9np0Bjit?= =?us-ascii?Q?3Uv1md/JF9Vd3Qc6ec2SeIGL/fLIF7N3KKhLmRFeW6o9YxfHo/W7GM8OY83J?= =?us-ascii?Q?8I2BPTL36siInoOhxahWMVrKkoLwYay50O+H7AY+2d8ECgNZ2iCmfLKZOC4p?= =?us-ascii?Q?aFGRki1D+8pxvJ9I3d9weRpqISbV9y14qPRqQYKW6sGAxNI+f3dYfNpSRXKz?= =?us-ascii?Q?uQfWOUMNPYw9+h0eTlj/VqSEx+vXng6VNo+Mxhy91lA/gLuVmMOCI94/VWh9?= =?us-ascii?Q?btvZSF26TB2ApI4yLDvlnrxXmfaIy9aEUcI9TLrF9wCn1NqX6M+93ke5Qngi?= =?us-ascii?Q?Q2V5w2tuhasnZ4gHLrF0dF2lSoS+oGIhiTPDX8f9B8AFPcHshGma9f2kSk8b?= =?us-ascii?Q?R/9G1rantVHDbyAPJi8nJbwUU13yQ9KaM+8xQy66N+/lrrkWPsasaGNwoXU1?= =?us-ascii?Q?H4GJhDGMkzFxrZUNK38qQRUAYF8Q9UyZwK0MXCM/tMUK/XPXh0mJSpjSicrj?= =?us-ascii?Q?3zcOX9R5wQiBvnT4RpgrOQxZBBq1k27p8pHYey2aNc+kaSdbpk+PqKQew9Tf?= =?us-ascii?Q?f5BTuLvb1swhM92HoVdgnxv6l+d04mtkQWGo6Oc4Fd/VWePICYmEOUP0Bkas?= =?us-ascii?Q?HgZuhmDYYOw7XZwIHF6VKctRsfX4n3wwbuKiXshq2DwpznbcFtzKTXhjEXL2?= =?us-ascii?Q?ROj7VkMMJZCT5BZttj0bq4Nh?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 20d6ed4d-f26f-4320-fde2-08d8d3bdf44e X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2021 03:33:27.3002 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Nan/s0orx/B8PxbowoOqbVjYqRBK+QUY1/Pde7Y6WEAw/QlUVa9iBWwpQnzGxW82FU6qzDjCGmUBUq50YwiPbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0394 X-OriginatorOrg: hpe.com X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-02-18_01:2021-02-16,2021-02-18 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 impostorscore=0 mlxscore=0 adultscore=0 clxscore=1015 priorityscore=1501 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102180027 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nickle Wang Thanks, Nickle > -----Original Message----- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Friday, January 29, 2021 12:20 PM > To: devel@edk2.groups.io > Cc: Leif Lindholm ; Wang, Nickle (HPS SW) > ; Michael D Kinney > Subject: [PATCH] RedfishPkg/JsonLib: Fix the mistake of removing code by = a > accident >=20 > json_string_value() in JsonValueGetAsciiString () is removed by a acciden= t > when clean up the code. >=20 > Signed-off-by: Abner Chang >=20 > Cc: Leif Lindholm > Cc: Nickle Wang > Cc: Michael D Kinney > --- > RedfishPkg/Library/JsonLib/JsonLib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/RedfishPkg/Library/JsonLib/JsonLib.c > b/RedfishPkg/Library/JsonLib/JsonLib.c > index 34ff381aee..d729e3ec27 100644 > --- a/RedfishPkg/Library/JsonLib/JsonLib.c > +++ b/RedfishPkg/Library/JsonLib/JsonLib.c > @@ -430,10 +430,10 @@ JsonValueGetAsciiString ( > IN EDKII_JSON_VALUE Json > ) > { > - CHAR8 *AsciiStr; > + CONST CHAR8 *AsciiStr; > UINTN Index; >=20 > - AsciiStr =3D (CHAR8 *) ((json_t *) Json); > + AsciiStr =3D json_string_value ((json_t *) Json); > if (AsciiStr =3D=3D NULL) { > return NULL; > } > -- > 2.17.1