From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web08.4866.1603952703215649526 for ; Wed, 28 Oct 2020 23:25:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=bq9NK1lc; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=057147ffc3=nickle.wang@hpe.com) Received: from pps.filterd (m0150241.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 09T6NDhX028225 for ; Thu, 29 Oct 2020 06:25:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=4HhnFC6g0h7Q/gr5+PsJSwDJf0chlBL0tAWOywHm2d4=; b=bq9NK1lc++9KRUwERSlO0yJ6/D/+VQ/8AnDJjOc0KPsprHehpLx/N3WaW1OsmNahWGR5 1bI9PiEs0M0/Q2fpVnDWduecGbgoKf4AC1pU5wt1zZTIT8FKPN2tVxP7SUk8wXsqkvMI 2b5lYzkqq9yBPpUBoA/tEFGdK/GOkwMSJOd2qLTiBlMUoXp+4ge8sQbNbQ3AA69igTSO GQ0QZPQCM6yP3jG0fSnHp7FcEV3WUw29MwMRZCs+Z2ykTqGXR+chFcFfR7sM5Y3Dq7Z/ Ibfsz2D2R7hmTWfLRWuiI9W49GtbYa2PiLshB9At51+xV7oMNHpPHPwaJb/lV+usr4b0 Ug== Received: from g9t5009.houston.hpe.com (g9t5009.houston.hpe.com [15.241.48.73]) by mx0a-002e3701.pphosted.com with ESMTP id 34f6vx88ye-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 29 Oct 2020 06:25:02 +0000 Received: from G4W9119.americas.hpqcorp.net (g4w9119.houston.hp.com [16.210.20.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5009.houston.hpe.com (Postfix) with ESMTPS id EC7CD5C for ; Thu, 29 Oct 2020 06:25:01 +0000 (UTC) Received: from G9W8456.americas.hpqcorp.net (2002:10d8:a15f::10d8:a15f) by G4W9119.americas.hpqcorp.net (2002:10d2:14d6::10d2:14d6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 29 Oct 2020 06:25:01 +0000 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (15.241.52.11) by G9W8456.americas.hpqcorp.net (16.216.161.95) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 29 Oct 2020 06:25:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kA6rp4yfSOXTLAZBEqC1gzZEb23I1+Blk3uVTF+/fiBIiwMmpUbES6McqZsIJoCbpsobiUntJ1v0dvqqj2cPKYlYYnTotaQpD+G9tH+1Vn1xUCqCz4jCIiBUTkKp+Xx06svVzQ8IAze0FBFj1Yf5Qg4LhsTcAZ0seHJpt6lTXnKQuMg9x4msiUtiW+4K9EAt0oto1D1dmYhdBKMLPO+ugNdFe2uz+/kLW2cq1m/MFQd3ctFAhHNrjsANitYYfyXsPyKUCDp7r2e9y5VkitlLsi2TwZC/eypyyjQbNahw+LTsUFcZxHGxOqWXUyzLxtCrDKU+KKuuFJemre2ZWMJHDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4HhnFC6g0h7Q/gr5+PsJSwDJf0chlBL0tAWOywHm2d4=; b=S2IlPWPSPpfuTuK3HK/sGh1E8NwXiG2j1QwQn6jJ+Z5eNjvDzumjcbEgt/XkByEqqKYYTAvMiqaYfiC19iNtHNs5C1vnFMev0h1vez8YAhd02EnacAfiR504fTuMxqy8X7YbtOepOdj3X09jmaEeXlKlNz1WmfbuEUeU2p2m9qqnJBULDtpWQzJK4wW17siAxqejfxwL79BJtzRkiN9pa1I62Ws6vmfhCVQoymCIWadoclikDA719UfAJ8WoMdVe4w9M57d7qM6TsuffVPtO9IWHP5mSiiiX7+qGH5vMGdngHeBUOuJUFgZuCdy74T6NgIY4LAygZgnaMrHBTNzy4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::7) by DF4PR8401MB0955.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21; Thu, 29 Oct 2020 06:24:58 +0000 Received: from DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c9cf:9c73:a8a5:331b]) by DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c9cf:9c73:a8a5:331b%12]) with mapi id 15.20.3499.018; Thu, 29 Oct 2020 06:24:58 +0000 From: "Nickle Wang" To: "Chang, Abner (HPS SW/FW Technologist)" , "devel@edk2.groups.io" CC: Jiaxin Wu , Siyuan Fu , Fan Wang , Jiewen Yao Subject: Re: [EFI Redfish Host Interface PATCH 2/5] RedfishPkg/Include: PlatformHostInterfaceLib header file Thread-Topic: [EFI Redfish Host Interface PATCH 2/5] RedfishPkg/Include: PlatformHostInterfaceLib header file Thread-Index: AQHWoRyyNDRTvE2C702m2R8iQH9thKmuNXrA Date: Thu, 29 Oct 2020 06:24:58 +0000 Message-ID: References: <20201013040805.20523-1-abner.chang@hpe.com> <20201013040805.20523-3-abner.chang@hpe.com> In-Reply-To: <20201013040805.20523-3-abner.chang@hpe.com> Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: hpe.com; dkim=none (message not signed) header.d=none;hpe.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [36.224.251.48] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ec4e5e18-b69a-4c04-4d11-08d87bd35c1a x-ms-traffictypediagnostic: DF4PR8401MB0955: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:153; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8hcWM2dG0Cl+ZomvLlEEx6Z6WjkaM93j4+8jHxo/bld77bGtPAbrSj39Gowk5rwS8TH6B8xEhsptuJYMhe9lo/VUgSYtIoACJJfixGexbxqvMhaFfANCNtJH2luZNrZNInMX3W+mQMzm+6gYPnamNdIvK5z36hLWdoLB+JC5QuWNYpk4BgYRs7LrzPpf1ILzU0d8Av+GM43Z5MjgO59sBCD1Crck8/9Ow7IEMgMrBAKtR42Cu1YlqjKR9iT6OHMhEGuy4GL0Bv9QPRV6AtguZ5FcGgsC26kH8XhwE3fLFGrU3lPttwsyWdtTJt6+Gf9g x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(396003)(136003)(39860400002)(366004)(376002)(346002)(2906002)(6506007)(5660300002)(52536014)(66476007)(8676002)(54906003)(9686003)(186003)(8936002)(316002)(110136005)(71200400001)(7696005)(26005)(86362001)(53546011)(33656002)(66946007)(76116006)(478600001)(55016002)(83380400001)(66446008)(64756008)(66556008)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: J39sKLIX6GUBaRf00YdLmWjeI4GFSmc34oVAcL+PXUcffddh38Qnf8ESIxwBu7ItauArv/x4e4GcBsVB///P5NACdgf13CiO6Ygt4NJc9oKJbF4WEFmhPqjGnEysMseArYF6RjWE4r8f1rd4VlzgYH9+cflcDLX3uAiIsj2CKoSQ1s+IueDj0xoKVZUA0qJgaT/i/yj6ZxAWXsS+iFznTdL3+eabJCk4/bEoh0OIb7joy9JZR/Yy2OYC1dkaZsyUxWvtvK9WHVKlUxZhFhDvFBx3//LaZq9ZjnlIAaM6lVlRtaBe9c7QnVjKA2nl5R/rUDJ9jfSjFgpVlHmofeb46hV5seC9q8Wxt5XekqoV44eRLMmHZj5ZE+5+/RxkzscB1j7o5n92cFvxy2qQgaLmGmrATYfWto5nVJBE0XpmHFjGOAqdXxSSUXJodXVG642Yxa1cn31gD7J7Va6y1xrZe2eENldu+zDDC1iykGzC2Dmr/hCYbVVl+hO1J/wpUJmFTKOLpAPKlmmEG7CfGfnpcNeDpP6F49PzIOiIQdWNLG8BKanBtnN+3IVEBgSeszrnybYjdT3yHM1JkG/Ee+PRg78oZWjbeOWRyCkect8HiGYL31MgENSv8yt7gr7Yvlw2JvELDGItT6LKlcTP2PXCDQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: ec4e5e18-b69a-4c04-4d11-08d87bd35c1a X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2020 06:24:58.5079 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sML9/PyFLCa+xa4zAdlXTIlGHiHPdRxlF+W9LYjHdqd3UkW0ru4QjTFgjiXLkQ0hnZX1j+JOF6oaKGrocWPb2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0955 X-OriginatorOrg: hpe.com X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-10-29_01:2020-10-29,2020-10-29 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 phishscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 adultscore=0 mlxlogscore=999 clxscore=1015 lowpriorityscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010290046 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Abner, I found that the parameter is not defined as it is described in function he= ader. Please check my comment inline below. Thanks, Nickle > -----Original Message----- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Tuesday, October 13, 2020 12:08 PM > To: devel@edk2.groups.io > Cc: Jiaxin Wu ; Siyuan Fu ; Fan > Wang ; Jiewen Yao ; Wang, > Nickle (HPS SW) > Subject: [EFI Redfish Host Interface PATCH 2/5] RedfishPkg/Include: > PlatformHostInterfaceLib header file >=20 > Signed-off-by: Abner Chang >=20 > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Fan Wang > Cc: Jiewen Yao > Cc: Nickle Wang > --- > .../Include/Library/RedfishHostInterfaceLib.h | 52 +++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 RedfishPkg/Include/Library/RedfishHostInterfaceLib.h >=20 > diff --git a/RedfishPkg/Include/Library/RedfishHostInterfaceLib.h > b/RedfishPkg/Include/Library/RedfishHostInterfaceLib.h > new file mode 100644 > index 0000000000..870109e09a > --- /dev/null > +++ b/RedfishPkg/Include/Library/RedfishHostInterfaceLib.h > @@ -0,0 +1,52 @@ > +/** @file > + Definitinos of RedfishHostInterfaceDxe driver. > + > + (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > +#ifndef REDFISH_HOST_INTERFACE_LIB_H_ > +#define REDFISH_HOST_INTERFACE_LIB_H_ > + > +#include > +#include > +#include > + > +#include > + > +/** > + Get platform Redfish host interface device descriptor. > + > + @param[out] DeviceType Pointer to retrieve device type. > + @param[out] DeviceDescriptor Pointer to retrieve > REDFISH_INTERFACE_DATA, caller has to free > + this memory using FreePool(). > + @retval EFI_SUCCESS Device descriptor is returned successfully in > DeviceDescriptor. > + @retval EFI_NOT_FOUND No Redfish host interface descriptor provided > on this platform. > + @retval Others Fail to get device descriptor. > +**/ > +EFI_STATUS > +RedfishPlatformHostInterfaceDeviceDescriptor ( > + IN UINT8 *DeviceType, > + IN REDFISH_INTERFACE_DATA **DeviceDescriptor In the function header, they are OUT parameter but they are defined as IN h= ere. > +); > +/** > + Get platform Redfish host interface protocol data. > + Caller should pass NULL in ProtocolRecord to retrive the first protoco= l > record. > + Then continuously pass previous ProtocolRecord for retrieving the next > ProtocolRecord. > + > + @param[in, out] ProtocolRecord Pointer to retrieve the first or the n= ext > protocol record. > + caller has to free the new protocol re= cord returned from > + this function using FreePool(). > + param[in] IndexOfProtocolData The index of protocol data. > + > + @retval EFI_SUCESS Protocol records are all returned. > + @retval EFI_NOT_FOUND No more protocol records. > + @retval Others Fail to get protocol records. > +**/ > +EFI_STATUS > +RedfishPlatformHostInterfaceProtocolData ( > + IN MC_HOST_INTERFACE_PROTOCOL_RECORD **ProtocolRecord, This is IN and OUT, right? If not, the function header needs modification. > + IN UINT8 IndexOfProtocolData > +); > +#endif > -- > 2.17.1