From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web11.11246.1591181739199425025 for ; Wed, 03 Jun 2020 03:55:39 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0423fc3eaf=walon.li@hpe.com) Received: from pps.filterd (m0150241.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 053AmJNo029002 for ; Wed, 3 Jun 2020 10:55:38 GMT Received: from g4t3426.houston.hpe.com (g4t3426.houston.hpe.com [15.241.140.75]) by mx0a-002e3701.pphosted.com with ESMTP id 31e9jegerv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 03 Jun 2020 10:55:38 +0000 Received: from G9W8453.americas.hpqcorp.net (g9w8453.houston.hp.com [16.216.160.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3426.houston.hpe.com (Postfix) with ESMTPS id 2C2DC5C for ; Wed, 3 Jun 2020 10:55:38 +0000 (UTC) Received: from G4W9119.americas.hpqcorp.net (2002:10d2:14d6::10d2:14d6) by G9W8453.americas.hpqcorp.net (2002:10d8:a0d3::10d8:a0d3) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 3 Jun 2020 10:55:37 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (15.241.52.10) by G4W9119.americas.hpqcorp.net (16.210.20.214) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 3 Jun 2020 10:55:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oHCwdQO24Q/CfcBHx4cfsXS0YZEfF0stGZ0WtmrmnCTeboVFKd00/Ll/jWsRP/n4lQ4u1hw17BhAvo1EApCmkCp9azUBRtHV6b0ja63ziD3cD6Jke/AbDEE9beSkje50G/1WOMmlKvxVER8o+MTbLW8jBZjXxHYG9M6V/2Btn/CpbG6PFdVGK4wvLM3oRnT4U+6ChvXDFS2oojtD+pMEqIJkIVlYLY+LvNZXTjgY7jd/6jmJiab2Pmd3B9+674p9Pjr6pcwzNu2RHiMsp0VNKV/rePt1PQD2/7SQSD8M/UaLZMJEHL+3WMUzKxEVU2RcZ8mlcNlFy7D64x3kLnjN4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ejixgxoBV27lRUtwie3BoPC7blJvI1xTmBVTBAfKjP0=; b=Fh4IFsTXgMyvYXtatFRiDWYDOcdS/OzW7h0LEoy5rAKBEhUEab1nJNCTFsWjqvqKz/Mq2zVjtHKHrm068twF4p0uQLG4ggFHjABExmljfOHcJy6wwy/vZ/3qK7qCmsXibvh8CLZq2Yuf2p2Elt5kmOm15dNMe3xWZ1/KDAq2HEnN5HihuWt1QXmwfGVy+T1Q+rDzF1cxE2adeseU2k34771R5GbbBeFa7YObuYfD6GDPP5HNkOeMV9+pmrcqmGd6x5D2SV4Sv8XDoSv8RicBip9IZQX4Ryt9Bcq5MHHyDxRBlX9sgMYLQYIKXCzSe6uZtT4Sh58A4pHdxu+21xWFqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760f::13) by DF4PR8401MB1068.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7610::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19; Wed, 3 Jun 2020 10:55:36 +0000 Received: from DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM ([fe80::f19c:e18d:ef9f:45a5]) by DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM ([fe80::f19c:e18d:ef9f:45a5%12]) with mapi id 15.20.3066.018; Wed, 3 Jun 2020 10:55:36 +0000 From: "Li, Walon" To: "Bi, Dandan" , "devel@edk2.groups.io" , "liming.gao@intel.com" CC: "Wang, Nickle (HPS SW)" , "Chang, Abner (HPS SW/FW Technologist)" , "Wang, Sunny (HPS SW)" Subject: Re: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect driver with form-update Thread-Topic: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect driver with form-update Thread-Index: AQHWLl65x/ibOz1LmkqMq8olb25hJKi22fiAgA/zYnA= Date: Wed, 3 Jun 2020 10:55:35 +0000 Message-ID: References: <20200520042447.1017-1-walon.li@hpe.com> In-Reply-To: Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [36.227.241.123] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 759a15d8-efdf-486d-d035-08d807aca547 x-ms-traffictypediagnostic: DF4PR8401MB1068: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-forefront-prvs: 04238CD941 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9uGiB+TT2EBk6pA9GmoPLYNyQgDMz6OYESzd6lDLT3asAf9ddDxv03rxZy8fXPxIcG2/uEXTQgwqsDgbar4FEWjkRHXraG7BEyoApe/JdS5JP7flCzpIKgQD0yozJnH7UrWdAQ0DPt0J2q/rVHaVX6N784LMkmQ0OVcnc++mVVkGPmv/p9GHrdaadx1/u7I2QKrX1erP/JtFdim5DbSy7DzY1pYun1G/gGsYCrTEK10JLgRJTU0pww+A6VjJ91o/MabOg5cBNOy+SrC3Im8rJ0bM+Cxj8ZUfT4EXGMGfe0wVb8uEyXzvkM3g9DYW3uCmWZUldM6vNn6klD424qhEsXIKJXE2MhLhyfQefmEubiN0KpE1SE3YvelfEKl6Ec9Zq/p3rL2sW2dZGGNO0hxaGw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFTY:;SFS:(376002)(366004)(396003)(346002)(136003)(39860400002)(316002)(186003)(9686003)(76116006)(66556008)(66476007)(64756008)(66446008)(55016002)(86362001)(33656002)(110136005)(83380400001)(26005)(54906003)(66946007)(7696005)(71200400001)(52536014)(2906002)(8676002)(5660300002)(4326008)(15650500001)(478600001)(53546011)(66574014)(8936002)(19627235002)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: +fFds1/OxC9afibd0GsAABunI3126tGGXl6t1w9ShhgfBLEJxjwPZJMO2NQUz2H2qIHJPOZ8f9V/uAEMnNJE7/sI6ZOKnIAC6YiYQlsArCrDGb2yHmTDjLPkFkGPZEClZEpGIbM3PnNgV3RSqqd9/SDC5Wv5KrMj0emNihv5KXS4MZRXCbws57vAZALhGHRDMnlc1V++sB0UKU6p2dimoEOSZ0xrvf2d6Abx+rQh0XO/yB3sOioaitRYymmEDf7yt3hpYxfNt4s+CmYLAv+5yFyvifXR1+VCu8CebkOXrYmG1S6ilwiXPGFnIxXYm1NdUro4Tnunan6OmzdYgptlqMik08MBHzPyabJSDww2MMHuPUWHju0NdlfVXMIwF/tR1hoyPCkqQ55mixTX87bK0kzX62n91yNE8EM9SOv3nhN4VIQe9xql3NOXf9HPt1/JPuA8njGs6Sg4qxDpdIPEjgyA9ilDf6M1+/BDKO3h3r/wirbj+D1Z6hQhRAULm/ZA X-MS-Exchange-CrossTenant-Network-Message-Id: 759a15d8-efdf-486d-d035-08d807aca547 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2020 10:55:36.0232 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: X8aUWEJ4lywdznmLX4tdYV5F2A+pC1OpNU+yru9Z/48LAX1i5VfGvTQUHyWptFMrohQHVmV9A6mY7NYUcIpvzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB1068 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-06-03_11:2020-06-02,2020-06-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 cotscore=-2147483648 spamscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 impostorscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 bulkscore=0 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006030085 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable May I know the schedule of pushing this change to edk2-master? Or what's ne= xt step I should do? Thanks, Walon -----Original Message----- From: Bi, Dandan [mailto:dandan.bi@intel.com]=20 Sent: Sunday, May 24, 2020 3:17 PM To: Li, Walon ; devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Chang, Abner (HPS SW/FW Te= chnologist) ; Wang, Sunny (HPS SW) Subject: RE: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect driver = with form-update Reviewed-by: Dandan Bi Thanks, Dandan > -----Original Message----- > From: Walon Li > Sent: Wednesday, May 20, 2020 12:25 PM > To: devel@edk2.groups.io > Cc: walon.li@hpe.com; Bi, Dandan ;=20 > nickle.wang@hpe.com; abner.chang@hpe.com; sunnywang@hpe.com > Subject: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect driver=20 > with form-update >=20 > REF:INVALID URI REMOVED > ocore.org_show-5Fbug.cgi-3Fid-3D2701&d=3DDwIFAg&c=3DC5b8zRQO1miGmBeVZ2LFWg > &r=3DnGx4G_nX3rQG_ai3uSb52w&m=3Dj34dsoHyXFEvnpFmkT_iUSnMAF1kWbmBFnMbHVJkJx > U&s=3DV7D879dizWzD8-fTk-wXmw5sypK5jfdtjWAENVbXntQ&e=3D >=20 > Recording to the spec, the reconnect is activated upon exiting of the=20 > formset or the browser. Exiting is by user but form-browser internal=20 > logic. That means the reconnection is only happened when user press=20 > ESC or _EXIT action to exit form. > Driver callback may update HII form dynamically so form-browser needs=20 > to refresh its internal data. It's not exiting formset for user=20 > exactly and they didn't know what happened. So use a flag to record=20 > that and do not reconnect driver if updated by callback. >=20 > Signed-off-by: Walon Li > --- > MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 2 ++ > MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 8 +++++++- > 2 files changed, 9 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > index bafee4c612..7f85873730 100644 > --- a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > @@ -19,6 +19,7 @@ LIST_ENTRY mRefreshEventList =3D > INITIALIZE_LIST_HEAD_VARIABLE (mRefreshEv > UINT16 mCurFakeQestId; FORM_DISPLAY_ENGINE_FORM > gDisplayFormData; BOOLEAN mFinishRetrieveCall =3D FALSE;+BOOLE= AN > mDynamicFormUpdated =3D FALSE; /** Check whether the ConfigAccess > protocol is available.@@ -1762,6 +1763,7 @@ FormUpdateNotify ( > ) { mHiiPackageListUpdated =3D TRUE;+ mDynamicFormUpdated =3D TRUE; > return EFI_SUCCESS; }diff --git > a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > index 82067b541c..f936a4b8e8 100644 > --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > @@ -68,6 +68,7 @@ extern EFI_GUID mCurrentFormSetGuid; > extern EFI_HII_HANDLE mCurrentHiiHandle; extern UINT16=20 > mCurrentFormId; extern FORM_DISPLAY_ENGINE_FORM > gDisplayFormData;+extern BOOLEAN mDynamicFormUpdated; /** > Create a menu with specified formset GUID and form ID, and add it as a=20 > child@@ -536,6 +537,7 @@ SendForm ( > } Selection->FormSet =3D FormSet; mSystemLevelFormSet = =3D > FormSet;+ mDynamicFormUpdated =3D FALSE; // // Display = this > formset@@ -547,7 +549,11 @@ SendForm ( > gCurrentSelection =3D NULL; mSystemLevelFormSet =3D NULL; - = if > (gFlagReconnect || gCallbackReconnect) {+ //+ // If callback up= date > form dynamically, it's not exiting of the formset for user so system do n= ot > reconnect driver hanlde+ // this time.+ //+ if > (!mDynamicFormUpdated && (gFlagReconnect || gCallbackReconnect)) > { RetVal =3D ReconnectController (FormSet->DriverHandle); = if (!RetVal) > { PopupErrorMessage(BROWSER_RECONNECT_FAIL, NULL, NULL, > NULL);-- > 2.23.0.windows.1