public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Lin, Derek (HPS SW)" <derek.lin2@hpe.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"bret.barkelew@microsoft.com" <bret.barkelew@microsoft.com>
Subject: Re: [edk2-devel] Basetools fail without error message due to PCD type differs in architecture.
Date: Wed, 8 Apr 2020 02:40:51 +0000	[thread overview]
Message-ID: <DF4PR8401MB09557F87A1A9D7532961064DC2C00@DF4PR8401MB0955.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CY4PR21MB0743481A4EF4593F059B4ED9EFC30@CY4PR21MB0743.namprd21.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 2360 bytes --]

Hi Bret,

Thanks for your feedback. I'm very sorry that I didn't describe it clearly.

The Basetools just "crash" in the configuration. The Basetools crash without any information, then build stops.
I've looked into the BaseTools code, the python code crash, during the generation of PCD database for IA32.


I'm not sure if the PCD spec allows different PCD type in different architectures.
If the spec allows it, the build needs to be fixed and make sure it works. I remember the dynamic PCD database carry from PEI to DXE. And I don't think that work if PEI is FixedAtBuild while DXE is Dyanamic.

In my opinion, this configuration should come to a build failure. And define the error in PCD spec.

Thanks,
Derek

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bret Barkelew via groups.io
Sent: Wednesday, April 8, 2020 5:48 AM
To: devel@edk2.groups.io; Lin, Derek (HPS SW) <derek.lin2@hpe.com>
Subject: Re: [EXTERNAL] [edk2-devel] Basetools fail without error message due to PCD type differs in architecture.

This seems like a legitimate configuration. I don't know that it should be considered an error. A warning, maybe.

This is also what the build report is perfect for finding. Did you check the PCD build report when debugging?

- Bret

From: Lin, Derek (HPS SW) via groups.io<mailto:derek.lin2=hpe.com@groups.io>
Sent: Sunday, April 5, 2020 7:55 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: [EXTERNAL] [edk2-devel] Basetools fail without error message due to PCD type differs in architecture.

We've found a Basetool issue.
When a PCD is FixAtBuild at IA32 and Dynamic is at X64, there is no error message in this situation and it's very difficult to find the root cause.

Here's example to see the issue:
https://github.com/howdou/edk2/commit/333c5f33adc652308355ec100f7f385d552392fa<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhowdou%2Fedk2%2Fcommit%2F333c5f33adc652308355ec100f7f385d552392fa&data=02%7C01%7Cbret.barkelew%40microsoft.com%7Cffb03103e6ea44f2983d08d7d9d5f14d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637217385209311719&sdata=NARbUbs0zdooQRcLakblGydppgYFoxm1BBNhm4Ap4Ek%3D&reserved=0>

I think it is not allowed to have FixAtBuild at IA32 and Dynamic at X64. BaseTool should have an error message for this.



[-- Attachment #2: Type: text/html, Size: 6604 bytes --]

  reply	other threads:[~2020-04-08  2:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06  2:55 Basetools fail without error message due to PCD type differs in architecture Lin, Derek (HPS SW)
2020-04-07 21:48 ` [EXTERNAL] [edk2-devel] " Bret Barkelew
2020-04-08  2:40   ` Lin, Derek (HPS SW) [this message]
2020-04-08  4:11     ` Bret Barkelew

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DF4PR8401MB09557F87A1A9D7532961064DC2C00@DF4PR8401MB0955.NAMPRD84.PROD.OUTLOOK.COM \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox