From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=01793483dc=abner.chang@hpe.com) Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by groups.io with SMTP; Wed, 02 Oct 2019 17:53:12 -0700 Received: from pps.filterd (m0150242.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x930pGwH005554; Thu, 3 Oct 2019 00:53:08 GMT Received: from g9t5009.houston.hpe.com (g9t5009.houston.hpe.com [15.241.48.73]) by mx0a-002e3701.pphosted.com with ESMTP id 2vct1pcrak-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Oct 2019 00:53:08 +0000 Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5009.houston.hpe.com (Postfix) with ESMTPS id 9596B6B; Thu, 3 Oct 2019 00:53:06 +0000 (UTC) Received: from G4W9326.americas.hpqcorp.net (16.208.32.96) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 3 Oct 2019 00:53:01 +0000 Received: from G1W8106.americas.hpqcorp.net (16.193.72.61) by G4W9326.americas.hpqcorp.net (16.208.32.96) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 3 Oct 2019 00:53:00 +0000 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (15.241.52.11) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 3 Oct 2019 00:53:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J+L9jJm2TK3clEjMZsQdkguFZ9omWlO2w+R/1UvHgPORov/YGGZA2UcYKDmGEbaGAdRsd3woUWLKGTN9BPLgl6aiiGGx8NtwszeeHSo1qwzrzXRfGLxBCkTzpID0KFHFed+S78Ar+H07HDlFI4fy9AT0m44b1KeZrowCCc7s7qTrEvey1/pWCsiVFhp+tIdzO7Dwxcyo2J3tufasm0oX6F1CPmQqw/kBNYXdpjGZxWHsCBS3MVksMDA7TX98EHB5GKp4Y3Eor7RUk4IMvtENsf4jh1pckbLs/4RZcQZrk6LIQ65iSO3k/n7mcEKn8Wt7bqFpPDsuDIYLN+uZBls1eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g3kx9s+SkbCDQ982Dx2zK5BzpJIX6bwsrvRpWtZ7IyY=; b=Am3RQjqPxGs22XO56E4oO5FltTpu9c1gN+topBDaNBzB5gs2EXKD9SlRgx9f1j8nuHBrfKTCEaVNU/OwmvUIlls9cFQ5htaadXrS6mtmxPUYAOVTXaoixDIqTXApYqncciKoHyZTFcUPR9FZf6C4cGxy3MQd5N096+A0Vqdoinmi04fVnVBjMZC67C3Q2sKPQQrlFSs+ngDzsQmryzKEBk+3YRqcHbNJBTDKnFBqRoxlMXXJ4gRPWz4DFiDsquayCMBJ6nlpcmGbBUOhSU8xts6KpBH3rkzd4HboxfxULfq4nXH3cZNOMBTWabXFQLJNKatjounDKSzfKNbvqB7//w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from DF4PR8401MB1195.NAMPRD84.PROD.OUTLOOK.COM (10.169.87.15) by DF4PR8401MB0858.NAMPRD84.PROD.OUTLOOK.COM (10.169.85.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.20; Thu, 3 Oct 2019 00:52:57 +0000 Received: from DF4PR8401MB1195.NAMPRD84.PROD.OUTLOOK.COM ([fe80::f540:ada0:c8e4:a0c1]) by DF4PR8401MB1195.NAMPRD84.PROD.OUTLOOK.COM ([fe80::f540:ada0:c8e4:a0c1%11]) with mapi id 15.20.2305.023; Thu, 3 Oct 2019 00:52:57 +0000 From: "Abner Chang" To: "devel@edk2.groups.io" , "leif.lindholm@linaro.org" , "afish@apple.com" CC: =?iso-8859-1?Q?Philippe_Mathieu-Daud=E9?= , Mike Kinney , Liming Gao Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 09/29] MdePkg/BaseIoLibIntrinsic: RISC-V I/O intrinsic functions. Thread-Topic: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 09/29] MdePkg/BaseIoLibIntrinsic: RISC-V I/O intrinsic functions. Thread-Index: AQHVcaqiBkSqxWRnL0+yEAnqc2QjJac+o/AAgAbjCwCAAAThAIABC+JggACILYCAAHF8wIAAB8UAgAACNQCAAImkUA== Date: Thu, 3 Oct 2019 00:52:57 +0000 Message-ID: References: <1569198715-31552-1-git-send-email-abner.chang@hpe.com> <1569198715-31552-11-git-send-email-abner.chang@hpe.com> <20190926233928.GL25504@bivouac.eciton.net> <90c04adf-79b1-2d89-1683-c916444126c7@redhat.com> <20191001090705.GQ25504@bivouac.eciton.net> <20191002091317.GZ25504@bivouac.eciton.net> <22170513-D99D-43E1-8086-B322DAC50857@apple.com> <20191002163510.GB25504@bivouac.eciton.net> In-Reply-To: <20191002163510.GB25504@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 88b13cbe-77d6-48cf-a46d-08d7479c0860 x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: DF4PR8401MB0858: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:785; x-forefront-prvs: 01792087B6 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6029001)(396003)(366004)(376002)(136003)(346002)(39860400002)(13464003)(199004)(189003)(486006)(9686003)(86362001)(8676002)(476003)(6306002)(6246003)(64756008)(66446008)(11346002)(5660300002)(71190400001)(71200400001)(66556008)(66946007)(446003)(76116006)(2501003)(66066001)(8936002)(2906002)(55016002)(52536014)(4326008)(2201001)(81156014)(81166006)(3846002)(54906003)(25786009)(6116002)(76176011)(966005)(6436002)(66476007)(256004)(14454004)(19627235002)(478600001)(53546011)(229853002)(186003)(316002)(102836004)(305945005)(7736002)(74316002)(110136005)(26005)(6506007)(7696005)(99286004)(33656002);DIR:OUT;SFP:1102;SCL:1;SRVR:DF4PR8401MB0858;H:DF4PR8401MB1195.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2pDr93ELiaFpNIYnRkM6IKVr/oiZrAQqHsL7eVD0dEUdBKeHYKqT6xVMJezZApZ/cgIhiZU0EVFaY3F9wsRNWpHXzhj7YphwHpJZ451bcuBMwD6Jiv20UjWHGE+Cm0j/DRsTPZaiL1xwLXg3CC9a1Jyy8UQbSyqZNoUWa3fXxUDpJWmbLQEpeh9UOs6cZrlQdhGyXWoZhmjlyMt+ZQanaLvKEOXf7CDclZ+4RuivFz9qM7XlgTabOFGMyyWDn2aB8tGW+rzeFIh12VhkiwMPsyzcflQdSvxLQu733gY0TtHmgEOSg68JlpXnfVouevUcBazvFGZfl4gQf+0lGOaIu4/6mvC/eJfcrfglDuprK7v0YynO5bhjA1IYlG4jhS1ZCUHWUZwEVY98wB40/ZyfedFbtOi6PlZe0ob/D5P93zT5YVVfaGLMhb341crVnSq/47UgSWTS1mpx+6Evn0FO9A== x-ms-exchange-transport-forked: True X-MS-Exchange-CrossTenant-Network-Message-Id: 88b13cbe-77d6-48cf-a46d-08d7479c0860 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2019 00:52:57.6156 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SIYjUde2aLhp0ekw1ASbuu2P91ZtW6ib9tPJ1b0oRPPbaO1bIJ7YsYdIEjFpn5RQ9JaKJhndLo3Xx1MbDZBZ8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0858 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-02_10:2019-10-01,2019-10-02 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 spamscore=0 mlxlogscore=999 clxscore=1011 mlxscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1910030004 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Thursday, October 3, 2019 12:35 AM > To: devel@edk2.groups.io; afish@apple.com > Cc: Chang, Abner (HPS SW/FW Technologist) ; > Philippe Mathieu-Daud=E9 ; Mike Kinney > ; Liming Gao > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 09/29] > MdePkg/BaseIoLibIntrinsic: RISC-V I/O intrinsic functions. >=20 > On Wed, Oct 02, 2019 at 11:27:16AM -0500, Andrew Fish via Groups.Io wrot= e: > > > > > > > On Oct 2, 2019, at 11:14 AM, Abner Chang > wrote: > > > > > > Thanks Leif, let me check with maintainers. > > > > > > Hi Mike and Liming, > > > How do you think about to use IoLibArm as the I/O lib instance for R= ISC-V > arch? I personally don't like to use IoLibArm.c in [Source.RISCV64] sect= ion, > instead I would like to use IoLibRiscV.c which conform with current sour= ce file > organization under BaseIoLibIntrinsics. What's your preference? > > > > > > > Abner, > > > > So is the plan to just copy IoLibArm.c to IoLibRiskV.c? I kind of > > agree with Leif that having two copies of the same thing does not make > > sense. I do see your point about naming, but maybe the issue the > > IoLibArm.c name. I don't see anything ARM specific in IoLibArm.c it > > seems to me it is generic C code for a platform that does not have IO > > Ports. So I guess we could just change the file name of IoLibArm.c to > > IoLibNoIo.c and have ARM and RISC-V point at the common file? Yes, naming is my concern. No technical issues here. Thanks for this suggestion. >=20 > Works for me. > We can untangle the remaining mess unrelated from the Risc-V upstreaming= . Leif, I will rename IoLibRiscV.c to IoLibNoIo.c in the next version of pat= ches. You can adopt the new file in ARM side later. Thanks Abner >=20 > Best Regards, >=20 > Leif >=20 >=20