From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0713.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe46::713]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2D9F91A1E43 for ; Wed, 26 Oct 2016 21:09:31 -0700 (PDT) Received: from DF4PR84MB0025.NAMPRD84.PROD.OUTLOOK.COM (10.162.192.14) by DF4PR84MB0122.NAMPRD84.PROD.OUTLOOK.COM (10.162.192.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.679.12; Thu, 27 Oct 2016 04:09:28 +0000 Received: from DF4PR84MB0025.NAMPRD84.PROD.OUTLOOK.COM ([10.162.192.14]) by DF4PR84MB0025.NAMPRD84.PROD.OUTLOOK.COM ([10.162.192.14]) with mapi id 15.01.0679.015; Thu, 27 Oct 2016 04:09:28 +0000 From: "Lin, Derek (HPS UEFI Dev)" To: "edk2-devel@lists.01.org" , "afish@apple.com" Thread-Topic: [edk2] [BaseTools] Library GUIDs missing from Guid.xref file. Thread-Index: AQHSL+637m0gt1BefEud2qkE2Tmo86C7ii/QgAAZptA= Date: Thu, 27 Oct 2016 04:09:28 +0000 Message-ID: References: <497D3E4E-A601-476E-897C-78F3ED389C46@apple.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=derek.lin2@hpe.com; x-originating-ip: [15.211.131.14] x-ms-office365-filtering-correlation-id: 9853aa7f-d84a-4b96-1697-08d3fe1f0c18 x-microsoft-exchange-diagnostics: 1; DF4PR84MB0122; 7:1t9dpn2D8BSw92f8IkQ+D//2lkwT3sLG9hMyTVvW/Z2wI/B/IM5BR5HzAVMugMJTgfc61NLp6uBGw0oywib9DQI8rBg6dRkD85S3wnTL07JbP99+rYVIP3KqgkUS6WngCS7pp93syF4d+6RF9PPe6J5rhbrs1aUvHjWLTOkyqqifaiN1gXpLYPx8x/Z2bg5wlsrO2bGnxladUl26wUfdDXg44AlqW24x94PTeEm/nhLbcbkyh3bifSrHeKlmUxq/s30Kyyypn67b+/A96Whgmw32jw/RqfUMbaVm0RDws7i0wG16RHI4g00C6lSghoVEi09WHy83G05CXSrIP2cpJceK6Oab5VJ1NiqxOm+ZKeo= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DF4PR84MB0122; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(166708455590820)(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026); SRVR:DF4PR84MB0122; BCL:0; PCL:0; RULEID:; SRVR:DF4PR84MB0122; x-forefront-prvs: 0108A997B2 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(377454003)(189002)(199003)(7696004)(92566002)(3660700001)(106116001)(87936001)(9686002)(15975445007)(7736002)(68736007)(3280700002)(5001770100001)(4326007)(189998001)(122556002)(3846002)(2900100001)(97736004)(2501003)(6116002)(2950100002)(102836003)(586003)(10400500002)(19580395003)(99286002)(19580405001)(2906002)(74316002)(86362001)(11100500001)(66066001)(81166006)(8936002)(8676002)(76176999)(5660300001)(50986999)(54356999)(106356001)(101416001)(8666005)(81156014)(105586002)(77096005)(5002640100001)(305945005)(7846002)(33656002)(7059030); DIR:OUT; SFP:1102; SCL:1; SRVR:DF4PR84MB0122; H:DF4PR84MB0025.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2016 04:09:28.7646 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR84MB0122 Subject: Re: [BaseTools] Library GUIDs missing from Guid.xref file. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2016 04:09:31 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Andrew, We also see this issue recently. And we have a fix. I've send email patch m= inutes ago. Thanks, Derek From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Andr= ew Fish Sent: Thursday, October 27, 2016 9:08 AM To: edk2-devel Subject: [edk2] [BaseTools] Library GUIDs missing from Guid.xref file. I noticed if a GUID (PPI & Protocol) was only used via a library it does no= t end up in the Guid.xref file.=20 It looks to me like this code is only extracting the GUIDs from the Drivers= INF file and the GUIDs defined in dependent libraries are skipped? =20 https://github.com/tianocore/edk2/blob/master/BaseTools/Source/Python/GenFd= s/GenFds.py#L701 for Arch in ArchList: PlatformDataBase =3D BuildDb.BuildObject[GenFdsGlobalVariable.A= ctivePlatform, Arch, GenFdsGlobalVariable.TargetName, GenFdsGlobalVariable.= ToolChainTag] for ModuleFile in PlatformDataBase.Modules: Module =3D BuildDb.BuildObject[ModuleFile, Arch, GenFdsGlob= alVariable.TargetName, GenFdsGlobalVariable.ToolChainTag] GuidXRefFile.write("%s %s\n" % (Module.Guid, Module.BaseNam= e)) for key, item in Module.Protocols.items(): GuidDict[key] =3D item for key, item in Module.Guids.items(): GuidDict[key] =3D item for key, item in Module.Ppis.items(): GuidDict[key] =3D item Does anyone know how to extract the info from the dependent libs?=20 I have an lldb type formatter for EFI_GUID that will print out the GUID C n= ame so I noticed when some of them went missing.=20 Thanks, Andrew Fish _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel