From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g9t5008.houston.hpe.com (g9t5008.houston.hpe.com [15.241.48.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D31A22194EB79 for ; Sun, 16 Apr 2017 21:46:01 -0700 (PDT) Received: from G4W9122.americas.hpqcorp.net (g4w9122.houston.hp.com [16.210.21.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5008.houston.hpe.com (Postfix) with ESMTPS id CC65059 for ; Mon, 17 Apr 2017 04:46:00 +0000 (UTC) Received: from G4W9122.americas.hpqcorp.net (2002:10d2:1511::10d2:1511) by G4W9122.americas.hpqcorp.net (2002:10d2:1511::10d2:1511) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Mon, 17 Apr 2017 04:46:00 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (15.241.52.10) by G4W9122.americas.hpqcorp.net (16.210.21.17) with Microsoft SMTP Server (TLS) id 15.0.1178.4 via Frontend Transport; Mon, 17 Apr 2017 04:46:00 +0000 Received: from DF4PR84MB0041.NAMPRD84.PROD.OUTLOOK.COM (10.162.192.143) by DF4PR84MB0044.NAMPRD84.PROD.OUTLOOK.COM (10.162.192.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.10; Mon, 17 Apr 2017 04:45:53 +0000 Received: from DF4PR84MB0041.NAMPRD84.PROD.OUTLOOK.COM ([10.162.192.143]) by DF4PR84MB0041.NAMPRD84.PROD.OUTLOOK.COM ([10.162.192.143]) with mapi id 15.01.1034.013; Mon, 17 Apr 2017 04:45:46 +0000 From: "Subramanian, Sriram" To: Jiaxin Wu , "edk2-devel@lists.01.org" CC: Ye Ting , Fu Siyuan , Zhang Lubo Thread-Topic: [Patch] MdeModulePkg/Ip4Dxe: Fix the incorrect RemoveEntryList Thread-Index: AQHStyt9ezTtbYWChkytCo+Dn2/2maHI/IVg Date: Mon, 17 Apr 2017 04:45:46 +0000 Message-ID: References: <1492400035-6092-1-git-send-email-jiaxin.wu@intel.com> In-Reply-To: <1492400035-6092-1-git-send-email-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [16.242.235.130] x-microsoft-exchange-diagnostics: 1; DF4PR84MB0044; 7:Rjha2a4Ow1/vnp85rLOWHDqpCKkUZtEJ1seL/6RTpvWGfn5nTgiT9jipdX7JHD8Z0hYYrdxfKz++JpLE+MrOtPB9uKjrDsJJ5Lhg37kE1MSYuFVx6sBZwg60YOMrI2V9RDxhUVa+BGuAvX+p7LGDAPTjK5fWtq9XHJgR/DuGjdXBs2kEkXP1Q1q1kviZVCxeqJcFdj1BkG/h177SFOl7tMKBCxlovft6pBnXAfJyXciqx+N5QPkLAKOeyoSc8OMPvH8lup4OlMdvbi8XDDdwVGJNVAD1HGtCU+cL8MBJkbJYxXjhc5ujzZqBy+sbKYgSTH5khC49WeC3KaeAPLemVQ== x-ms-office365-filtering-correlation-id: bc806c51-94c3-4521-ff3d-08d4854c9d0b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081); SRVR:DF4PR84MB0044; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123560025)(20161123562025)(20161123555025)(20161123564025)(6072148); SRVR:DF4PR84MB0044; BCL:0; PCL:0; RULEID:; SRVR:DF4PR84MB0044; x-forefront-prvs: 02801ACE41 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(39850400002)(39400400002)(39410400002)(39450400003)(39860400002)(39840400002)(13464003)(377454003)(5660300001)(38730400002)(3660700001)(81166006)(25786009)(2950100002)(33656002)(74316002)(3280700002)(189998001)(2900100001)(86362001)(305945005)(53546009)(229853002)(8936002)(66066001)(55016002)(4326008)(50986999)(77096006)(54356999)(7696004)(6506006)(53936002)(76176999)(7736002)(2906002)(102836003)(6116002)(3846002)(2501003)(8676002)(9686003)(122556002)(6246003)(6436002)(19627235001); DIR:OUT; SFP:1102; SCL:1; SRVR:DF4PR84MB0044; H:DF4PR84MB0041.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2017 04:45:46.4431 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR84MB0044 X-OriginatorOrg: hpe.com Subject: Re: [Patch] MdeModulePkg/Ip4Dxe: Fix the incorrect RemoveEntryList X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Apr 2017 04:46:02 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sriram Subramanian -----Original Message----- From: Jiaxin Wu [mailto:jiaxin.wu@intel.com]=20 Sent: Monday, April 17, 2017 9:04 AM To: edk2-devel@lists.01.org Cc: Subramanian, Sriram ; Ye Ting ; Fu= Siyuan ; Zhang Lubo ; Wu Jiaxin= Subject: [Patch] MdeModulePkg/Ip4Dxe: Fix the incorrect RemoveEntryList Cc: Subramanian Sriram Cc: Ye Ting Cc: Fu Siyuan Cc: Zhang Lubo Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c b/MdeModulePkg/U= niversal/Network/Ip4Dxe/Ip4If.c index 7512a00..d29d873 100644 --- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c +++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c @@ -853,11 +853,11 @@ Ip4OnArpResolvedDpc ( // InsertTailList (&Interface->SentFrames, &Token->Link); =20 Status =3D Interface->Mnp->Transmit (Interface->Mnp, &Token->MnpToken)= ; if (EFI_ERROR (Status)) { - RemoveEntryList (Entry); + RemoveEntryList (&Token->Link); Token->CallBack (Token->IpInstance, Token->Packet, Status, 0, Token-= >Context); =20 Ip4FreeLinkTxToken (Token); continue; } @@ -1079,11 +1079,11 @@ SEND_NOW: // Remove it if the returned status is not EFI_SUCCESS. // InsertTailList (&Interface->SentFrames, &Token->Link); Status =3D Interface->Mnp->Transmit (Interface->Mnp, &Token->MnpToken); if (EFI_ERROR (Status)) { - RemoveEntryList (&Interface->SentFrames); + RemoveEntryList (&Token->Link); goto ON_ERROR; } =20 return EFI_SUCCESS; =20 --=20 1.9.5.msysgit.1