public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Huber, Brandon" <brandon.huber@hp.com>
To: "edk2-devel (edk2-devel@lists.01.org)" <edk2-devel@lists.01.org>
Subject: DSC macro expansion
Date: Wed, 18 Jan 2017 23:35:26 +0000	[thread overview]
Message-ID: <DF4PR84MB013790912A5B6BC5FBE2B7A4917F0@DF4PR84MB0137.NAMPRD84.PROD.OUTLOOK.COM> (raw)

Hi All,

There seems to be a discrepancy between the DSC spec and the EDKII implementation regarding what macros are allowed in !include statements within a DSC file.

>From the spec (v1.26 section 2.2.5):

Macros, defined in this file, are not permitted in the path or file name of the !include statement, as these files are included prior to processing the file for macros. If the path starts with a "$" character, then one of the system environment variables, $(WORKSPACE), $(EDK_SOURCE), $(EFI_SOURCE), or $(ECP_SOURCE) is being used; only these system environment variables are permitted to start the path of the included file.
Yet from experimentation, all macros defined in DSC files seem to be permitted in !include statements by the build tools. Is the spec out of date, or is the code wrong?

I think the code in question is _GetMacros() in BaseTools/Source/Python/Workspace/WorkspaceDatabase.py<https://github.com/tianocore/edk2/commit/0d2711a69397d2971079121df4326d84736c181e#diff-7cfd5e9099421b207e7718d47950d40dR148> (https://github.com/tianocore/edk2/commit/0d2711a69397d2971079121df4326d84736c181e#diff-7cfd5e9099421b207e7718d47950d40dR148).

Thanks,
-Brandon



             reply	other threads:[~2017-01-18 23:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18 23:35 Huber, Brandon [this message]
2017-01-19 10:28 ` DSC macro expansion Zhu, Yonghong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DF4PR84MB013790912A5B6BC5FBE2B7A4917F0@DF4PR84MB0137.NAMPRD84.PROD.OUTLOOK.COM \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox