From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on071e.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe41::71e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5DCCF81C48 for ; Wed, 14 Dec 2016 14:08:39 -0800 (PST) Received: from DF4PR84MB0154.NAMPRD84.PROD.OUTLOOK.COM (10.162.192.28) by DF4PR84MB0155.NAMPRD84.PROD.OUTLOOK.COM (10.162.192.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.771.8; Wed, 14 Dec 2016 22:08:36 +0000 Received: from DF4PR84MB0154.NAMPRD84.PROD.OUTLOOK.COM ([10.162.192.28]) by DF4PR84MB0154.NAMPRD84.PROD.OUTLOOK.COM ([10.162.192.28]) with mapi id 15.01.0771.014; Wed, 14 Dec 2016 22:08:35 +0000 From: "Palmer, Thomas" To: Laszlo Ersek , Bruce Cran , "edk2-devel (edk2-devel@lists.01.org)" CC: "Wu, Hao A" , "Ni, Ruiyu" , "Gao, Liming" Thread-Topic: [edk2] OVMF: cross-filesystem copy broken? ("The source and destination are the same") Thread-Index: AQHSQIBPTbyGSQttkkm0YqECUAj9uaDc6umAgABhbACAAAvPAIAq0wgA Date: Wed, 14 Dec 2016 22:08:35 +0000 Message-ID: References: <47cd17d8-f022-6ca5-2f52-06a8250f8d14@cran.org.uk> <886a3cc4-3dcb-db33-cc74-cbe4c6714d09@cran.org.uk> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=thomas.palmer@hpe.com; x-originating-ip: [15.203.227.4] x-ms-office365-filtering-correlation-id: 379c1243-5b52-4e6c-1c94-08d4246dc016 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DF4PR84MB0155; x-microsoft-exchange-diagnostics: 1; DF4PR84MB0155; 7:Pz9FhUOWQWPvdMrki8ROw/3joJpeGghfrq+5YhLRJDWXiqcsaMFFl2OdCQL+vT5DuLWemZqhLFuKGwM5MqgUAO9B2pDa75pMlSCF9MRTtFCUGc7aqc8sMfG3fWpvGuf7mrlrT3GaiLh/ikJpPbL+vvax/GDmIx4uXZHucnQo0p/zmaigxlFKhCE69AIRf2oUmoduwaSayHkI/NbZSNSg25be3jkCUjw6maF8ltwva6BhGgNZ6EyYMYWW7okjAIomH1DDcaOC3+jWcbPu/GTlGzIbc7QGj2QCq1AtHBZNSpL/IQKT5aePZvQ85zT7wm0+6CdK3CHvcjDzMZRK+XbqkNi3A/za99bC/9ItHMrVNvizqmgk/UXX9HptrpnuvBIKih26aele5c5bkpnwUU6bKE6p2UuJClX9BycSNnzXuxv1EA9hgFt8H6YRekq2/bU4WKrg0STeLtxc49hjbp8fZA== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(190756311086443)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(6072148); SRVR:DF4PR84MB0155; BCL:0; PCL:0; RULEID:; SRVR:DF4PR84MB0155; x-forefront-prvs: 01565FED4C x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(39860400002)(39450400003)(39410400002)(39850400002)(39840400002)(13464003)(199003)(24454002)(377454003)(189002)(305945005)(2906002)(7736002)(101416001)(189998001)(122556002)(8676002)(3660700001)(99286002)(86362001)(93886004)(106356001)(2900100001)(106116001)(92566002)(6116002)(33656002)(97736004)(5001770100001)(105586002)(102836003)(3846002)(7696004)(5660300001)(76176999)(50986999)(54356999)(74316002)(6506006)(9686002)(229853002)(68736007)(6436002)(3280700002)(4326007)(8936002)(81156014)(77096006)(66066001)(81166006)(2950100002)(38730400001)(19627235001); DIR:OUT; SFP:1102; SCL:1; SRVR:DF4PR84MB0155; H:DF4PR84MB0154.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2016 22:08:35.6397 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR84MB0155 Subject: Re: OVMF: cross-filesystem copy broken? ("The source and destination are the same") X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Dec 2016 22:08:39 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Laszlo, et al~ I recently encountered a "cp" failure on OVMF whereby cp always thought my = source and destination file paths were equivalent. Turns out that StrniCmp= function was broken b/c the InternalCharToUpper declaration in UefiShellLe= vel2CommandsLib.c was missing the EFIAPI token. Once I added EFIAPI back, = my cp command worked. I'm on vacation so I can't write up a formal patch right now. Give it a t= ry and if it works please write up a patch, else I'll get back to it when I= get back. Regards, Thomas Palmer "I have only made this letter longer because I have not had the time to mak= e it shorter" - Blaise Pascal -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Lasz= lo Ersek Sent: Thursday, November 17, 2016 10:07 AM To: Bruce Cran ; edk2-devel (edk2-devel@lists.01.org) Cc: Wu, Hao A ; Ni, Ruiyu ; Gao, Li= ming Subject: Re: [edk2] OVMF: cross-filesystem copy broken? ("The source and de= stination are the same") On 11/17/16 16:24, Bruce Cran wrote: > On 11/17/2016 2:35 AM, Laszlo Ersek wrote: >=20 >> There's a patch on the list for said BZ: >> [edk2] [PATCH v2] API PathRemoveLastItem not handle root paths=20 >> properly >> >> so if the BZ is indeed what you're encountering, then the patch=20 >> should fix it for you. Can you please test it and report back in that th= read? >=20 > Unfortunately the patch doesn't fix the problem I'm seeing. >=20 Thanks for trying it. Unfortunately, I can't find the time to dig into this now. And, I think it'= s likely related to ShellPkg anyway. Can you please help by filing a BZ for= ShellPkg, and/or bisecting the issue (assuming you remember the same comma= nd working at some point)? ... I observe that the least recent commit that affected "Cp.c" with any po= tential to break it like this could be commit fbd2dfadfe6fb16ab7b49fca3764e05e65d97b8a Author: Qiu Shumin Date: Fri Oct 23 02:03:20 2015 +0000 ShellPkg: Follow spec to remove the last '\' char in return name of Get= CurDir(). but that commit is more than a year old now... So I'm not sure. Could be on= e of the underlying helper functions. Time to pull out GDB and single step = the code? :) Thanks! Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel