From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0706.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe45::706]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DCB7181951 for ; Mon, 9 Jan 2017 01:29:31 -0800 (PST) Received: from DF4PR84MB0236.NAMPRD84.PROD.OUTLOOK.COM (10.162.193.153) by DF4PR84MB0236.NAMPRD84.PROD.OUTLOOK.COM (10.162.193.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.829.7; Mon, 9 Jan 2017 09:29:30 +0000 Received: from DF4PR84MB0236.NAMPRD84.PROD.OUTLOOK.COM ([10.162.193.153]) by DF4PR84MB0236.NAMPRD84.PROD.OUTLOOK.COM ([10.162.193.153]) with mapi id 15.01.0829.013; Mon, 9 Jan 2017 09:29:30 +0000 From: "Augustine, Linson P" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "michael.d.kinney@intel.com" , "liming.gao@intel.com" Thread-Topic: [edk2] [PATCH v1 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43 Thread-Index: AQHSalanIao2JfYByUi6JOMU/jx3fqEv3iuAgAACb7A= Date: Mon, 9 Jan 2017 09:29:30 +0000 Message-ID: References: <20170109085859.7732-1-linson.augustine@hpe.com> <21cdd05a-a9ef-8b8f-01ec-a6caf7e92157@intel.com> In-Reply-To: <21cdd05a-a9ef-8b8f-01ec-a6caf7e92157@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=linson.augustine@hpe.com; x-originating-ip: [15.219.195.4] x-ms-office365-filtering-correlation-id: f781b3ad-5a12-4cb7-006f-08d4387203bb x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DF4PR84MB0236; x-microsoft-exchange-diagnostics: 1; DF4PR84MB0236; 7:imOsBHdiDCE+Jg7KRt1MHLlMEKQ1V41gHm0BvKwKTXKyuyKeXTrTqTOfntYF/T9R7ipiK0SdBwEym98fC+smKhlpcJsPi3DWtz5s719XOvx/W68YUYD3nYekCnklM63mznMCn4gtw6WytWOSi1nIfx6gXCJDyOwaGOGQGxRLu1mkH1Mw1ceuX4s/pbdV+eoQLwt3ObNp9Li6+1kt7We6dnqVtPjobNaXJU6JWy0q67JOE7l/z6uOaXEp7ttczzJ13nXkf2jS1McFLkBOFGidZyKBE3PDh05dH9QPZUly7btBNF3jOtvXcQsySMQcOswqFWccrqx32AW4jDtE0E92grtesbyoDWhvMgbKuBJ4c3GHmmN6hb3rfV+vTgv66uKDw4AB6/JPOKbvjwI/W8CzdFTnWqioCqU9aQezgvRbKvVXw13XsMCUuW35WZ6yvw7Umh5o6I22RvL2niXwRTJ6ew== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148); SRVR:DF4PR84MB0236; BCL:0; PCL:0; RULEID:; SRVR:DF4PR84MB0236; x-forefront-prvs: 0182DBBB05 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6029001)(6009001)(7916002)(39850400002)(39860400002)(39840400002)(39450400003)(39410400002)(13464003)(24454002)(189002)(377454003)(199003)(122556002)(8676002)(97736004)(2501003)(5001770100001)(106356001)(105586002)(106116001)(305945005)(92566002)(3660700001)(7736002)(74316002)(66066001)(2900100001)(81166006)(2950100002)(8936002)(81156014)(76176999)(50986999)(54356999)(189998001)(77096006)(4326007)(33656002)(68736007)(101416001)(38730400001)(54906002)(7696004)(86362001)(55016002)(6436002)(6506006)(3280700002)(9686003)(102836003)(3846002)(5660300001)(6116002)(2906002)(229853002); DIR:OUT; SFP:1102; SCL:1; SRVR:DF4PR84MB0236; H:DF4PR84MB0236.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2017 09:29:30.3804 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR84MB0236 Subject: Re: [PATCH v1 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 09:29:32 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank you Star for the review. I will change the commit the message. I don't have plans for the other definitions. Regards, Linson -----Original Message----- From: Zeng, Star [mailto:star.zeng@intel.com]=20 Sent: Monday, January 09, 2017 2:49 PM To: Augustine, Linson P ; edk2-devel@lists.01.org Cc: michael.d.kinney@intel.com; liming.gao@intel.com; star.zeng@intel.com Subject: Re: [edk2] [PATCH v1 1/1] MdePkg/SmBios.h: Add new defines for SMB= IOS record type 43 Hi Linson, On 2017/1/9 16:58, Linson Augustine wrote: > Added defintions for the new SMBIOS Type 43 record. Typo "defintions" should be "definitions". I noticed that the new type 43 is added in new SMBIOS spec 3.1.0, but there= are also other definitions and structure fields added in new SMBIOS spec 3= .1.0, will you plan to add them too? Thanks, Star > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Augustine Linson P > --- > MdePkg/Include/IndustryStandard/SmBios.h | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h=20 > b/MdePkg/Include/IndustryStandard/SmBios.h > index c66422fc3a..debc85af6e 100644 > --- a/MdePkg/Include/IndustryStandard/SmBios.h > +++ b/MdePkg/Include/IndustryStandard/SmBios.h > @@ -2,7 +2,7 @@ > Industry Standard Definitions of SMBIOS Table Specification v3.0.0. > > Copyright (c) 2006 - 2015, Intel Corporation. All rights=20 > reserved.
> -(C) Copyright 2015 Hewlett Packard Enterprise Development LP
> +(C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP
> This program and the accompanying materials are licensed and made=20 > available under the terms and conditions of the BSD License that accompa= nies this distribution. > The full text of the license may be found at @@ -97,6 +97,7 @@=20 > WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPL= IED. > #define SMBIOS_TYPE_ADDITIONAL_INFORMATION 40 > #define SMBIOS_TYPE_ONBOARD_DEVICES_EXTENDED_INFORMATION 41 #define=20 > SMBIOS_TYPE_MANAGEMENT_CONTROLLER_HOST_INTERFACE 42 > +#define SMBIOS_TYPE_TPM_DEVICE 43 > > /// > /// Inactive type is added from SMBIOS 2.2. Reference SMBIOS 2.6, chapte= r 3.3.43. > @@ -2359,6 +2360,21 @@ typedef struct { } SMBIOS_TABLE_TYPE42; > > /// > +/// TPM Device (Type 43). > +/// > +typedef struct { > + SMBIOS_STRUCTURE Hdr; > + UINT8 VendorID[4]; > + UINT8 MajorSpecVersion; > + UINT8 MinorSpecVersion; > + UINT32 FirmwareVersion1; > + UINT32 FirmwareVersion2; > + UINT8 Description; > + UINT64 Characteristics; > + UINT32 OemDefined; > +} SMBIOS_TABLE_TYPE43; > + > +/// > /// Inactive (Type 126) > /// > typedef struct { > @@ -2420,6 +2436,7 @@ typedef union { > SMBIOS_TABLE_TYPE40 *Type40; > SMBIOS_TABLE_TYPE41 *Type41; > SMBIOS_TABLE_TYPE42 *Type42; > + SMBIOS_TABLE_TYPE43 *Type43; > SMBIOS_TABLE_TYPE126 *Type126; > SMBIOS_TABLE_TYPE127 *Type127; > UINT8 *Raw; >