* [PATCH v2 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43
@ 2017-01-11 9:10 Linson Augustine
2017-01-11 9:23 ` Zeng, Star
0 siblings, 1 reply; 4+ messages in thread
From: Linson Augustine @ 2017-01-11 9:10 UTC (permalink / raw)
To: edk2-devel
Cc: jaben.carsey, ruiyu.ni, michael.d.kinney, liming.gao, star.zeng
Added definitions for the new SMBIOS Type 43 record.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Augustine Linson P <linson.augustine@hpe.com>
---
MdePkg/Include/IndustryStandard/SmBios.h | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index c66422fc3a..debc85af6e 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -2,7 +2,7 @@
Industry Standard Definitions of SMBIOS Table Specification v3.0.0.
Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR>
-(C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
+(C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>
This program and the accompanying materials are licensed and made available under
the terms and conditions of the BSD License that accompanies this distribution.
The full text of the license may be found at
@@ -97,6 +97,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
#define SMBIOS_TYPE_ADDITIONAL_INFORMATION 40
#define SMBIOS_TYPE_ONBOARD_DEVICES_EXTENDED_INFORMATION 41
#define SMBIOS_TYPE_MANAGEMENT_CONTROLLER_HOST_INTERFACE 42
+#define SMBIOS_TYPE_TPM_DEVICE 43
///
/// Inactive type is added from SMBIOS 2.2. Reference SMBIOS 2.6, chapter 3.3.43.
@@ -2359,6 +2360,21 @@ typedef struct {
} SMBIOS_TABLE_TYPE42;
///
+/// TPM Device (Type 43).
+///
+typedef struct {
+ SMBIOS_STRUCTURE Hdr;
+ UINT8 VendorID[4];
+ UINT8 MajorSpecVersion;
+ UINT8 MinorSpecVersion;
+ UINT32 FirmwareVersion1;
+ UINT32 FirmwareVersion2;
+ UINT8 Description;
+ UINT64 Characteristics;
+ UINT32 OemDefined;
+} SMBIOS_TABLE_TYPE43;
+
+///
/// Inactive (Type 126)
///
typedef struct {
@@ -2420,6 +2436,7 @@ typedef union {
SMBIOS_TABLE_TYPE40 *Type40;
SMBIOS_TABLE_TYPE41 *Type41;
SMBIOS_TABLE_TYPE42 *Type42;
+ SMBIOS_TABLE_TYPE43 *Type43;
SMBIOS_TABLE_TYPE126 *Type126;
SMBIOS_TABLE_TYPE127 *Type127;
UINT8 *Raw;
--
2.11.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43
2017-01-11 9:10 [PATCH v2 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43 Linson Augustine
@ 2017-01-11 9:23 ` Zeng, Star
2017-01-11 9:35 ` Augustine, Linson P
0 siblings, 1 reply; 4+ messages in thread
From: Zeng, Star @ 2017-01-11 9:23 UTC (permalink / raw)
To: Linson Augustine, edk2-devel
Cc: jaben.carsey, ruiyu.ni, michael.d.kinney, liming.gao, star.zeng
Linson,
Add minor comments inline.
On 2017/1/11 17:10, Linson Augustine wrote:
> Added definitions for the new SMBIOS Type 43 record.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Augustine Linson P <linson.augustine@hpe.com>
> ---
> MdePkg/Include/IndustryStandard/SmBios.h | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
> index c66422fc3a..debc85af6e 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -2,7 +2,7 @@
> Industry Standard Definitions of SMBIOS Table Specification v3.0.0.
>
> Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR>
> -(C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> +(C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>
> This program and the accompanying materials are licensed and made available under
> the terms and conditions of the BSD License that accompanies this distribution.
> The full text of the license may be found at
> @@ -97,6 +97,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> #define SMBIOS_TYPE_ADDITIONAL_INFORMATION 40
> #define SMBIOS_TYPE_ONBOARD_DEVICES_EXTENDED_INFORMATION 41
> #define SMBIOS_TYPE_MANAGEMENT_CONTROLLER_HOST_INTERFACE 42
> +#define SMBIOS_TYPE_TPM_DEVICE 43
>
> ///
> /// Inactive type is added from SMBIOS 2.2. Reference SMBIOS 2.6, chapter 3.3.43.
> @@ -2359,6 +2360,21 @@ typedef struct {
> } SMBIOS_TABLE_TYPE42;
>
> ///
> +/// TPM Device (Type 43).
> +///
> +typedef struct {
> + SMBIOS_STRUCTURE Hdr;
> + UINT8 VendorID[4];
> + UINT8 MajorSpecVersion;
> + UINT8 MinorSpecVersion;
> + UINT32 FirmwareVersion1;
> + UINT32 FirmwareVersion2;
> + UINT8 Description;
It is better to use "SMBIOS_TABLE_STRING Description" instead of "UINT8
Description".
If you agree that, you can have my Reviewed-by: Star Zeng
<star.zeng@intel.com>.
And you do not need to resend the patch, I will help push the patch with
the line fixed if no others' comments.
Thanks,
Star
> + UINT64 Characteristics;
> + UINT32 OemDefined;
> +} SMBIOS_TABLE_TYPE43;
> +
> +///
> /// Inactive (Type 126)
> ///
> typedef struct {
> @@ -2420,6 +2436,7 @@ typedef union {
> SMBIOS_TABLE_TYPE40 *Type40;
> SMBIOS_TABLE_TYPE41 *Type41;
> SMBIOS_TABLE_TYPE42 *Type42;
> + SMBIOS_TABLE_TYPE43 *Type43;
> SMBIOS_TABLE_TYPE126 *Type126;
> SMBIOS_TABLE_TYPE127 *Type127;
> UINT8 *Raw;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43
2017-01-11 9:23 ` Zeng, Star
@ 2017-01-11 9:35 ` Augustine, Linson P
2017-01-12 1:33 ` Zeng, Star
0 siblings, 1 reply; 4+ messages in thread
From: Augustine, Linson P @ 2017-01-11 9:35 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org
Cc: jaben.carsey@intel.com, ruiyu.ni@intel.com,
michael.d.kinney@intel.com, liming.gao@intel.com
Star,
I agree with this. Please help me to push this patch.
Regards,
Linson.
-----Original Message-----
From: Zeng, Star [mailto:star.zeng@intel.com]
Sent: Wednesday, January 11, 2017 2:53 PM
To: Augustine, Linson P <linson.augustine@hpe.com>; edk2-devel@lists.01.org
Cc: jaben.carsey@intel.com; ruiyu.ni@intel.com; michael.d.kinney@intel.com; liming.gao@intel.com; star.zeng@intel.com
Subject: Re: [edk2] [PATCH v2 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43
Linson,
Add minor comments inline.
On 2017/1/11 17:10, Linson Augustine wrote:
> Added definitions for the new SMBIOS Type 43 record.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Augustine Linson P <linson.augustine@hpe.com>
> ---
> MdePkg/Include/IndustryStandard/SmBios.h | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index c66422fc3a..debc85af6e 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -2,7 +2,7 @@
> Industry Standard Definitions of SMBIOS Table Specification v3.0.0.
>
> Copyright (c) 2006 - 2015, Intel Corporation. All rights
> reserved.<BR>
> -(C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> +(C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>
> This program and the accompanying materials are licensed and made
> available under the terms and conditions of the BSD License that accompanies this distribution.
> The full text of the license may be found at @@ -97,6 +97,7 @@
> WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> #define SMBIOS_TYPE_ADDITIONAL_INFORMATION 40
> #define SMBIOS_TYPE_ONBOARD_DEVICES_EXTENDED_INFORMATION 41 #define
> SMBIOS_TYPE_MANAGEMENT_CONTROLLER_HOST_INTERFACE 42
> +#define SMBIOS_TYPE_TPM_DEVICE 43
>
> ///
> /// Inactive type is added from SMBIOS 2.2. Reference SMBIOS 2.6, chapter 3.3.43.
> @@ -2359,6 +2360,21 @@ typedef struct { } SMBIOS_TABLE_TYPE42;
>
> ///
> +/// TPM Device (Type 43).
> +///
> +typedef struct {
> + SMBIOS_STRUCTURE Hdr;
> + UINT8 VendorID[4];
> + UINT8 MajorSpecVersion;
> + UINT8 MinorSpecVersion;
> + UINT32 FirmwareVersion1;
> + UINT32 FirmwareVersion2;
> + UINT8 Description;
It is better to use "SMBIOS_TABLE_STRING Description" instead of "UINT8 Description".
If you agree that, you can have my Reviewed-by: Star Zeng <star.zeng@intel.com>.
And you do not need to resend the patch, I will help push the patch with the line fixed if no others' comments.
Thanks,
Star
> + UINT64 Characteristics;
> + UINT32 OemDefined;
> +} SMBIOS_TABLE_TYPE43;
> +
> +///
> /// Inactive (Type 126)
> ///
> typedef struct {
> @@ -2420,6 +2436,7 @@ typedef union {
> SMBIOS_TABLE_TYPE40 *Type40;
> SMBIOS_TABLE_TYPE41 *Type41;
> SMBIOS_TABLE_TYPE42 *Type42;
> + SMBIOS_TABLE_TYPE43 *Type43;
> SMBIOS_TABLE_TYPE126 *Type126;
> SMBIOS_TABLE_TYPE127 *Type127;
> UINT8 *Raw;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43
2017-01-11 9:35 ` Augustine, Linson P
@ 2017-01-12 1:33 ` Zeng, Star
0 siblings, 0 replies; 4+ messages in thread
From: Zeng, Star @ 2017-01-12 1:33 UTC (permalink / raw)
To: Augustine, Linson P, edk2-devel@lists.01.org
Cc: Carsey, Jaben, Ni, Ruiyu, Kinney, Michael D, Gao, Liming,
Zeng, Star
Linson,
The patch has been pushed at 713e4b007cb791829397522ad8f366dd1e08bee6, thanks for the contribution.
Star
-----Original Message-----
From: Augustine, Linson P [mailto:linson.augustine@hpe.com]
Sent: Wednesday, January 11, 2017 5:36 PM
To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: RE: [edk2] [PATCH v2 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43
Star,
I agree with this. Please help me to push this patch.
Regards,
Linson.
-----Original Message-----
From: Zeng, Star [mailto:star.zeng@intel.com]
Sent: Wednesday, January 11, 2017 2:53 PM
To: Augustine, Linson P <linson.augustine@hpe.com>; edk2-devel@lists.01.org
Cc: jaben.carsey@intel.com; ruiyu.ni@intel.com; michael.d.kinney@intel.com; liming.gao@intel.com; star.zeng@intel.com
Subject: Re: [edk2] [PATCH v2 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43
Linson,
Add minor comments inline.
On 2017/1/11 17:10, Linson Augustine wrote:
> Added definitions for the new SMBIOS Type 43 record.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Augustine Linson P <linson.augustine@hpe.com>
> ---
> MdePkg/Include/IndustryStandard/SmBios.h | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index c66422fc3a..debc85af6e 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -2,7 +2,7 @@
> Industry Standard Definitions of SMBIOS Table Specification v3.0.0.
>
> Copyright (c) 2006 - 2015, Intel Corporation. All rights
> reserved.<BR>
> -(C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> +(C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>
> This program and the accompanying materials are licensed and made
> available under the terms and conditions of the BSD License that accompanies this distribution.
> The full text of the license may be found at @@ -97,6 +97,7 @@
> WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> #define SMBIOS_TYPE_ADDITIONAL_INFORMATION 40
> #define SMBIOS_TYPE_ONBOARD_DEVICES_EXTENDED_INFORMATION 41 #define
> SMBIOS_TYPE_MANAGEMENT_CONTROLLER_HOST_INTERFACE 42
> +#define SMBIOS_TYPE_TPM_DEVICE 43
>
> ///
> /// Inactive type is added from SMBIOS 2.2. Reference SMBIOS 2.6, chapter 3.3.43.
> @@ -2359,6 +2360,21 @@ typedef struct { } SMBIOS_TABLE_TYPE42;
>
> ///
> +/// TPM Device (Type 43).
> +///
> +typedef struct {
> + SMBIOS_STRUCTURE Hdr;
> + UINT8 VendorID[4];
> + UINT8 MajorSpecVersion;
> + UINT8 MinorSpecVersion;
> + UINT32 FirmwareVersion1;
> + UINT32 FirmwareVersion2;
> + UINT8 Description;
It is better to use "SMBIOS_TABLE_STRING Description" instead of "UINT8 Description".
If you agree that, you can have my Reviewed-by: Star Zeng <star.zeng@intel.com>.
And you do not need to resend the patch, I will help push the patch with the line fixed if no others' comments.
Thanks,
Star
> + UINT64 Characteristics;
> + UINT32 OemDefined;
> +} SMBIOS_TABLE_TYPE43;
> +
> +///
> /// Inactive (Type 126)
> ///
> typedef struct {
> @@ -2420,6 +2436,7 @@ typedef union {
> SMBIOS_TABLE_TYPE40 *Type40;
> SMBIOS_TABLE_TYPE41 *Type41;
> SMBIOS_TABLE_TYPE42 *Type42;
> + SMBIOS_TABLE_TYPE43 *Type43;
> SMBIOS_TABLE_TYPE126 *Type126;
> SMBIOS_TABLE_TYPE127 *Type127;
> UINT8 *Raw;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-12 1:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-11 9:10 [PATCH v2 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43 Linson Augustine
2017-01-11 9:23 ` Zeng, Star
2017-01-11 9:35 ` Augustine, Linson P
2017-01-12 1:33 ` Zeng, Star
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox