From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0719.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe48::719]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 97F1B81B5C for ; Wed, 11 Jan 2017 01:35:36 -0800 (PST) Received: from DF4PR84MB0236.NAMPRD84.PROD.OUTLOOK.COM (10.162.193.153) by DF4PR84MB0233.NAMPRD84.PROD.OUTLOOK.COM (10.162.193.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.829.7; Wed, 11 Jan 2017 09:35:35 +0000 Received: from DF4PR84MB0236.NAMPRD84.PROD.OUTLOOK.COM ([10.162.193.153]) by DF4PR84MB0236.NAMPRD84.PROD.OUTLOOK.COM ([10.162.193.153]) with mapi id 15.01.0829.017; Wed, 11 Jan 2017 09:35:35 +0000 From: "Augustine, Linson P" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "jaben.carsey@intel.com" , "ruiyu.ni@intel.com" , "michael.d.kinney@intel.com" , "liming.gao@intel.com" Thread-Topic: [edk2] [PATCH v2 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43 Thread-Index: AQHSa+qXchCcSMFyK0aEXi/1FST4NqEzAN6AgAADJaA= Date: Wed, 11 Jan 2017 09:35:35 +0000 Message-ID: References: <20170111091014.9832-1-linson.augustine@hpe.com> <256aa7ac-bd7f-ed7a-507b-c09dcdd50425@intel.com> In-Reply-To: <256aa7ac-bd7f-ed7a-507b-c09dcdd50425@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=linson.augustine@hpe.com; x-originating-ip: [15.219.195.4] x-ms-office365-filtering-correlation-id: f5bf8df7-96ff-4ca4-c103-08d43a05321c x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DF4PR84MB0233; x-microsoft-exchange-diagnostics: 1; DF4PR84MB0233; 7:wnkoGsibjHQDmQcXMcv//b8grzEteMTxGO0iVYVJ+K4jPXITVzEZ+Vww23hamT4HNUOo1mUXaCKGuljwyZUNUe0KFCZSqD+sWGSAmXzt+N9NVBi5EoJ92afWnDOv4bpnzYBxAA1dHO6jusVhyU3FU586klcLwY7LR7tsVnem0A/zfdgkQ8XSKJ5kF5rt8+bURgPQNbRfKRDpChnNOTYbXC6cqrLx3xkxNxA2kp2k4780HnlzHSsKzYKxIwtC+FHIrwERpw/HVJ4qPrjS4IVl3jRmPwt3ttk/z+cvY5W9dJBrqPl+E08Tpmuryei1Uzyvm7rpbUdZ/LpJZ9isQDy+E+bnGmUlqDqxVjj74SWiNY0nVYWG++Df2SkpOUxd8XjI7ubwqwPPV9nOSIbCpNT7fbdbFlaEqvl4kC8+hcyNFBQHc/06dTXRW3Ptf7YqQBaV8yNPyvGc805nRWy7uhzbQw== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148); SRVR:DF4PR84MB0233; BCL:0; PCL:0; RULEID:; SRVR:DF4PR84MB0233; x-forefront-prvs: 01842C458A x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6029001)(6009001)(7916002)(39410400002)(39860400002)(39840400002)(39450400003)(39850400002)(53474002)(189002)(24454002)(199003)(13464003)(377454003)(55016002)(2501003)(6506006)(6436002)(2900100001)(2906002)(68736007)(5001770100001)(97736004)(38730400001)(189998001)(77096006)(229853002)(3846002)(33656002)(102836003)(6116002)(92566002)(54906002)(3280700002)(3660700001)(4326007)(54356999)(76176999)(50986999)(9686003)(101416001)(5660300001)(8676002)(105586002)(74316002)(106356001)(86362001)(106116001)(7696004)(7736002)(66066001)(122556002)(8936002)(305945005)(2950100002)(81166006)(81156014); DIR:OUT; SFP:1102; SCL:1; SRVR:DF4PR84MB0233; H:DF4PR84MB0236.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2017 09:35:35.4744 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR84MB0233 Subject: Re: [PATCH v2 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 09:35:36 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Star, I agree with this. Please help me to push this patch. Regards, Linson. -----Original Message----- From: Zeng, Star [mailto:star.zeng@intel.com]=20 Sent: Wednesday, January 11, 2017 2:53 PM To: Augustine, Linson P ; edk2-devel@lists.01.org Cc: jaben.carsey@intel.com; ruiyu.ni@intel.com; michael.d.kinney@intel.com;= liming.gao@intel.com; star.zeng@intel.com Subject: Re: [edk2] [PATCH v2 1/1] MdePkg/SmBios.h: Add new defines for SMB= IOS record type 43 Linson, Add minor comments inline. On 2017/1/11 17:10, Linson Augustine wrote: > Added definitions for the new SMBIOS Type 43 record. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Augustine Linson P > --- > MdePkg/Include/IndustryStandard/SmBios.h | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h=20 > b/MdePkg/Include/IndustryStandard/SmBios.h > index c66422fc3a..debc85af6e 100644 > --- a/MdePkg/Include/IndustryStandard/SmBios.h > +++ b/MdePkg/Include/IndustryStandard/SmBios.h > @@ -2,7 +2,7 @@ > Industry Standard Definitions of SMBIOS Table Specification v3.0.0. > > Copyright (c) 2006 - 2015, Intel Corporation. All rights=20 > reserved.
> -(C) Copyright 2015 Hewlett Packard Enterprise Development LP
> +(C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP
> This program and the accompanying materials are licensed and made=20 > available under the terms and conditions of the BSD License that accompa= nies this distribution. > The full text of the license may be found at @@ -97,6 +97,7 @@=20 > WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPL= IED. > #define SMBIOS_TYPE_ADDITIONAL_INFORMATION 40 > #define SMBIOS_TYPE_ONBOARD_DEVICES_EXTENDED_INFORMATION 41 #define=20 > SMBIOS_TYPE_MANAGEMENT_CONTROLLER_HOST_INTERFACE 42 > +#define SMBIOS_TYPE_TPM_DEVICE 43 > > /// > /// Inactive type is added from SMBIOS 2.2. Reference SMBIOS 2.6, chapte= r 3.3.43. > @@ -2359,6 +2360,21 @@ typedef struct { } SMBIOS_TABLE_TYPE42; > > /// > +/// TPM Device (Type 43). > +/// > +typedef struct { > + SMBIOS_STRUCTURE Hdr; > + UINT8 VendorID[4]; > + UINT8 MajorSpecVersion; > + UINT8 MinorSpecVersion; > + UINT32 FirmwareVersion1; > + UINT32 FirmwareVersion2; > + UINT8 Description; It is better to use "SMBIOS_TABLE_STRING Description" instead of "UINT8 Des= cription". If you agree that, you can have my Reviewed-by: Star Zeng . And you do not need to resend the patch, I will help push the patch with th= e line fixed if no others' comments. Thanks, Star > + UINT64 Characteristics; > + UINT32 OemDefined; > +} SMBIOS_TABLE_TYPE43; > + > +/// > /// Inactive (Type 126) > /// > typedef struct { > @@ -2420,6 +2436,7 @@ typedef union { > SMBIOS_TABLE_TYPE40 *Type40; > SMBIOS_TABLE_TYPE41 *Type41; > SMBIOS_TABLE_TYPE42 *Type42; > + SMBIOS_TABLE_TYPE43 *Type43; > SMBIOS_TABLE_TYPE126 *Type126; > SMBIOS_TABLE_TYPE127 *Type127; > UINT8 *Raw; >