Re: [PATCH v1 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43

["Augustine, Linson P" <linson.augustine@hpe.com>]

Hi Star,
 Suggested changes for the commit message is done.

Regards,
Linson

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Augustine, Linson P
Sent: Monday, January 09, 2017 3:00 PM
To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
Cc: michael.d.kinney@intel.com; liming.gao@intel.com
Subject: Re: [edk2] [PATCH v1 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43

Thank you Star for the review. I will change the commit the message.

I don't have plans for the other definitions.

Regards,
Linson

-----Original Message-----
From: Zeng, Star [mailto:star.zeng@intel.com]
Sent: Monday, January 09, 2017 2:49 PM
To: Augustine, Linson P <linson.augustine@hpe.com>; edk2-devel@lists.01.org
Cc: michael.d.kinney@intel.com; liming.gao@intel.com; star.zeng@intel.com
Subject: Re: [edk2] [PATCH v1 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43

Hi Linson,

On 2017/1/9 16:58, Linson Augustine wrote:
> Added defintions for the new SMBIOS Type 43 record.

Typo "defintions" should be "definitions".

I noticed that the new type 43 is added in new SMBIOS spec 3.1.0, but there are also other definitions and structure fields added in new SMBIOS spec 3.1.0, will you plan to add them too?

Thanks,
Star

>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Augustine Linson P <linson.augustine@hpe.com>
> ---
>  MdePkg/Include/IndustryStandard/SmBios.h | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index c66422fc3a..debc85af6e 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -2,7 +2,7 @@
>    Industry Standard Definitions of SMBIOS Table Specification v3.0.0.
>
>  Copyright (c) 2006 - 2015, Intel Corporation. All rights 
> reserved.<BR>
> -(C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> +(C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>
>  This program and the accompanying materials are licensed and made 
> available under  the terms and conditions of the BSD License that accompanies this distribution.
>  The full text of the license may be found at @@ -97,6 +97,7 @@ 
> WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>  #define SMBIOS_TYPE_ADDITIONAL_INFORMATION               40
>  #define SMBIOS_TYPE_ONBOARD_DEVICES_EXTENDED_INFORMATION 41  #define 
> SMBIOS_TYPE_MANAGEMENT_CONTROLLER_HOST_INTERFACE 42
> +#define SMBIOS_TYPE_TPM_DEVICE                           43
>
>  ///
>  /// Inactive type is added from SMBIOS 2.2. Reference SMBIOS 2.6, chapter 3.3.43.
> @@ -2359,6 +2360,21 @@ typedef struct {  } SMBIOS_TABLE_TYPE42;
>
>  ///
> +/// TPM Device (Type 43).
> +///
> +typedef struct {
> +  SMBIOS_STRUCTURE                  Hdr;
> +  UINT8                             VendorID[4];
> +  UINT8                             MajorSpecVersion;
> +  UINT8                             MinorSpecVersion;
> +  UINT32                            FirmwareVersion1;
> +  UINT32                            FirmwareVersion2;
> +  UINT8                             Description;
> +  UINT64                            Characteristics;
> +  UINT32                            OemDefined;
> +} SMBIOS_TABLE_TYPE43;
> +
> +///
>  /// Inactive (Type 126)
>  ///
>  typedef struct {
> @@ -2420,6 +2436,7 @@ typedef union {
>    SMBIOS_TABLE_TYPE40   *Type40;
>    SMBIOS_TABLE_TYPE41   *Type41;
>    SMBIOS_TABLE_TYPE42   *Type42;
> +  SMBIOS_TABLE_TYPE43   *Type43;
>    SMBIOS_TABLE_TYPE126  *Type126;
>    SMBIOS_TABLE_TYPE127  *Type127;
>    UINT8                 *Raw;
>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel