Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP

["Heng Luo" <heng.luo@intel.com>]

Hi Liming & Mike,
Could you please help to merge PR https://github.com/tianocore/edk2/pull/5075 ?

Thanks,
Heng

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heng Luo
> Sent: Tuesday, January 9, 2024 11:17 AM
> To: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io;
> Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary
> <zachary.clark-williams@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if
> not connect to AP
> 
> HI Liming,
> All checks have passed in https://github.com/tianocore/edk2/pull/5075. What
> do I need to do?
> 
> Thanks,
> Heng
> 
> > -----Original Message-----
> > From: Luo, Heng
> > Sent: Wednesday, January 3, 2024 1:55 PM
> > To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io;
> > Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary
> > <Zachary.Clark-williams@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: RE: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan
> > only if not connect to AP
> >
> > Thank Liming, here is the PR:
> > https://github.com/tianocore/edk2/pull/5075
> >
> > Thanks,
> > Heng
> >
> > > -----Original Message-----
> > > From: gaoliming <gaoliming@byosoft.com.cn>
> > > Sent: Wednesday, January 3, 2024 8:55 AM
> > > To: devel@edk2.groups.io; Luo, Heng <heng.luo@intel.com>; Kasbekar,
> > > Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary
> > > <zachary.clark- williams@intel.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>
> > > Subject: 回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly
> > > scan only if not connect to AP
> > >
> > > Heng:
> > >   Can you help create pull request for this patch? Once it pass CI,
> > > I will merge it.
> > >
> > > Thanks
> > > Liming
> > > > -----邮件原件-----
> > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Heng Luo
> > > > 发送时间: 2024年1月2日 16:55
> > > > 收件人: Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams,
> > > > Zachary <zachary.clark-williams@intel.com>; devel@edk2.groups.io;
> > > > Kinney, Michael D <michael.d.kinney@intel.com>
> > > > 主题: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan
> > > > only
> > > if
> > > > not connect to AP
> > > >
> > > > Hi Mike,
> > > > Would you like to help us merge the patch?
> > > >
> > > > Thanks,
> > > > Heng
> > > >
> > > > > -----Original Message-----
> > > > > From: Kasbekar, Saloni <saloni.kasbekar@intel.com>
> > > > > Sent: Friday, December 15, 2023 4:36 AM
> > > > > To: Luo, Heng <heng.luo@intel.com>; Clark-williams, Zachary
> > > > <zachary.clark-
> > > > > williams@intel.com>; devel@edk2.groups.io; Kinney, Michael D
> > > > > <michael.d.kinney@intel.com>
> > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only
> > > > > if not
> > > > connect
> > > > > to AP
> > > > >
> > > > > Mike,
> > > > >
> > > > > Would you be able to help us merge the patch?
> > > > >
> > > > > Thanks,
> > > > > Saloni
> > > > >
> > > > > -----Original Message-----
> > > > > From: Luo, Heng <heng.luo@intel.com>
> > > > > Sent: Thursday, December 14, 2023 3:20 AM
> > > > > To: Clark-williams, Zachary <zachary.clark-williams@intel.com>;
> > > Kasbekar,
> > > > > Saloni <saloni.kasbekar@intel.com>; devel@edk2.groups.io
> > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only
> > > > > if not
> > > > connect
> > > > > to AP
> > > > >
> > > > > Hi Saloni,
> > > > > Could you help to merge the patch?
> > > > >
> > > > > Thanks,
> > > > > Heng
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Luo, Heng
> > > > > > Sent: Monday, December 11, 2023 4:13 PM
> > > > > > To: Clark-williams, Zachary
> > > > > > <Zachary.Clark-williams@intel.com>;
> > > > > > Kasbekar, Saloni <saloni.kasbekar@intel.com>;
> > > > > > devel@edk2.groups.io
> > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only
> > > > > > if not connect to AP
> > > > > >
> > > > > > Hi Zack,
> > > > > > Could you please review the change?
> > > > > > Thanks,
> > > > > > Heng
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Kasbekar, Saloni <saloni.kasbekar@intel.com>
> > > > > > > Sent: Saturday, December 2, 2023 5:25 AM
> > > > > > > To: Luo, Heng <heng.luo@intel.com>; devel@edk2.groups.io
> > > > > > > Cc: Clark-williams, Zachary
> > > > > > > <zachary.clark-williams@intel.com>
> > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan
> > > > > > > only if not connect to AP
> > > > > > >
> > > > > > > Reviewed-by: Kasbekar, Saloni <saloni.kasbekar@intel.com>
> > > > > > >
> > > > > > > Thanks,
> > > > > > > Saloni
> > > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Luo, Heng <heng.luo@intel.com>
> > > > > > > Sent: Monday, November 27, 2023 7:07 PM
> > > > > > > To: devel@edk2.groups.io
> > > > > > > Cc: Kasbekar, Saloni <saloni.kasbekar@intel.com>;
> > > > > > > Clark-williams, Zachary <zachary.clark-williams@intel.com>
> > > > > > > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only
> > > > > > > if not connect to AP
> > > > > > >
> > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605
> > > > > > >
> > > > > > > When UEFI Wi-Fi is in BSS connected state, the platform is
> > > > > > > considered as a static and Wi-Fi roaming support is not needed.
> > > > > > > Wifi connection manager should not initiate Scan requests in
> > > > > > > this state affect BSS client connectivity and must be avoided.
> > > > > > > Triger regularly scan only if not connect to AP.
> > > > > > >
> > > > > > > Signed-off-by: Heng Luo <heng.luo@intel.com>
> > > > > > > Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
> > > > > > > Cc: Zachary Clark-williams
> > > > > > > <zachary.clark-williams@intel.com>
> > > > > > > ---
> > > > > > >
> NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > |
> > > > 4
> > > > > ++-
> > > > > > -
> > > > > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > > > >
> > > > > > > diff --git
> > > > > > >
> > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > > > > > >
> > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > > > > > > index d1182e52bd..4c5460b65c 100644
> > > > > > > ---
> > > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > > > > > > +++
> > > > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > > > > > > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick (
> > > > > > >    }    Nic->ScanTickTime++;-  if (((Nic->ScanTickTime >
> > > > > > > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&-
> > > > (Nic-
> > > > > > > >ScanState == WifiMgrScanFinished))+  if
> > > > > > > >((((Nic->ScanTickTime
> > > > > > > >>
> > > > > > > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState !=
> > > > > > WifiMgrConnectedToAp))
> > > > > > > ||+       Nic->OneTimeScanRequest) && (Nic->ScanState ==
> > > > > > > WifiMgrScanFinished))   {     Nic->OneTimeScanRequest = FALSE;
> > > > Nic-
> > > > > > > >ScanTickTime       = 0;--
> > > > > > > 2.31.1.windows.1
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113788): https://edk2.groups.io/g/devel/message/113788
Mute This Topic: https://groups.io/mt/103497585/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-