From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 699187803CE for ; Mon, 4 Mar 2024 01:53:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=8PtnRIE7LxGFmfDIwFzZoP5tFUMgJYHcco+zlDgjvaE=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709517197; v=1; b=jMdZgu+ljWW+rXsGw2Yklv4tdzHUHfLzhnUVg6iCL9Q8nqNX3otlqukXLaQMzcgo0puYbFPx mn1Ez59uqBBVQgAQ0nehClO87uz6PztX1sd2waznN4/UUK5aEAsBwsqq//AL9pKdxSK9AEf7Qt8 UQum5uwD7LBkgxck6JKhOCsk= X-Received: by 127.0.0.2 with SMTP id dzkDYY7687511xwa385p34LW; Sun, 03 Mar 2024 17:53:17 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.41]) by mx.groups.io with SMTP id smtpd.web11.88700.1709517197073644862 for ; Sun, 03 Mar 2024 17:53:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lsELt/FAiToqa4GcSiuJodSVLgtDPYyUSYs0/lkdvsv8HtvBmQOuuoBPC4tHRlBRVA/c5IOd23cwJQCFH/hw2gqyWMCQSI6kFNhUMaTS5FcBvXl4vGEE8Aq5hl2qQS5WjEGIllTPlBrxQOgD+j4t4Ips5qdjiFK8jXwqQi9O3/n3yzfTcdrZlbfPdoO1fLxCYNpeT47SQ2HxQWlY/YuuRE0uUq0dzvjBqs2oL4skKa6vXLkjFM98ELZ51zHjzLCV0JkTffevbmSM55wHCo1TluBz8klHv34MzG+5pCU/iBl6wOci3NYUTtYSM+F4w69CDgmysADAqXxUVE7KnzBEXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qBSb04l5Exu5stw4ysi29aUVwwEuG/jzTzg1XNNTpVI=; b=go8sjx4Dj/JMXjO+2MCFNfWg2RXFdswYFTVgWP7g/44Rhx1Y70fR7Wj2pzZMFb9tADeQhoHlkmM1c3W4bD/cDWwmyu92p4GeD5bhneKUdfeCVpjaqZYTtioaVXTyCajleaSw58U96w1cNq0fr0BhnewV6af1RCx2IE5g5o8V8FDvSQjHkjIkq/K9vWbxNbO+ruRI7DBnwMSIGoyYRPiFGuFEA/7ekVoqm4HTnWrQRRgLli20f4SH99iJpiNdpyHVXRB/uhbZntzUQQI5y9aDgFGjV3lJ9MP91lOQmKbJE8YloZgE/eeaVFvev7Eynd2IxpCY1b5MSGRnksEyRo1htg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from DM3PR12MB9433.namprd12.prod.outlook.com (2603:10b6:0:47::11) by PH0PR12MB7813.namprd12.prod.outlook.com (2603:10b6:510:286::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.38; Mon, 4 Mar 2024 01:53:11 +0000 X-Received: from DM3PR12MB9433.namprd12.prod.outlook.com ([fe80::943e:4534:7864:59ef]) by DM3PR12MB9433.namprd12.prod.outlook.com ([fe80::943e:4534:7864:59ef%4]) with mapi id 15.20.7339.035; Mon, 4 Mar 2024 01:53:11 +0000 From: "Chang, Abner via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 01/13] RedfishClientPkg/.github: do not run uncrustify to deleted file. Thread-Topic: [edk2-redfish-client][PATCH 01/13] RedfishClientPkg/.github: do not run uncrustify to deleted file. Thread-Index: AQHaauy/Y3pUal2peUC4nJ//WW97XbEm135Q Date: Mon, 4 Mar 2024 01:53:11 +0000 Message-ID: References: <20240229085258.111854-1-nicklew@nvidia.com> In-Reply-To: <20240229085258.111854-1-nicklew@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=5b418357-4604-482a-86e3-413ca6f731e4;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-03-04T01:52:53Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM3PR12MB9433:EE_|PH0PR12MB7813:EE_ x-ms-office365-filtering-correlation-id: 80fcca10-1b09-422d-061f-08dc3bedd8fa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: qlFTEFDRDRd4LRVErAxUWXWDaqCxhnM3CzaIY+jz2pmHahpyKJE/r6NgP0FL59c89/r/4y6UAnGW94KrAa/B/E1ay/mJlLprY8/Vn++V0Tx0stOPTvXHo7bzZcfWP7iHpEQT5Lx+hcxPolrD+A0p0vTO2vb/UElOwFv5Dqb5y22kG75oh7/bc2fyMoKO+y7oa4dSWHrhhUAKyOZYwCLodxRSe+DvNXLviodgFJxCKJleJYZa1wSwOt5vIhoC2mBkf9rCKB4Jg7pmzBmBM5UtBZ53816jy0n46D1ZeEk+Lb9EUfWGIFfWtmX1cwSyXNqL7HCdL5zc5zZZLQDgmO93nV3+RP48JAOz+/zZuOl19RhmOWq7N2hB+Qe0rsSJE+3PKqGRx07K0bJdyRj/PPJqyglCw4KOb0QrnNr2c6Ex0tJE6GZmWMoGg0guAxoDy7hUOaMifiuKcAlTmXfB1Ca3FgeJIFczMKQMT5eE4hyAKCDlpNZSxGHYcx0/v57S4QCdAe+JSAWvgyF2MLS4gw4JF5WSX1y//ZZYsvdQym5Rn3NYOwFsIA7Nw9h3VBxN0b7pivCupUINvAMtiVWTg4hhkvssVCMy5Lt52z8XsN4JrJOUS14FMspf7TySUAVT+iVVvNy3F4w8AWIutgPo3vvUP7Q4v3ZQCfEXzEFCcscTBsgfocExNidTByE4lWfrTyYlnVqm105kLrZs97kMKiHa9g== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?M70XcoXlgyZHkF6L8ksmz3JJjCmEPAzhZOBucb1ffPMEQat2cRprmmDWlRoo?= =?us-ascii?Q?Ru8tIZo1ko+iogWubvGdheS3k0OaRC31OU6KLZ6Ny7nxOWWCsjcON23y/ShK?= =?us-ascii?Q?4l3C+XC/Ih281AyEmN/O7hCdsZaoAEKVOP4l46NzVOkrjshJFzjhNKYYZdKb?= =?us-ascii?Q?X0wX6mmp8fcP4+qhmdzQVtHl+0d52OBz4qCSfrIPuC+Y63PsbDJFi60sBBSB?= =?us-ascii?Q?4pZcXU0dErt13x3NPgDh/LLl8gOCMKhDAEISOKH4bdYdFtFvYtTQbbyvE8vc?= =?us-ascii?Q?WQzhENgP3NdwILopxexy+DBk+MLJGB7At/GPQLtDSv2AYT1MyNbD4RhJOBai?= =?us-ascii?Q?g6QhtfVNgbFPxgWOOvBln94R3W/NZLJrstiImKqg1o+9AkZXluCb/3rcJaZu?= =?us-ascii?Q?RjWLa19v/ngqniO8rJBa2d3nQRFvkboCcEei3f4fk1r1mP1X0KSE4Rh9CoyF?= =?us-ascii?Q?jLX5Osak1wuEr6mqM6kgnzBc6M0N0X92e1DHwj7Htw3Bbx7XIwKj4ultxtnH?= =?us-ascii?Q?300g5y4udmhFx2tzt0e+4c00b5SAQXkvcr/xGH86AoMqjTiXZyg7nXEN1MNS?= =?us-ascii?Q?OWDQsXfg3ksE7hdxkRli8yE7QUf3HRJmlDQkUl4oKWKKH67u5R2IBsIqgWCr?= =?us-ascii?Q?rauqIDsSy3yIv8xRZ1gWPE8OCxyidP1PkLdild9FDGdtKxYHj0UbZDIXmnhv?= =?us-ascii?Q?vDbMVON5CmZ3UnjC1YEiPOQVXdstU/6H0n+bxisRlz5+D7KI5jiVX+AfK8Sd?= =?us-ascii?Q?LcntLRFIX6tp5lhY2TRlE6tue6H8Z0kBmlHsGASalgcMmE0r+YifzcqGeucc?= =?us-ascii?Q?7DYypOY7sP8Mu13cm80GFWFwLaGHtx7/TziMwF+IDoe5FJmc6hGCiXN1El4Y?= =?us-ascii?Q?p8ktksC3sUqTU6Ug/04MGAB+PwvQuGG8um7kYbWVGW659A1oFP1J2kBfEh2w?= =?us-ascii?Q?gum5cCLPNfLYjk/FxXYSnQ3s9eNDKqnjqoIfJ8Hae2kUHc/c02hCLv6UTZNA?= =?us-ascii?Q?5CBKzGk9VCcuWoMgIStMKLWkyBVy2mcuHfbMir/q/j7V4Xsso+oGoupHJY8g?= =?us-ascii?Q?pskQKSiGXp5/4HJ74rfba1p39BLgDJ0KV5hRv8RWF4Z61zMm1J6tz4khiwr5?= =?us-ascii?Q?FNTr9UeXJHO5eTEMCZkvsRNpgsyFbR/Uq5hWmcGW+vBibqlIphfWpEKFYIWI?= =?us-ascii?Q?U593XrGJuOEwf3Z413xa1Jn6G6XtpMl1M2e2r9P2SpTQjTsnbNimjg06hv4Y?= =?us-ascii?Q?kqMiGs8McTQfKEZCHmol4w8m+B7UqOQoZu9Y76jQ+hsfJ+F7LjJnDOCUCFx7?= =?us-ascii?Q?AJ4bUtsG/YJaQm2fzd3rjjRtU5iZhKYe7c0g7nm2WxH8bulsysF6I8JIxIeD?= =?us-ascii?Q?JTGI83/sAMY6u6GSR5n/+pcTRq5Sh7/emnhRVb8MzxM6wvSwBzCzjMuVFCC9?= =?us-ascii?Q?2YYIKyQcloj4yGc4jV+c4f1fwdDSGC1kHLkWZVJNuhoLP9jHPgZItyLBgJxg?= =?us-ascii?Q?NIwUHpxJJdE/uE/pgZHKLcPMqv800LqaxVakbUGm/xZmBrMCV0lNITXWDNMF?= =?us-ascii?Q?0i9S6iGXOL9+llDM47o=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM3PR12MB9433.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80fcca10-1b09-422d-061f-08dc3bedd8fa X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Mar 2024 01:53:11.2927 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mMzFGpw3CS+atYtCp0QUhcSTmH09g2X0R7pvGu7tq0XiV21oKz5UxbPI0VyAUS52wN2ODbXYtEdJni1JG56thA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7813 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: P8CA2KukngM1mJqwxo6kCARWx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=jMdZgu+l; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Thursday, February 29, 2024 4:53 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH 01/13] RedfishClientPkg/.github: do = not > run uncrustify to deleted file. > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Check to see if file exists or not before running uncrustify. > The file in change list may be a deleted file. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > --- > .github/workflows/uncrustify-check.sh | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/.github/workflows/uncrustify-check.sh > b/.github/workflows/uncrustify-check.sh > index 7c1765cff..e6cf00b1f 100755 > --- a/.github/workflows/uncrustify-check.sh > +++ b/.github/workflows/uncrustify-check.sh > @@ -1,6 +1,6 @@ > #!/bin/bash > # > -# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > +# Copyright (c) 2023-2024, NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -40,12 +40,17 @@ fi > > for file in $CHANGED_FILES > do > - echo "Uncrustify check file: $file" > - uncrustify -c $CONFIG_FILE -f $file --check > - if [ $? -ne 0 ] > + if [ -e "$file" ] > then > - echo "Uncrustify check failure on file: $file" > - FAILURE=3D1 > + echo "Uncrustify check file: $file" > + uncrustify -c $CONFIG_FILE -f $file --check > + if [ $? -ne 0 ] > + then > + echo "Uncrustify check failure on file: $file" > + FAILURE=3D1 > + fi > + else > + echo "File does not exist (deleted file?): $file" > fi > done > > -- > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116297): https://edk2.groups.io/g/devel/message/116297 Mute This Topic: https://groups.io/mt/104640215/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-