From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7B193AC0408 for ; Mon, 4 Mar 2024 02:04:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=5QI3Jd5pk3IF5TBx157KBdCDCRD/esP/T4XXAoWTcaU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709517840; v=1; b=RvN6FnTHGzGWKhrgpUQeQVroAdtYTGYppaDVGcJkfl0pV7XWUqeFBVKDv5RB0Iq0mlTKNMu6 1LqdQmlMscfN5PH9q5zzX5XNGqn+9aWRSqwW8wcYoSPsta7rnuWcGzUwpJpI6WDbYF9y1mT2Rxm z8f93sfrI1CPxeNzrZyU317Q= X-Received: by 127.0.0.2 with SMTP id CDGTYY7687511x6f3q7R8J0z; Sun, 03 Mar 2024 18:04:00 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.40]) by mx.groups.io with SMTP id smtpd.web11.88876.1709517839503205994 for ; Sun, 03 Mar 2024 18:03:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QMlmSNliLFRo6DVppytiDTCwQ4k7G7+PUXXYndLo54qF+ON0oYMtTAd3pWkdhhWmryguqUaOuFkaXtO6DN4EsL3eS2SxkUJEX14zO4zwNVVUUCm7NTQUEFiYMzYdR12YyWzuZi6nQsOP1RNam5mVv37QkBjRLTGsrEFiIIxfxbwJHyJrk1le+nFw0vIQ4lXRBLd9PepSgYpnU6YSutUvFmnmjt7OFzlaZ3JKgNWxjkVYdBeBVrX96IvoG3TDvvracaEUcvQud4xj2HynAHo1orT26DCWaXJ7WSKbdyt/3BaM8UG3TawJ4q3ROvbk2Leye6dVSBE6a5osOHL1waluPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3XTC2LkGZaX22jorO6+dJ1u2o+mvAau3iHwo5fkrM9o=; b=ghytAHIUPtuGnNZckprxuQXnOd1XUXC1VNxcxFFquaLfSBFAqVioypNZ+XI1WEEBEnpxJu3roumwpQcw+p0qD+WBAwRL9Zlx6clsCy/7fAdsIzmQMPI4l9wEKQ2aL+a7/yRTxQJa6inTlIhdNt7tWTkcWW9iLfXoagOgX87mr6uk6zeKxdn3RB1uxZBBHWxdt9OA2csyBiFAg6ll9QRVqVbUFowGSpiZs4a5LZ5NZcpPxzMtTmPW0V2f0a9LWYytWvFViQCd0Uifizhg+AUc3V7Na6+pcqkk8JejMnWnR8FDxZHsuHp8oRfl30VtK80JIEsla7NVpdOYlRJRbmzsaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from DM3PR12MB9433.namprd12.prod.outlook.com (2603:10b6:0:47::11) by SN7PR12MB8147.namprd12.prod.outlook.com (2603:10b6:806:32e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.38; Mon, 4 Mar 2024 02:03:56 +0000 X-Received: from DM3PR12MB9433.namprd12.prod.outlook.com ([fe80::943e:4534:7864:59ef]) by DM3PR12MB9433.namprd12.prod.outlook.com ([fe80::943e:4534:7864:59ef%4]) with mapi id 15.20.7339.035; Mon, 4 Mar 2024 02:03:56 +0000 From: "Chang, Abner via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol Thread-Topic: [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol Thread-Index: AQHaauy7+C+0rB0i0EOIMS3Vr0/ca7Em2lEA Date: Mon, 4 Mar 2024 02:03:56 +0000 Message-ID: References: <20240229085248.111772-1-nicklew@nvidia.com> In-Reply-To: <20240229085248.111772-1-nicklew@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=2b7505f3-c74d-4961-9ebe-feeee029cb7d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-03-04T02:03:00Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM3PR12MB9433:EE_|SN7PR12MB8147:EE_ x-ms-office365-filtering-correlation-id: 29ec5b6f-9ad0-4ab0-530d-08dc3bef5999 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: kSNgt6IHbmUC5y6vGq+9nzxrU7ViRlUbQG3a4+6It5ubbcnwoK3INsyAg1lx5hUwD/PYMpMNm8jFgDj6CRFYQNzWvmg361JIVYzqmOVsLbuYLX5i6q1H6sgUmS7jYDTdXhqeiklkL7R141YUhAAa/3H6hJ3/R/giSlslAt2ta4CdRvJSiVID/YjyEL+4BV+hXRoDlbjngOqUHDrrkyHZ08sM9237QW53kNMd0MhlPguwpRc1Efkgo8KJr4Ps8ODLUYkkG8/Lntdi7T5U3C9fDelGgaxrwV1a1qAERihFFPXjhig65ANglIjlcY494aRCf6fLW5PcDO7523sxHUhpNKe0x09ZhSxQENq9e7jFcN1V20wK/l8a1zXiKaFR2aU05wZ3CLgjIymekyXYTccY8GUB48ZBLAISk8Q7jQA+gfdL7o7nVx1iYpvd3gTpFua6TCYTRmJg+fXGsovmirquLCB/CZhiTZoHfqo9hkJslen4HRK/zrVQsSXpXaJ9Zv3O90UTxrscoN2KqyMhfUSVprcHEQuOhtgCRLYMvDN71B0wqE1vbbyzIWmktpb/+11/RnhwF/XDkHmUqec7UiH7A0CBpeWhoF/NkULJ5IXeLpaH0zn0I3NRFB6KwO1vDHhoR/REIKfbcw3kydKw0J9zVSrp7u0nwh1tzg3YASS/6E0= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TeZjVDiOQTTKDpDlyJlzkpilwW+g9Vx5jxSTq1iWjRYLqXjx2vS52O8lbdVq?= =?us-ascii?Q?NK3W6iTTQV32PpfWCkPOl3PgI0Z5dMjELGusqp0kICHc+0ltESaGmhyDYm9S?= =?us-ascii?Q?YZyDqKTaTzoPijHEPcTEC0xaEFalMgWdHI081g3M4HXVPCZybtNAHdIyF5XE?= =?us-ascii?Q?bmWaOerpUfj86y6W7Ln9HQM/HB4q/f+xFwIhwD/axw6JtoL8e2Lecq00/I9A?= =?us-ascii?Q?evDyvtNq18CCQhc2an2GO2E73/XRLAydwMf6VpGCqhSL1nARx3ARVYhSUr67?= =?us-ascii?Q?L64vpLOMM3LkcXHBSF8gML2cX89vcMiR+SY4OEwRkUvrrytnh4LuLYlgG0Oh?= =?us-ascii?Q?9lUw0Z0M0LekeYBf+DjoRn6SMc5Kf1BRqJOLRVSpCPIjdMkURr1eozZkWNCP?= =?us-ascii?Q?4sEWv5kgGGens7KHVCjVXOpgEZFkca/702MXaR3ex5T3dYl9Q0TUvzL+hi80?= =?us-ascii?Q?6zJ0LrVj6lWR9E6Kr3VkoLs/SCLfusnaw6LeUYhn9r2WLICUAJS+qebjYta5?= =?us-ascii?Q?UFOcy4RE3d8T+3K+vpGaYGmg+dlYjT1BMQfZBCySHFSVpcN/32d3hxw1ffpp?= =?us-ascii?Q?7glHcP6U7TQbJ52sUuDC2vss1ayF+cHDw3T8pvWV8hW5FhftUMnapib/asXx?= =?us-ascii?Q?a9kJ83s5VBowLrc5zs9QriA64lQhbZudyqZZ5oOt8Nkq5JqFVqYjmr67Q0wg?= =?us-ascii?Q?H/3uiZp9dQi4eJsJXFuzHN4IkZaSowh/hrKWo5HtOkcrSVats4RmppZWbJ3c?= =?us-ascii?Q?GZ8fBS3EF/v4LNkhq0OXsLXOcih1S4MmIUTP3Scy3rCRLqZ9vlgPa5RSI5g/?= =?us-ascii?Q?8sA+GFJUV0o9/isjAN7Cx4LR8q9n3eZaKZejJosiCLfauv0V832VNb/PCD1R?= =?us-ascii?Q?BWQw9XqI8I1ZpMyg7XlixFRDf5XFgw67q7gFDdDpA8DqMAE3rTwkZ3BcLXAf?= =?us-ascii?Q?6V/8ogmTrFQbz03GhVakms4FxUKHBt7h284xsg6lKYxQHy1y9qyUQNo2obFe?= =?us-ascii?Q?n0RImVSFVnENXTmOH5P7rbXro+Mm04EcvE52nwo4/z2dGXN8S4U5XBn5Q7n5?= =?us-ascii?Q?FfmWWJCwOelE6l1bsmMGL4OWtH1+HXjKnSa4KpJvMoUobrxjPQjUt2EYxIg6?= =?us-ascii?Q?vB1ew9rBc4ZlCI0K7Eh8DKCgpe3wXQNlrLs9fZK3Y9gszEqj7/8W/3eCcnRE?= =?us-ascii?Q?/6TQJXG660PN+dyigKIFnLKv07jY5J10RFWrY0+nh+XbaaOo20CAER63DmMO?= =?us-ascii?Q?FYKxlwz1esTMNRRu+FguOiFDZzPa4D3U8ac21iHwdUKtYcDHFq47xdsoySZU?= =?us-ascii?Q?cceHtseRll6WpI/Agq9/W1PA0kFDaVgjwDEX7sjHiOTjVTBr1tVEM07LMcXr?= =?us-ascii?Q?BnwA0znhIiusAFfcz7idNpyXwyEqCH31yBBQuAJtRDPZz/6o9XaYqPqCHeyy?= =?us-ascii?Q?Pe2p0Yu/njCT9Njkyqe2tCWXgPMzOhiCWpJjVfNuNZxPE6tNH8VQFB7py5nD?= =?us-ascii?Q?Sh/LBcn9vyi/pfQoMWY6csuPgBiS6G3zuV2LC+uExlwyMJRRtNedPWD8eTmE?= =?us-ascii?Q?9KSrcT7ZlCI63R0hhOw=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM3PR12MB9433.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29ec5b6f-9ad0-4ab0-530d-08dc3bef5999 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Mar 2024 02:03:56.5987 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: p+RaEHlTj4emxVINeF5HjGiIvWN1NskMVtX5akEsMcRv5VmYKSH5Xufz9hd/E8lV6DkJhqaX/dmI8cXFZjL/8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8147 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: XlXm29lMMHyvNMSAaDv3DDC5x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=RvN6FnTH; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Went through each patch, no problem with entire series. Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Thursday, February 29, 2024 4:53 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update > RedfishClientPkg to use RedfishHttpLib. And remove the use of > RedfishHttpCacheLib. > > I also replace several functions from RedfishLib with the function > provided in RedfishHttpLib. In this way, there is no dependency on > RedfishLib in RedfishClientPkg. > > I noticed that there is false alarm in uncrustify check. When there > are deleted files, uncrustiry cannot check them and trigger uncrustify > failure. > > Pull request is created here for testing CI: > https://github.com/tianocore/edk2-redfish-client/pull/79 > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > > Nickle Wang (13): > RedfishClientPkg/.github: do not run uncrustify to deleted file. > RedfishClientPkg: remove RedfishHttpCacheLib > RedfishClientPkg: ues RedfishHttpLib > RedfishClientPkg/RedfishResourceConfigLib: ues RedfishHttpLib > RedfishClientPkg/RedfishFeatureUtilityLib: ues RedfishHttpLib > RedfishClientPkg/RedfishVersionLib: ues RedfishHttpLib > RedfishClientPkg/BiosDxe: ues RedfishHttpLib > RedfishClientPkg/BootOptionDxe: ues RedfishHttpLib > RedfishClientPkg/BootOptionCollectionDxe: ues RedfishHttpLib > RedfishClientPkg/ComputerSystemDxe: ues RedfishHttpLib > RedfishClientPkg/ComputerSystemCollectionDxe: ues RedfishHttpLib > RedfishClientPkg/MemoryDxe: ues RedfishHttpLib > RedfishClientPkg/MemoryCollectionDxe: ues RedfishHttpLib > > RedfishClientPkg/RedfishClientPkg.dec | 1 - > RedfishClientPkg/RedfishClientLibs.dsc.inc | 2 +- > RedfishClientPkg/RedfishClientPkg.dsc | 1 - > .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +- > .../BootOption/v1_0_4/Dxe/BootOptionDxe.inf | 5 +- > .../BootOptionCollectionDxe.inf | 5 +- > .../v1_13_0/Dxe/ComputerSystemDxe.inf | 3 +- > .../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +- > .../ComputerSystemCollectionDxe.inf | 3 +- > .../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +- > .../MemoryCollectionDxe.inf | 3 +- > .../EdkIIRedfishResourceConfigLib.inf | 2 +- > .../RedfishFeatureUtilityLib.inf | 3 +- > .../RedfishHttpCacheLib.inf | 48 -- > .../RedfishVersionLib/RedfishVersionLib.inf | 3 +- > .../Library/EdkIIRedfishResourceConfigLib.h | 4 +- > .../Library/RedfishFeatureUtilityLib.h | 46 +- > .../Include/Library/RedfishHttpCacheLib.h | 59 -- > .../Include/RedfishCollectionCommon.h | 3 +- > .../Include/RedfishResourceCommon.h | 3 +- > .../RedfishFeatureUtilityInternal.h | 3 +- > .../RedfishHttpCacheLibInternal.h | 63 -- > .../Features/Bios/v1_0_9/Common/BiosCommon.c | 92 +-- > .../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 113 +-- > .../v1_0_4/Common/BootOptionCommon.c | 45 +- > .../BootOption/v1_0_4/Dxe/BootOptionDxe.c | 86 +- > .../BootOptionCollectionDxe.c | 26 +- > .../v1_13_0/Common/ComputerSystemCommon.c | 68 +- > .../v1_13_0/Dxe/ComputerSystemDxe.c | 85 +- > .../v1_5_0/Common/ComputerSystemCommon.c | 68 +- > .../v1_5_0/Dxe/ComputerSystemDxe.c | 84 +- > .../ComputerSystemCollectionDxe.c | 15 +- > .../Memory/V1_7_1/Common/MemoryCommon.c | 86 +- > .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 111 +-- > .../MemoryCollectionDxe/MemoryCollectionDxe.c | 15 +- > .../EdkIIRedfishResourceConfigLib.c | 6 +- > .../RedfishFeatureUtilityLib.c | 182 +--- > .../RedfishHttpCacheLib/RedfishHttpCacheLib.c | 774 ------------------ > .../RedfishVersionLib/RedfishVersionLib.c | 24 +- > .github/workflows/uncrustify-check.sh | 17 +- > 40 files changed, 328 insertions(+), 1838 deletions(-) > delete mode 100644 > RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.inf > delete mode 100644 > RedfishClientPkg/Include/Library/RedfishHttpCacheLib.h > delete mode 100644 > RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLibInternal.= h > delete mode 100644 > RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.c > > -- > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116301): https://edk2.groups.io/g/devel/message/116301 Mute This Topic: https://groups.io/mt/104640214/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-