From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.12200.1678422641246413173 for ; Thu, 09 Mar 2023 20:30:41 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=huOp8+AU; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: darbin.reyes@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678422641; x=1709958641; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=cbCSAgN1TMOQMFogE0lQ7E4BQqvgeFKh4JuUcVWEmmE=; b=huOp8+AU4ez3YvPTH3M3L12KQ0Af3b+7w1HUdOEHRI9f/641Es/9xk+6 YxVCG6FhFmiNmBxXsca5PJBoMuAPSfR1XTO/E4vLkaeX5gXm7Axkh4Kxo L/ekEJ4l8+7WOfnp9MIGFjEK9Ym9XwJw+i+oY+TlTspXo2EXH96YGTKno mxvtJTufZRwmqBpRSCEEWdHaF+WG1SAXnCeiVHiJP8qF1SYuMVVZMKQhB HBsxkdJOSsau+ROUpB6s0Kh1PmaoHCzFNUHX6RkhyCP1OuWGYZuxQJc6G 8Tfn5zwdn2vFbI/1mgjgZq2H7Ad7mKynFQxKqF8RfYOQoRnaOuPxy2GSX A==; X-IronPort-AV: E=McAfee;i="6500,9779,10644"; a="334121442" X-IronPort-AV: E=Sophos;i="5.98,248,1673942400"; d="scan'208,217";a="334121442" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2023 20:30:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10644"; a="741820173" X-IronPort-AV: E=Sophos;i="5.98,248,1673942400"; d="scan'208,217";a="741820173" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 09 Mar 2023 20:30:40 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 9 Mar 2023 20:30:40 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 9 Mar 2023 20:30:39 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 9 Mar 2023 20:30:39 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Thu, 9 Mar 2023 20:30:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AJIw+uajhmx9Uy2U+Oqtfp89oG3e63MEb6duHC8FrBqq/o5WPe8gU4K4PxoKc0SlLXy95fu4hLmXeUBaQP+D2M+Nlypq4kNg8xrR5o9e4Th5GDDJYe2ePE9n7pzsGMrbREjCRh/EyRUJz2d7A22ykATfN5fHXKJ/aqToKzClW92RSj+vu6Ie58ZBFLWRl+8p1BVnT9/J5HAAhVjSVV0xCNBxRtPh79JPiHchwdy5uha7t8wNd3Zdj5mNqs2rzYREiUrce9UUtFUh7jFyrzloxjP/HJn3QXDPq1FcTinu+ZVjgwTsUxKvkylcaroW2yidKblyQkls51nXoJj9I1YVvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7jBXg19fwVw0HYE3xvrROiO7ZJ9gx9+ZhTkJZabt4Yc=; b=njKm5f9OmT0vgWkWaOHs15WY+/hN94TBylxP++N6EMnFf/um+uN3n7+duRJI9BtL3nE6+goWqehEMtyJm+Ky9CpvA3Vsbvod0r2uLhBXxlB1+7wyLk1dvwanURbz3gyrMHX/EkCBvh7YGoBIBTiViH/msFJfUrnv53ltDZfaVO7MjLUnoeJG1rrv3yKH7uDu1vRuulrlVH5ezGIbvnoRP/GVh/etCQnr62n6BuHSRYmVoemUoe9bBIOP54bp0CIkjPGOIB6sEu9edkbxiYQRntXqbUD7XGtfUp1g5EDMMwNbUvJXPkBeWd/9QIWsrW4WlrdpRnVCJm6Y9Yf65FIccg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5264.namprd11.prod.outlook.com (2603:10b6:5:38b::6) by CY5PR11MB6534.namprd11.prod.outlook.com (2603:10b6:930:42::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19; Fri, 10 Mar 2023 04:30:38 +0000 Received: from DM4PR11MB5264.namprd11.prod.outlook.com ([fe80::115:54b4:55f7:3269]) by DM4PR11MB5264.namprd11.prod.outlook.com ([fe80::115:54b4:55f7:3269%5]) with mapi id 15.20.6178.019; Fri, 10 Mar 2023 04:30:38 +0000 From: "Darbin Reyes" To: "devel@edk2.groups.io" , "Reyes, Darbin" , "Dong, Eric" , "Ni, Ray" , "Kumar, Rahul R" , "kraxel@redhat.com" CC: "Narey, Jacob" Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fix exception Thread-Topic: [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fix exception Thread-Index: AQHZUUpzWlo+3J8ma0GAn7mUOpxWmK7zaxmE Date: Fri, 10 Mar 2023 04:30:37 +0000 Message-ID: References: <174A4606FE58D79B.1912@groups.io> In-Reply-To: <174A4606FE58D79B.1912@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5264:EE_|CY5PR11MB6534:EE_ x-ms-office365-filtering-correlation-id: 52d59418-abc2-44e4-ec30-08db212032e5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RSaSrhVZ8+vuYU+kqB0+eSJwUreid5OJY41T1AX5T2btV/EwoUjPEc0Nvi4uJONWuq2oa6QEzBnaQbWGwQ99rYnBMozYqkzclRmRF1GE/rHOe6Ca9IzEeEoETl1J5BULhsaNWjLu8MMtjs31bQC8c9+Td00sbuCgGn+EFQEHj1oby0XEabOlvGx51IBSsAC72pChD7s4gZO1RUawHLJU066Zkrs4kqk2vmIASHH9hQzpZ2pbICg2QuTrdfdknmcNxy1KII/YyURe0ZSS1WZsdaN9GWXYM2n0nstGQ0kGBm/tdQRQgAmFrNBZBDcNLPo+I9ns30Lf4n74Cs5Aipx82/T6NoOADH21rd2h6MRGn4smTbMwyv2DrXm4ZbjsyTzq/6FIuDS9IgvT6mvL3J9PHyf9e9JGyAlPIEqHh9BJeYSWz/FRE9dN1ROvxWE7nUks2H110PPUorzDPBMPSJOhSUVnOQfCnDty26XLihSXhLPagJNGeRqOArPKcAB+b3RWArii6U36fwJoEFNKTBuc4jO9F4q5GiEt+Ss21BuKLGI6q2N+JIfSAri/VYCyeJX4httZaTFvrLPyGr8nKDgSWuM62KOW4cDMVi+FVHPK9HGVIwCVKJNTW6IeeUcXoWHWVgsUaaDhjos+uxITG+ALUctImtUlY/F7dTxLbrf6lfX8Y7nAYWNMovMBCguGB+sjmNydC4XDfPdC+KERlMcjK/sonBikRnXjbMYpCTLvOUxLiF0mNbLazd0rv6aT6kL1 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5264.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(376002)(136003)(366004)(39860400002)(396003)(451199018)(66899018)(19627405001)(110136005)(33656002)(55016003)(38100700002)(86362001)(921005)(38070700005)(82960400001)(6506007)(53546011)(26005)(83380400001)(9686003)(186003)(166002)(7696005)(316002)(5660300002)(71200400001)(52536014)(122000001)(478600001)(76116006)(966005)(41300700001)(4326008)(107886003)(66556008)(8936002)(64756008)(2906002)(66446008)(66476007)(8676002)(91956017)(66946007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+PhgfLvLwUXcZiCs17Nq/El4cY70blTTeenCg0ZpD0vCO6aaFsoKyb69Wr6x?= =?us-ascii?Q?GqpUy7UqWP606OhzV7y5llSUezUZQ4bYDzp80T4zg1ZPcdl108IxUFj2WbSt?= =?us-ascii?Q?GEPS6AZ3XzspMyS02HLAhbPCm6fM6An3Fp1AgOIJfEMMWq5NUHKgIoEQ49/Y?= =?us-ascii?Q?LoM+sRZAsLlUxkI5JtjzsEPfp04j9iUMEt8lOzd3xppk6OwY3DeJ+IWQyV5P?= =?us-ascii?Q?71R4BQhYmuuydhg8Wb0DFHwhjXlYCtuEF6H9S1U2UPZgCHo3/yK7XMqKESrU?= =?us-ascii?Q?AYL70JumUpyqAxs1gAYdSMV9C4B9kWXVPzNG0YQTDlHcoTwLPQtYskpgE1QI?= =?us-ascii?Q?rM1RftIkROuqTLkSoAXUKJfJYGeIfnF3zuJOcdKsULwFxQnilaQYR8DSDb8o?= =?us-ascii?Q?r+rC1jCipBYSKG4oTeZAlRPN6RcqoYopp/+x4Z9hf6DgrdeelCNCV6OpHdI+?= =?us-ascii?Q?iwdR17j/NfauSHmbolO2kdzZDxi1yIZ168XWxCRT045hdcMM1nGJIJlOdAcT?= =?us-ascii?Q?4XYQ4AoQ41lXIcnUbLjO5YcodLfNFpjJ7G+3NNWvSIpLfJGboh3zTgyTpt0O?= =?us-ascii?Q?D07OlFYs974X6GWJVj9nbjovJol7g4KzvEt1CO8u4aUGjD0508u7Mnpd/Weh?= =?us-ascii?Q?13VAVjH8JsH6bOWDCvAMI843riXB5VgOjSbGj0W48twjoGppCb2XMy1v/pC/?= =?us-ascii?Q?fPXzC5vsJfX1wo0o5Mv3RQCrYOdDzBS9NTJ4Lgh4S2cF/SZmtqpwAur3FGiO?= =?us-ascii?Q?ldeEC8BO03f54EV4jIqwqrfbSjmVFaTF1HY6m1pLRnDGRg7FtuBI2NFGhKAj?= =?us-ascii?Q?SohHxYhmvcLslZXQFtPJmU/9mDhtjYWwlmUJHga22QEQd576osWxUHJBi6B6?= =?us-ascii?Q?09CENxD0C+wiRI/fQP5h3xHrSTRTNcuyTxT1qEP0jGFc3E3f15ppiBslV6+V?= =?us-ascii?Q?l6md54cbpxSSx9Z+rqBowfFS3u11AbLawWTGb3i9W3oDDbtsfRGKrgnD809Q?= =?us-ascii?Q?1jPhUmuj7z1hirXe3PUhvaLPZbq6KM8Q8B3o26VFZyvcMw9fRqWOiyqWY08k?= =?us-ascii?Q?OoNbVdYnW1IO0kBqoLCEWkX+ULwswDzGUZxrC5WheYba/L79TLTjlJhKJrlz?= =?us-ascii?Q?HZH6deMV4Ag/ldiTOyCxRO7Y2AJeoLk07TwlacZB61pvhESE8Nzye6UpEm0E?= =?us-ascii?Q?iL9VEhPvQyoBGzXMGj8NMNL7kWoV2v26EbrgXxOZDBZDNf0un4P47uh5JARP?= =?us-ascii?Q?qDeRfv2KUWxobdVk3XBZxoNwFpamuGjFCM/QhJeiONeh/9h/vPmvrJMKW5TN?= =?us-ascii?Q?hQgnWM9ComU0QH290hO1eA4S+VcuKnCeeTf9qHKIaeaig95gJkUuJRyc5Wi8?= =?us-ascii?Q?2cMQpT3skn6NjszW/BiGsymkTeZnCisIqt5fJcaFg4g5hgFWMF7G1hCnYG5q?= =?us-ascii?Q?zGMDXtuhWWEVXPi+5mBtijkiNRZrCj+n7syUqdMPlXQ63YoceuzUCGHY/l3f?= =?us-ascii?Q?dvGsJuQuUfNRCbZcJtYKyVl2FZdK6b7G6TJuD1hNUBLC2BVKfRGpRHWh8P/J?= =?us-ascii?Q?WOS1m1kRz3yA93cQS4ekaNsK+6BAdBRdPn/NY4ji?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5264.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52d59418-abc2-44e4-ec30-08db212032e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Mar 2023 04:30:37.9500 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZgFFxZ4nFGko+TsDFjmBduLwJiShLZipbyGU79uwyhkyL+fLuVL1nEvHjsJFW12pXIWFsauSgNnjpRbs6tCzxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6534 Return-Path: darbin.reyes@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DM4PR11MB52641321242DC7395EA8FA3B8BBA9DM4PR11MB5264namp_" --_000_DM4PR11MB52641321242DC7395EA8FA3B8BBA9DM4PR11MB5264namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable + @UefiCpuPkg Maintainers Requesting an estimated ETA on integration of this 1 character patch. I understand the patch queue is huge, just looking to provide a realistic e= xpectation to those who are blocked by this and waiting for me to provide a= n update. Warm Regards, Darbin ________________________________ From: devel@edk2.groups.io on behalf of Darbin Reyes= Sent: Tuesday, March 7, 2023 3:04 PM To: devel@edk2.groups.io Cc: Reyes, Darbin ; Narey, Jacob Subject: [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fix excep= tion REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4360 An incorrect format specifier is being used in a DEBUG print, specifically, a variable of type EFI_STATUS was being printed with the %a format specifier (pointer to an ASCII string), thus the value of the Status variable was being treated as the address of a string, leading to a CPU exception, when encountered this bug manifests itself as a hang near "Ready to Boot Event", with the last DEBUG print being "INFO: Got MicrocodePatchHob with microcode patches starting address" followed by a CPU Exception dump. Signed-off-by: Darbin Reyes Reviewed-by: Jacob Narey --- UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c b= /UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c index 762ca159ff..5fd3b3365c 100644 --- a/UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c +++ b/UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c @@ -238,7 +238,7 @@ MeasureMicrocodePatches ( TotalMicrocodeSize) ); } else { - DEBUG ((DEBUG_ERROR, "ERROR: TpmMeasureAndLogData failed with status %= a!\n", Status)); + DEBUG ((DEBUG_ERROR, "ERROR: TpmMeasureAndLogData failed with status %= r!\n", Status)); } FreePool (Offsets); -- 2.38.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100818): https://edk2.groups.io/g/devel/message/100818 Mute This Topic: https://groups.io/mt/97461560/7511391 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [darbin.reyes@intel.com] -=3D-=3D-=3D-=3D-=3D-=3D --_000_DM4PR11MB52641321242DC7395EA8FA3B8BBA9DM4PR11MB5264namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
+ @UefiCpuPkg Maintainers

Requesting an estimated ETA on integration of this 1 character patch. =

I understand the patch queue is huge, just looking to provide a realistic e= xpectation to those who are blocked by this and waiting for me to provide a= n update.

Warm Regards,
Darbin
From: devel@edk2.groups.io = <devel@edk2.groups.io> on behalf of Darbin Reyes <darbin.reyes@int= el.com>
Sent: Tuesday, March 7, 2023 3:04 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Reyes, Darbin <darbin.reyes@intel.com>; Narey, Jacob <j= acob.narey@intel.com>
Subject: [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fi= x exception
 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4360

An incorrect format specifier is being used in a DEBUG print,
specifically, a variable of type EFI_STATUS was being printed with
the %a format specifier (pointer to an ASCII string), thus the value of
the Status variable was being treated as the address of a string,
leading to a CPU exception, when encountered this bug manifests itself
as a hang near "Ready to Boot Event", with the last DEBUG print b= eing
"INFO: Got MicrocodePatchHob with microcode patches starting address&q= uot;
followed by a CPU Exception dump.

Signed-off-by: Darbin Reyes <darbin.reyes@intel.com>
Reviewed-by: Jacob Narey <jacob.narey@intel.com>
---
 UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c | 2 +-  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c b= /UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c
index 762ca159ff..5fd3b3365c 100644
--- a/UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c
+++ b/UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c
@@ -238,7 +238,7 @@ MeasureMicrocodePatches (
        TotalMicrocodeSize)

       );

   } else {

-    DEBUG ((DEBUG_ERROR, "ERROR: TpmMeasureAndLogData = failed with status %a!\n", Status));

+    DEBUG ((DEBUG_ERROR, "ERROR: TpmMeasureAndLogData = failed with status %r!\n", Status));

   }

 

   FreePool (Offsets);

--
2.38.1.windows.1



-=3D-=3D-=3D-=3D-=3D-=3D
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100818): https://edk2.groups.io/g/devel/message/100818
Mute This Topic: https://= groups.io/mt/97461560/7511391
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.= groups.io/g/devel/unsub [darbin.reyes@intel.com]
-=3D-=3D-=3D-=3D-=3D-=3D


--_000_DM4PR11MB52641321242DC7395EA8FA3B8BBA9DM4PR11MB5264namp_--