From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC structure
Date: Thu, 9 Sep 2021 02:23:57 +0000 [thread overview]
Message-ID: <DM4PR11MB527722053213B846B7A70409F6D59@DM4PR11MB5277.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210824153013.30144-1-AbdulLateef.Attar@amd.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Thanks,
Zhichao
> -----Original Message-----
> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Sent: Tuesday, August 24, 2021 11:30 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
> Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Subject: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC structure
>
> Parse and print the below interrupt structures
> - I/O APIC Structure
> - Interrupt Source Override Structure
> - Processor Local x2APIC Structure
> - Local x2APIC NMI Structure
>
> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> ---
> .../Parsers/Madt/MadtParser.c | 99 +++++++++++++++++++
> 1 file changed, 99 insertions(+)
>
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars
> er.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars
> er.c
> index 15aa2392b6..2ba8c9ae52 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars
> er.c
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars
> +++ er.c
> @@ -181,6 +181,57 @@ STATIC CONST ACPI_PARSER GicITSParser[] = {
> {L"Reserved", 4, 16, L"0x%x", NULL, NULL, NULL, NULL} };
>
> +/**
> + An ACPI_PARSER array describing the IO APIC Structure.
> +**/
> +STATIC CONST ACPI_PARSER IoApic[] = {
> + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
> + {L"I/O APIC ID", 1, 2, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Reserved", 1, 3, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"I/O APIC Address", 4, 4, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Global System Interrupt Base", 4, 8, L"0x%x", NULL, NULL, NULL,
> +NULL} };
> +
> +/**
> + An ACPI_PARSER array describing the Interrupt Source Override Structure.
> +**/
> +STATIC CONST ACPI_PARSER InterruptSourceOverride[] = {
> + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
> + {L"Bus", 1, 2, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Source", 1, 3, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Global System Interrupt", 4, 4, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Flags", 2, 8, L"0x%x", NULL, NULL, NULL, NULL} };
> +
> +
> +/**
> + An ACPI_PARSER array describing the Processor Local x2APIC Structure.
> +**/
> +STATIC CONST ACPI_PARSER ProcessorLocalX2Apic[] = {
> + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
> + {L"Reserved", 2, 2, L"0x%x", NULL, NULL, NULL, NULL},
> +
> + {L"X2APIC ID", 4, 4, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Flags", 4, 8, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"ACPI Processor UID", 4, 12, L"0x%x", NULL, NULL, NULL, NULL} };
> +
> +/**
> + An ACPI_PARSER array describing the Local x2APIC NMI Structure.
> +**/
> +STATIC CONST ACPI_PARSER LocalX2ApicNmi[] = {
> + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
> + {L"Flags", 2, 2, L"0x%x", NULL, NULL, NULL, NULL},
> +
> + {L"ACPI Processor UID", 4, 4, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Local x2APIC LINT#", 1, 8, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Reserved", 3, 9, L"0x%x%x%x", Dump3Chars, NULL, NULL, NULL} };
> +
> /**
> An ACPI_PARSER array describing the ACPI MADT Table.
> **/
> @@ -357,6 +408,54 @@ ParseAcpiMadt (
> break;
> }
>
> + case EFI_ACPI_6_3_IO_APIC: {
> + ParseAcpi (
> + TRUE,
> + 2,
> + "IO APIC",
> + InterruptContollerPtr,
> + *MadtInterruptControllerLength,
> + PARSER_PARAMS (IoApic)
> + );
> + break;
> + }
> +
> + case EFI_ACPI_6_3_INTERRUPT_SOURCE_OVERRIDE: {
> + ParseAcpi (
> + TRUE,
> + 2,
> + "INTERRUPT SOURCE OVERRIDE",
> + InterruptContollerPtr,
> + *MadtInterruptControllerLength,
> + PARSER_PARAMS (InterruptSourceOverride)
> + );
> + break;
> + }
> +
> + case EFI_ACPI_6_3_PROCESSOR_LOCAL_X2APIC: {
> + ParseAcpi (
> + TRUE,
> + 2,
> + "PROCESSOR LOCAL X2APIC",
> + InterruptContollerPtr,
> + *MadtInterruptControllerLength,
> + PARSER_PARAMS (ProcessorLocalX2Apic)
> + );
> + break;
> + }
> +
> + case EFI_ACPI_6_3_LOCAL_X2APIC_NMI: {
> + ParseAcpi (
> + TRUE,
> + 2,
> + "LOCAL x2APIC NMI",
> + InterruptContollerPtr,
> + *MadtInterruptControllerLength,
> + PARSER_PARAMS (LocalX2ApicNmi)
> + );
> + break;
> + }
> +
> default: {
> IncrementErrorCount ();
> Print (
> --
> 2.25.1
next prev parent reply other threads:[~2021-09-09 2:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 15:30 [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC structure Abdul Lateef Attar
2021-09-09 2:23 ` Gao, Zhichao [this message]
2021-10-20 13:13 ` Attar, AbdulLateef (Abdul Lateef)
2021-10-21 5:36 ` Gao, Zhichao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB527722053213B846B7A70409F6D59@DM4PR11MB5277.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox