* [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC structure
@ 2021-08-24 15:30 Abdul Lateef Attar
2021-09-09 2:23 ` Gao, Zhichao
0 siblings, 1 reply; 4+ messages in thread
From: Abdul Lateef Attar @ 2021-08-24 15:30 UTC (permalink / raw)
To: devel; +Cc: ray.ni, zhichao.gao, Abdul Lateef Attar
Parse and print the below interrupt structures
- I/O APIC Structure
- Interrupt Source Override Structure
- Processor Local x2APIC Structure
- Local x2APIC NMI Structure
Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
---
.../Parsers/Madt/MadtParser.c | 99 +++++++++++++++++++
1 file changed, 99 insertions(+)
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c
index 15aa2392b6..2ba8c9ae52 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c
@@ -181,6 +181,57 @@ STATIC CONST ACPI_PARSER GicITSParser[] = {
{L"Reserved", 4, 16, L"0x%x", NULL, NULL, NULL, NULL}
};
+/**
+ An ACPI_PARSER array describing the IO APIC Structure.
+**/
+STATIC CONST ACPI_PARSER IoApic[] = {
+ {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
+ {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
+ {L"I/O APIC ID", 1, 2, L"0x%x", NULL, NULL, NULL, NULL},
+ {L"Reserved", 1, 3, L"0x%x", NULL, NULL, NULL, NULL},
+ {L"I/O APIC Address", 4, 4, L"0x%x", NULL, NULL, NULL, NULL},
+ {L"Global System Interrupt Base", 4, 8, L"0x%x", NULL, NULL, NULL, NULL}
+};
+
+/**
+ An ACPI_PARSER array describing the Interrupt Source Override Structure.
+**/
+STATIC CONST ACPI_PARSER InterruptSourceOverride[] = {
+ {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
+ {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
+ {L"Bus", 1, 2, L"0x%x", NULL, NULL, NULL, NULL},
+ {L"Source", 1, 3, L"0x%x", NULL, NULL, NULL, NULL},
+ {L"Global System Interrupt", 4, 4, L"0x%x", NULL, NULL, NULL, NULL},
+ {L"Flags", 2, 8, L"0x%x", NULL, NULL, NULL, NULL}
+};
+
+
+/**
+ An ACPI_PARSER array describing the Processor Local x2APIC Structure.
+**/
+STATIC CONST ACPI_PARSER ProcessorLocalX2Apic[] = {
+ {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
+ {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
+ {L"Reserved", 2, 2, L"0x%x", NULL, NULL, NULL, NULL},
+
+ {L"X2APIC ID", 4, 4, L"0x%x", NULL, NULL, NULL, NULL},
+ {L"Flags", 4, 8, L"0x%x", NULL, NULL, NULL, NULL},
+ {L"ACPI Processor UID", 4, 12, L"0x%x", NULL, NULL, NULL, NULL}
+};
+
+/**
+ An ACPI_PARSER array describing the Local x2APIC NMI Structure.
+**/
+STATIC CONST ACPI_PARSER LocalX2ApicNmi[] = {
+ {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
+ {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
+ {L"Flags", 2, 2, L"0x%x", NULL, NULL, NULL, NULL},
+
+ {L"ACPI Processor UID", 4, 4, L"0x%x", NULL, NULL, NULL, NULL},
+ {L"Local x2APIC LINT#", 1, 8, L"0x%x", NULL, NULL, NULL, NULL},
+ {L"Reserved", 3, 9, L"0x%x%x%x", Dump3Chars, NULL, NULL, NULL}
+};
+
/**
An ACPI_PARSER array describing the ACPI MADT Table.
**/
@@ -357,6 +408,54 @@ ParseAcpiMadt (
break;
}
+ case EFI_ACPI_6_3_IO_APIC: {
+ ParseAcpi (
+ TRUE,
+ 2,
+ "IO APIC",
+ InterruptContollerPtr,
+ *MadtInterruptControllerLength,
+ PARSER_PARAMS (IoApic)
+ );
+ break;
+ }
+
+ case EFI_ACPI_6_3_INTERRUPT_SOURCE_OVERRIDE: {
+ ParseAcpi (
+ TRUE,
+ 2,
+ "INTERRUPT SOURCE OVERRIDE",
+ InterruptContollerPtr,
+ *MadtInterruptControllerLength,
+ PARSER_PARAMS (InterruptSourceOverride)
+ );
+ break;
+ }
+
+ case EFI_ACPI_6_3_PROCESSOR_LOCAL_X2APIC: {
+ ParseAcpi (
+ TRUE,
+ 2,
+ "PROCESSOR LOCAL X2APIC",
+ InterruptContollerPtr,
+ *MadtInterruptControllerLength,
+ PARSER_PARAMS (ProcessorLocalX2Apic)
+ );
+ break;
+ }
+
+ case EFI_ACPI_6_3_LOCAL_X2APIC_NMI: {
+ ParseAcpi (
+ TRUE,
+ 2,
+ "LOCAL x2APIC NMI",
+ InterruptContollerPtr,
+ *MadtInterruptControllerLength,
+ PARSER_PARAMS (LocalX2ApicNmi)
+ );
+ break;
+ }
+
default: {
IncrementErrorCount ();
Print (
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC structure
2021-08-24 15:30 [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC structure Abdul Lateef Attar
@ 2021-09-09 2:23 ` Gao, Zhichao
2021-10-20 13:13 ` Attar, AbdulLateef (Abdul Lateef)
0 siblings, 1 reply; 4+ messages in thread
From: Gao, Zhichao @ 2021-09-09 2:23 UTC (permalink / raw)
To: Abdul Lateef Attar, devel@edk2.groups.io; +Cc: Ni, Ray
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Thanks,
Zhichao
> -----Original Message-----
> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Sent: Tuesday, August 24, 2021 11:30 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
> Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Subject: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC structure
>
> Parse and print the below interrupt structures
> - I/O APIC Structure
> - Interrupt Source Override Structure
> - Processor Local x2APIC Structure
> - Local x2APIC NMI Structure
>
> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> ---
> .../Parsers/Madt/MadtParser.c | 99 +++++++++++++++++++
> 1 file changed, 99 insertions(+)
>
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars
> er.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars
> er.c
> index 15aa2392b6..2ba8c9ae52 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars
> er.c
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars
> +++ er.c
> @@ -181,6 +181,57 @@ STATIC CONST ACPI_PARSER GicITSParser[] = {
> {L"Reserved", 4, 16, L"0x%x", NULL, NULL, NULL, NULL} };
>
> +/**
> + An ACPI_PARSER array describing the IO APIC Structure.
> +**/
> +STATIC CONST ACPI_PARSER IoApic[] = {
> + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
> + {L"I/O APIC ID", 1, 2, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Reserved", 1, 3, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"I/O APIC Address", 4, 4, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Global System Interrupt Base", 4, 8, L"0x%x", NULL, NULL, NULL,
> +NULL} };
> +
> +/**
> + An ACPI_PARSER array describing the Interrupt Source Override Structure.
> +**/
> +STATIC CONST ACPI_PARSER InterruptSourceOverride[] = {
> + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
> + {L"Bus", 1, 2, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Source", 1, 3, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Global System Interrupt", 4, 4, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Flags", 2, 8, L"0x%x", NULL, NULL, NULL, NULL} };
> +
> +
> +/**
> + An ACPI_PARSER array describing the Processor Local x2APIC Structure.
> +**/
> +STATIC CONST ACPI_PARSER ProcessorLocalX2Apic[] = {
> + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
> + {L"Reserved", 2, 2, L"0x%x", NULL, NULL, NULL, NULL},
> +
> + {L"X2APIC ID", 4, 4, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Flags", 4, 8, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"ACPI Processor UID", 4, 12, L"0x%x", NULL, NULL, NULL, NULL} };
> +
> +/**
> + An ACPI_PARSER array describing the Local x2APIC NMI Structure.
> +**/
> +STATIC CONST ACPI_PARSER LocalX2ApicNmi[] = {
> + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
> + {L"Flags", 2, 2, L"0x%x", NULL, NULL, NULL, NULL},
> +
> + {L"ACPI Processor UID", 4, 4, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Local x2APIC LINT#", 1, 8, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Reserved", 3, 9, L"0x%x%x%x", Dump3Chars, NULL, NULL, NULL} };
> +
> /**
> An ACPI_PARSER array describing the ACPI MADT Table.
> **/
> @@ -357,6 +408,54 @@ ParseAcpiMadt (
> break;
> }
>
> + case EFI_ACPI_6_3_IO_APIC: {
> + ParseAcpi (
> + TRUE,
> + 2,
> + "IO APIC",
> + InterruptContollerPtr,
> + *MadtInterruptControllerLength,
> + PARSER_PARAMS (IoApic)
> + );
> + break;
> + }
> +
> + case EFI_ACPI_6_3_INTERRUPT_SOURCE_OVERRIDE: {
> + ParseAcpi (
> + TRUE,
> + 2,
> + "INTERRUPT SOURCE OVERRIDE",
> + InterruptContollerPtr,
> + *MadtInterruptControllerLength,
> + PARSER_PARAMS (InterruptSourceOverride)
> + );
> + break;
> + }
> +
> + case EFI_ACPI_6_3_PROCESSOR_LOCAL_X2APIC: {
> + ParseAcpi (
> + TRUE,
> + 2,
> + "PROCESSOR LOCAL X2APIC",
> + InterruptContollerPtr,
> + *MadtInterruptControllerLength,
> + PARSER_PARAMS (ProcessorLocalX2Apic)
> + );
> + break;
> + }
> +
> + case EFI_ACPI_6_3_LOCAL_X2APIC_NMI: {
> + ParseAcpi (
> + TRUE,
> + 2,
> + "LOCAL x2APIC NMI",
> + InterruptContollerPtr,
> + *MadtInterruptControllerLength,
> + PARSER_PARAMS (LocalX2ApicNmi)
> + );
> + break;
> + }
> +
> default: {
> IncrementErrorCount ();
> Print (
> --
> 2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC structure
2021-09-09 2:23 ` Gao, Zhichao
@ 2021-10-20 13:13 ` Attar, AbdulLateef (Abdul Lateef)
2021-10-21 5:36 ` Gao, Zhichao
0 siblings, 1 reply; 4+ messages in thread
From: Attar, AbdulLateef (Abdul Lateef) @ 2021-10-20 13:13 UTC (permalink / raw)
To: Gao, Zhichao, devel@edk2.groups.io; +Cc: Ni, Ray
[AMD Official Use Only]
Gentle reminder to merge the code.
-----Original Message-----
From: Gao, Zhichao <zhichao.gao@intel.com>
Sent: 09 September 2021 07:54
To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>
Subject: RE: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC structure
[CAUTION: External Email]
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Thanks,
Zhichao
> -----Original Message-----
> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Sent: Tuesday, August 24, 2021 11:30 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
> Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Subject: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC
> structure
>
> Parse and print the below interrupt structures
> - I/O APIC Structure
> - Interrupt Source Override Structure
> - Processor Local x2APIC Structure
> - Local x2APIC NMI Structure
>
> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> ---
> .../Parsers/Madt/MadtParser.c | 99 +++++++++++++++++++
> 1 file changed, 99 insertions(+)
>
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars
> er.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars
> er.c
> index 15aa2392b6..2ba8c9ae52 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars
> er.c
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars
> +++ er.c
> @@ -181,6 +181,57 @@ STATIC CONST ACPI_PARSER GicITSParser[] = {
> {L"Reserved", 4, 16, L"0x%x", NULL, NULL, NULL, NULL} };
>
> +/**
> + An ACPI_PARSER array describing the IO APIC Structure.
> +**/
> +STATIC CONST ACPI_PARSER IoApic[] = {
> + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
> + {L"I/O APIC ID", 1, 2, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Reserved", 1, 3, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"I/O APIC Address", 4, 4, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Global System Interrupt Base", 4, 8, L"0x%x", NULL, NULL, NULL,
> +NULL} };
> +
> +/**
> + An ACPI_PARSER array describing the Interrupt Source Override Structure.
> +**/
> +STATIC CONST ACPI_PARSER InterruptSourceOverride[] = {
> + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
> + {L"Bus", 1, 2, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Source", 1, 3, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Global System Interrupt", 4, 4, L"0x%x", NULL, NULL, NULL,
> +NULL},
> + {L"Flags", 2, 8, L"0x%x", NULL, NULL, NULL, NULL} };
> +
> +
> +/**
> + An ACPI_PARSER array describing the Processor Local x2APIC Structure.
> +**/
> +STATIC CONST ACPI_PARSER ProcessorLocalX2Apic[] = {
> + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
> + {L"Reserved", 2, 2, L"0x%x", NULL, NULL, NULL, NULL},
> +
> + {L"X2APIC ID", 4, 4, L"0x%x", NULL, NULL, NULL, NULL}, {L"Flags",
> + 4, 8, L"0x%x", NULL, NULL, NULL, NULL}, {L"ACPI Processor UID", 4,
> + 12, L"0x%x", NULL, NULL, NULL, NULL} };
> +
> +/**
> + An ACPI_PARSER array describing the Local x2APIC NMI Structure.
> +**/
> +STATIC CONST ACPI_PARSER LocalX2ApicNmi[] = {
> + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
> + {L"Flags", 2, 2, L"0x%x", NULL, NULL, NULL, NULL},
> +
> + {L"ACPI Processor UID", 4, 4, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Local x2APIC LINT#", 1, 8, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Reserved", 3, 9, L"0x%x%x%x", Dump3Chars, NULL, NULL, NULL} };
> +
> /**
> An ACPI_PARSER array describing the ACPI MADT Table.
> **/
> @@ -357,6 +408,54 @@ ParseAcpiMadt (
> break;
> }
>
> + case EFI_ACPI_6_3_IO_APIC: {
> + ParseAcpi (
> + TRUE,
> + 2,
> + "IO APIC",
> + InterruptContollerPtr,
> + *MadtInterruptControllerLength,
> + PARSER_PARAMS (IoApic)
> + );
> + break;
> + }
> +
> + case EFI_ACPI_6_3_INTERRUPT_SOURCE_OVERRIDE: {
> + ParseAcpi (
> + TRUE,
> + 2,
> + "INTERRUPT SOURCE OVERRIDE",
> + InterruptContollerPtr,
> + *MadtInterruptControllerLength,
> + PARSER_PARAMS (InterruptSourceOverride)
> + );
> + break;
> + }
> +
> + case EFI_ACPI_6_3_PROCESSOR_LOCAL_X2APIC: {
> + ParseAcpi (
> + TRUE,
> + 2,
> + "PROCESSOR LOCAL X2APIC",
> + InterruptContollerPtr,
> + *MadtInterruptControllerLength,
> + PARSER_PARAMS (ProcessorLocalX2Apic)
> + );
> + break;
> + }
> +
> + case EFI_ACPI_6_3_LOCAL_X2APIC_NMI: {
> + ParseAcpi (
> + TRUE,
> + 2,
> + "LOCAL x2APIC NMI",
> + InterruptContollerPtr,
> + *MadtInterruptControllerLength,
> + PARSER_PARAMS (LocalX2ApicNmi)
> + );
> + break;
> + }
> +
> default: {
> IncrementErrorCount ();
> Print (
> --
> 2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC structure
2021-10-20 13:13 ` Attar, AbdulLateef (Abdul Lateef)
@ 2021-10-21 5:36 ` Gao, Zhichao
0 siblings, 0 replies; 4+ messages in thread
From: Gao, Zhichao @ 2021-10-21 5:36 UTC (permalink / raw)
To: Attar, AbdulLateef (Abdul Lateef), devel@edk2.groups.io; +Cc: Ni, Ray
Sorry for the miss. PR create: https://github.com/tianocore/edk2/pull/2100
Thanks,
Zhichao
> -----Original Message-----
> From: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> Sent: Wednesday, October 20, 2021 9:14 PM
> To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>
> Subject: RE: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC
> structure
>
> [AMD Official Use Only]
>
> Gentle reminder to merge the code.
>
> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: 09 September 2021 07:54
> To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>;
> devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>
> Subject: RE: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC
> structure
>
> [CAUTION: External Email]
>
> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
>
> Thanks,
> Zhichao
>
> > -----Original Message-----
> > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> > Sent: Tuesday, August 24, 2021 11:30 PM
> > To: devel@edk2.groups.io
> > Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
> > Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> > Subject: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC
> > structure
> >
> > Parse and print the below interrupt structures
> > - I/O APIC Structure
> > - Interrupt Source Override Structure
> > - Processor Local x2APIC Structure
> > - Local x2APIC NMI Structure
> >
> > Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> > ---
> > .../Parsers/Madt/MadtParser.c | 99 +++++++++++++++++++
> > 1 file changed, 99 insertions(+)
> >
> > diff --git
> >
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars
> > er.c
> >
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars
> > er.c
> > index 15aa2392b6..2ba8c9ae52 100644
> > ---
> >
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars
> > er.c
> > +++
> >
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars
> > +++ er.c
> > @@ -181,6 +181,57 @@ STATIC CONST ACPI_PARSER GicITSParser[] = {
> > {L"Reserved", 4, 16, L"0x%x", NULL, NULL, NULL, NULL} };
> >
> > +/**
> > + An ACPI_PARSER array describing the IO APIC Structure.
> > +**/
> > +STATIC CONST ACPI_PARSER IoApic[] = {
> > + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
> > + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
> > + {L"I/O APIC ID", 1, 2, L"0x%x", NULL, NULL, NULL, NULL},
> > + {L"Reserved", 1, 3, L"0x%x", NULL, NULL, NULL, NULL},
> > + {L"I/O APIC Address", 4, 4, L"0x%x", NULL, NULL, NULL, NULL},
> > + {L"Global System Interrupt Base", 4, 8, L"0x%x", NULL, NULL, NULL,
> > +NULL} };
> > +
> > +/**
> > + An ACPI_PARSER array describing the Interrupt Source Override
> Structure.
> > +**/
> > +STATIC CONST ACPI_PARSER InterruptSourceOverride[] = {
> > + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
> > + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
> > + {L"Bus", 1, 2, L"0x%x", NULL, NULL, NULL, NULL},
> > + {L"Source", 1, 3, L"0x%x", NULL, NULL, NULL, NULL},
> > + {L"Global System Interrupt", 4, 4, L"0x%x", NULL, NULL, NULL,
> > +NULL},
> > + {L"Flags", 2, 8, L"0x%x", NULL, NULL, NULL, NULL} };
> > +
> > +
> > +/**
> > + An ACPI_PARSER array describing the Processor Local x2APIC Structure.
> > +**/
> > +STATIC CONST ACPI_PARSER ProcessorLocalX2Apic[] = {
> > + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
> > + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
> > + {L"Reserved", 2, 2, L"0x%x", NULL, NULL, NULL, NULL},
> > +
> > + {L"X2APIC ID", 4, 4, L"0x%x", NULL, NULL, NULL, NULL}, {L"Flags",
> > + 4, 8, L"0x%x", NULL, NULL, NULL, NULL}, {L"ACPI Processor UID", 4,
> > + 12, L"0x%x", NULL, NULL, NULL, NULL} };
> > +
> > +/**
> > + An ACPI_PARSER array describing the Local x2APIC NMI Structure.
> > +**/
> > +STATIC CONST ACPI_PARSER LocalX2ApicNmi[] = {
> > + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
> > + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL},
> > + {L"Flags", 2, 2, L"0x%x", NULL, NULL, NULL, NULL},
> > +
> > + {L"ACPI Processor UID", 4, 4, L"0x%x", NULL, NULL, NULL, NULL},
> > + {L"Local x2APIC LINT#", 1, 8, L"0x%x", NULL, NULL, NULL, NULL},
> > + {L"Reserved", 3, 9, L"0x%x%x%x", Dump3Chars, NULL, NULL, NULL} };
> > +
> > /**
> > An ACPI_PARSER array describing the ACPI MADT Table.
> > **/
> > @@ -357,6 +408,54 @@ ParseAcpiMadt (
> > break;
> > }
> >
> > + case EFI_ACPI_6_3_IO_APIC: {
> > + ParseAcpi (
> > + TRUE,
> > + 2,
> > + "IO APIC",
> > + InterruptContollerPtr,
> > + *MadtInterruptControllerLength,
> > + PARSER_PARAMS (IoApic)
> > + );
> > + break;
> > + }
> > +
> > + case EFI_ACPI_6_3_INTERRUPT_SOURCE_OVERRIDE: {
> > + ParseAcpi (
> > + TRUE,
> > + 2,
> > + "INTERRUPT SOURCE OVERRIDE",
> > + InterruptContollerPtr,
> > + *MadtInterruptControllerLength,
> > + PARSER_PARAMS (InterruptSourceOverride)
> > + );
> > + break;
> > + }
> > +
> > + case EFI_ACPI_6_3_PROCESSOR_LOCAL_X2APIC: {
> > + ParseAcpi (
> > + TRUE,
> > + 2,
> > + "PROCESSOR LOCAL X2APIC",
> > + InterruptContollerPtr,
> > + *MadtInterruptControllerLength,
> > + PARSER_PARAMS (ProcessorLocalX2Apic)
> > + );
> > + break;
> > + }
> > +
> > + case EFI_ACPI_6_3_LOCAL_X2APIC_NMI: {
> > + ParseAcpi (
> > + TRUE,
> > + 2,
> > + "LOCAL x2APIC NMI",
> > + InterruptContollerPtr,
> > + *MadtInterruptControllerLength,
> > + PARSER_PARAMS (LocalX2ApicNmi)
> > + );
> > + break;
> > + }
> > +
> > default: {
> > IncrementErrorCount ();
> > Print (
> > --
> > 2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-21 5:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-24 15:30 [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC structure Abdul Lateef Attar
2021-09-09 2:23 ` Gao, Zhichao
2021-10-20 13:13 ` Attar, AbdulLateef (Abdul Lateef)
2021-10-21 5:36 ` Gao, Zhichao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox