From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.5468.1634794584088528410 for ; Wed, 20 Oct 2021 22:36:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=LCVGzfDg; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: zhichao.gao@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10143"; a="228896243" X-IronPort-AV: E=Sophos;i="5.87,168,1631602800"; d="scan'208";a="228896243" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2021 22:36:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,168,1631602800"; d="scan'208";a="552480340" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga004.fm.intel.com with ESMTP; 20 Oct 2021 22:36:22 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 20 Oct 2021 22:36:22 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 20 Oct 2021 22:36:22 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 20 Oct 2021 22:36:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B9jWQh8sTpMZemGWXzJnrPgO5nCWOQ/y0eaenMJHFfWaxpyYanZ68xAKGchS7kvhtuTHzGqBpzUyqZ9bbF6npQkFfiAd3Fac6rqCGioPjuXYGAJueAYRYoBoreEqUTihVugkBZtc2JVAdER8Z5QcQivN4fT29BELQP8OG1++OC1/g39/fz8lt3uBD/MNmjyvMsfw15+YFg++dZwCsTG8KFxMrlNW98adLWBFgUkqP+Yi+SNi74MiKvUq8YeRyw408Hguf18/YDGvDRO0sCDNIeoaR0CrkcgxAezVm4Usld9oo6uDYBnhlJJHsTk5SLtQCXtP0rlBXcN0fa9OrWtV5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IYSI7H/oVCWT9X55AcyhmDtYZ8u8ahZxtcJCYa7zysc=; b=G3j3lnd+PZpIbxn9pFFhxkJHf/poYXiMWTpmHUXGkl1iHCHTtQkq2eCqPWAdaTnM0V8+V7uNAQn9t9rR9p6diTQoBBk4Au+ef21QanYYOl/mXj4cn3gus1/MoTuWVr2cwiT4xwiYTtsqsRcPQUOjYnovfkT8jne1IJ26+JGK1c2XW9SpzW2+aoQ0u09Y+upgrhCtZ0gYgVvMIs5qhAuD0oBH5DfpnudPQOxgDcPae2iZ55bozgOx4xJNkGmvC0DVDa19pyefS34hMNFvqh2dj5lXRC3EdE0INsgkQDBvphsRHTHr/t1x1eAxpKQwzzZlkJGkUdh6LiBYyTHUNQBAPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IYSI7H/oVCWT9X55AcyhmDtYZ8u8ahZxtcJCYa7zysc=; b=LCVGzfDgouocS/TCmxaA6Wxork8cr6+LaSLJCrQiYtGFM9FqUsCmkib8YD4MuTYcKIXmnUYD/OfTlwnz9t3HqwPzHjiZN1bBkTTjAWM4pgRHGyZoE5XTbVw67KHa20lIa2fLLXc8W3FqH9EMW5wD6nEv34+yEQ4owtE0wbPyIlw= Received: from DM4PR11MB5277.namprd11.prod.outlook.com (2603:10b6:5:388::23) by DM6PR11MB3065.namprd11.prod.outlook.com (2603:10b6:5:72::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Thu, 21 Oct 2021 05:36:21 +0000 Received: from DM4PR11MB5277.namprd11.prod.outlook.com ([fe80::fcab:50dd:7598:3b40]) by DM4PR11MB5277.namprd11.prod.outlook.com ([fe80::fcab:50dd:7598:3b40%5]) with mapi id 15.20.4608.018; Thu, 21 Oct 2021 05:36:21 +0000 From: "Gao, Zhichao" To: "Attar, AbdulLateef (Abdul Lateef)" , "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC structure Thread-Topic: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC structure Thread-Index: AQHXmP0LzehBDP1XaUenLMIgivkTraubEWkggEElA4CAARKhIA== Date: Thu, 21 Oct 2021 05:36:21 +0000 Message-ID: References: <20210824153013.30144-1-AbdulLateef.Attar@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Enabled=true; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SetDate=2021-10-20T13:13:35Z; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Method=Standard; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Name=AMD Official Use Only-AIP 2.0; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ActionId=6bebc327-8186-4da8-913f-72abb5dea63b; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ContentBits=1 dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ce2b58b5-7d8f-4c81-1f57-08d99454b6dd x-ms-traffictypediagnostic: DM6PR11MB3065: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: c4Wo/tFlcF2cmvCmFKglXxA4Zo0YJ3eTcvIoJpjLjE5ctUkd7Ay5emZjYctCp/qMksMSeY8EKOM7P61oemcKjR7XXz7xIQD9JTdZasrgo04Xa98wDXH4reHS/DxBy58AY79vdFYuVNfuDeqp6WqVUX0EqmblzGdrpW5faFnXShomlOlRc/N0EKzwMbg08H53bH8Iil+wNJZIUrMNgY2LLktYmS2442x8kvuRJpEeiHzIo3ZhjZz3zUOlSwHp66C0j4/Lx7WebNIYq0nSl+so3BBRtD2olFaIfw6oTe6THb+5eMjIoKhIGOtEytEjhqTIXAoHmcryGITj2HVMRGyxbeBVfu0fDUyngcJely4YibgJ3X2CugPToOck4H/5PHazr8vDYCxi4Don9Feeovy02/iUjGktSqlht9IfUO5ZXMUewg7r/ionqzPaaUq62DIJFyZVxQMexZaWWXOZnSbKrOMLuitoi8icPXdzYSZjOGWfkXWq3+t0R01a/lHaSd6cEW/uz0wdA8dqg8wepM35gjcKlc7wQKWNRO5NS8BAM4eJMnXJrePYdriMDb5sH4fDWo5kyVgN00+TTkcxjLUDCaeCJiG5UHnRL5x/UleMJWtDRZ0Zz4HGfVr9RHlSKc619iWRDyokBCJF/MIbr7IOg0mdQ0cdiA+bQZ1V86f5+6ELy17FSb9WeELiGAq2e6M9wnDH90CanIUZPRI8VsCdICsOM1O1/hHZ9db15rRU5FYo4BFrGsTtZf5RQz3PxwKToTdlw/w16jCi0gM2WzTY7IN3Sc2LnLwQ+EKblfcIcHk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5277.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(110136005)(4326008)(26005)(52536014)(186003)(86362001)(82960400001)(33656002)(966005)(38100700002)(122000001)(107886003)(6506007)(53546011)(38070700005)(316002)(5660300002)(508600001)(7696005)(76116006)(66946007)(2906002)(8676002)(83380400001)(55016002)(9686003)(66476007)(66556008)(66446008)(64756008)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KdsONTzXD9cMWAaKydwABkIF4/D8pGVyUdqEqjD5PVwaO23tWLiplmpX/HxR?= =?us-ascii?Q?K0PA2mD8eaw4oxcaW34wlQwMe+efTgg/8BmUu2gXu8CRRfLFjokTCdD4rEGg?= =?us-ascii?Q?1JY+gU3jFFKdJSCruP7sLFeR9yqERlFVFYjD1jwv5unns6s+tmZj9Zp3LJ4R?= =?us-ascii?Q?DwuwrCvIjhDEsxFYUWXuOmxCiN2qdqbY2JzzaQVE8iFIZFUh3QEO9n4ZtZfG?= =?us-ascii?Q?3GcRjkMlQYdXa7qyiXaGjhvZ/VqzWc4TRIs324Sg/UFaD67oTT9raaLrdZHF?= =?us-ascii?Q?dYp4I8mhUFDmL/3gQSLzAEMdjnPupXP49sX/aOo/MGp6WzT7hirgH8GB+fst?= =?us-ascii?Q?XwDqDUsoO0uftSCgOQa24jj6EAteCBqAUMz4lTUKBpJjE2WEJ9AU63lo3hlb?= =?us-ascii?Q?dVuUeD1TCpRpFl2HNhjU0mUP3ZRk2kpBoco/EPXwUj1XINIeSnVCbI79CwOg?= =?us-ascii?Q?J+qNdC7DF3Xe2GHoKJc5m/udejKjQviOd3E3QcpG9RJvX2SfGA17+Vtr7otE?= =?us-ascii?Q?OaND4d64U3nwKANHbZqpYFVhFe07qrism/zF2tfPxA7NlNqImznCA8RW6cCJ?= =?us-ascii?Q?49zhHCnNzPVjLYYBtj06lMl/j6OOptSRiABs476swpugM8CFK4dEbHNoOWVr?= =?us-ascii?Q?cz4CSm+dtwA2DiUpdbl/438rAJlOWBisaHbXlkzh2Vmsmmkxud1HPbr8xX61?= =?us-ascii?Q?U/xczmwtUk+TrbNx1eMwGHhrRU3gl+oNZqw2FNl7Q5Yq4YS7Sy0Bq4RMEQlD?= =?us-ascii?Q?XXkReqpuQKX9ivXRT6c07VNvpnvXCGZup3PrVa/heth+nlitxo41Mz6O5K53?= =?us-ascii?Q?kVkb5ShaTwqNm5/tEeYZlNGoOlPXmDw7ak3841VGxmmPinQxJnToHHkh6LcN?= =?us-ascii?Q?GeQvmAP1m0nR7dtkwUY7ef7Ur76pbBNJnM9P/14PGA2OSRy98tcnApEc0O1p?= =?us-ascii?Q?yobNSXuBLse9MHtP/xVgJiqlfcMn+zov+UrNjcby5j67wS90mklWZsFBGra+?= =?us-ascii?Q?zm4NnrEnPrswJp1Ereds2aU7TGTukvMV1lvpeQeADNAcAcYfWIzLP9B5oJ2K?= =?us-ascii?Q?06JH1fPx4oVQwZOHyKJCCdLTok0SH20vOm62cnwxluoVm2FP4BnSKjYH2+74?= =?us-ascii?Q?tqKwaMT8nuGJD6lddjfJo4IdQnjKHnwEcaSseLBMLvmDFDxAL3r9ldPj9Kpl?= =?us-ascii?Q?yfoaUlN6LxXDzwGWkw7BRvDbWMa5vQcoduNquccyohHOyBVKDSRitNDM6G1S?= =?us-ascii?Q?ea738Hsl1vHar1c9zrSJAiz6q82fXML9mrlNCVcoYqFnjiiCDCYJQ2jtTcvt?= =?us-ascii?Q?K25VpfqDjV5pDO3HVUuGu26gIrkTWivBGucpKa8TtpTKr8GsTWnKwYu3jr1s?= =?us-ascii?Q?qcz47iunSwf4S+ytwl0erYNNxad9HFAPRdKXPe41ZoqQKZl0KK35QEJ7WnP6?= =?us-ascii?Q?rOWSSboRadQ=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5277.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce2b58b5-7d8f-4c81-1f57-08d99454b6dd X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2021 05:36:21.4768 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zhichao.gao@intel.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3065 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sorry for the miss. PR create: https://github.com/tianocore/edk2/pull/2100 Thanks, Zhichao > -----Original Message----- > From: Attar, AbdulLateef (Abdul Lateef) > Sent: Wednesday, October 20, 2021 9:14 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Ni, Ray > Subject: RE: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC > structure >=20 > [AMD Official Use Only] >=20 > Gentle reminder to merge the code. >=20 > -----Original Message----- > From: Gao, Zhichao > Sent: 09 September 2021 07:54 > To: Attar, AbdulLateef (Abdul Lateef) ; > devel@edk2.groups.io > Cc: Ni, Ray > Subject: RE: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC > structure >=20 > [CAUTION: External Email] >=20 > Reviewed-by: Zhichao Gao >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: Abdul Lateef Attar > > Sent: Tuesday, August 24, 2021 11:30 PM > > To: devel@edk2.groups.io > > Cc: Ni, Ray ; Gao, Zhichao ; > > Abdul Lateef Attar > > Subject: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC > > structure > > > > Parse and print the below interrupt structures > > - I/O APIC Structure > > - Interrupt Source Override Structure > > - Processor Local x2APIC Structure > > - Local x2APIC NMI Structure > > > > Signed-off-by: Abdul Lateef Attar > > --- > > .../Parsers/Madt/MadtParser.c | 99 +++++++++++++++++++ > > 1 file changed, 99 insertions(+) > > > > diff --git > > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars > > er.c > > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars > > er.c > > index 15aa2392b6..2ba8c9ae52 100644 > > --- > > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars > > er.c > > +++ > > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars > > +++ er.c > > @@ -181,6 +181,57 @@ STATIC CONST ACPI_PARSER GicITSParser[] =3D { > > {L"Reserved", 4, 16, L"0x%x", NULL, NULL, NULL, NULL} }; > > > > +/** > > + An ACPI_PARSER array describing the IO APIC Structure. > > +**/ > > +STATIC CONST ACPI_PARSER IoApic[] =3D { > > + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL}, > > + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL}, > > + {L"I/O APIC ID", 1, 2, L"0x%x", NULL, NULL, NULL, NULL}, > > + {L"Reserved", 1, 3, L"0x%x", NULL, NULL, NULL, NULL}, > > + {L"I/O APIC Address", 4, 4, L"0x%x", NULL, NULL, NULL, NULL}, > > + {L"Global System Interrupt Base", 4, 8, L"0x%x", NULL, NULL, NULL, > > +NULL} }; > > + > > +/** > > + An ACPI_PARSER array describing the Interrupt Source Override > Structure. > > +**/ > > +STATIC CONST ACPI_PARSER InterruptSourceOverride[] =3D { > > + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL}, > > + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL}, > > + {L"Bus", 1, 2, L"0x%x", NULL, NULL, NULL, NULL}, > > + {L"Source", 1, 3, L"0x%x", NULL, NULL, NULL, NULL}, > > + {L"Global System Interrupt", 4, 4, L"0x%x", NULL, NULL, NULL, > > +NULL}, > > + {L"Flags", 2, 8, L"0x%x", NULL, NULL, NULL, NULL} }; > > + > > + > > +/** > > + An ACPI_PARSER array describing the Processor Local x2APIC Structure= . > > +**/ > > +STATIC CONST ACPI_PARSER ProcessorLocalX2Apic[] =3D { > > + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL}, > > + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL}, > > + {L"Reserved", 2, 2, L"0x%x", NULL, NULL, NULL, NULL}, > > + > > + {L"X2APIC ID", 4, 4, L"0x%x", NULL, NULL, NULL, NULL}, {L"Flags", > > + 4, 8, L"0x%x", NULL, NULL, NULL, NULL}, {L"ACPI Processor UID", 4, > > + 12, L"0x%x", NULL, NULL, NULL, NULL} }; > > + > > +/** > > + An ACPI_PARSER array describing the Local x2APIC NMI Structure. > > +**/ > > +STATIC CONST ACPI_PARSER LocalX2ApicNmi[] =3D { > > + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL}, > > + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL}, > > + {L"Flags", 2, 2, L"0x%x", NULL, NULL, NULL, NULL}, > > + > > + {L"ACPI Processor UID", 4, 4, L"0x%x", NULL, NULL, NULL, NULL}, > > + {L"Local x2APIC LINT#", 1, 8, L"0x%x", NULL, NULL, NULL, NULL}, > > + {L"Reserved", 3, 9, L"0x%x%x%x", Dump3Chars, NULL, NULL, NULL} }; > > + > > /** > > An ACPI_PARSER array describing the ACPI MADT Table. > > **/ > > @@ -357,6 +408,54 @@ ParseAcpiMadt ( > > break; > > } > > > > + case EFI_ACPI_6_3_IO_APIC: { > > + ParseAcpi ( > > + TRUE, > > + 2, > > + "IO APIC", > > + InterruptContollerPtr, > > + *MadtInterruptControllerLength, > > + PARSER_PARAMS (IoApic) > > + ); > > + break; > > + } > > + > > + case EFI_ACPI_6_3_INTERRUPT_SOURCE_OVERRIDE: { > > + ParseAcpi ( > > + TRUE, > > + 2, > > + "INTERRUPT SOURCE OVERRIDE", > > + InterruptContollerPtr, > > + *MadtInterruptControllerLength, > > + PARSER_PARAMS (InterruptSourceOverride) > > + ); > > + break; > > + } > > + > > + case EFI_ACPI_6_3_PROCESSOR_LOCAL_X2APIC: { > > + ParseAcpi ( > > + TRUE, > > + 2, > > + "PROCESSOR LOCAL X2APIC", > > + InterruptContollerPtr, > > + *MadtInterruptControllerLength, > > + PARSER_PARAMS (ProcessorLocalX2Apic) > > + ); > > + break; > > + } > > + > > + case EFI_ACPI_6_3_LOCAL_X2APIC_NMI: { > > + ParseAcpi ( > > + TRUE, > > + 2, > > + "LOCAL x2APIC NMI", > > + InterruptContollerPtr, > > + *MadtInterruptControllerLength, > > + PARSER_PARAMS (LocalX2ApicNmi) > > + ); > > + break; > > + } > > + > > default: { > > IncrementErrorCount (); > > Print ( > > -- > > 2.25.1