From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web09.5237.1649724523050006935 for ; Mon, 11 Apr 2022 17:48:43 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=WhJDcrri; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: zhichao.gao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649724523; x=1681260523; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=6cGxDQucwyr0JtlKYFbamGk4uKCiMi35etPAP0SkFzM=; b=WhJDcrrix4rwpfQrkxMAtLmWSimbLVTcvioovRwsQioJGSwiCB/HI8NV Xf6fudtARs3ZNkk1KS6W6Rp2RvIms+0NWRZFxUTscwnzMakcuNZnKu5Ti bM+JVQ+htSJSKcidIE2OnyxC5AV/GxIzFE58kpDKc3G3HUKtdofGjBuR5 8j2dSiO9tGh8SSdoN1C55xGFpxIcFpktF2UN9VnioMjI3xoEDeUxy6yVR 6f5oVogOWvk5my5swpI2tHvHd7Bz14cQtUQ1eU5IU5RbfZC1HZuF6PvN9 bzSX1bC5x6NUI4uqCWBLTTIt5Us/3tlx6Z04UdEFS8zULvOIJ1pUWVlNF A==; X-IronPort-AV: E=McAfee;i="6400,9594,10314"; a="242187118" X-IronPort-AV: E=Sophos;i="5.90,252,1643702400"; d="scan'208";a="242187118" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 17:48:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,252,1643702400"; d="scan'208";a="699604893" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga001.fm.intel.com with ESMTP; 11 Apr 2022 17:48:41 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 11 Apr 2022 17:48:41 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 11 Apr 2022 17:48:41 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 11 Apr 2022 17:48:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IveVXMEaXtc6bI4Fy9UO0x0Fuibl6CTZQl4DlS+fRjVQcIB83iUqJhArkUXaVa6BDHEv4+2G1ttJKJdmNxnQz0pQLh7N1Tt4aCw/cgs8DXdZpR5Y7T15eDraIy7fAINq97C89/2icoCWCoYCf4s7GORcuhdGJczCLzfW4z6lQpnLe3MfHCWsfuegjUFZFEyflmFWH70tttlk4vHdhhlWA4dQiJKH39fjw6BnWkIwVW1jrYNXUo0hxJrSPjP6pgb8qgmzK3i0lItxpL+scXJbXYdP/TfMQE7je8y/AqlK3k0tdnmLal1D9mvaEKNl+dEJDkSq6StlwqQhzlyrPaU+yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E8qvwaAbghk6ZYf8D5pHsSss8v2iWVgkdhdOgpQhcTA=; b=AbG0XGiC7FtSoMFZ830199MCMdGBE8yBuFE0iFXRScDg1QgC7gwtcKqFrKu8nunlAl2/a3eDmKuYe/0O03Fc5vrKPCZBEtwO1axRE5t39mxBfSwHvxAR4yREHFPMcjACrAVR9UtyEJu/oxfXNAc+qhpNzXm4R+IlT6VypKtOrclJYdKw1UNvlU9XdD4b/w4XFlsNaAlkZ+/diH7PxhIvc1U3CS05+tTVPKmmCdZfsBFxTjF1ac1ngV1rdbvKUe46WPiXiL8A3iIOC7dAlJaX2J9iPQPR6KlSBfn6l+9eErAwxwOqjo3kLUxAXR5l6vK2Y+k3UEqSblJ+b9sn+fn0mA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5277.namprd11.prod.outlook.com (2603:10b6:5:388::23) by DM5PR11MB1691.namprd11.prod.outlook.com (2603:10b6:3:b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Tue, 12 Apr 2022 00:48:33 +0000 Received: from DM4PR11MB5277.namprd11.prod.outlook.com ([fe80::3c64:1d03:3b40:7b0e]) by DM4PR11MB5277.namprd11.prod.outlook.com ([fe80::3c64:1d03:3b40:7b0e%5]) with mapi id 15.20.5144.029; Tue, 12 Apr 2022 00:48:33 +0000 From: "Gao, Zhichao" To: "Ke, Bo-ChangX" , "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: [PATCH] ShellPkg: Update smbiosview type 9 with SMBIOS 3.5 fields Thread-Topic: [PATCH] ShellPkg: Update smbiosview type 9 with SMBIOS 3.5 fields Thread-Index: AQHYTXJx3d46fXqJaUSPk56VJkWJwqzrcgsA Date: Tue, 12 Apr 2022 00:48:33 +0000 Message-ID: References: <02c85afc682e5e3147c1f5fea4e60b2c6a8f85ba.1649657331.git.bo-changx.ke@intel.com> In-Reply-To: <02c85afc682e5e3147c1f5fea4e60b2c6a8f85ba.1649657331.git.bo-changx.ke@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 55d61d21-c6ea-4dc1-77fa-08da1c1e2be4 x-ms-traffictypediagnostic: DM5PR11MB1691:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BRL/kz1wQdDUPbnv750vdtbXPVsyDE3NXGzeWl6ikCwhMWbJ1/Hv2iub6Hw9+TEAGNjlZrNQloHfgJ5CEpyovjvTrB/5nSHVdKV9PfnAUjBhkHlM8mtNS1P3PJV+jAx+1huIu4jxRP5gfSgqSMVlltljyZ2k4trNdPttnNumhxcGs31QUtUFuIudA42YPPaxurRypKgxA/aW9IzUOxP9D1BHxQEFTwETu5pHpbU+qDf7hBWXJZ/K3v76FewSeXl24vChuLxCngmMZT4Eokaj40Zq8V10DS8mdlzd6ld73tKEsrm/4QQLKTNChglu7ud8TIRLW4dt3wvZ5h5C2uNp+pwgg+3pC7AFnaYTUC50gHf+Pj12Q9H4EO+yVq328auxRyZDz2zdjzSMNGoodb8CCr7D8hWOTV4O+bY8lCJ1ycKvrPJYnyfjFTsuUCHNZ/CMKsfpTh8cudiBKkQoGuWAy7AYQNdqu+7Sj6vDQ4wS63a6XiDAXTTlSZQpkNQymchRSGQl68tTcetzGC6zX1qBpBjw2563O9wFCNwCYTvkCNXOfM+MSAsXpcfAHuJDciyRnHM7Jixwqr6tHhwbR9+7cRqFb/nYYfDgpB0dBsq5N9L+8fwqgZY+UKX+cLjQXD+gwS6gqWWDgc7gZ9Zu9+m+7mcnaPxLdpjQDx6dtp0A7D45hPTRgAAm0N1fLCKGs+dZyTJEUhNkuGJCjEtClcn+fy9BYkl7Rik/lySbEe4vo2J17nZo0FCpZpQdZvEuPYyUFhb3/4EHorQSN8ZwETZiHkksnPjtcBqLamKhrt3jpE8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5277.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(33656002)(107886003)(19627235002)(110136005)(55016003)(64756008)(66556008)(66946007)(76116006)(66476007)(83380400001)(4326008)(66446008)(86362001)(26005)(186003)(508600001)(5660300002)(15650500001)(38100700002)(8676002)(30864003)(8936002)(82960400001)(122000001)(71200400001)(316002)(38070700005)(7696005)(6506007)(53546011)(9686003)(2906002)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?D+Y0/kFxvIyixrqe9TI4sLZ4/UQlotevl6gE4gJBnbp+W3fhEqB0wwrmQyUd?= =?us-ascii?Q?aK65F5ApaEc0H8gHbJ7XS4WlWRypk1NWjJrxTOtK3lHyTKvtYYgvahByPI9S?= =?us-ascii?Q?umM9bbVYoJDDtE9Ou8HxkjT0Ci/lKeafNNQb/dTyYdQnnUXgIu+N1e7j4NgH?= =?us-ascii?Q?zDC0F8fKsIvhvdPBzmiVmPnP2Nvy3U6Gw+7Zos2VbRE4e9/29nt17RMwnvsh?= =?us-ascii?Q?bK8Elpf+DWn5xQ4mQ3z/rIN0Gd4A/OrpkW9r2WpbAWN9mC2rGNAR0btw4j4N?= =?us-ascii?Q?SbsGfITy70nFEORsDxx4WYIzBnNeOXEaUa36Z+qGObGbaFRpramvQdXWg/MQ?= =?us-ascii?Q?QwFhgvYLA9CEbeBF6gTilMiKHvp1t37BhE/MJMwuABtcSYr/VAcJ4XTBnmMj?= =?us-ascii?Q?VFv5oBcHTgQrsllP4fG42YvKSjgTAmNr7939++CBGfiFT3+0f+fX7FPUaNpg?= =?us-ascii?Q?AIBlk3BCqVD5AmJQUy6TsgzyxJhnSQu9BvQ3vUuMitO+7m28NOk/aOwLS2qz?= =?us-ascii?Q?MUI5Vf+r/vMNMJWVqgDJVu76MZ5SFbGdajM1ANJIlua6k9Y3F31ZdRNa6XL5?= =?us-ascii?Q?xTsOfowqF3LAGynZ/q0SNXNJuKxKdF28c+x8Z/1hk8OlaPwEJ+IaHgriUnWN?= =?us-ascii?Q?7zV6CQXY9MLEUCZAdviQqeWVhlwg55sKlgYv0v1n1UjoDdtaj9J/Ie6msANA?= =?us-ascii?Q?iTTEjM4G1Z85ZKsjlRwvBNcizDQd3qhwlAun+aoD1NPzwm1NdvrmzkTlayG1?= =?us-ascii?Q?feZhmg+Pq/BZGVHp6shTjVGQBJUzt9PcgpI1olegtdyyxzsn3BcI/U+hM12N?= =?us-ascii?Q?DN5MIhdV8PtsqeAiWb86pxubr2PDl8kk9sPh/nhYbJhFaRXMx/43caMrEbTv?= =?us-ascii?Q?1+eIYorxhkVsyXfu8PbeJtpBNbww/78bHZfIf8RUxW5Y1K+MmvJde7C/OKMF?= =?us-ascii?Q?0rCGzmY00pSwX2G5SEQe/5pvwVrtCQrYCRyHOh2b3mkdTMbgi7KFAFdxVoB3?= =?us-ascii?Q?ou+HsG+PfHf990fHNNTPL6qBu16rHkIaJMIA5Sez6Lllqo++w8PwkSw7PBME?= =?us-ascii?Q?FW1OdraE2QK/vupIr2QkkOt8TYslu4HCb2r09Ow/2BHz2eY/635XmPpfNzDh?= =?us-ascii?Q?hHa/NOmhGjFWBvJsnBHjALWPI7TzNxj0tBTUFtRPNsIBmH6o0f1wOwf7+81w?= =?us-ascii?Q?1nXZ+lQ2X/SXv2inUM8QRfjasozK6AfhHkA1bVhJJw5ileN58XClkH+tYSO3?= =?us-ascii?Q?F7clraxc8S5hPe5DA296+Vw85Qu1jXeONhSmNEQU0NQnby8Ss8xkchIj6HVe?= =?us-ascii?Q?8roQq/vhbcbCvNd5dRHMtjp0oQpP+1xCiciL/X2z7MgV0d48FGjNwbCC26ms?= =?us-ascii?Q?w2/o66n9NfdgNLDGZmOCORbEY1csoDIvXKUeRLXb7HdkC4mESnt0bG8VI+se?= =?us-ascii?Q?5+SKxxRcf+KEAcf/kcN7V2Q8huX6LSTZ+RlMOacjfGOa5Zao/lZ7Fe9tFp83?= =?us-ascii?Q?jNTaCVS4e2bNBMKdmL/ohY6X5SYEVxaBlsiX701S0hMy7pKa3u61zDg6qi4s?= =?us-ascii?Q?wL5sz6dZYVW+5g3WqBW8zQPvNw5FOVDt9YVeSDkLIIbapdT6QPkIwrqSZ15u?= =?us-ascii?Q?cokNg/7qFJfBzW7q9GPeDN2aZT0qeWXS64q7rTqwikljfKAXZJXQYgjIp2CX?= =?us-ascii?Q?roJoQtdwBrYRJ9EwfhbEbyGpUpIgusDk3ECobz7i1LksnBlpdEcEk6KsbP4C?= =?us-ascii?Q?0pTO77kRfw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5277.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55d61d21-c6ea-4dc1-77fa-08da1c1e2be4 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2022 00:48:33.6229 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MffzbGg5qu0GFwd8ZngpEqRlyYBEzT3fxqJxPCzQ6ACUQHzkt95DT0bwgxK12t1trlC1e9zih05/9Ne1DH0yuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1691 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Ke, Bo-ChangX > Sent: Monday, April 11, 2022 3:05 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao > Subject: [PATCH] ShellPkg: Update smbiosview type 9 with SMBIOS 3.5 field= s >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3896 >=20 > update smbiosview type 9 related fileds. >=20 > Signed-off-by: Bo Chang Ke > Cc: Ray Ni > Cc: Zhichao Gao > --- > .../SmbiosView/PrintInfo.c | 11 +- > .../SmbiosView/QueryTable.c | 238 ++++++++++++++++++ > .../SmbiosView/QueryTable.h | 36 +++ > .../SmbiosView/SmbiosViewStrings.uni | 5 +- > 4 files changed, 285 insertions(+), 5 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > index b144600a25..0fa40dbe0c 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > @@ -637,6 +637,13 @@ SmbiosPrintStructure ( > } > } > } > + if (AE_SMBIOS_VERSION (0x3, 0x2)) { > + if (Struct->Hdr->Length > 0x12) { > + DisplaySystemSlotHeight(Struct->Type9->SlotHeight, Option); > + DisplaySystemSlotPhysicalWidth(Struct->Type9->SlotPhysicalWidt= h, > Option); > + DisplaySystemSlotInformation(Struct->Type9->SlotInformation, > Option); > + } > + } There are some condition check in above code. Why put these separately? And= please add the white space between the function name and first '('. Others looks OK to me. Thanks, Zhichao >=20 > break; > } > @@ -2898,10 +2905,6 @@ DisplaySystemSlotId ( > IN UINT8 Option > ) > { > - // > - // Display slot type first > - // > - DisplaySystemSlotType (SlotType, Option); >=20 > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > (STR_SMBIOSVIEW_PRINTINFO_SLOT_ID), gShellDebug1HiiHandle); > // > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > index c4a6acb167..96e0e4036a 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > +++ c > @@ -1447,6 +1447,27 @@ TABLE_ITEM SystemSlotTypeTable[] =3D { > 0x23, > L"PCI Express Mini 76-pin (CEM spec. 2.0) Corresponds to Display-Min= i > card" > }, > + { > + 0x24, > + L"PCI Express Gen 4 SFF-8639 (U.2)" > + }, > + { > + 0x25, > + L"PCI Express Gen 5 SFF-8639 (U.2)" > + }, > + { > + 0x26, > + L"OCP NIC 3.0 Small Form Factor (SFF)" > + }, > + { > + 0x27, > + L"OCP NIC 3.0 Large Form Factor (LFF)" > + }, > + { > + 0x28, > + L"OCP NIC Prior to 3.0" > + }, > + > { > SlotTypeCXLFlexbus10, > L"CXL Flexbus 1.0" > @@ -1566,6 +1587,42 @@ TABLE_ITEM SystemSlotTypeTable[] =3D { > { > SlotTypePciExpressGen4X16, > L"PCI Express Gen 4 X16" > + }, > + { > + SlotTypePCIExpressGen5, > + L"PCI Express Gen 5" > + }, > + { > + SlotTypePCIExpressGen5X1, > + L"PCI Express Gen 5 x1" > + }, > + { > + SlotTypePCIExpressGen5X2, > + L"PCI Express Gen 5 x2" > + }, > + { > + SlotTypePCIExpressGen5X4, > + L"PCI Express Gen 5 x4" > + }, > + { > + SlotTypePCIExpressGen5X8, > + L"PCI Express Gen 5 x8" > + }, > + { > + SlotTypePCIExpressGen5X16, > + L"PCI Express Gen 5 x16" > + }, > + { > + SlotTypePCIExpressGen6andBeyond, > + L"PCI Express Gen 6 and Beyond" > + }, > + { > + SlotTypeEnterpriseandDatacenter1UE1FormFactorSlot, > + L"Enterprise and Datacenter 1U E1 Form Factor Slot" > + }, > + { > + SlotTypeEnterpriseandDatacenter3E3FormFactorSlot, > + L"Enterprise and Datacenter 3'E3 Form Factor Slot" > } > }; >=20 > @@ -1628,6 +1685,96 @@ TABLE_ITEM SystemSlotDataBusWidthTable[] =3D { > } > }; >=20 > +TABLE_ITEM SystemSlotPhysicalWidthTable[] =3D { > + { > + 0x01, > + L" Other" > + }, > + { > + 0x02, > + L" Unknown" > + }, > + { > + 0x03, > + L" 8 bit" > + }, > + { > + 0x04, > + L" 16 bit" > + }, > + { > + 0x05, > + L" 32 bit" > + }, > + { > + 0x06, > + L" 64 bit" > + }, > + { > + 0x07, > + L" 128 bit" > + }, > + { > + 0x08, > + L" 1x or x1" > + }, > + { > + 0x09, > + L" 2x or x2" > + }, > + { > + 0x0A, > + L" 4x or x4" > + }, > + { > + 0x0B, > + L" 8x or x8" > + }, > + { > + 0x0C, > + L" 12x or x12" > + }, > + { > + 0x0D, > + L" 16x or x16" > + }, > + { > + 0x0E, > + L" 32x or x32" > + } > +}; > + > +TABLE_ITEM SystemSlotInformationTable[] =3D { > + { > + 0x00, > + L" Others" > + }, > + { > + 0x01, > + L" Gen 1" > + }, > + { > + 0x02, > + L" Gen 2" > + }, > + { > + 0x03, > + L" Gen 3" > + }, > + { > + 0x04, > + L" Gen 4" > + }, > + { > + 0x05, > + L" Gen 5" > + }, > + { > + 0x06, > + L" Gen 6" > + } > +}; > + > TABLE_ITEM SystemSlotCurrentUsageTable[] =3D { > { > 0x01, > @@ -1670,6 +1817,30 @@ TABLE_ITEM SystemSlotLengthTable[] =3D { > }, > }; >=20 > +TABLE_ITEM SystemSlotHeightTable[] =3D { > + { > + 0x00, > + L" Not applicable" > + }, > + { > + 0x01, > + L" Other" > + }, > + { > + 0x02, > + L" Unkown" > + }, > + { > + 0x03, > + L" Full height" > + }, > + { > + 0x04, > + L" Low-Profile" > + }, > + > +}; > + > TABLE_ITEM SlotCharacteristics1Table[] =3D { > { > 0, > @@ -1722,6 +1893,22 @@ TABLE_ITEM SlotCharacteristics2Table[] =3D { > { > 3, > L" PCIe slot supports bifurcation" > + }, > + { > + 4, > + L" Slot supports async/surprise removal" > + }, > + { > + 5, > + L" Flexbus slot, CXL 1.0 capable" > + }, > + { > + 6, > + L" Flexbus slot, CXL 2.0 capable" > + }, > + { > + 7, > + L" Reserved" > } > }; >=20 > @@ -4208,6 +4395,57 @@ DisplaySlotCharacteristics2 ( > PRINT_BITS_INFO (SlotCharacteristics2Table, Chara2); } >=20 > +/** > + Display System Slots (Type 9) Information. > + > + @param[in] Width The key of the structure. > + @param[in] Option The optional information. > +**/ > +VOID > +DisplaySystemSlotInformation ( > + IN UINT8 Width, > + IN UINT8 Option > + ) > +{ > + ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > +(STR_SMBIOSVIEW_QUERYTABLE_SYSTEM_SLOT_INFORMATION), > +gShellDebug1HiiHandle); > + PRINT_INFO_OPTION (Width, Option); > + PRINT_TABLE_ITEM (SystemSlotInformationTable, Width); } > + > +/** > + Display System Slots (Type 9) Physical Width. > + > + @param[in] Width The key of the structure. > + @param[in] Option The optional information. > +**/ > +VOID > +DisplaySystemSlotPhysicalWidth ( > + IN UINT8 Width, > + IN UINT8 Option > + ) > +{ > + ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > +(STR_SMBIOSVIEW_QUERYTABLE_SYSTEM_SLOT_PHYSICAL_WIDTH), > +gShellDebug1HiiHandle); > + PRINT_INFO_OPTION (Width, Option); > + PRINT_TABLE_ITEM (SystemSlotPhysicalWidthTable, Width); } > + > +/** > + Display System Slots (Type 9) slot height. > + > + @param[in] Length The key of the structure. > + @param[in] Option The optional information. > +**/ > +VOID > +DisplaySystemSlotHeight ( > + IN UINT8 Length, > + IN UINT8 Option > + ) > +{ > + ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > +(STR_SMBIOSVIEW_QUERYTABLE_SYSTEM_SLOT_HEIGHT), > gShellDebug1HiiHandle); > + PRINT_INFO_OPTION (Length, Option); > + PRINT_TABLE_ITEM (SystemSlotHeightTable, Length); } > + > /** > Display On Board Devices Information (Type 10) types. >=20 > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > h > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > h > index 5111d35f63..5f062762b3 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > h > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > +++ h > @@ -415,6 +415,42 @@ DisplaySlotCharacteristics2 ( > IN UINT8 Option > ); >=20 > +/** > + Display System Slots (Type 9) Information. > + > + @param[in] Width The key of the structure. > + @param[in] Option The optional information. > +**/ > +VOID > +DisplaySystemSlotInformation ( > + IN UINT8 Width, > + IN UINT8 Option > + ); > + > +/** > + Display System Slots (Type 9) Physical Width. > + > + @param[in] Width The key of the structure. > + @param[in] Option The optional information. > +**/ > +VOID > +DisplaySystemSlotPhysicalWidth ( > + IN UINT8 Width, > + IN UINT8 Option > + ); > + > +/** > + Display System Slots (Type 9) slot height. > + > + @param[in] Length The key of the structure. > + @param[in] Option The optional information. > +**/ > +VOID > +DisplaySystemSlotHeight ( > + IN UINT8 Length, > + IN UINT8 Option > + ); > + > /** > Display On Board Devices Information (Type 10) types. >=20 > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosView > Strings.uni > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosView > Strings.uni > index 9433e8a25f..a8728d6abc 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosView > Strings.uni > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosView > S > +++ trings.uni > @@ -294,7 +294,7 @@ > #string STR_SMBIOSVIEW_PRINTINFO_MEM_SIZE #languag= e en- > US " Memory Size: %d MB\r\n" > #string STR_SMBIOSVIEW_PRINTINFO_MEM_MODULE_DOUBLE_BANK > #language en-US "The memory module has a Double-bank connection\r\n" > #string STR_SMBIOSVIEW_PRINTINFO_MEM_MODULE_SINGLE_BANK > #language en-US "The memory module has a Single-bank connection\r\n" > -#string STR_SMBIOSVIEW_PRINTINFO_SLOT_ID #languag= e en- > US " Slot Id:" > +#string STR_SMBIOSVIEW_PRINTINFO_SLOT_ID #languag= e en- > US "Slot Id:" > #string STR_SMBIOSVIEW_PRINTINFO_LOGICAL_MICRO_CHAN > #language en-US " the logical Micro Channel slot number is:" > #string STR_SMBIOSVIEW_PRINTINFO_ONE_VAR_D #languag= e > en-US " %d\r\n" > #string STR_SMBIOSVIEW_PRINTINFO_ERROR_NOT_1_15 > #language en-US " error, not 1-15.\r\n" > @@ -412,6 +412,9 @@ > #string STR_SMBIOSVIEW_QUERYTABLE_SYSTEM_SLOT_LENGTH > #language en-US "System Slot Length: " > #string STR_SMBIOSVIEW_QUERYTABLE_SLOT_CHARACTERISTICS > #language en-US "Slot characteristics 1: " > #string STR_SMBIOSVIEW_QUERYTABLE_SLOT_CHARACTERISTICS_2 > #language en-US "Slot characteristics 2: " > +#string STR_SMBIOSVIEW_QUERYTABLE_SYSTEM_SLOT_INFORMATION > #language en-US "System Slot Information: " > +#string STR_SMBIOSVIEW_QUERYTABLE_SYSTEM_SLOT_HEIGHT > #language en-US "System Slot Height: " > +#string STR_SMBIOSVIEW_QUERYTABLE_SYSTEM_SLOT_PHYSICAL_WIDTH > #language en-US "System Slot Physical Width: " > #string STR_SMBIOSVIEW_QUERYTABLE_ONBOARD_DEVICE_TYPE > #language en-US "Onboard Device Type: " > #string STR_SMBIOSVIEW_QUERYTABLE_SYSTEM_EVENT_LOG_TYPE > #language en-US "System Event Log Type: " > #string STR_SMBIOSVIEW_QUERYTABLE_EVENT_LOG_VAR_DATA_FORMAT > #language en-US "Event Log Variable Data Format Types: " > -- > 2.32.0.windows.1