From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.5143.1647569175414618234 for ; Thu, 17 Mar 2022 19:06:15 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=LijeMtJV; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: zhichao.gao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647569175; x=1679105175; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=CfurFls/vTinXagPwyGN03gGbENWgjZkvCoaqB+nP+A=; b=LijeMtJVAXV44tMUskaeXZ1vyHEAOFU9VCZ//SJtpZFVMsKLvnyVNrlp MPCpFEzhrJAr+FwKcqESCUWWjBzIU+qG/zE9I7BOC5chwqAjeIToa1FDQ cihhXfSKtSM25cxEp+u1EJRVcd8TMjGmJ7SZG9LJfBzzo5s7x94xNvj6v 6GN0ug5S5mb7hGjhgqCw9P4zrQDs5b1eFYvpoJwEob6tT8HHcoBserS/L J9/DUc2HjKK5XR65IhjI/b9wBLMcXpCvWaNBW8Fnowd7/NMpT12koP+gG MJEUB31HxNSR/Pw2g4WlE6TE9dxuIpg8w00JtLy93p6+nLinksL9Ps44e g==; X-IronPort-AV: E=McAfee;i="6200,9189,10289"; a="256976185" X-IronPort-AV: E=Sophos;i="5.90,190,1643702400"; d="scan'208";a="256976185" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2022 19:04:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,190,1643702400"; d="scan'208";a="499059987" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP; 17 Mar 2022 19:04:46 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 17 Mar 2022 19:04:46 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 17 Mar 2022 19:04:45 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Thu, 17 Mar 2022 19:04:45 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.47) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Thu, 17 Mar 2022 19:04:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Om8x3KFl9bYieq+BSY3PiXLdplT4DmQWW78DUl2h/uOmvQp68uKGna+nhNFWvR0jNkbP7TOiytJgxcbXyFHtE+vwWgtUBu9err9Zb8jiGe0XP7dYavSCq01E/FKDTIb+MrhkDZ16rKt4swzseXYV0vCk1Zgg2ysGXRJk4CNIGDL+jvY4aHnNOYURsIEsoNwSYbDZ5Vvhm5EorxtU78D9o6MJs247lNZ9VygnR/5zys7b+BjlRO8T8LYsBfsLMY9bcqFTt+IWC/otYoSu4/GSwe+oSO8XGx352ia1YtyQHARM54xjm7WY2+IWZlRv6vpV04NrdYaa/RyJmtzvahOFIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vf/648BI4wjI1fq/FqDvh0Ovv3veck+y1Z9wCCgcsUE=; b=AkvgDcCYojltpqLJv8qKdVpF8BPmi4YgVOXQB8HY0LpkluSFGo7tSUaTNUFqQ+mh1/jj7JYUXXXsLFzile75GZ0FN463CQeIO8oIIUkjY0dxVpJVXUrk5SCvVO0nikmTdGbgfn4dsK5N3Uf27ui82A1aMhJHduV75f8TD9a/jyNTwS9yy2iDi32J2TedeOnMaSftZ67NKZNcOVjEOjBwZV8ZwmHXOybtWqmTTzLMbStmURM/upmATYLO0aSMvuFbfMX7yiWdymGPhdttFtJtx045agP3dB5oMAbC7scAKrsskV0FFZCDrWKBk0OYTLysIme4FaAndryVm+9HB8OkOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5277.namprd11.prod.outlook.com (2603:10b6:5:388::23) by DM6PR11MB2667.namprd11.prod.outlook.com (2603:10b6:5:c1::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.17; Fri, 18 Mar 2022 02:04:37 +0000 Received: from DM4PR11MB5277.namprd11.prod.outlook.com ([fe80::ccd:e745:38c1:56cd]) by DM4PR11MB5277.namprd11.prod.outlook.com ([fe80::ccd:e745:38c1:56cd%9]) with mapi id 15.20.5081.016; Fri, 18 Mar 2022 02:04:37 +0000 From: "Gao, Zhichao" To: "Attar, AbdulLateef (Abdul Lateef)" , "devel@edk2.groups.io" CC: "Ni, Ray" , Sami Mujawar Subject: Re: [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser Thread-Topic: [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser Thread-Index: AQHYIyZTgXzkoCca10eTEKbVs1SzIKydpgKAgCWvu9CAATy8wA== Date: Fri, 18 Mar 2022 02:04:37 +0000 Message-ID: References: <20220216111355.9801-1-abdattar@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4ad46685-013b-4946-d235-08da0883a7e4 x-ms-traffictypediagnostic: DM6PR11MB2667:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DmNe0jjTLXm+1Tww0VcgzNkyDcq60vJju5IS3G+n7NmXUOWKDqx/nsCtFOsOjtD67mPzMMckJisrBQMbN4fs9lvYuS5k0x26vgyhrNO94AaM+qsi0OCfn0fPfv/cW7N24DfPQ9rw0NgTysu8RVg60KsTQMGcsqHG/FMnH0oYDKPaZbQt6FOpa7/SN8LQWjpoazZZT6s7+2J2Qznj8hw3EFWlfdy/+0fVLAyCPTbt2UyJbgCohayZYHUlE1NKAV4f231XAtThqm1iUIIwlU7XFfI+4m9TsDnn5Y2GTvCs9+OQKeHU4sC57RFrdL5yMOWYNP3ajANA3vPV5Y7Xj6hil2NM8mwdRT3xZvI94Ipkn0QNRIiHScL3WHyx8W+9rvUjAGfS62uFvh5A/mcP5u49sx6CQkR8es/BPMl6POjP37WNGl+9TNCg65MOnHTamvITb2h3prlQz8KvHbRuhWkYMLp6bbFAy77lDp7AzHhOZK5dzw/UU5DHDZ56N88/vvxg9UKw3Ai/qhEDqrA2HxBW7j5AqtshHijmyjavuPQ9jtcCBCW/rA2LmPkHchVKvdBQJmfygbWZuxrzq7pWlBk3g1o+BuQkqc3Z5QYP1lGrgKNiBFtpoiizWVYCh+CL0ZUSh5HdVqrGPRLZYtdBK1zus+ANPMhKczijcvIjDsayzdZ0fXneDQXndvyDjqnc3EbN8Cl0HGNGbvX9lX8D1M/QVH0CzZhxwLa+69iTfUdwI56xEg/upfjcUzPUF4ll6R4bPdQnVaKzK3CqptDYF/5pr02tlvF5zFx9501fws5L9rc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5277.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(55016003)(45080400002)(122000001)(38100700002)(966005)(5660300002)(82960400001)(186003)(33656002)(52536014)(2906002)(8936002)(38070700005)(54906003)(83380400001)(66946007)(76116006)(4326008)(66476007)(316002)(8676002)(66446008)(86362001)(66556008)(64756008)(110136005)(508600001)(9686003)(26005)(71200400001)(53546011)(7696005)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZrZfE68arnOaDCZ8gW8BArYUzNpzI/wHfRf2/+DnqSUP0nh8ky0onapVwoFB?= =?us-ascii?Q?Wau/pYFrk9/xCl4VGuzsomSfQiN6Trl0iGR8Nf8txsaU2Kt8kuIhUq/O63JN?= =?us-ascii?Q?LwQxpk3QqPzMF0DphxyE/ThopsfDFEPtxXtLJlqbQmF15aDDSVHgp+mDpCUz?= =?us-ascii?Q?u9C6EhoCsLLAgdu2aGmHtHSzGHQOoIqaIoA/5b3nh0nbqZK9ppkH1md/eJ9V?= =?us-ascii?Q?+mgiGPwy5jMKxzrjHDEM6qJ56GC/+LFB8nYtM29wAnpoJs13aoIb/zX6aAkW?= =?us-ascii?Q?QYDUfRpOGP4rKm6wn/TcC6sc1n4SpxQTXuoW9Tm/kimrsybowyCYacBqfGRA?= =?us-ascii?Q?aplgGclRRKsFAH19si3H/hYzRXAFatNHuGNqAbXNCJ6jaE/fxc/iePsZpLZ6?= =?us-ascii?Q?E3rMivGWzeaHTyszIUKQzjpHUMsmxQg9/nihBN99RdgGqfvTfFiLb5qnyH12?= =?us-ascii?Q?Y5mFNPRm1n7J/XQn1PGg1jatZT/6R4CmG7gsbjneuge9OOPDIefC4dqsI1T+?= =?us-ascii?Q?D/6Pny4HTxHKQHu5tCjROne+kvatEQ3JgP78RgLrpt0lV4zaS3uYrF1PrRxQ?= =?us-ascii?Q?WsPF7JQsNPe5L7df/YmsCMhXg2Bp2Z9uk8ETERY3GPIaIDsnfG9387rOXSML?= =?us-ascii?Q?Ebqcoh4xq5kxJOMetvhMDQ+jikZnfLGX/zrP7IySwQq7SEMSYyUIbYwbgXYb?= =?us-ascii?Q?ISDWRT9Bq4VCnad1EFZICVuW14R8mzrObr3PjSaWzdFLvnE3CgUJi0XUx7K9?= =?us-ascii?Q?vWJnUxErjtj0vwA21zlID/jKjJBluq9LnJpTC4oGvVgaMcNWtX7JDHj8q8HE?= =?us-ascii?Q?/rTYP74/i9qyMNQG4OAaz5QKS7MTb84Gho+Olrr+FuothYZyPFefVcSsQycs?= =?us-ascii?Q?kRKzI6X8ctq2bmgIBopGs9j7Jwra9EZTEIGBKhhikyP5Juuafjm/PyRMn8Rm?= =?us-ascii?Q?yf7doT/vyw7oD5wrz5x0kM2uLu+f5dYUBY1A+LTiC+I5Vq53VoKfUFTUd7a9?= =?us-ascii?Q?akvZGHk6GHrJ4RRRlqr+8Lr71Ysl7YzTm7WsXzKY3l3Kp6qh9QYpZx3YBYIz?= =?us-ascii?Q?mJ/xRbZssIt53QxalaoLIoHkva29o5YbUnVZp7YkKVG5xUmS1WkRh3zqntc+?= =?us-ascii?Q?Znt55iYlguWywh6SQwx6x5o4ut3h+BFeClScVMGna8X3J3ZVru2mkgu6ws8v?= =?us-ascii?Q?ktMapoT/lb0Ovc5eAA1JQ6nURwUBeXj/K/JONEz2C54hZtuGZVso+5wBtvyp?= =?us-ascii?Q?uJi/3Ddn+evJVzjgGtM55oYaIfJwBfsmxIbJ+I2gPLasFJkbeolbfbidjaZR?= =?us-ascii?Q?b704OcpuVF7WdpnjFVyQkeenXcGxEBwstChHjRwnen+VEF73FZSOnDH43Iey?= =?us-ascii?Q?gKPQpwlL5Y4vjU/ABm8H9v0v+IaIh1O018zf163/LIXpV9xOwvcyh0t1CSqR?= =?us-ascii?Q?jLQ1GWJ58V74z2Dhd1GDB+Ley0aszMIb?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5277.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ad46685-013b-4946-d235-08da0883a7e4 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Mar 2022 02:04:37.6094 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: a5VY90dAJN3iWc2ICkxyZ4jGhbXN54G5UNmip6LU1k4GX1drl1H368Jzy1VZeVZwVRDBM206+wIpWct4yzluUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2667 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sorry. I forgot to update. I have create the PR twice but the open-CI faile= d. Can you check? https://github.com/tianocore/edk2/pull/2568 Thanks, Zhichao > -----Original Message----- > From: Attar, AbdulLateef (Abdul Lateef) > Sent: Thursday, March 17, 2022 3:10 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Ni, Ray ; Sami Mujawar > Subject: RE: [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield > parser >=20 > Gentle reminder for PR. >=20 > -----Original Message----- > From: Gao, Zhichao > Sent: Monday, February 21, 2022 1:10 PM > To: Attar, AbdulLateef (Abdul Lateef) ; > devel@edk2.groups.io > Cc: Ni, Ray ; Sami Mujawar > Subject: RE: [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield > parser >=20 > [CAUTION: External Email] >=20 > Patchset Reviewed-by: Zhichao Gao >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: Abdul Lateef Attar > > Sent: Wednesday, February 16, 2022 7:14 PM > > To: devel@edk2.groups.io > > Cc: Ni, Ray ; Gao, Zhichao ; > > Sami Mujawar > > Subject: [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield > > parser > > > > Hi, > > Sorry for the delayed reply. > > I had updated the patch according to the review comments. > > Please review the updated patch. > > > > REF: > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit= h > > > ub.com%2Fabdattar%2Fedk2%2Ftree%2FFadtFlagsParserV5&data=3D04%7C0 > 1%7 > > > CAbdulLateef.Attar%40amd.com%7Cdbcced5d461947c4c52908d9f50d60e9%7C > 3dd8 > > > 961fe4884e608e11a82d994e183d%7C0%7C0%7C637810260090713957%7CUnk > nown%7C > > > TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJX > VC > > > I6Mn0%3D%7C3000&sdata=3DlqrY9GyWZTJl%2BsRa%2F223ft8ei5rKBbm36av > 4SQh4 > > l9g%3D&reserved=3D0 > > > > > > Cc: Ray Ni > > Cc: Zhichao Gao > > Cc: Sami Mujawar > > > > Abdul Lateef Attar (2): > > ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser > > ShellPkg/AcpiView: PrintFormatter for FADT Flags field > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h = | 48 > > +++++ > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c = | 188 > > ++++++++++++++++++++ > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c > > | 167 +++++++++++------ > > 3 files changed, 348 insertions(+), 55 deletions(-) > > > > -- > > 2.25.1