From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web08.7096.1644912624089892017 for ; Tue, 15 Feb 2022 00:10:24 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=WGavRmMl; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: zhichao.gao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644912624; x=1676448624; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=cgT7Uhv+JspkCVsK8FaiSBmSaVg+/wCanrwsR63sgKY=; b=WGavRmMlROEDZdE1Klevz0+gvvJ6whAs5vkXsITfJaej/+JlUWuqanSo ZkoNIIMg764fW6SL+3NhuAqGRIHycCqxulVmVC1+4gvh5gFelacA3XT0k 2o/+ScQ103YZ2FU/jMoZ/CzZXn6ZEDBXqNOpL2/98w/WAwCdHZs8XNNtw eBidOEHHnetGC46bH5GCcA30TP2Vg7BMb0NiD5RT1jNldaMimxZEE9PYq CXUWqxc5yTgi8Pjn95MTUb4Ox0lAZPnPi0LdOKNylTiemo+fUoPwwuYRy ihgh9V988Ywzc8a4/eJp/sQ/jUqP2RD9wvrSjgN4FFZJUtio4zWThsBxG Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="313554414" X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="313554414" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 00:09:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="635701324" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga004.jf.intel.com with ESMTP; 15 Feb 2022 00:09:51 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 00:09:51 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 15 Feb 2022 00:09:51 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.44) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 15 Feb 2022 00:09:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wmx7Ktu+ninLbpMsDh9ufTcpkV1WyGW06pJZ23BhPfbGEQh5ju0V2Xbnw9L6sPlVFuraGFuMaepDbFQWP6tC0IUbaK7t+8WYf4CGRbImjBtf7yYR1QT/OC8uJTfVigGBSQ52IshqGDLwW6vlE0LPLI8HHTH3oB6w9uuAZ314mS0qOHAMxflgHcEdshxVnR6sQn4hQ3/gtdfPoEugDV6M/7MoJ4puIeBlyDWxcbySVkjfQR8H+76Q5pNl8zonM2XEy1iZUI2WnNtujTZ4zX+/+kB8Vm641vbDGKtUFKVenVL8lAQPE1nBGIlRrGQ2ZbAmt1UjgQtcPChGELjbZKJ4Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JbjcEBj2WAS3ROSA6fXXaLGBVHC7ymGCJ0rgqetAGYM=; b=kadyzYHN7vQiWWrIL38x1QWGoyHhNnQK+4eOvK68m+uB0siwfCbJRsHfQkbaYnh4iblkAfM/RY/6my459bX0eqUnjUw/uQx4CXh1hcAdgGgSIYc+UO7+HR9NHkSHgfJLzkAgtFH6gLzZ0cm3FPtbbfNTqfH+Jr2/U1bcrBc5b7xQRBlxey1Rqm4csSsWS4TLhJpvx6jqoR+CDQbuxd3JpuFbJr/aUn3oEnG6AQzHoPUwwW+lzcNhvjqVX6ePLfNCq4Vb+gPdwlx+9PjUs2bkQSmaBpRT/qCRbu3CZIGJYGnKiq1jnWJyYnjOlANpVL3dlTB/ogg7QvH49aRBw/2bkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM4PR11MB5277.namprd11.prod.outlook.com (2603:10b6:5:388::23) by CY4PR11MB1413.namprd11.prod.outlook.com (2603:10b6:903:2f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Tue, 15 Feb 2022 08:09:37 +0000 Received: from DM4PR11MB5277.namprd11.prod.outlook.com ([fe80::8ff:19e1:23df:426]) by DM4PR11MB5277.namprd11.prod.outlook.com ([fe80::8ff:19e1:23df:426%5]) with mapi id 15.20.4975.017; Tue, 15 Feb 2022 08:09:37 +0000 From: "Gao, Zhichao" To: "Rehan, MohammedX" , "devel@edk2.groups.io" , "Esakkithevar, Kathappan" , "Ni, Ray" , "Pethaiyan, Madhan" CC: "Thirupugal, MadhaviX" Subject: Re: [PATCH] ShellPkg: Fix Ping GetTimerPeriod API failure Thread-Topic: [PATCH] ShellPkg: Fix Ping GetTimerPeriod API failure Thread-Index: AQHYIkMWnbQpaPSn/EK+FH9q+Q6jC6yUQh2Q Date: Tue, 15 Feb 2022 08:09:37 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6fcf160c-9e13-4cef-ac20-08d9f05a82a4 x-ms-traffictypediagnostic: CY4PR11MB1413:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:651; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Hcp5W7eoDAirsmElWexBiUIMzM+hxmZ4TpaawGyOJ1YgekfqUYBmFCowoZprs3b22Ijl1gWDJm6dmNMkps+ddynandgx80zcJX/mobZRQYR76n6cDXoT3hjL349bJSSgCvnh8jYou2RflLTUKUmuLtuCxn4m26d53xrlYLr9YS665/Q0P0ZQ0EKKCMF/TuIiVSlui5EQmrlFaA2UJFP1n1RoCmvAnFa/HHxdWE8iNErTOaJVVk2P0mB0EnZj2iJr8t9gEY7+W1ZCXmEQgqBZ9bQtM2eAL7t+Uboo2hlaVj8p1hKk15CZRwdW9h3NcWXLiJ3L2gnp1BQtdFyeIR6TEdFE01eUaDrebwnogHGLYqBxBWB0pjW1/WY1s6BKU2gZ/Ea5y/MOyw34pmPh+T5r7E4yKOW+BX7zS9rPzGN/zzMwIwC5iikPXXYLh8vYdtl7a2vMMviMU9nHmL2CmstGdmbg6/4CWfZa39txhbGEnJQOs+yd4+/BgwOrCiJJ0XbxcHN8T1DNs3y8GeYdfZT6rqOVlvr295kLdARq3eVcOMg5hZ71JWuJEQM67foLCWzY+6WDteg/eRFPGt7ZfZAXjL/oKnubl6lQLzsjbf87u/uW2qGOXpHMx1m8h58DCOqOK2eflRGFgaS0LkAQ4nEjVPpBK5+To1IEsftBXcQz1GjxH9/WuBSyX2CcHn8+1R1L+3OM9eAndR/0D+eHNShd8JLIwg1oPu+4tfZZwNRxizf6okaI7ybhSVdS0FPnIU+eXsDRbO7orrQj7Jk0Dom4BiPz0aMWYOc2eNjBYSbb9NU= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5277.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(110136005)(2906002)(55016003)(38070700005)(6636002)(122000001)(508600001)(966005)(316002)(9686003)(82960400001)(53546011)(66446008)(64756008)(71200400001)(33656002)(66946007)(8676002)(6506007)(52536014)(8936002)(26005)(66476007)(86362001)(186003)(7696005)(66556008)(76116006)(83380400001)(38100700002)(4326008)(5660300002)(107886003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WWAKCrGn14w+jut3n8aN+R47CkYWVfRi9pmYY2gweo9l31FtcClRHRyKfc77?= =?us-ascii?Q?x6oS6tCeJ/f1bDDBWX30XR/qHcTX1PqDWZXbBYP5KEGojMnURnnl9Cqc08b+?= =?us-ascii?Q?kINSVMSI7f/Ao1GVyfCUIMJ6Jb+05RdyXv0QXy1d9pUF7pQXtQ9WI62YGkRv?= =?us-ascii?Q?Pi5nqqo56XqgVUjPZcw0HE8QgFim8iiRaJ78NnqH7titIJq0zj9qfkj2SxHg?= =?us-ascii?Q?OLFwMF3V0gmGabxsUCMWeECJ1q4DQQ6fzV+v+JCBjByi6kiK2slxid72hlmv?= =?us-ascii?Q?K0PQsOuAIrFhqjJ+cZ1hHY8qlTks5Pux+wM1zKYOLATiHJBTYAP+9fsW8pTP?= =?us-ascii?Q?cXwP/OjJhm2GCwtj6eXl8FoDSRQ/eky2xXxfRZaQC36t/vP5X0PwkNjk2EkQ?= =?us-ascii?Q?cwoNlV3OTmdSFfJ6l84uC6pFORl7UHGNQ2JgoXPWZTv11Facgl4kTi2Psgil?= =?us-ascii?Q?XLpvM5eucSb5JIbmjd+ukgMovx/eo96R4PyJ5c/z8REGGuA6zlgtS3whMe5k?= =?us-ascii?Q?dkLMYIXddcxTxfR62OlXBMgBZTiuPwEixgDkRNetTa3R6/3hLtLwgVc0EdqX?= =?us-ascii?Q?TInkhdi9tdBryqxFEYr92PzOHo3qu3XUpgldBFraMZcz+la5jhDLolLG36GZ?= =?us-ascii?Q?Sq7P2lMJni2H+TdI87ep+5AAopZN8dxxtQwwVNYzn9YXrnGXz5FAevKwWKKd?= =?us-ascii?Q?Fpu9bWGxea5aion20EHJav/T/GYAkYmOu/NfDSs6b9HP1bDHLuSrbDJDZ9+I?= =?us-ascii?Q?7CxXTrqPC4KQssg5LC+wQcuXqAzGLjKQXt5lLkkxqdG8+7BNSpcaWir4v88/?= =?us-ascii?Q?qIQOUy4aJ/gW38G3pTbYhsgmnrCoWGTVS/A1ZdpLIyBO2lwgadIzqQt1FfkS?= =?us-ascii?Q?rKk4ZtgvtcVWUlS7b4cteq3aFETWqLovmLBCzgRwCppAw/si7QlOpmhTfIaC?= =?us-ascii?Q?29ITGeahqtT6l7GvI5kiO4+t+cCDpGpcbnY+tcfbiaZj6l2UixH90KxZrp2g?= =?us-ascii?Q?c1dZ4rm+yFEvzVdgSCp3Q20jNxfwwpkzCHDXmExCUhSePQkCXkTs0tPsv9tn?= =?us-ascii?Q?VD22pniTxOeyZzg2/4UfKoHLoCcZ9lzSI8yPbaL3ZAOsiksqZZXFA8zyT5kB?= =?us-ascii?Q?0DcrAWET07btO7fk3MrojFYA35PfFcQaAqMQHqM+uz4nblaKSyrjGdzyCG50?= =?us-ascii?Q?AZeb1kVc0SrmLrkSdqyrheMk86YmR9zHlNnUIyKnQLTgiFkpfN9XBtU3OqAZ?= =?us-ascii?Q?TV1P6PuA5TTEh1afqhiVY5go4V+OGg5SsKZlMfVxabn53M3OlTNmPNmq488U?= =?us-ascii?Q?wnxbDCxbmSnSH45Qsii0ktvudcVTcH57JeO8cj+plr8FToSY0EGVuBgJ8e2a?= =?us-ascii?Q?Jerwx1suYIFsg9ldtkIc1zmucocbPxU0kC6a0BhK/hiFhpIuIGSatuuNvsfb?= =?us-ascii?Q?RE3xBmUEIBIFYsSp4Ior7qjPxCTmmBQu8U8dsMjNvvOwQ6Z81axe5rz0ZHIL?= =?us-ascii?Q?6pWy0aqojeqhst/baUAVGtkRWCecOXRltV1ry33TbkEYDM7Jv/KmVOVVgTyq?= =?us-ascii?Q?JPxsNGB2Leuz2/+j0tti+8a9MOfG8atPPt2naVuiwqPfPRKbRn5PxSmIgUiD?= =?us-ascii?Q?8WJzhsfHfFibGYgoPY7IrYw=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5277.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6fcf160c-9e13-4cef-ac20-08d9f05a82a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 08:09:37.8095 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m9dv7QXdarxyEgEmSfdp0gNiL2RV65g0NfI8XE0K1+eTXlYSV7/BOSyaM0ReegukCfvJEzEDQSEBU9mftHuw6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1413 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: Rehan, MohammedX > Sent: Tuesday, February 15, 2022 4:07 PM > To: devel@edk2.groups.io; Esakkithevar, Kathappan > ; Gao, Zhichao > ; Ni, Ray ; Pethaiyan, Madhan > > Cc: Thirupugal, MadhaviX ; Rehan, > MohammedX > Subject: [PATCH] ShellPkg: Fix Ping GetTimerPeriod API failure >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3819 >=20 > Ping GetTimerPeriod API returns sometime zero value when StallCounter has > smaller value than RttTimerTick (divide by zero) which results some failu= re at > ping UEFI shell command >=20 > Signed-off-by: MohammedX Rehan > --- > ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c > index ec1e0a188b..6a002b15e5 100644 > --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c > +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c > @@ -259,9 +259,11 @@ GetTimerPeriod ( > EFI_EVENT TimerEvent; UINT32 StallCounter; EFI_TPL OldT= pl;+ > UINT32 TimerPeriod; RttTimerTick =3D 0; StallCounter =3D 0;+ T= imerPeriod =3D > 0; Status =3D gBS->CreateEvent ( EVT_TIMER | > EVT_NOTIFY_SIGNAL,@@ -295,7 +297,12 @@ GetTimerPeriod ( > gBS->SetTimer (TimerEvent, TimerCancel, 0); gBS->CloseEvent > (TimerEvent); - return StallCounter / RttTimerTick;+ TimerPeriod =3D > StallCounter / RttTimerTick;+ if (TimerPeriod !=3D 0) {+ return Timer= Period;+ } > else {+ return 1;+ } } /**-- > 2.30.0.windows.2