From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.8226.1624866838569316954 for ; Mon, 28 Jun 2021 00:53:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Ev2gsznj; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: zhichao.gao@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10028"; a="206080391" X-IronPort-AV: E=Sophos;i="5.83,305,1616482800"; d="scan'208";a="206080391" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2021 00:53:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,305,1616482800"; d="scan'208";a="475472848" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga004.fm.intel.com with ESMTP; 28 Jun 2021 00:53:55 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 28 Jun 2021 00:53:54 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 28 Jun 2021 00:53:54 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Mon, 28 Jun 2021 00:53:54 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Mon, 28 Jun 2021 00:53:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Il0lszUI2ZRlagwW2jFMT1uJIwEttGLzAcnsh/Wl9v23SdrLysii+puk31qlh0TZ4fwDWJsh/GBIfnyHRBv3M8r+2EGQqI+9DGOCg/1uH53uDbntncOygtFg5igoOw1RRMshMG6aEEMRcMxF5+judNYukI+8goMW9VDP/qgL7wE6DTlxNR5ibJnKUCnGWVcyiTIwlI2kJjn2nIOxGw7yBOhxgBT505+2mqZtG37l0tmqfzVCYs23coelM4DD8aSgO3h4XgMukVVhT6euCc0CDJRNR4x7VasSCtIvrmqpzHy4kr84Gm2mbKXGD2aOEGWI4P0NJ2j0GoFJ3YzZrP9rGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z/QH8RCr7SCzhwswwD36P3ZFtOLGVqIl1XDPQL4+nng=; b=HYKg2waolhjMYh1AXz2d0xVoYkcP5AkXQ/L/bW5Lvc1k5DrycZpeAf0vXK4KvUBgrV1iJ1lVI1gkS4PuYxIsfFeB80Yagn/b0pUDRydaDRKGnqZaQwMlNZVHv5lXfh+k7FdspTrFvZSz94FMALCBDUhEbJ92kdufCDfhC1z2UHB2J36c2XYaPmTckLWkBEC2cP30ZMpRSrhV5yfpLtfpDWg7oFM04NCvY7S2EvoHI7LkagLkCe8a8iYWajPLooxYYHMVGK8OM7PZ3kh8KmYCG6At8iDYRzDT2a7ANsWQffF3CFhmDgdy4QFsDp70Mly0VjfezMB0+Cc7us+p8mOEcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z/QH8RCr7SCzhwswwD36P3ZFtOLGVqIl1XDPQL4+nng=; b=Ev2gsznj4Xdfl9kT/nYbDWF95GmLxDmeWG8F6tGiZj2I6247FHjMZOJZpv4C5OP4JofWr4xJfQ/qZB5uGp1hT9frt2oGU/U9Z6hGPu3QFyIEG8Fgu7NSeHjTu+0I0xKRz7a7mFVgO7LHfwCru8BnHxHQDC476QqzCqs3NIRBIqg= Received: from DM4PR11MB5277.namprd11.prod.outlook.com (2603:10b6:5:388::23) by DM6PR11MB3706.namprd11.prod.outlook.com (2603:10b6:5:13e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.24; Mon, 28 Jun 2021 07:53:52 +0000 Received: from DM4PR11MB5277.namprd11.prod.outlook.com ([fe80::c4ba:12e7:71d3:a5b3]) by DM4PR11MB5277.namprd11.prod.outlook.com ([fe80::c4ba:12e7:71d3:a5b3%7]) with mapi id 15.20.4264.026; Mon, 28 Jun 2021 07:53:52 +0000 From: "Gao, Zhichao" To: Sami Mujawar , "devel@edk2.groups.io" CC: "Alexei.Fedorov@arm.com" , "Matteo.Carlini@arm.com" , "Ben.Adderson@arm.com" , "Ni, Ray" , "nd@arm.com" Subject: Re: [PATCH v2 3/8] ShellPkg: Acpiview: Abbreviate field names to preserve alignment Thread-Topic: [PATCH v2 3/8] ShellPkg: Acpiview: Abbreviate field names to preserve alignment Thread-Index: AQHXY178J4CVXiMWRkiIJW9TkI6zgqspHq+Q Date: Mon, 28 Jun 2021 07:53:51 +0000 Message-ID: References: <20210617095538.93280-1-sami.mujawar@arm.com> <20210617095538.93280-4-sami.mujawar@arm.com> In-Reply-To: <20210617095538.93280-4-sami.mujawar@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.143.3] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d2128f6e-ea28-40bb-f30c-08d93a09df0e x-ms-traffictypediagnostic: DM6PR11MB3706: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9c2Lxhw9dQD/wB5rG913F39ojjMJ4kwIUhMgb1ByEBvLRDoxDRpZFwuPEQjZw0xqmN1EPyPU/EikJgt035C2BK3fpuotqyck5VROpM5FR8xnyE2TcpoJ1MpFr3udHE/LA8z2S1kYot1WUe0n1eiW4+l0FJexr4Fhib8z8KlSQzeotSk+xPA44yYhyH/GbTQ+ZKxwd9500ytMNn2rFR0ttuXndXiM6Bw/sJ6tch8StlbJZxLscJkDju6GtZswXTxbS9aLAjr0TOVn4GAdJjjoGHMMmz0tTxPM7qExb+QTJV5sQ7aChfMDTbu54ASqp7vsGnedzA9BUTLkLRSMvvle8tLxMKAdMAntm3an2N4zxT3+e/2UjPEYeZEZnAK0huNEm14WiU3V7lwqcgDIciqbk2frxgCVu72mi4P72w+70a/RhbPK/kXtTcUDzt9+7Y7TKOEvihWLP7Noyo6jjEXt34BoNiVT4FyRtSPdd7pZC7nbbGiqYBALlOYdllw3dVqRLVwkjdALKoGipGKFtXuPTHK+hDeGqs0cYl/gcRmK2VtGJb+SwyHLRSOBnIUA/LyIwImDbrVRLEALCTrpHbNyhsAZSVIM5nvTt54l+VLznhI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5277.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(376002)(346002)(136003)(39860400002)(396003)(76116006)(6506007)(186003)(9686003)(86362001)(110136005)(122000001)(55016002)(38100700002)(64756008)(7696005)(8936002)(4326008)(66446008)(54906003)(8676002)(2906002)(53546011)(66946007)(478600001)(71200400001)(66476007)(33656002)(52536014)(26005)(83380400001)(316002)(66556008)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pKqU2eAg6TQGDHrgn85hWgegnc10B7VWojK5J3MZbhbqV1P+1X7RhrjxYqGN?= =?us-ascii?Q?ngKaAMMvk3wy/u7xJOz5/bqNqq2QN46/E0xKUBQcblydf4oh/js3VnBQi3GE?= =?us-ascii?Q?q7m/d2lPYcYXWReZ7WjsgkIacpygHP4DgEINeQsmyYe+SChVAkJi4byW60Wb?= =?us-ascii?Q?NJxpS9/j0+OEOh+XNW3Kf1swbNx0nyhSbaqwdeL3GXYGbifx6EejDbqz8yBk?= =?us-ascii?Q?XvMFK+Fn8lZBE78obydUAG6kcGKVNbgcTx3W/36F4xVz20zotitrKMBc/ung?= =?us-ascii?Q?+widuTIWB7bwGBx0eBhrggFwGnccOjiG4icZM937G2JadvzMN5BMldZPspyG?= =?us-ascii?Q?vH/1iyjWQ7UEgvw909z0pl2CeV2lalV6IuEwxG1MZk8GmY6z5RATCIYQqg8z?= =?us-ascii?Q?hj9CQLw3u64NRXBd/m0tQfMLwzoFg127Oz+2jA2xR4EMTbXQoMm061I8TFsu?= =?us-ascii?Q?TusNbucUz0YqVyBQCsfsrCVr7Bq1dUZkgGUE4PMijwdPZN8m3UQjnKTRukUp?= =?us-ascii?Q?i4mCQb0GI0e/a0SNNnIkJOK6iub5GCznZc5f9MA2ix9oRbKrARm/yqLCa5zi?= =?us-ascii?Q?C7SAcgQyG08zCAaA5NBLXDJLTigimqOm6PGyYOBpssO7ZtbnN5TujThzyrBF?= =?us-ascii?Q?J9uiKRaAG/TaRZhn/Y2pCTPhGjb5Gaf2ydvmy04s5pyI8n3rq+s0Szi9A5Bz?= =?us-ascii?Q?uA8vXVDGe5/94UMIjHBW63NkNAOVHH1AWgdycsjqBjMbcXSpOcJessHUusDy?= =?us-ascii?Q?GR6AleCCRixTPDc6dg5e2ea33gY+GX13maKrPdzz5eRNbjNhtV8pD1YAE0G7?= =?us-ascii?Q?eQl8NR2WKvE3Avvx4dO0jMN6Kj78Uxu+3lWccXeF80IpAsWrsEqVQpueXCV3?= =?us-ascii?Q?e5WafWVp20EyLgofTZxYb9REaJghvOeTw849ihqkaieH79unWN2SEEiqD6Hu?= =?us-ascii?Q?uC1h1vWHjQtA5Mt/x38SYIjdz7GcFucjSZLR1ChZgNp3V48bViCCpvW6A8XP?= =?us-ascii?Q?HDyMSdcYXdsJt5pZyqhuwEY7G6+6mQyjbO3kR+4I3YiH7DwiL6yLsBsjwrJK?= =?us-ascii?Q?5wBP+ddUYRBXwPAJHCAxXYObVfxLY82KwYLArxGIWCFE0syDooAVpsa0uBTp?= =?us-ascii?Q?WPtARGMU3wlqErZKnZF9rngMc8Rtmb7u7dAdl8KVvXz45a9r7Hm8/LXQlxyG?= =?us-ascii?Q?tRlhLE7gcjFZgw1ndNYW9H1Kyf3OUF8j4IEVNrabOhPj0sbLju6cL8Y14VOA?= =?us-ascii?Q?J3L0Mc1sek9F6NPffuw9yBoqOyWjlLqPb1lN7Ph+K68oeQ2Ht7t9m4mvML9B?= =?us-ascii?Q?4PFWwiM5e3cnnA0HD0zSlXys?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5277.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2128f6e-ea28-40bb-f30c-08d93a09df0e X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2021 07:53:52.0025 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OERAwzKQVGBV3anUWyAWsxsPS/nB85oHoA07cUCweEySDTvTbLbwLF+5by3bD9l3gw8ijEH4KHsp2rsM43lFDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3706 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: Sami Mujawar > Sent: Thursday, June 17, 2021 5:56 PM > To: devel@edk2.groups.io > Cc: Sami Mujawar ; Alexei.Fedorov@arm.com; > Matteo.Carlini@arm.com; Ben.Adderson@arm.com; Ni, Ray > ; Gao, Zhichao ; nd@arm.com > Subject: [PATCH v2 3/8] ShellPkg: Acpiview: Abbreviate field names to > preserve alignment >=20 > Some field names in the IORT table parser were longer than the > OUTPUT_FIELD_COLUMN_WIDTH plus indentation, resulting in loss of the > output print alignment. Therefore, abbreviate the field names. >=20 > Signed-off-by: Sami Mujawar > --- >=20 > Notes: > v2: > - No code change since v1. Re-sending with v2 series. [SAMI] >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | > 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c > index > f7447947b2308d35d4d2890373778f0fd2f97f9e..fcecaff5134256497bda87241f3 > 39076897c3ece 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortPars > +++ er.c > @@ -1,11 +1,14 @@ > /** @file > IORT table parser >=20 > - Copyright (c) 2016 - 2020, ARM Limited. All rights reserved. > + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > - - IO Remapping Table, Platform Design Document, Revision D, March 20= 18 > + - IO Remapping Table, Platform Design Document, Revision D, March > + 2018 > + > + @par Glossary: > + - Ref - Reference > **/ >=20 > #include > @@ -144,15 +147,15 @@ STATIC CONST ACPI_PARSER > IortNodeSmmuV1V2Parser[] =3D { > {L"Span", 8, 24, L"0x%lx", NULL, NULL, NULL, NULL}, > {L"Model", 4, 32, L"%d", NULL, NULL, NULL, NULL}, > {L"Flags", 4, 36, L"0x%x", NULL, NULL, NULL, NULL}, > - {L"Reference to Global Interrupt Array", 4, 40, L"0x%x", NULL, NULL, N= ULL, > + {L"Global Interrupt Array Ref", 4, 40, L"0x%x", NULL, NULL, NULL, > NULL}, > {L"Number of context interrupts", 4, 44, L"%d", NULL, > (VOID**)&InterruptContextCount, NULL, NULL}, > - {L"Reference to Context Interrupt Array", 4, 48, L"0x%x", NULL, > + {L"Context Interrupt Array Ref", 4, 48, L"0x%x", NULL, > (VOID**)&InterruptContextOffset, NULL, NULL}, > {L"Number of PMU Interrupts", 4, 52, L"%d", NULL, > (VOID**)&PmuInterruptCount, NULL, NULL}, > - {L"Reference to PMU Interrupt Array", 4, 56, L"0x%x", NULL, > + {L"PMU Interrupt Array Ref", 4, 56, L"0x%x", NULL, > (VOID**)&PmuInterruptOffset, NULL, NULL}, >=20 > // Interrupt Array > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'