* [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 fields
@ 2022-04-11 7:17 Bo Chang Ke
2022-04-12 1:01 ` Gao, Zhichao
0 siblings, 1 reply; 5+ messages in thread
From: Bo Chang Ke @ 2022-04-11 7:17 UTC (permalink / raw)
To: devel; +Cc: Ray Ni, Zhichao Gao
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3900
update smbiosview type 41 related fileds.
Signed-off-by: Bo Chang Ke <bo-changx.ke@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
---
.../SmbiosView/QueryTable.c | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index c4a6acb167..7ec6d2b5f1 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -1766,6 +1766,30 @@ TABLE_ITEM OnboardDeviceTypesTable[] = {
0x0A,
L" Sas Controller"
},
+ {
+ 0x0B,
+ L" Wireless LAN"
+ },
+ {
+ 0x0C,
+ L" Bluetooth"
+ },
+ {
+ 0x0D,
+ L" WWAN"
+ },
+ {
+ 0x0E,
+ L" embedded Multi-Media Controller"
+ },
+ {
+ 0x0F,
+ L" NVMe Controller"
+ },
+ {
+ 0x10,
+ L" UFS Controller"
+ }
};
TABLE_ITEM SELTypesTable[] = {
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 fields
2022-04-11 7:17 [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 fields Bo Chang Ke
@ 2022-04-12 1:01 ` Gao, Zhichao
2022-04-12 1:55 ` Ni, Ray
0 siblings, 1 reply; 5+ messages in thread
From: Gao, Zhichao @ 2022-04-12 1:01 UTC (permalink / raw)
To: Ke, Bo-ChangX, devel@edk2.groups.io; +Cc: Ni, Ray
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Thanks,
Zhichao
> -----Original Message-----
> From: Ke, Bo-ChangX <bo-changx.ke@intel.com>
> Sent: Monday, April 11, 2022 3:18 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5
> fields
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3900
>
> update smbiosview type 41 related fileds.
>
> Signed-off-by: Bo Chang Ke <bo-changx.ke@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> ---
> .../SmbiosView/QueryTable.c | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> index c4a6acb167..7ec6d2b5f1 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> @@ -1766,6 +1766,30 @@ TABLE_ITEM OnboardDeviceTypesTable[] = {
> 0x0A,
> L" Sas Controller"
> },
> + {
> + 0x0B,
> + L" Wireless LAN"
> + },
> + {
> + 0x0C,
> + L" Bluetooth"
> + },
> + {
> + 0x0D,
> + L" WWAN"
> + },
> + {
> + 0x0E,
> + L" embedded Multi-Media Controller"
> + },
> + {
> + 0x0F,
> + L" NVMe Controller"
> + },
> + {
> + 0x10,
> + L" UFS Controller"
> + }
> };
>
> TABLE_ITEM SELTypesTable[] = {
> --
> 2.32.0.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 fields
2022-04-12 1:01 ` Gao, Zhichao
@ 2022-04-12 1:55 ` Ni, Ray
0 siblings, 0 replies; 5+ messages in thread
From: Ni, Ray @ 2022-04-12 1:55 UTC (permalink / raw)
To: Gao, Zhichao, Ke, Bo-ChangX, devel@edk2.groups.io
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: Tuesday, April 12, 2022 9:02 AM
> To: Ke, Bo-ChangX <bo-changx.ke@intel.com>; devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>
> Subject: RE: [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 fields
>
> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
>
> Thanks,
> Zhichao
>
> > -----Original Message-----
> > From: Ke, Bo-ChangX <bo-changx.ke@intel.com>
> > Sent: Monday, April 11, 2022 3:18 PM
> > To: devel@edk2.groups.io
> > Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
> > Subject: [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5
> > fields
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3900
> >
> > update smbiosview type 41 related fileds.
> >
> > Signed-off-by: Bo Chang Ke <bo-changx.ke@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > ---
> > .../SmbiosView/QueryTable.c | 24 +++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> >
> > diff --git
> > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> > c
> > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> > c
> > index c4a6acb167..7ec6d2b5f1 100644
> > ---
> > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> > c
> > +++
> > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> > c
> > @@ -1766,6 +1766,30 @@ TABLE_ITEM OnboardDeviceTypesTable[] = {
> > 0x0A,
> > L" Sas Controller"
> > },
> > + {
> > + 0x0B,
> > + L" Wireless LAN"
> > + },
> > + {
> > + 0x0C,
> > + L" Bluetooth"
> > + },
> > + {
> > + 0x0D,
> > + L" WWAN"
> > + },
> > + {
> > + 0x0E,
> > + L" embedded Multi-Media Controller"
> > + },
> > + {
> > + 0x0F,
> > + L" NVMe Controller"
> > + },
> > + {
> > + 0x10,
> > + L" UFS Controller"
> > + }
> > };
> >
> > TABLE_ITEM SELTypesTable[] = {
> > --
> > 2.32.0.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 fields
@ 2022-04-08 16:26 Bo Chang Ke
2022-04-11 3:43 ` Zeng, Star
0 siblings, 1 reply; 5+ messages in thread
From: Bo Chang Ke @ 2022-04-08 16:26 UTC (permalink / raw)
To: devel; +Cc: Dandan Bi, Star Zeng
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3900
update smbiosview type 41 related fileds.
Signed-off-by: Bo Chang Ke <bo-changx.ke@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
---
.../SmbiosView/QueryTable.c | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index c4a6acb167..7ec6d2b5f1 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -1766,6 +1766,30 @@ TABLE_ITEM OnboardDeviceTypesTable[] = {
0x0A,
L" Sas Controller"
},
+ {
+ 0x0B,
+ L" Wireless LAN"
+ },
+ {
+ 0x0C,
+ L" Bluetooth"
+ },
+ {
+ 0x0D,
+ L" WWAN"
+ },
+ {
+ 0x0E,
+ L" embedded Multi-Media Controller"
+ },
+ {
+ 0x0F,
+ L" NVMe Controller"
+ },
+ {
+ 0x10,
+ L" UFS Controller"
+ }
};
TABLE_ITEM SELTypesTable[] = {
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 fields
2022-04-08 16:26 Bo Chang Ke
@ 2022-04-11 3:43 ` Zeng, Star
0 siblings, 0 replies; 5+ messages in thread
From: Zeng, Star @ 2022-04-11 3:43 UTC (permalink / raw)
To: Ke, Bo-ChangX, devel@edk2.groups.io; +Cc: Bi, Dandan, Ni, Ray, Gao, Zhichao
Personally, I think "eMMC" should be enough to instead " embedded Multi-Media Controller ".
Others look good to me.
And you'd better to get RB from ShellPkg's maintainer (Cced).
Thanks,
Star
-----Original Message-----
From: Ke, Bo-ChangX <bo-changx.ke@intel.com>
Sent: Saturday, April 9, 2022 12:26 AM
To: devel@edk2.groups.io
Cc: Bi, Dandan <dandan.bi@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 fields
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3900
update smbiosview type 41 related fileds.
Signed-off-by: Bo Chang Ke <bo-changx.ke@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
---
.../SmbiosView/QueryTable.c | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index c4a6acb167..7ec6d2b5f1 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -1766,6 +1766,30 @@ TABLE_ITEM OnboardDeviceTypesTable[] = {
0x0A,
L" Sas Controller"
},
+ {
+ 0x0B,
+ L" Wireless LAN"
+ },
+ {
+ 0x0C,
+ L" Bluetooth"
+ },
+ {
+ 0x0D,
+ L" WWAN"
+ },
+ {
+ 0x0E,
+ L" embedded Multi-Media Controller"
+ },
+ {
+ 0x0F,
+ L" NVMe Controller"
+ },
+ {
+ 0x10,
+ L" UFS Controller"
+ }
};
TABLE_ITEM SELTypesTable[] = {
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-12 1:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-11 7:17 [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 fields Bo Chang Ke
2022-04-12 1:01 ` Gao, Zhichao
2022-04-12 1:55 ` Ni, Ray
-- strict thread matches above, loose matches on Subject: below --
2022-04-08 16:26 Bo Chang Ke
2022-04-11 3:43 ` Zeng, Star
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox