public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: "Ke, Bo-ChangX" <bo-changx.ke@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Liu, Zhiguang" <zhiguang.liu@intel.com>,
	"Bi, Dandan" <dandan.bi@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH v2] MdePkg: Update smbiosview type 9 with SMBIOS 3.5 fields
Date: Thu, 14 Apr 2022 02:24:48 +0000	[thread overview]
Message-ID: <DM4PR11MB5277B40FA9F685292D06A0F3F6EF9@DM4PR11MB5277.namprd11.prod.outlook.com> (raw)
In-Reply-To: <bf5f88cfd424bc05c3c2c3a436edb83a85ad90b6.1649819610.git.bo-changx.ke@intel.com>

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Ke, Bo-ChangX <bo-changx.ke@intel.com>
> Sent: Wednesday, April 13, 2022 11:14 AM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Gao, Zhichao
> <zhichao.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Zeng, Star
> <star.zeng@intel.com>
> Subject: [PATCH v2] MdePkg: Update smbiosview type 9 with SMBIOS 3.5 fields
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3896
> 
> update smbiosview type 9 related fileds.
> 
> Signed-off-by: Bo Chang Ke <bo-changx.ke@intel.com>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/SmBios.h | 49 +++++++++++++++++++++++-
>  1 file changed, 48 insertions(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index 2b1567b052..52f2e35ee9 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -1306,6 +1306,11 @@ typedef enum {
>    SlotTypePciExpressMini52pinWithBSKO    = 0x21,    ///< PCI Express Mini 52-pin
> (CEM spec. 2.0) with bottom-side keep-outs.
>    SlotTypePciExpressMini52pinWithoutBSKO = 0x22,    ///< PCI Express Mini 52-
> pin (CEM spec. 2.0) without bottom-side keep-outs.
>    SlotTypePciExpressMini76pin            = 0x23,    ///< PCI Express Mini 76-pin (CEM
> spec. 2.0) Corresponds to Display-Mini card.
> +  SlotTypePCIExpressGen4SFF_8639         = 0x24,    ///< U.2
> +  SlotTypePCIExpressGen5SFF_8639         = 0x25,    ///< U.2
> +  SlotTypeOCPNIC30SmallFormFactor        = 0x26,    ///< SFF
> +  SlotTypeOCPNIC30LargeFormFactor        = 0x27,    ///< LFF
> +  SlotTypeOCPNICPriorto30                = 0x28,
>    SlotTypeCXLFlexbus10                   = 0x30,
>    SlotTypePC98C20                        = 0xA0,
>    SlotTypePC98C24                        = 0xA1,
> @@ -1335,7 +1340,16 @@ typedef enum {
>    SlotTypePciExpressGen4X2               = 0xBA,
>    SlotTypePciExpressGen4X4               = 0xBB,
>    SlotTypePciExpressGen4X8               = 0xBC,
> -  SlotTypePciExpressGen4X16              = 0xBD
> +  SlotTypePciExpressGen4X16              = 0xBD,
> +  SlotTypePCIExpressGen5                 = 0xBE,
> +  SlotTypePCIExpressGen5X1               = 0xBF,
> +  SlotTypePCIExpressGen5X2               = 0xC0,
> +  SlotTypePCIExpressGen5X4               = 0xC1,
> +  SlotTypePCIExpressGen5X8               = 0xC2,
> +  SlotTypePCIExpressGen5X16              = 0xC3,
> +  SlotTypePCIExpressGen6andBeyond        = 0xC4,
> +  SlotTypeEnterpriseandDatacenter1UE1FormFactorSlot = 0xC5,
> + SlotTypeEnterpriseandDatacenter3E3FormFactorSlot  = 0xC6
>  } MISC_SLOT_TYPE;
> 
>  ///
> @@ -1358,6 +1372,39 @@ typedef enum {
>    SlotDataBusWidth32X     = 0x0E     ///< Or X32
>  } MISC_SLOT_DATA_BUS_WIDTH;
> 
> +///
> +/// System Slots - Slot Physical Width.
> +///
> +typedef enum {
> +  SlotPhysicalWidthOther   = 0x01,
> +  SlotPhysicalWidthUnknown = 0x02,
> +  SlotPhysicalWidth8Bit    = 0x03,
> +  SlotPhysicalWidth16Bit   = 0x04,
> +  SlotPhysicalWidth32Bit   = 0x05,
> +  SlotPhysicalWidth64Bit   = 0x06,
> +  SlotPhysicalWidth128Bit  = 0x07,
> +  SlotPhysicalWidth1X      = 0x08,    ///< Or X1
> +  SlotPhysicalWidth2X      = 0x09,    ///< Or X2
> +  SlotPhysicalWidth4X      = 0x0A,    ///< Or X4
> +  SlotPhysicalWidth8X      = 0x0B,    ///< Or X8
> +  SlotPhysicalWidth12X     = 0x0C,    ///< Or X12
> +  SlotPhysicalWidth16X     = 0x0D,    ///< Or X16
> +  SlotPhysicalWidth32X     = 0x0E     ///< Or X32
> +} MISC_SLOT_PHYSICAL_WIDTH;
> +
> +///
> +/// System Slots - Slot Information.
> +///
> +typedef enum {
> +  others = 0x00,
> +  Gen1   = 0x01,
> +  Gen2   = 0x01,
> +  Gen3   = 0x03,
> +  Gen4   = 0x04,
> +  Gen5   = 0x05,
> +  Gen6   = 0x06
> +} MISC_SLOT_INFORMATION;
> +
>  ///
>  /// System Slots - Current Usage.
>  ///
> --
> 2.32.0.windows.1


  reply	other threads:[~2022-04-14  2:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13  3:14 [PATCH v2] MdePkg: Update smbiosview type 9 with SMBIOS 3.5 fields Bo Chang Ke
2022-04-14  2:24 ` Gao, Zhichao [this message]
2022-04-15  8:35   ` Bo Chang Ke
2022-04-17  3:24     ` 回复: [edk2-devel] " gaoliming
2022-04-19  5:08       ` Gao, Zhichao
2022-04-19 23:49         ` 回复: " gaoliming
     [not found]         ` <16E771221F3810EE.23693@groups.io>
2022-04-21  1:03           ` gaoliming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR11MB5277B40FA9F685292D06A0F3F6EF9@DM4PR11MB5277.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox