From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web08.8379.1636436795629237173 for ; Mon, 08 Nov 2021 21:46:36 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=JkB0FyQz; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: zhichao.gao@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10162"; a="219584316" X-IronPort-AV: E=Sophos;i="5.87,219,1631602800"; d="scan'208";a="219584316" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2021 21:46:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,219,1631602800"; d="scan'208";a="601685321" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga004.jf.intel.com with ESMTP; 08 Nov 2021 21:46:09 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 8 Nov 2021 21:46:08 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 8 Nov 2021 21:46:08 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 8 Nov 2021 21:46:08 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 8 Nov 2021 21:46:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I8ounoMqndKDMb2UgRefKQLNHacL1iixxGXHgxJFMl7YMXbQ7H7KBQ77CvU4dfQAN36rBagyuiLClLq1HjjKZ75EFo23nPyJ9uq6XEo7KRyLSrfv4rQ50hZqJ0taH7eWIOj85BO1m7RpZ31cXdMKCRS/ad/SSGaatYY5kKtEkYUHvpN5zF0PsB9+PbcveXp2Ou3DXmC417AgWCuifVCGyERpxU6quGow3y0OiHrddFG2F7v+Xqem4HVUIqUupbLoAi209WTypY12bwQtC3LvCDQNrq/2lXbEKGQP4Th0n1/F9nS37nuHWe01GhiAVLABVF82SS99u5R/MGvKXR5YFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kAeU5/02kA3EcNsVl0xt+Kp0LX+ojNP6dWI3zFasBTY=; b=QoSPDqmwcTRmvUZ0BS54TOSrtk+kktolw2e5ZWp2tLzox3cTEGQz/z/Vx+KzyXIH2TQWYkIci4eARKOX43HEuyI51vpsLF2j11Er2mhKPvyCa30rjhFySEG+0Zk4owaPygVkozGs0jINJK1wx5es4NiexBqXmoT6o2b2eTzqg3LF4YMTVEYAphoZfcdW3aG73QtkulNNzIatjDC0hUAffBL/gT91Y0G2tw3GEaYf3ISnGDWH6h6Q5qdLqB2G6gOixvpCyp+Vq3A3k3YA84E73xUc5sdGZ99fNJlAkg+i8dncFLMe98WFJQvT9sEJryI2COTkyNQcPO1eAyOw/xiupw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kAeU5/02kA3EcNsVl0xt+Kp0LX+ojNP6dWI3zFasBTY=; b=JkB0FyQzComQzy5wFT2dMLUJf+wncAv6DcxhETpa4C1wbU4m8yRSZKcAy4nV0jgwQjPJBxwQGM+TE0dKvZu76w7fb8gJOzt0mv3xtU1lklamGwq/XFcULaMUO5RdnIQ+uVQbCtvaUwOGl1c+3Z7C1+mUkHiUncJlpuwZefMhn1k= Received: from DM4PR11MB5277.namprd11.prod.outlook.com (2603:10b6:5:388::23) by DM5PR11MB1787.namprd11.prod.outlook.com (2603:10b6:3:112::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13; Tue, 9 Nov 2021 05:46:06 +0000 Received: from DM4PR11MB5277.namprd11.prod.outlook.com ([fe80::e5c7:5202:3900:e51c]) by DM4PR11MB5277.namprd11.prod.outlook.com ([fe80::e5c7:5202:3900:e51c%5]) with mapi id 15.20.4649.019; Tue, 9 Nov 2021 05:46:06 +0000 From: "Gao, Zhichao" To: Joey Gouly , "devel@edk2.groups.io" CC: "sami.mujawar@arm.com" , "Ni, Ray" , "nd@arm.com" Subject: Re: [PATCH v2 1/5] ShellPkg: Replace 'Trace' parameter with 'ParseFlags' Thread-Topic: [PATCH v2 1/5] ShellPkg: Replace 'Trace' parameter with 'ParseFlags' Thread-Index: AQHXqwmnxTAR+HRO3EmqNmIZ4KrW76v7A49g Date: Tue, 9 Nov 2021 05:46:06 +0000 Message-ID: References: <20210916144605.42071-1-joey.gouly@arm.com> <20210916144605.42071-2-joey.gouly@arm.com> In-Reply-To: <20210916144605.42071-2-joey.gouly@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c75b01a0-87cd-467f-d869-08d9a344392c x-ms-traffictypediagnostic: DM5PR11MB1787: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: V0ZZ2cSbbUYHMB7bPUJjHo7HZ6V1UfRpsEUyTu6EBbMkTvCujNfFnyv1SoZ5lLNf2bKwKcpCfxf/VUYj5YBHzBts1EILEtbxAxsxBYX3/NtLyFj3PA+fRinbV+7rUYTcMThZPOkvzEcIZtKMWkoZpIQMj9p/SywiuYwHiiLbDjcK4ALd154teE/H007azi18cp2rWGQG6fFZgTgcK7sTewaUeWUZCP95mVCtAjqWmNCC4D+XV9kPybCmGXks35r6ArP9R6Adlc/w7pkrV5AsFZAJVRCMO0nC92uZJFgOSXqPinZABVDZxJ+Yqskf6BA93ebefdY2qh9lZJ/9XCHEYhqDrJSqDaaKgjOEBdcwi+2Nryy+ty/6GoMCEyve/e1FnBDDHNXWxTyQn9d6kn5Kk6LT9z6ZN8+6ehsfeO6cXkmkfFAQCRLa4osg5WnunMG+Ssv0sxkpRMrmrDRsUXNUICTb5eSdHnoty9v+WxRDKvaI8p257ph4wak2/hnAzrpp9a/kUTz4mgrL2ZrEA52PJCdgt0Rs7NqFnKHbwAfY9Eg/9ws7ZzFCnDJLU0mWix3Dd6DYtlkkW1je77C9fvd5IqeH3iYfNVGS6HvuHeXTKmvGRUcFhlrHtKVeijNjxQu/B/wUEdYk8AdPzfSthHyt64i+trWdNjAGgRYRnxro5T4xGu3JTgJN3hSIyulPWy3xnrxQHUnbgN0BXl+YBemCvubBCjQHmceHNOK59OeJlUoXmJ9cZ/A0DEFzzWXWKk0F7uvelSnQOSIk/lNlhdJR0FGrFIUcbLdLLM9Gf0LrqDc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5277.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(110136005)(66446008)(7696005)(9686003)(316002)(186003)(33656002)(66946007)(4326008)(64756008)(76116006)(19627235002)(54906003)(53546011)(5660300002)(6506007)(66556008)(26005)(52536014)(8936002)(82960400001)(508600001)(30864003)(8676002)(66476007)(55016002)(38100700002)(122000001)(2906002)(71200400001)(83380400001)(38070700005)(559001)(579004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?w8X3EMMUxd/MMA3o62nERJYwrQCWY8EDJSQklnpCd70vr8zIcnxK7LH2E6xt?= =?us-ascii?Q?wYRvFWlpWLCyJQRT7x0ZGH4m5Y5jXXV6YpAEt+jQe1dhxIbTi+yfG2bex1JF?= =?us-ascii?Q?gMWmSrZg9QYTUXmjt3HWQ+x7gkwW9B435QJrl40txBrorgGZtN4lXCbupbse?= =?us-ascii?Q?SkA+d1swzoR9q8uUWzp3pECXKc0+rg6tTDfQ9n2Ls54WNVkaMwoOrx/4oiww?= =?us-ascii?Q?0k3RH8iPprPaI3/aX3sibTofeXeTvQ5rd9O5f09TVRYue1DxYfGuW/e3qhXd?= =?us-ascii?Q?HrabE8CsumEC351Ldzbrj0rgLmv/Ur1Qn/Cgl6JfI7JWfIMuaJ26TTswHpqX?= =?us-ascii?Q?JoCzkVPhhnb3axVx1u7rvp5V8y0v4Hgow4kZnEsg39I2UqWgiRCXRe/36Qz9?= =?us-ascii?Q?sMhqCMuS39rcKwVeUYJatO2XvebCnZECBmf0V+a6bEUvPdr2zA5dStw4a/2g?= =?us-ascii?Q?zz7iF8j0UxEzSGJL/fvcvFuZtwBo0LqPQ2qZsFmVvm+LJQpBZCMJF9jl4uGc?= =?us-ascii?Q?J7PVgPieldzgve+qeDMd+/J8x90ZAIsjldZZej8E/dQ6Dsy9WMPMSV6IdtIN?= =?us-ascii?Q?5RWipzTvmpuZCCChmPqc7Uz7XFe4p9hxmQWlrWd4WGgHiYa7xnj/MQ411wGf?= =?us-ascii?Q?xJbx50nvhcm0HvfrxfgDLuAg1iUdxwJmqIydqWhs1EFx9InM2UGae0SYHEAT?= =?us-ascii?Q?lK8JBrBsxIAxOIDjq1iIvxXm5tqhXL1anq6CwRFYTxTWTU+BwOC8PYQ1/+wm?= =?us-ascii?Q?deZ2Ax36lHrMflLylBK2tRetFmB0m9Yx7JkVFApmlMZOulhhkWj5wZkHnPfE?= =?us-ascii?Q?zPDutZ3rqeObW6QFoCqFLDQlE+IW6iKcy98ySOzv6NEKvdOgFK0YLPm+hqdm?= =?us-ascii?Q?2yWFXnB6yWOA20xYe4ZIKoXkfNMquj2bSGfSGy+YOO9R+90NjgaYDbHydkkc?= =?us-ascii?Q?Dd79ggVc8064efm4j/icpTLgP5GzjHDlh81NSU0DWNR/QZTmRwWfv3HqDsWX?= =?us-ascii?Q?oHbJtfQ8ShZk7bUK8VIE0G468FlBLRdIQ37nCy32jBS1KBUlDlumGf9CpjY+?= =?us-ascii?Q?+Gmthrsm2LAYLgkfaVIJf2RanOcXFOCljfh6mORc57L0uQliTrMGZc42coD7?= =?us-ascii?Q?qLqM00daDb9xO4PDeAOodZWKQGxLj3aHR/MSgY0oMH1RTsR7t2UM92j/59yv?= =?us-ascii?Q?Et+uaRsaASsdE3xtXhzDyM9GkLnZo2qpQuX8kEQpbKln9WA+b3BMWiSCZLjw?= =?us-ascii?Q?WnoiKqXdjNsTVnC7b8MmbfEnwW7vzlkGszlnfwrTRs4FKVvR56+bTXZqqm7O?= =?us-ascii?Q?+CdZmmOaYRmpsE9lWUm0apRmhfnaxZ+DEeZcXaFk30d75Ys18VReyPfJghzB?= =?us-ascii?Q?YgeVc6Dh452jWFWgtVxhGUL5orghIxrkqTFmv0DBOQxyZVl/XFjf0NEQj7Td?= =?us-ascii?Q?ZCS3v2GpA8ExNbhw2e+Xqmitu06TP2W3LJHe+mK5xapSBeXvUOfP3xLC8UFR?= =?us-ascii?Q?fePlez69yV0WMi7pHBPhSLV3Go4niBL6DxZMKZzmdk7An/aLrtddkp3LLRRF?= =?us-ascii?Q?nN+FkuWQhCdbdlsYErHJEb0IzowHOjRwg+KUu/SMPel8aSAnqRGt+ercCI2G?= =?us-ascii?Q?w1ygYpq7hv+td/hI98i9+/E=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5277.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c75b01a0-87cd-467f-d869-08d9a344392c X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2021 05:46:06.1153 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 83QtSXR9OJgPuQ6WNMY8cQV/VPG1KfrWbWGqgfomAqzIjSrJ4qDHMFmdoNEBCroizYV+g1BV30vksMqJNwUuww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1787 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable See below > -----Original Message----- > From: Joey Gouly > Sent: Thursday, September 16, 2021 10:46 PM > To: devel@edk2.groups.io > Cc: joey.gouly@arm.com; sami.mujawar@arm.com; Ni, Ray > ; Gao, Zhichao ; nd@arm.com > Subject: [PATCH v2 1/5] ShellPkg: Replace 'Trace' parameter with 'ParseFl= ags' >=20 > From: Marc Moisson-Franckhauser >=20 > Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3D3378) >=20 > This is preparation for adding a second flag to the parsers. >=20 > Signed-off-by: Joey Gouly > --- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h |= 77 > +++++++++++--------- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.h |= 6 > +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c |= 20 > ++--- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c |= 28 > ++++--- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Bgrt/BgrtParser.c > | 10 +-- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c > | 8 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dsdt/DsdtParser.c > | 8 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Facs/FacsParser.c | > 10 +-- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c > | 27 ++++--- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c > | 8 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | > 8 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser. > c | 8 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mcfg/McfgParser.c > | 8 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | > 47 +++++++----- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c > | 10 +-- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c | = 8 > +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Spcr/SpcrParser.c | > 8 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | > 8 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Ssdt/SsdtParser.c | > 8 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c > | 10 +-- > 20 files changed, 179 insertions(+), 146 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h > index > 0b7726b9d5807ad2f5c5447408c4c5451718938b..b078c0b99335ba28f7589cac6b > 0a4190d9a6c3b5 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h > @@ -1,7 +1,7 @@ > /** @file > Header file for ACPI parser >=20 > - Copyright (c) 2016 - 2020, Arm Limited. All rights reserved. > + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent **/ >=20 > @@ -16,6 +16,16 @@ > /// that allows us to process the log options. > #define RSDP_TABLE_INFO SIGNATURE_32('R', 'S', 'D', 'P') >=20 > +/** > + Flags for the parser. > +*/ > +#define PARSE_FLAGS_TRACE BIT0 > + > +/** > + Helper macros to test parser flags. > +*/ > +#define IS_TRACE_FLAG_SET(Flags) (((Flags) & PARSE_FLAGS_TRACE) !=3D 0) > + > /** > This function increments the ACPI table error counter. > **/ > @@ -489,7 +499,7 @@ ParseAcpiAest ( >=20 > This function also performs validation of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -497,7 +507,7 @@ ParseAcpiAest ( > VOID > EFIAPI > ParseAcpiBgrt ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -510,7 +520,7 @@ ParseAcpiBgrt ( >=20 > This function also performs validation of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -518,7 +528,7 @@ ParseAcpiBgrt ( > VOID > EFIAPI > ParseAcpiDbg2 ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -531,7 +541,7 @@ ParseAcpiDbg2 ( > For the DSDT table only the ACPI header fields are parsed and > traced. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -539,7 +549,7 @@ ParseAcpiDbg2 ( > VOID > EFIAPI > ParseAcpiDsdt ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -552,7 +562,7 @@ ParseAcpiDsdt ( >=20 > This function also performs validation of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -560,7 +570,7 @@ ParseAcpiDsdt ( > VOID > EFIAPI > ParseAcpiFacs ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -573,7 +583,7 @@ ParseAcpiFacs ( >=20 > This function also performs validation of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -581,7 +591,7 @@ ParseAcpiFacs ( > VOID > EFIAPI > ParseAcpiFadt ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -598,7 +608,7 @@ ParseAcpiFadt ( >=20 > This function also performs validation of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -606,7 +616,7 @@ ParseAcpiFadt ( > VOID > EFIAPI > ParseAcpiGtdt ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -653,7 +663,7 @@ ParseAcpiHmat ( >=20 > This function also performs validation of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -661,7 +671,7 @@ ParseAcpiHmat ( > VOID > EFIAPI > ParseAcpiIort ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -682,7 +692,7 @@ ParseAcpiIort ( >=20 > This function also performs validation of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -690,7 +700,7 @@ ParseAcpiIort ( > VOID > EFIAPI > ParseAcpiMadt ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -703,7 +713,7 @@ ParseAcpiMadt ( >=20 > This function also performs validation of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -711,7 +721,7 @@ ParseAcpiMadt ( > VOID > EFIAPI > ParseAcpiMcfg ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -746,7 +756,7 @@ ParseAcpiPcct ( >=20 > This function also performs validation of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -754,7 +764,7 @@ ParseAcpiPcct ( > VOID > EFIAPI > ParseAcpiPptt ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -769,7 +779,7 @@ ParseAcpiPptt ( > This function also performs a RAW dump of the ACPI table and > validates the checksum. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -777,7 +787,7 @@ ParseAcpiPptt ( > VOID > EFIAPI > ParseAcpiRsdp ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -793,7 +803,8 @@ ParseAcpiRsdp ( > - Relative distance from System Locality at i*N+j is same as > j*N+i >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser ne= eds to > + do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -801,7 +812,7 @@ ParseAcpiRsdp ( > VOID > EFIAPI > ParseAcpiSlit ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -814,7 +825,7 @@ ParseAcpiSlit ( >=20 > This function also performs validations of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -822,7 +833,7 @@ ParseAcpiSlit ( > VOID > EFIAPI > ParseAcpiSpcr ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -841,7 +852,7 @@ ParseAcpiSpcr ( >=20 > This function also performs validation of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -849,7 +860,7 @@ ParseAcpiSpcr ( > VOID > EFIAPI > ParseAcpiSrat ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -862,7 +873,7 @@ ParseAcpiSrat ( > For the SSDT table only the ACPI header fields are > parsed and traced. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -870,7 +881,7 @@ ParseAcpiSrat ( > VOID > EFIAPI > ParseAcpiSsdt ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -882,7 +893,7 @@ ParseAcpiSsdt ( >=20 > This function also performs validation of the XSDT table. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -890,7 +901,7 @@ ParseAcpiSsdt ( > VOID > EFIAPI > ParseAcpiXsdt ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.h > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.h > index > 0ebf79fb653ae3a8190273aee452723c6213eb58..94ce0a4860e5296d99d398480 > 655a8013ab0f240 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.h > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.h > @@ -1,7 +1,7 @@ > /** @file > Header file for ACPI table parser >=20 > - Copyright (c) 2016 - 2020, Arm Limited. All rights reserved. > + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent **/ >=20 > @@ -20,7 +20,7 @@ > /** > A function that parses the ACPI table. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -28,7 +28,7 @@ > typedef > VOID > (EFIAPI * PARSE_ACPI_TABLE_PROC) ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c > index > 4b618f131eac3957f4070a95e06c8cd157c3223c..ecb5d6339af37397c6ba1ba4c8f > 0d42a95811bf6 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c > @@ -1,7 +1,7 @@ > /** @file > ACPI table parser >=20 > - Copyright (c) 2016 - 2020, ARM Limited. All rights reserved. > + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Glossary: > @@ -183,7 +183,7 @@ ProcessAcpiTable ( > ) > { > EFI_STATUS Status; > - BOOLEAN Trace; > + UINT8 ParseFlags; > CONST UINT32* AcpiTableSignature; > CONST UINT32* AcpiTableLength; > CONST UINT8* AcpiTableRevision; > @@ -197,13 +197,13 @@ ProcessAcpiTable ( > &AcpiTableRevision > ); >=20 > - Trace =3D ProcessTableReportOptions ( > - *AcpiTableSignature, > - Ptr, > - *AcpiTableLength > - ); > + ParseFlags =3D ProcessTableReportOptions ( > + *AcpiTableSignature, > + Ptr, > + *AcpiTableLength > + ); >=20 > - if (Trace) { > + if (IS_TRACE_FLAG_SET (ParseFlags)) { > DumpRaw (Ptr, *AcpiTableLength); >=20 > // Do not process the ACPI table any further if the table length rea= d @@ - > 236,14 +236,14 @@ ProcessAcpiTable ( > Status =3D GetParser (*AcpiTableSignature, &ParserProc); > if (EFI_ERROR (Status)) { > // No registered parser found, do default handling. > - if (Trace) { > + if (IS_TRACE_FLAG_SET (ParseFlags)) { > DumpAcpiHeader (Ptr); > } > return; > } >=20 > ParserProc ( > - Trace, > + ParseFlags, > Ptr, > *AcpiTableLength, > *AcpiTableRevision > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c > index > 9a5b013fb234e2a09a12a690607b5b871dffde72..a4242ba9d99b05d07c829520c > 4011439445aadb0 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c > @@ -1,6 +1,6 @@ > /** @file >=20 > - Copyright (c) 2016 - 2020, ARM Limited. All rights reserved. > + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Glossary: > @@ -73,9 +73,9 @@ DumpAcpiTableToFile ( > @param [in] TablePtr Pointer to the ACPI table data. > @param [in] Length The length fo the ACPI table. >=20 > - @retval Returns TRUE if the ACPI table should be traced. > + @retval Returns the ParseFlags for the ACPI table. > **/ > -BOOLEAN > +UINT8 > ProcessTableReportOptions ( > IN CONST UINT32 Signature, > IN CONST UINT8* TablePtr, > @@ -84,7 +84,7 @@ ProcessTableReportOptions ( { > UINTN OriginalAttribute; > UINT8 *SignaturePtr; > - BOOLEAN Log; > + UINT8 ParseFlags; > BOOLEAN HighLight; > SELECTED_ACPI_TABLE *SelectedTable; >=20 > @@ -93,17 +93,17 @@ ProcessTableReportOptions ( > // > OriginalAttribute =3D 0; > SignaturePtr =3D (UINT8*)(UINTN)&Signature; > - Log =3D FALSE; > + ParseFlags =3D 0; > HighLight =3D GetColourHighlighting (); > GetSelectedAcpiTable (&SelectedTable); >=20 > switch (GetReportOption ()) { > case ReportAll: > - Log =3D TRUE; > + ParseFlags |=3D PARSE_FLAGS_TRACE; > break; > case ReportSelected: > if (Signature =3D=3D SelectedTable->Type) { > - Log =3D TRUE; > + ParseFlags |=3D PARSE_FLAGS_TRACE; > SelectedTable->Found =3D TRUE; > } > break; > @@ -143,7 +143,7 @@ ProcessTableReportOptions ( > break; > } // switch >=20 > - if (Log) { > + if (IS_TRACE_FLAG_SET (ParseFlags)) { > if (HighLight) { > OriginalAttribute =3D gST->ConOut->Mode->Attribute; > gST->ConOut->SetAttribute ( > @@ -164,7 +164,7 @@ ProcessTableReportOptions ( > } > } >=20 > - return Log; > + return ParseFlags; > } >=20 >=20 > @@ -196,7 +196,7 @@ AcpiView ( > UINT32 RsdpLength; > UINT8 RsdpRevision; > PARSE_ACPI_TABLE_PROC RsdpParserProc; > - BOOLEAN Trace; > + UINT8 ParseFlags; > SELECTED_ACPI_TABLE *SelectedTable; >=20 > // > @@ -249,7 +249,11 @@ AcpiView ( > // The RSDP length is 4 bytes starting at offset 20 > RsdpLength =3D *(UINT32*)(RsdpPtr + RSDP_LENGTH_OFFSET); >=20 > - Trace =3D ProcessTableReportOptions (RSDP_TABLE_INFO, RsdpPtr, > RsdpLength); > + ParseFlags =3D ProcessTableReportOptions ( > + RSDP_TABLE_INFO, > + RsdpPtr, > + RsdpLength > + ); >=20 > Status =3D GetParser (RSDP_TABLE_INFO, &RsdpParserProc); > if (EFI_ERROR (Status)) { > @@ -260,7 +264,7 @@ AcpiView ( > } >=20 > RsdpParserProc ( > - Trace, > + ParseFlags, > RsdpPtr, > RsdpLength, > RsdpRevision > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Bgrt/BgrtParser. > c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Bgrt/BgrtParser. > c > index > 1a180271a4ebe47948b7f0b56d1cb6f81b5fdf13..6bd4c35bec85e038875ce3d95 > 48c9139b1de2755 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Bgrt/BgrtParser. > c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Bgrt/BgrtPars > +++ er.c > @@ -1,7 +1,7 @@ > /** @file > BGRT table parser >=20 > - Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. > + Copyright (c) 2017 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > @@ -36,7 +36,7 @@ STATIC CONST ACPI_PARSER BgrtParser[] =3D { >=20 > This function also performs validation of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -44,18 +44,18 @@ STATIC CONST ACPI_PARSER BgrtParser[] =3D { VOID > EFIAPI ParseAcpiBgrt ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > ) > { > - if (!Trace) { > + if (!IS_TRACE_FLAG_SET (ParseFlags)) { > return; > } >=20 > ParseAcpi ( > - Trace, > + TRUE, > 0, > "BGRT", > Ptr, > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parse > r.c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parse > r.c > index > 9df111ecaa7d7a703a13a39c243ed78b9f12ee97..a22f8ab76b84432b2073bea6c > a6d8245ea9df7fb 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parse > r.c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Pars > +++ er.c > @@ -1,7 +1,7 @@ > /** @file > DBG2 table parser >=20 > - Copyright (c) 2016 - 2020, ARM Limited. All rights reserved. > + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > @@ -212,7 +212,7 @@ DumpDbgDeviceInfo ( >=20 > This function also performs validation of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -220,7 +220,7 @@ DumpDbgDeviceInfo ( > VOID > EFIAPI > ParseAcpiDbg2 ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -229,7 +229,7 @@ ParseAcpiDbg2 ( > UINT32 Offset; > UINT32 Index; >=20 > - if (!Trace) { > + if (!IS_TRACE_FLAG_SET (ParseFlags)) { > return; > } >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dsdt/DsdtParser > .c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dsdt/DsdtParser > .c > index > 6d43974f54d23fd9990fa7af721c96518bb96a36..609c17ef02d460be66f0c39020 > 3cae55ece653e3 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dsdt/DsdtParser > .c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dsdt/DsdtPars > +++ er.c > @@ -1,7 +1,7 @@ > /** @file > DSDT table parser >=20 > - Copyright (c) 2016 - 2018, ARM Limited. All rights reserved. > + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > @@ -20,7 +20,7 @@ > For the DSDT table only the ACPI header fields are parsed and > traced. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -28,13 +28,13 @@ > VOID > EFIAPI > ParseAcpiDsdt ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > ) > { > - if (!Trace) { > + if (!IS_TRACE_FLAG_SET (ParseFlags)) { > return; > } >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Facs/FacsParser. > c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Facs/FacsParser. > c > index > d6bea86bdbaa79aa35b86840c809394b3c7a3bf6..d7545b6161eadd24e986a782 > 8910662f2f52b2ec 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Facs/FacsParser. > c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Facs/FacsPars > +++ er.c > @@ -1,7 +1,7 @@ > /** @file > FACS table parser >=20 > - Copyright (c) 2019, ARM Limited. All rights reserved. > + Copyright (c) 2019 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > @@ -42,7 +42,7 @@ STATIC CONST ACPI_PARSER FacsParser[] =3D { >=20 > This function also performs validation of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -50,18 +50,18 @@ STATIC CONST ACPI_PARSER FacsParser[] =3D { VOID > EFIAPI ParseAcpiFacs ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > ) > { > - if (!Trace) { > + if (!IS_TRACE_FLAG_SET (ParseFlags)) { > return; > } >=20 > ParseAcpi ( > - Trace, > + TRUE, > 0, > "FACS", > Ptr, > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser. > c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser. > c > index > d86718bab67d45fd612bb7ac725b5eb3eeb7dfdc..8d0eb42ec3b361c1727184c5 > 42a757e39ef3da5c 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser. > c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPars > +++ er.c > @@ -1,7 +1,7 @@ > /** @file > FADT table parser >=20 > - Copyright (c) 2016 - 2020, ARM Limited. All rights reserved. > + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > @@ -198,7 +198,7 @@ STATIC CONST ACPI_PARSER FadtParser[] =3D { >=20 > This function also performs validation of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -206,7 +206,7 @@ STATIC CONST ACPI_PARSER FadtParser[] =3D { VOID > EFIAPI ParseAcpiFadt ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -219,6 +219,9 @@ ParseAcpiFadt ( > UINT32 FacsLength; > UINT8 FacsRevision; > PARSE_ACPI_TABLE_PROC FacsParserProc; > + BOOLEAN Trace; > + > + Trace =3D IS_TRACE_FLAG_SET (ParseFlags); >=20 > ParseAcpi ( > Trace, > @@ -253,7 +256,7 @@ ParseAcpiFadt ( > // if HW_REDUCED_ACPI flag is not set, both FIRMWARE_CTRL and > // X_FIRMWARE_CTRL cannot be zero, and the FACS Table must be > // present. > - if ((Trace) && > + if (Trace && > (Flags !=3D NULL) && > ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) !=3D > EFI_ACPI_6_3_HW_REDUCED_ACPI)) { > IncrementErrorCount (); > @@ -274,11 +277,15 @@ ParseAcpiFadt ( > // The FACS version is 1 byte starting at offset 32. > FacsRevision =3D *(UINT8*)(FirmwareCtrlPtr + FACS_VERSION_OFFSET); >=20 > - Trace =3D ProcessTableReportOptions ( > - FacsSignature, > - FirmwareCtrlPtr, > - FacsLength > - ); > + if (ProcessTableReportOptions ( > + FacsSignature, > + FirmwareCtrlPtr, > + FacsLength > + )) { > + ParseFlags |=3D PARSE_FLAGS_TRACE; > + } else { > + ParseFlags &=3D ~PARSE_FLAGS_TRACE; > + } Why use such format instead of assign ParseFlags with the return value of P= rocessTableReportOptions? Thanks, Zhichao >=20 > Status =3D GetParser (FacsSignature, &FacsParserProc); > if (EFI_ERROR (Status)) { > @@ -289,7 +296,7 @@ ParseAcpiFadt ( > } >=20 > FacsParserProc ( > - Trace, > + ParseFlags, > FirmwareCtrlPtr, > FacsLength, > FacsRevision > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > .c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > .c > index > d02fc4929d6fa5e04672276810b19d3f4c62efd2..da93938771bfcf0da146fd46a0 > 25addeb05e71cc 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > .c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtPars > +++ er.c > @@ -1,7 +1,7 @@ > /** @file > GTDT table parser >=20 > - Copyright (c) 2016 - 2020, ARM Limited. All rights reserved. > + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > @@ -254,7 +254,7 @@ DumpWatchdogTimer ( >=20 > This function also performs validation of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -262,7 +262,7 @@ DumpWatchdogTimer ( > VOID > EFIAPI > ParseAcpiGtdt ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -272,7 +272,7 @@ ParseAcpiGtdt ( > UINT32 Offset; > UINT8* TimerPtr; >=20 > - if (!Trace) { > + if (!IS_TRACE_FLAG_SET (ParseFlags)) { > return; > } >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c > index > f7447947b2308d35d4d2890373778f0fd2f97f9e..2f659349499a02175820ee4faf3 > a84034c8ced76 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortPars > +++ er.c > @@ -1,7 +1,7 @@ > /** @file > IORT table parser >=20 > - Copyright (c) 2016 - 2020, ARM Limited. All rights reserved. > + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > @@ -612,7 +612,7 @@ DumpIortNodePmcg ( >=20 > This function also performs validation of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -620,7 +620,7 @@ DumpIortNodePmcg ( > VOID > EFIAPI > ParseAcpiIort ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -630,7 +630,7 @@ ParseAcpiIort ( > UINT32 Index; > UINT8* NodePtr; >=20 > - if (!Trace) { > + if (!IS_TRACE_FLAG_SET (ParseFlags)) { > return; > } >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars > er.c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars > er.c > index > 15aa2392b60cee9e3843c7c560b0ab84e0be4174..a29bf97a3985a74ff888f225e > b0e5cfbcbea72b0 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars > er.c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars > +++ er.c > @@ -1,7 +1,7 @@ > /** @file > MADT table parser >=20 > - Copyright (c) 2016 - 2020, ARM Limited. All rights reserved. > + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > @@ -216,7 +216,7 @@ STATIC CONST ACPI_PARSER > MadtInterruptControllerHeaderParser[] =3D { >=20 > This function also performs validation of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -224,7 +224,7 @@ STATIC CONST ACPI_PARSER > MadtInterruptControllerHeaderParser[] =3D { VOID EFIAPI ParseAcpiMadt = ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -236,7 +236,7 @@ ParseAcpiMadt ( >=20 > GICDCount =3D 0; >=20 > - if (!Trace) { > + if (!IS_TRACE_FLAG_SET (ParseFlags)) { > return; > } >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mcfg/McfgParse > r.c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mcfg/McfgParse > r.c > index > 9da4d60e849721ed3b635bfff8a3bd76728c0ade..febf8a2bd92d8e38bdc59a3f9 > 7a8c4485cdba5a5 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mcfg/McfgParse > r.c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mcfg/McfgPars > +++ er.c > @@ -1,7 +1,7 @@ > /** @file > MCFG table parser >=20 > - Copyright (c) 2016 - 2018, ARM Limited. All rights reserved. > + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > @@ -42,7 +42,7 @@ STATIC CONST ACPI_PARSER > PciCfgSpaceBaseAddrParser[] =3D { >=20 > This function also performs validation of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -50,7 +50,7 @@ STATIC CONST ACPI_PARSER > PciCfgSpaceBaseAddrParser[] =3D { VOID EFIAPI ParseAcpiMcfg ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -60,7 +60,7 @@ ParseAcpiMcfg ( > UINT32 PciCfgOffset; > UINT8* PciCfgSpacePtr; >=20 > - if (!Trace) { > + if (!IS_TRACE_FLAG_SET (ParseFlags)) { > return; > } >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser. > c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser. > c > index > acd2b81bb3258c7322aa10d2c0e0d842d89e358b..538b6a69350d75ccbf36b86ff > f115255e77437c7 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser. > c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttPars > +++ er.c > @@ -1,7 +1,7 @@ > /** @file > PPTT table parser >=20 > - Copyright (c) 2019 - 2020, ARM Limited. All rights reserved. > + Copyright (c) 2019 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > @@ -241,13 +241,15 @@ STATIC CONST ACPI_PARSER IdStructureParser[] =3D { > /** > This function parses the Processor Hierarchy Node Structure (Type 0). >=20 > - @param [in] Ptr Pointer to the start of the Processor Hierarchy No= de > - Structure data. > - @param [in] Length Length of the Processor Hierarchy Node Structure. > + @param [in] ParseFlags Flags describing what the parser needs to do. > + @param [in] Ptr Pointer to the start of the Processor Hierarc= hy Node > + Structure data. > + @param [in] Length Length of the Processor Hierarchy Node Struct= ure. > **/ > STATIC > VOID > DumpProcessorHierarchyNodeStructure ( > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT8 Length > ) > @@ -257,7 +259,7 @@ DumpProcessorHierarchyNodeStructure ( > CHAR16 Buffer[OUTPUT_FIELD_COLUMN_WIDTH]; >=20 > Offset =3D ParseAcpi ( > - TRUE, > + IS_TRACE_FLAG_SET (ParseFlags), > 2, > "Processor Hierarchy Node Structure", > Ptr, > @@ -315,18 +317,20 @@ DumpProcessorHierarchyNodeStructure ( > /** > This function parses the Cache Type Structure (Type 1). >=20 > - @param [in] Ptr Pointer to the start of the Cache Type Structure d= ata. > - @param [in] Length Length of the Cache Type Structure. > + @param [in] ParseFlags Flags describing what the parser needs to do. > + @param [in] Ptr Pointer to the start of the Cache Type Structu= re data. > + @param [in] Length Length of the Cache Type Structure. > **/ > STATIC > VOID > DumpCacheTypeStructure ( > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT8 Length > ) > { > ParseAcpi ( > - TRUE, > + IS_TRACE_FLAG_SET (ParseFlags), > 2, > "Cache Type Structure", > Ptr, > @@ -338,18 +342,20 @@ DumpCacheTypeStructure ( > /** > This function parses the ID Structure (Type 2). >=20 > - @param [in] Ptr Pointer to the start of the ID Structure data. > - @param [in] Length Length of the ID Structure. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > + @param [in] Ptr Pointer to the start of the ID Structur= e data. > + @param [in] Length Length of the ID Structure. > **/ > STATIC > VOID > DumpIDStructure ( > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > - IN UINT8 Length > + IN UINT8 Length > ) > { > ParseAcpi ( > - TRUE, > + IS_TRACE_FLAG_SET (ParseFlags), > 2, > "ID Structure", > Ptr, > @@ -370,7 +376,7 @@ DumpIDStructure ( >=20 > This function also performs validation of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -378,7 +384,7 @@ DumpIDStructure ( > VOID > EFIAPI > ParseAcpiPptt ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -387,12 +393,12 @@ ParseAcpiPptt ( > UINT32 Offset; > UINT8* ProcessorTopologyStructurePtr; >=20 > - if (!Trace) { > + if (!IS_TRACE_FLAG_SET (ParseFlags)) { > return; > } >=20 > Offset =3D ParseAcpi ( > - TRUE, > + IS_TRACE_FLAG_SET (ParseFlags), > 0, > "PPTT", > Ptr, > @@ -440,24 +446,29 @@ ParseAcpiPptt ( > return; > } >=20 > - PrintFieldName (2, L"* Structure Offset *"); > - Print (L"0x%x\n", Offset); > + if (IS_TRACE_FLAG_SET (ParseFlags)) { > + PrintFieldName (2, L"* Structure Offset *"); > + Print (L"0x%x\n", Offset); > + } >=20 > switch (*ProcessorTopologyStructureType) { > case EFI_ACPI_6_2_PPTT_TYPE_PROCESSOR: > DumpProcessorHierarchyNodeStructure ( > + ParseFlags, > ProcessorTopologyStructurePtr, > *ProcessorTopologyStructureLength > ); > break; > case EFI_ACPI_6_2_PPTT_TYPE_CACHE: > DumpCacheTypeStructure ( > + ParseFlags, > ProcessorTopologyStructurePtr, > *ProcessorTopologyStructureLength > ); > break; > case EFI_ACPI_6_2_PPTT_TYPE_ID: > DumpIDStructure ( > + ParseFlags, > ProcessorTopologyStructurePtr, > *ProcessorTopologyStructureLength > ); > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParse > r.c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParse > r.c > index > f4a8732a7db7c437031f2a3d2f266b80eff17b4b..c98bc62719c3aef3381152ff243 > 6cb1a29f98362 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParse > r.c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpPars > +++ er.c > @@ -1,7 +1,7 @@ > /** @file > RSDP table parser >=20 > - Copyright (c) 2016 - 2019, ARM Limited. All rights reserved. > + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > @@ -110,7 +110,7 @@ STATIC CONST ACPI_PARSER RsdpParser[] =3D { > This function also performs a RAW dump of the ACPI table and > validates the checksum. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -118,19 +118,19 @@ STATIC CONST ACPI_PARSER RsdpParser[] =3D { VOID > EFIAPI ParseAcpiRsdp ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > ) > { > - if (Trace) { > + if (IS_TRACE_FLAG_SET (ParseFlags)) { > DumpRaw (Ptr, AcpiTableLength); > VerifyChecksum (TRUE, Ptr, AcpiTableLength); > } >=20 > ParseAcpi ( > - Trace, > + IS_TRACE_FLAG_SET (ParseFlags), > 0, > "RSDP", > Ptr, > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c > index > e4625ee8b13907893a9b6990ecb956baf91cc3b9..20d2fb79a8ea6251b0e31b53 > 70cc400be9e1478f 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitPars > +++ er.c > @@ -1,7 +1,7 @@ > /** @file > SLIT table parser >=20 > - Copyright (c) 2016 - 2019, ARM Limited. All rights reserved. > + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > @@ -42,7 +42,7 @@ STATIC CONST ACPI_PARSER SlitParser[] =3D { > - Relative distance from System Locality at i*N+j is same as > j*N+i >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -50,7 +50,7 @@ STATIC CONST ACPI_PARSER SlitParser[] =3D { VOID > EFIAPI ParseAcpiSlit ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -63,7 +63,7 @@ ParseAcpiSlit ( > UINT8* LocalityPtr; > CHAR16 Buffer[80]; // Used for AsciiName param of ParseAcpi >=20 > - if (!Trace) { > + if (!IS_TRACE_FLAG_SET (ParseFlags)) { > return; > } >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Spcr/SpcrParser. > c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Spcr/SpcrParser. > c > index > 3b06b05dee8c056c6e009b9e485ccd35d4194e95..99cffafa946979b79a06cd28f1 > 4257beaa6cafec 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Spcr/SpcrParser. > c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Spcr/SpcrPars > +++ er.c > @@ -1,7 +1,7 @@ > /** @file > SPCR table parser >=20 > - Copyright (c) 2016 - 2019, ARM Limited. All rights reserved. > + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > @@ -114,7 +114,7 @@ STATIC CONST ACPI_PARSER SpcrParser[] =3D { >=20 > This function also performs validations of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -122,13 +122,13 @@ STATIC CONST ACPI_PARSER SpcrParser[] =3D { VOID > EFIAPI ParseAcpiSpcr ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > ) > { > - if (!Trace) { > + if (!IS_TRACE_FLAG_SET (ParseFlags)) { > return; > } >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c > index > b9b67820b89f7fc5560a1022e976663db7d9df2d..907856368fbe0ad9f140d8f27 > e51bd9460f35b1a 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratPars > +++ er.c > @@ -1,7 +1,7 @@ > /** @file > SRAT table parser >=20 > - Copyright (c) 2016 - 2020, ARM Limited. All rights reserved. > + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > @@ -344,7 +344,7 @@ STATIC CONST ACPI_PARSER > SratX2ApciAffinityParser[] =3D { >=20 > This function also performs validation of the ACPI table fields. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -352,7 +352,7 @@ STATIC CONST ACPI_PARSER > SratX2ApciAffinityParser[] =3D { VOID EFIAPI ParseAcpiSrat ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -375,7 +375,7 @@ ParseAcpiSrat ( > ApicSapicAffinityIndex =3D 0; > X2ApicAffinityIndex =3D 0; >=20 > - if (!Trace) { > + if (!IS_TRACE_FLAG_SET (ParseFlags)) { > return; > } >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Ssdt/SsdtParser. > c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Ssdt/SsdtParser. > c > index > f18664b8a6879b82dc9c55d9979ca21e01c4fc99..138a3159fb1a6121387f832621 > d23960c688ce30 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Ssdt/SsdtParser. > c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Ssdt/SsdtPars > +++ er.c > @@ -1,7 +1,7 @@ > /** @file > SSDT table parser >=20 > - Copyright (c) 2016 - 2018, ARM Limited. All rights reserved. > + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > @@ -20,7 +20,7 @@ > For the SSDT table only the ACPI header fields are > parsed and traced. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -28,13 +28,13 @@ > VOID > EFIAPI > ParseAcpiSsdt ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > ) > { > - if (!Trace) { > + if (!IS_TRACE_FLAG_SET (ParseFlags)) { > return; > } >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser. > c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser. > c > index > e39061f8e2612f2cce4aebf51a511b63b703662b..bbd58d72ad9c676b4843d3b4f > 1d7c554a5abbd3f 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser. > c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtPars > +++ er.c > @@ -1,7 +1,7 @@ > /** @file > XSDT table parser >=20 > - Copyright (c) 2016 - 2019, ARM Limited. All rights reserved. > + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > @@ -40,7 +40,7 @@ GetAcpiXsdtHeaderInfo ( >=20 > This function also performs validation of the XSDT table. >=20 > - @param [in] Trace If TRUE, trace the ACPI fields. > + @param [in] ParseFlags Flags describing what the parser needs = to do. > @param [in] Ptr Pointer to the start of the buffer. > @param [in] AcpiTableLength Length of the ACPI table. > @param [in] AcpiTableRevision Revision of the ACPI table. > @@ -48,7 +48,7 @@ GetAcpiXsdtHeaderInfo ( VOID EFIAPI ParseAcpiXsdt ( > - IN BOOLEAN Trace, > + IN UINT8 ParseFlags, > IN UINT8* Ptr, > IN UINT32 AcpiTableLength, > IN UINT8 AcpiTableRevision > @@ -61,7 +61,7 @@ ParseAcpiXsdt ( > CHAR16 Buffer[32]; >=20 > Offset =3D ParseAcpi ( > - Trace, > + IS_TRACE_FLAG_SET (ParseFlags), > 0, > "XSDT", > Ptr, > @@ -71,7 +71,7 @@ ParseAcpiXsdt ( >=20 > TableOffset =3D Offset; >=20 > - if (Trace) { > + if (IS_TRACE_FLAG_SET (ParseFlags)) { > EntryIndex =3D 0; > TablePointer =3D (UINT64*)(Ptr + TableOffset); > while (Offset < AcpiTableLength) { > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")