From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.8279.1645429206455503706 for ; Sun, 20 Feb 2022 23:40:07 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=U4S6DhFy; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: zhichao.gao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645429206; x=1676965206; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=owzolF65+Kk6Fq25ROtaWZdrsQq2iZlnsjyFK4yj8QQ=; b=U4S6DhFyTiEG4LOvoyPOlIyz3gQneYmX92/ZYvV2fFxbD6R8E601QvwB KM/RhOWomkqaVGE9+wXhMagdPjb0JGDIxH54pr503mO0domjEVx5d2LLg WTP/jXHsej1mvTRVDPcoqW/Hfey36in14y3ZeMthKFjp5zQW+iTLuyB2g obk0HMJDy30qeYpvpNCm7cdvME6WzInTweQXL7kDnyL6sqGVu8V9V2pWS MBTvdqfwgmlQoLp8z/GeEazuZkj+tYmwvtcZALtbKwe0xf6QYPhcb1h2h vMyg6PjskC3fuk8cIvmWhcdjEZvxWyf+9lE43DnybPOnach/Y1MWaG5pf Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10264"; a="234995832" X-IronPort-AV: E=Sophos;i="5.88,385,1635231600"; d="scan'208";a="234995832" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2022 23:40:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,385,1635231600"; d="scan'208";a="542534308" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga007.fm.intel.com with ESMTP; 20 Feb 2022 23:40:05 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 20 Feb 2022 23:40:04 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Sun, 20 Feb 2022 23:40:04 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Sun, 20 Feb 2022 23:40:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YwxlxLM7dGvF2YBlbgvGn9RrItpu3FqLdpdG+vkCwzaBXgKlhgYErU2pk/UKwKCp9KSwTFNJ78F4TQmir16zjze2CzP1mPnttbxlw4XusPv10K6AI4BjPh1lvWWAT8GRfgSA5Y9A+v6/3NYj3OBK2bvWKUmiMyEr/6KnaGiynafb2sZ5YIuoehWNDlHmwFTK3X8HZ41vCRfUPYD8SmcljCP+PiCgFY6cR9rpQrtL3RHavP6RyCMuAm6OqgLdxwpo+pHlbYg7Hv+zUli5qIcR0wPxrQmqQHEvRo9fqmhQcuT2wrfM0eyxL6td6/qM0+2L2CrjnfiQ5jN0TqTSsrgOJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=axz6N5lBYJ0s/ecX4W/P4174Mk0Cb3o83Tbcr04MhTc=; b=SoMFPAz0HFUliUA5UTdnagGXHvUJtkwyodsXLCx+d/xKiyUxduc/bQ3pmwssqulKip81mYahyi/TLVINU0agk6MOkbVPDl5rEKgJDt6zRn3pEEUJpOvHJDtSpE8mV8lDZd2RGrbdL5hT/2IIjcbyC0TuXxtg3A4x3gPjJhIrjyH+mkjctf+nnph1UGT66NwH4JMM5fdxVWVonIbSkIg8uGRX1tfrKwDdj3Fr97TJJd++Cmi7X7wbFn4VG1t8AabkRmLYaawxJ72BTTbnq/JGCMXkSV3yIiV6c8ryX3fkthbtKBgtwRjj5YKQC97m/QA0iw3ACPdOtR2i/lUFircLOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5277.namprd11.prod.outlook.com (2603:10b6:5:388::23) by MWHPR11MB1455.namprd11.prod.outlook.com (2603:10b6:301:9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Mon, 21 Feb 2022 07:40:02 +0000 Received: from DM4PR11MB5277.namprd11.prod.outlook.com ([fe80::8ff:19e1:23df:426]) by DM4PR11MB5277.namprd11.prod.outlook.com ([fe80::8ff:19e1:23df:426%5]) with mapi id 15.20.4995.027; Mon, 21 Feb 2022 07:40:02 +0000 From: "Gao, Zhichao" To: Abdul Lateef Attar , "devel@edk2.groups.io" CC: "Ni, Ray" , Sami Mujawar Subject: Re: [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser Thread-Topic: [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser Thread-Index: AQHYIyZTgXzkoCca10eTEKbVs1SzIKydpgKA Date: Mon, 21 Feb 2022 07:40:02 +0000 Message-ID: References: <20220216111355.9801-1-abdattar@amd.com> In-Reply-To: <20220216111355.9801-1-abdattar@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cfbdd5a0-fdab-492f-fcec-08d9f50d5f14 x-ms-traffictypediagnostic: MWHPR11MB1455:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i+/zY4omQnjWNjQCZu8yNaARXhln0qtWT/P1tzvER3XJKlbyfQa1PuM1bvIIbqX7EfS2I0NkMZbAvNOgUAQly24hF6emGUDMUPytKdvW570wcvTeSK6FqAkxXLD2XbKoeyUR6sOvmcHfr2Xfednlbu+ipyBZHKtCtnelXTwM/EEyINlJeBEzpCyEoKTy1EFswGuTkhSIKLK2j6WXqHB2akltmtBMbSgPPzKH600yKJL8RTs7lRmXYRRiHZzqx1h6i+6SsYRcSnXWPVYrqyvKWNCNe8nYPsv/zwQ9+l4+PmPjkX7Exkr7QdWteN6qT9y3HqGZ0P6AMpyko4s9BNSskDA4gNMeH1cNQdCKcvKI7u5AmY4ESyljT5Ac9WqSbGe1uEkjfjoe/UkYidFXKIBzpICHZtSTLl0jQ8InOa8yC7G/1WTLSg2Qw8vOM3/1rh4LfJjmjD+9xM1ej52HGUS2jIGwAjTcj0PLP5Jb8QSF+mFjKSjVP98mZLlZfbAI6VGddEFDCMPDzNBzsBdju0U0OBLH6CDQdh7vYCQMLQdii7EQqMbY1MnJ0QVSiGOLQND+uXIi5rZZgKSVEZY+86UbnWrIKKshQMecX+LiV6gLUgYx1foHn4iwWA1lfgvvX4mnKian6M78/MDECySvswwi9UWczw1WjgX91BrdzIWN5ZK8cnF3DC2hNvh9bnkCMHjb8wzxeSkc0fLCwZFNSKB/MwhuY1Ewqd4UCSReE3iGureySWIH7oxMz/JogFkBmVV3tSZa1etD51BDvvPEztXTWDVuq3J7OA76Cq7iWtRv3EA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5277.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(66446008)(64756008)(52536014)(66556008)(76116006)(66946007)(2906002)(7696005)(9686003)(53546011)(6506007)(966005)(8676002)(4326008)(38070700005)(38100700002)(33656002)(8936002)(508600001)(122000001)(55016003)(86362001)(316002)(5660300002)(71200400001)(186003)(26005)(83380400001)(110136005)(54906003)(82960400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UycPtlfy4NKG/tg4v/rh3PLx2i3UJuoqmvG5v6ypmK30HjZIi7vT7lv0mjxM?= =?us-ascii?Q?JiSfAEx4JzblImmo2TWO031rIj8w3mckBOZhd4TEDf1aMRztjBhFLS7BA7Dd?= =?us-ascii?Q?firFuMECcYU32/9y4ggmlVTYM6Xx0TdoyU77Ve9j42oCXmjfgJR+52ohIJWk?= =?us-ascii?Q?ZTN/PCUjVybQsMfxp94K74FXe0G5gDoE9g6CdqLs3v5+wEF4Bqa+A6g3fI0C?= =?us-ascii?Q?qEFklltKqPgEUZij7Myx92dK5J1PhyF22BPIryT05pQ9pR7cCdMlpMzuM5Px?= =?us-ascii?Q?EX9LNgD29fgh4BTZHaYuIzMMOORG651FjFIeJJrwNAF+wC4t0U4+P0s8J+sQ?= =?us-ascii?Q?fSX/dbYj6wwhf3hg0d6hR8rFYEB8FEF/gen366bJupi3Uh9/rBHAXy6aNgMT?= =?us-ascii?Q?9Tpz23TjKPoD8K1jElQVxK2n7Ie0yW8BJWq2qZCnXrYZgZXTvoly7/o04GCE?= =?us-ascii?Q?PL5GxMnL0z4fTUyTY7UqLIFi/kt8ciGSmsl86HoMwPt30f8FpxMxEQkJczYa?= =?us-ascii?Q?jqBbaEuYaEE86QOownrGieSZyaZ+IPTtA6x6ykYwrNAUiqt9yEFu/qLVMP/O?= =?us-ascii?Q?zlVQQTtHyHq8XRiDtxLlsKh+Hvon03Wl7oOX1t2RRWtWf65U2EIqqJ8Eyhwp?= =?us-ascii?Q?YmFdsT+CKRWLuOQTw6Bp/Zw260gi2osetXNOrk5Opd/8iO0Ky87GNe4gA7nQ?= =?us-ascii?Q?xuN3K4TyZ62AYYOtg2zFJwwLX5wAhH7KTcBRqFIU79Y+iEzayBRQiPp1E2ir?= =?us-ascii?Q?dZuOaKPeTre1DHMTozJnC/29DBAGmaYIt3UxhHY1wSWH6JIa3Rgtc1rxiubt?= =?us-ascii?Q?+/5wHNWHbksCNr4AaXKYMeeJbyTtVM4IGMqc/265R5cacd+dVDyYTkIwGojp?= =?us-ascii?Q?KzPmFGuyG2haNc+Hgrzq7ezDmAbmCRoW0OdNAw1+18/RbL+qTL5ju71of6kh?= =?us-ascii?Q?D/NFy15DxYaPrVZmM4kRNutSyumX1peA/RpaSD8suvevN9CZKtKWxeo/fhJN?= =?us-ascii?Q?ZC5ttQzaSABh6YMZpmLRheWESP9K2gPmQMZkfCB+CECYa5rX2RhC0ZEf9Pu1?= =?us-ascii?Q?UkyZPBEEwtOXapgr267/Jophh31TpwPPy9XWXTC+QynHr2BdWyUrWbGXZYvZ?= =?us-ascii?Q?W7Rjjw8rOtFI9rJ1I33C02G/+pvYDsEuro7YwL6sTQ8T5osUbYWkpMEVo9RL?= =?us-ascii?Q?x/rdVh1SLrfPDvtSQmjGkADIWOVZ7LdkVw9+pLqP5Xe834xxLVgEBrVkPoFO?= =?us-ascii?Q?dnA71NCkCyd0VYPffwY+IcAqwBH8UPMUwiziAfo1SOjA+eZ8NI0OmaVjCLyv?= =?us-ascii?Q?ZAT7BDTI7O7cvyDjMYsLRmxNEb/HWgYY+rHpy310Xbsk7OcGvGwKn9BUVMNs?= =?us-ascii?Q?USgCEpiuYSE/EDUoS/Az1NMXT1cMr4xaIo2tqED1ecwiiaBYGyZf95NI0ZUI?= =?us-ascii?Q?N/VmME8oJW1lZYKVp2yU1tz7iT6xqN1hmNJEJpj9B3a5qbFrb0MfTD6UPbIj?= =?us-ascii?Q?Wf9hWatkJHkqTzGgTeqkipTUB515cYBJMKtZrYUwtMvct9m/KJlbifsJRXM3?= =?us-ascii?Q?tgunW8iKhboGNmXtbJ9B/091rSEE30qjHNvIgBVqsLtRRuq1BaCb7phnm7+g?= =?us-ascii?Q?u6VBv0UmQGNyBj91iIfMGVI=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5277.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cfbdd5a0-fdab-492f-fcec-08d9f50d5f14 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2022 07:40:02.7133 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tqi9YbGrJI4boNQQU/fNq49kGF9q5EukNcDeI/Rcb1OuwLj4FgcXK+h8E9fpsZcWN6ECkcdX9nMbVMiGYKXgIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1455 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Patchset Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: Abdul Lateef Attar > Sent: Wednesday, February 16, 2022 7:14 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ; Sam= i > Mujawar > Subject: [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield > parser >=20 > Hi, > Sorry for the delayed reply. > I had updated the patch according to the review comments. > Please review the updated patch. >=20 > REF: https://github.com/abdattar/edk2/tree/FadtFlagsParserV5 >=20 >=20 > Cc: Ray Ni > Cc: Zhichao Gao > Cc: Sami Mujawar >=20 > Abdul Lateef Attar (2): > ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser > ShellPkg/AcpiView: PrintFormatter for FADT Flags field >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h |= 48 > +++++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c |= 188 > ++++++++++++++++++++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c > | 167 +++++++++++------ > 3 files changed, 348 insertions(+), 55 deletions(-) >=20 > -- > 2.25.1