From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BAB929412AA for ; Wed, 13 Mar 2024 06:48:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=rwBZZV/A+51E3VP+NQiN/9JqfTRQyTanM5BuMO34Ct8=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710312498; v=1; b=MCpvyxETcL2Aha/p5PfiKktHe7oygAFk1VzwPz3wZvvEc/hz/6z8zWO85HU7mMbZ1CQxKcI5 +2uxFHkx0TcHiN87ZVpV7QFXMwVC8RvT5F/oiezfhqC5n7tipV6/Fk981wUTGfVF3Snwxe/Xp8G VcFxPSpoa6tILjygOAteNubWk9G2kIH1exSRNqxOXY1gE1zLz3cB3amsUlE150I9lWuH5bydgt1 YYRIXQiymP5zMbThdqBkID3OjED+56pSVbzZ2+PNp3ixkWZkRRp/mzlRk6UdO6ELsazRJ1pu0+O u7iUa10JeaYeV/Nwx9MOrxHaVvLNo8YRD/0Lai/2MyORA== X-Received: by 127.0.0.2 with SMTP id dGGZYY7687511xqYPNJvqndP; Tue, 12 Mar 2024 23:48:18 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mx.groups.io with SMTP id smtpd.web10.10464.1710312497525393985 for ; Tue, 12 Mar 2024 23:48:17 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,11011"; a="4923923" X-IronPort-AV: E=Sophos;i="6.07,119,1708416000"; d="scan'208";a="4923923" X-Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2024 23:47:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,119,1708416000"; d="scan'208";a="12389098" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 Mar 2024 23:47:58 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 12 Mar 2024 23:47:56 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 12 Mar 2024 23:47:55 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 12 Mar 2024 23:47:55 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 12 Mar 2024 23:47:54 -0700 X-Received: from DM4PR11MB5280.namprd11.prod.outlook.com (2603:10b6:5:38b::18) by DM4PR11MB6263.namprd11.prod.outlook.com (2603:10b6:8:a6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.19; Wed, 13 Mar 2024 06:47:53 +0000 X-Received: from DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::507d:aee0:b06b:77a5]) by DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::507d:aee0:b06b:77a5%5]) with mapi id 15.20.7386.017; Wed, 13 Mar 2024 06:47:53 +0000 From: "Ashraf Ali S" To: "Lin, Du" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Chen, Gang C" , "Duggapu, Chinni B" , "Desimone, Nathaniel L" , "Zeng, Star" , "Mohapatra, Susovan" , "Kuo, Ted" Subject: Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Error handling of TpmMeasureAndLogDataWithFlags() Thread-Topic: [PATCH] IntelFsp2WrapperPkg: Error handling of TpmMeasureAndLogDataWithFlags() Thread-Index: AQHadF7bqOpYSUWfWUyWUPSrSyZMRbE1Ot8A Date: Wed, 13 Mar 2024 06:47:53 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5280:EE_|DM4PR11MB6263:EE_ x-ms-office365-filtering-correlation-id: 8d447eeb-61c4-4ab6-34a2-08dc432981e0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: mL2ai5wTIqwtTgxmi6flLFljcJrW9Nu4c/+HbWl6ywnPDt80gMexqlheUGJM283leoRT4MN7yh8OVoQakjXCCWN//QcJPtilC1T3gzlKi8sJ//NVecwFGVHJ92VEiQewx7EwoMB+prXOmvPFwnhvjs4pD2DhcA/hza4nOYszaVcpwP2q3lOpzubBeqNwbXcfG7AQqC72/gJlp1v3WlaNMc1cqBjw72gF5KZv46q41Tv3IApA6vgywS9rT+KP8+q/xKkwxWIXu0UA+nF7npHbhUW2Cypvj8ZN3eaE3/mbic14AHlWb+0hSaOHatex/ZYQWcUOgxem1HBXkCLwteYsXbJBQ8wK/xb8kz0hVi0h0l7wQQlHyTx+DpQHMPaxjryQ7OMXdu+jbPAkBsORWycIYZW/Ncc7PrGQXucTfAVDvdk2dre5Ifklp0UYK1K1baAWBKmcsMf6s9E/PrazZwP7961ZDngJWqtXvMNH4o0xKKBY9EJ6DBdJogPoX7yrG4WhIZ/McrGa3NbC7pwkPRzWr2ny0qHrVzadLkyG/6ZPXVem7yAwtTz4rUXokg2Pkd/VUxkXWEycAV+4v3zvyjfxuky6OYgGtL1q7SqCxtTytZT7I4Hxa6WTjKNphUFCztQMoBEutuvg5ckO7azxDKbmcta1Kxhf93vynQiAhThlkvU= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/aNKww/uoBCUuu1u0gooy3Ji/wc+zBNOsLtsMLk0glE2+WRLq58fYDKY/x3h?= =?us-ascii?Q?1xPXhIc0qybiQ9TqFNryajPyvdTixvQcIyxry/EEEKxSKjcSFw8T/kJgiViD?= =?us-ascii?Q?1pDHW1sNd1fCvP//UnzHs+Zq0xUWzPtn+GpDs6Hhak7pLf5T65u0NyyDTlvj?= =?us-ascii?Q?kXEkQUtCmQW2d0PC5LNRweYdk5lZBSMgiLKuiOaM8f/YDKWjHgO/ZaQyVoTD?= =?us-ascii?Q?8zMU69tzT1vMPUzn8hpg2kBJC9scuji5A6mkLJiGkABtmIT10KXr5wUsXf32?= =?us-ascii?Q?LPXUjA70bw0Tm+CNWMGxyENtqMNzfNpFcFv7BR+5pECMnF2jXy9NMb5ca5eD?= =?us-ascii?Q?0KrCwDnDzJY9MkpN0Z1h1E3jFdHjaVfTo8Ko50ee/52FXEAbFGr6PjB+8Cf4?= =?us-ascii?Q?gr2ocX851/Z9vBztHGosfYCL7FyahHpl2N46K43bm8zuVPBtNXA/99yr4o5x?= =?us-ascii?Q?w4yMkbkQvMXp0gEkc3kCjPPxC1a/muSpSr7OypBEuoj3oITbYfzfrSCw2/RX?= =?us-ascii?Q?rqseT4GVv0eFd+YXAp9SFhXCC28QVnwlWvYAzlV+Bh871zf4vfbwotHNNqwf?= =?us-ascii?Q?w+lJeH0kIakZDwfB3M7mDeij+xM1PWC9xI92UFNdiqwkR1a5pJzO9x2IVsVS?= =?us-ascii?Q?13e7F3wsCVtAjQCM8rCIC5w4t5IZcgYneWpieaXLHj384avuZRqfR/isJMJn?= =?us-ascii?Q?ZxN8hMCT+yqmp3x4zALZUMAKQzG0pT5UaIyhgsk7685GaJrXPdMjVcL4BfPX?= =?us-ascii?Q?0dg8q3ed5zdBzqKUtCCfY5QTVM6349XY6lqnUCpQpe8QEPaebJU95iKPIBYD?= =?us-ascii?Q?0RIIrUP0a16+GZzvU5d7azINp+Pr/gZ3mMAM+tvo40VvOeSybVnx2HtC9PVC?= =?us-ascii?Q?ZE/ia1F0h2sSnTUxot39B6gG/5OORprquBRIfb+1F6tl/0hDtmVRrMq7wIIx?= =?us-ascii?Q?bXTLaZSezoAY3xinNXTC8KX4pyb9eM2FJV6SxuR4HyGXcG3o8KLgxWmq38cq?= =?us-ascii?Q?0syM6ep3SBfVQ3diYjDalaDwpK35HCyTQ+HMNpRIRKRu0ZfmpAQUPRki9kAp?= =?us-ascii?Q?4TCcJkk4Gl4tknUv2IEQQws6cyHqsHeFnrWBYvBRZFJahbDmLqtvInFikpKj?= =?us-ascii?Q?KqRwKvNbdNwQBXTGNlbDYUVeaY01bzIBbLHz00+JgI77/YS17+pY0PZe/OrY?= =?us-ascii?Q?Mfn/WbwwnCAYMHvJl9EphFZ6s4jGZKa9HCIXufTCaGZ6avo0Mp5hBd9I5v+c?= =?us-ascii?Q?9sFY9NaEZ9gs8uaxzENMXrXfk9AOB3QKJX7uT5Rw5yTn6+eM19YYvwqp5SIn?= =?us-ascii?Q?szRimRCCiuNEmMywYU1MaeUanIKX6QVFLEG5L8PftOChIDx9o4K3LFrlh+cW?= =?us-ascii?Q?moGGevAmnTe/cTih4W24U+7RvcYksr97qtkgZamaW1BTQF4nuymLM/XWW66t?= =?us-ascii?Q?77Qkc01SoIUbezE44Fxag39rQIcbwfgj363dUNPH8cY1TfAsD6wA9HUI6uWH?= =?us-ascii?Q?0+3nqSVgE3QNN3sSoLMCTG636z0MJH+Q9jDEXJiWAVskXiOl6TEaJ3UbymZ5?= =?us-ascii?Q?1d2qn27vdnK4MEB3eS6r+2Bswrfww4SoKgoRx5FZ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5280.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d447eeb-61c4-4ab6-34a2-08dc432981e0 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2024 06:47:53.0804 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: don5o7pidDjfMLhIRsLzHlB2lLiCEUV+nNGQCbiR3N0ZakNS2r31vJjRx8nUwvZKwyW8dwv74UY+9ON12YXofg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6263 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 12 Mar 2024 23:48:17 -0700 Reply-To: devel@edk2.groups.io,ashraf.ali.s@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: qIfbCAzb0tXqnbHTxHFthK0Mx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=MCpvyxET; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: S, Ashraf Ali Thanks., S, Ashraf Ali -----Original Message----- From: Lin, Du =20 Sent: Tuesday, March 12, 2024 2:50 PM To: devel@edk2.groups.io Cc: Lin, Du ; S, Ashraf Ali ; Chi= u, Chasel ; Chen, Gang C ; Du= ggapu, Chinni B ; Desimone, Nathaniel L ; Zeng, Star ; Mohapatra, Sus= ovan ; Kuo, Ted Subject: [PATCH] IntelFsp2WrapperPkg: Error handling of TpmMeasureAndLogDat= aWithFlags() REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4700 TpmMeasureAndLogDataWithFlags() computes the measure the code and log it in= to PCR 0. TpmMeasureAndLogData() computes the hash for the configuration. T= he same "Status" variable is used to store the return values for both of th= e functions. There is no error handling if TpmMeasureAndLogDataWithFlags() returns an error Status. Fix the issue by adding error handling for TpmMeasureAndLogDataWithFlags(). Signed-off-by: Du Lin Cc: Ashraf Ali S Cc: Chasel Chiu Cc: Chen Gang C Cc: Duggapu Chinni B Cc: Nate DeSimone Cc: Star Zeng Cc: Susovan Mohapatra Cc: Ted Kuo --- .../Library/BaseFspMeasurementLib/FspMeasurementLib.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/FspMeasureme= ntLib.c b/IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/FspMeasurementL= ib.c index 2c017a4250..228277649b 100644 --- a/IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/FspMeasurementLib.c +++ b/IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/FspMeasurementLi +++ b.c @@ -197,6 +197,10 @@ MeasureFspFirmwareBlobWithCfg ( (UINTN)sizeof (DigestList), EDKII_TCG_PRE_HASH_LOG_ONLY ); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "TpmMeasureAndLogDataWithFlags failed - %r\n", St= atus)); + return Status; + } =20 Status =3D TpmMeasureAndLogData ( 1, -- 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116706): https://edk2.groups.io/g/devel/message/116706 Mute This Topic: https://groups.io/mt/104886875/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-