From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web08.30945.1661256406146606041 for ; Tue, 23 Aug 2022 05:06:46 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=lr3gQOZB; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ashraf.ali.s@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661256406; x=1692792406; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=QAqQD0tLbamYCyrnhGIe6VQLdlmGfj6vUNs0baFSCbA=; b=lr3gQOZBkWliZd34IckK6KZZyZariB2dNsKlRrzvAmJLjor61iFP3cqM QQxT/sMIlXSA3+LBWCReUO1btJ/VClxkI9rJRxvNxgd6nNOvF2PUEwGth +KTxwy+UkykoAu0D941WDCNJcrZ75exFq7YOwQajzqNFQMsRHevAySj/u +qDdfVeE8FqHIha0CWe0yJsbS5bgS3wDC2ZF0oHIj0W/akOwlx9RyIGbM 7QG0beeiwqfGvwNsDEM37ih5mjbfcdqMymyzbWifLtRqRKFiWd2HWYJZK YkCwwNJKjXGrx1JmHKLqotdxCb+sNIbGvPFlpgCxzRgfl13U2qEyQAhB8 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10447"; a="280641104" X-IronPort-AV: E=Sophos;i="5.93,257,1654585200"; d="scan'208";a="280641104" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2022 05:06:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,257,1654585200"; d="scan'208";a="670003721" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga008.fm.intel.com with ESMTP; 23 Aug 2022 05:06:45 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 23 Aug 2022 05:06:44 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 23 Aug 2022 05:06:44 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 23 Aug 2022 05:06:44 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 23 Aug 2022 05:06:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jCsUCkOB07Z2aNwHOvO3AtKn/+eG0EjFFHZpvadPoFGqw+euQoP7CefnNABajyOSFgujBARtY7zhIc3RPQFG0tnrEpWEQvA+bsY7JqU275zCYcs/ddqcMlylR6rhEQy/KGKkamYK79HmW3JwiwCcgMrKiMQELWWIEtrNmj+sjWdXd2anQKSPL8VKlC8XXlY/d5VBZKW5jnCtjlgysyFGyvr/BBt9+jW2JAkT2OBac7zYEMcfQH3VlB+vFp5OQLbBkmmcQdvH+KCi0iKQnAC5Q0Fp2upIw/G8YfxKQxmLNVbm1c4czdcpOSei4VxRxvqU3YT2MnnOjmBRQvmewCUddA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UewKL06VkKcH5gWX2QA3Ze+vBaChP2iL4Vxqjl77/vM=; b=EowVuoRCebKi8DAYmkh6ynTvZEkmvHWeVbDjGSf/s6PgfVSiuKO8sof7S9ubS8qJbxCD27V0pa/VolWwPnE5TP+hYI68cRWUTu8NTcbR1NeQMVY/y7PuECSiNCAmAGmDncwUY0WxFieeAkuXzOpNVFRXEM5nMzKdiXRw3YOl/NZ13+ddes/V8q5kJa291pTYugVHIgEIOwqL220ypLVWDK2/imJJEQMuL/Z1uIQKxlnX2EPnFJAvT5hkKB+ZXYk2a3FRI78o8YjIFXrimAQ2POTy2XGRcvcoBqCfcTLFPmrvSadPQ8zTei8kV4cQXKGSfrmTmBaRc7+sfoywW/6W0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5280.namprd11.prod.outlook.com (2603:10b6:5:38b::18) by BL0PR11MB2930.namprd11.prod.outlook.com (2603:10b6:208:73::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.19; Tue, 23 Aug 2022 12:06:42 +0000 Received: from DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::f47f:f918:e0b2:1074]) by DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::f47f:f918:e0b2:1074%5]) with mapi id 15.20.5566.014; Tue, 23 Aug 2022 12:06:42 +0000 From: "Ashraf Ali S" To: "Singh, DeepakX" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Chaganty, Rangasai V" , "Oram, Isaac W" , "Pir, Ovais F" Subject: Re: [PATCH] IntelSiliconPkg: Fix DEBUG macros having incorrect number of arguments Thread-Topic: [PATCH] IntelSiliconPkg: Fix DEBUG macros having incorrect number of arguments Thread-Index: AQHYttjbNLSjaUS9K0uR0dYLrZ4lb628Y3eg Date: Tue, 23 Aug 2022 12:06:42 +0000 Message-ID: References: <5772c493456f9e5c7ac7c669d3f9d07084c9b8f0.1661249378.git.deepakx.singh@intel.com> In-Reply-To: <5772c493456f9e5c7ac7c669d3f9d07084c9b8f0.1661249378.git.deepakx.singh@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1274088c-4ad5-4cfe-53ff-08da84fff11e x-ms-traffictypediagnostic: BL0PR11MB2930:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WeM4DoFfH3psebGr6NHMHY6cPCc6+NibfmJ3APSOJ18JfGSi//FLIZz1ZnWUHv7/m8oAP8wYWVHswmWT3DEabj6TAJCyhaGm4Rxiy7g7f0KWPRzx1+A+fGN23GclXeeYf+sZ5jy2Rm//HH6RdAHeOSIL368U1ucYiRGeB/COP8FYonf+P+daoQ+jwS25wyAkG23iBOEKavMamuWpDBQ6j4UblWPNdACmAEnTlKcSAKyHcF4WKawcXsH2B/tJg5PhcBBgtv5fkYaS8JQDUiTcCJnquaF6KHwNu8D0H+BwKC1Q8ZqaFhFx1Kdlj2aIBESx8JCX7QEM7wUgWkTqj/43BefLjqw0EnAjamffMfRG/3CmC1Vftu2bE7obMMrUw22a+GNoTmRlQinrLQUSxMtaZUoq0PDG4uar2eXejaA0W+dednnzKnUG6/h7qWZoNdqV9GcIeqCNhEbOuAnQILPtpqI3rLkd9MwHl5umE69CRUQChd9kybXL7RBi1F8Qdp0gkfRMWIu2ls4GywZHHAtbtbJFUAvGFXgIGqQCPAq3MQkJjkvHjqTuzMcDw4feOtiNn/ws/0SbLBqSdDd6MmfRcDlnMELb6y7nAd9LzKktJTVUaSy0gNfDYLSOSj8VadJBGJ/0FBENOdzcnmedj1SF2HalCFqgf2ly2BiveiqPb4igFha0zFUgPJqefctBy09qzSuVfahzJ+hRgQ3iRPq/ie8WBqYNiXzwLXKR5PsetlzEsT2dZxgL4xv8yKcDfZezAMWtdipCBDQ9WP6ONwe6PxGgeyH8tV0YySfmaLDlhOs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5280.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(396003)(366004)(39860400002)(376002)(136003)(5660300002)(41300700001)(52536014)(8936002)(71200400001)(316002)(33656002)(86362001)(76116006)(478600001)(66556008)(66946007)(55016003)(66446008)(9686003)(186003)(26005)(107886003)(64756008)(66476007)(4326008)(8676002)(83380400001)(82960400001)(38070700005)(55236004)(7696005)(6506007)(122000001)(53546011)(2906002)(38100700002)(54906003)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?usd31HMPQ91NuD3/sCzbFrULVqdQTE3RLHLgyvOkVPuC4WayX8p+PRuHcj?= =?iso-8859-1?Q?cFtDNJtbg169MO2+46H2lY/HRQcprA9gQFHHGGzNtXpiMNeQ8BWro+vi4B?= =?iso-8859-1?Q?JTf5zB8NuFB2+UigSkZ03nZ8gWTnCXKR1ogFVV19ZgpXk/VPwu3r2ISYpu?= =?iso-8859-1?Q?SSzwPHCNqi3flf2ul2ZufNlcUV6LT7pC1itsp3WikWjfFlnc7kG/0Aut1i?= =?iso-8859-1?Q?+5xUOMzJ1ei62Q57QQvF41xdYR8/bq/rAs/qg0E+qV0Ui3DkUy2Nyh2iTw?= =?iso-8859-1?Q?V0VIxh0AB0CjbjxKNL+MTmL98+SRhEpP5BoPd5f1tv4VAba3C6GAGYxe2P?= =?iso-8859-1?Q?qxcPMmJVdmh7H0hgZlwPnNs8Yinbs3Wx5ovvxp+LphdvmO9DmIi0cq+NJw?= =?iso-8859-1?Q?IbHM7OEJ3dpPYAfskifSiah76yZCEiSTZMoUcgJEFoPEnn5xZ1rutGUnyY?= =?iso-8859-1?Q?W/K4B0mlhVjCxSp+d3svfIYCpxSEcATRLwBCe6pdBUEF+m7w6lVFxt9Jcq?= =?iso-8859-1?Q?Lw0Ye3fq/x6rXw+C5PROUFv8XxTnetWVpBhYFmMXMSVMwnZT2vzyIX+8Sz?= =?iso-8859-1?Q?Te7kagSkTI9CmrlgB0CmR78Zly/n5f4BazZF/DM6JCvCWCcbipmfJ+DwTC?= =?iso-8859-1?Q?XapGlJH7roXAYbtR8o3jY7XHfneephMkRJyVm0pOJBT1piljKS3MLa1JRS?= =?iso-8859-1?Q?6yAHpVB51cCalqitjo/Ey+qY41AiIjAM62YBjA2JWU/K4cs6+cnyPtYg6h?= =?iso-8859-1?Q?cw++f+benNOcmXegvCBeTRPEgFNkOFCy4fa83kE5rR+nRYS+eRvIZGIzPW?= =?iso-8859-1?Q?N56qxyiImYJC84hRgDYNX0gI7zAF+uqXLotXSIMN/X7RiS9BBLlfXsZeBg?= =?iso-8859-1?Q?IiOItzktLW1gBCtUx471BjkdlfwTligx4m+6dU6NLlmRP+XJ44dftlyHdv?= =?iso-8859-1?Q?6JMi1pfxSRvVOOwdzqVTRpWrd6paFmHL4+Nc73n1y16EZxbgFdMJj8toWl?= =?iso-8859-1?Q?s8/m9R0sN5CDv2cPwVVEV7/95HDsEb4U/WiiPY0nxvexzzjw5fanvKVo93?= =?iso-8859-1?Q?m5eFAzwLzFNV38ngoIbGw49ELQN/xd1asmrjk+VXDDwaszGw0onzaTc+31?= =?iso-8859-1?Q?h8t7XmX7a4GCWCpX5VNcx4/D8g2II0VPp8HNMhThAXDcOYhobQ1B4mR0E7?= =?iso-8859-1?Q?aAc4t5i4VPMRq/I1+jcLFbs/6Alw84PJ0V5kw3gP9xseIRDUKRWZNeRcaG?= =?iso-8859-1?Q?mfEkW3QfxGuySJY33l7ZzWb3uOOYmQFK5cBabIOyaHhgb3H7WM+B/uhUhb?= =?iso-8859-1?Q?AZf87lh5ZjezrY/xa1WzTX+YQyhhhfG9mU+26qh1mVUQSqR10IhDEZrXR1?= =?iso-8859-1?Q?7uCDN1oC3837u97VREPqndGL1mZ4UsRrirj2Mel/AA5hXivEo8xcmXzf2J?= =?iso-8859-1?Q?/5emLTfEAX3xX39xqlKXmu7G4AkACkTvE3tD3x30sKYtgpuyjH+dJk5wvz?= =?iso-8859-1?Q?Umsmcp8AiKlAR1W1aK1xks2KG9rIss8HyvNoD+EmRcebBHLaO/Dk8KsDuJ?= =?iso-8859-1?Q?5mmIaXa7GlJb5psreJQ/UjN5xPpdzrmQwZXagE6kBxMLznLGWbjqpQOUwl?= =?iso-8859-1?Q?iCTZdp9oyDR8/7jTBolblhOYmQ0txwSWn/?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5280.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1274088c-4ad5-4cfe-53ff-08da84fff11e X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2022 12:06:42.2544 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Wyn3N9Al8Qwp8f1S0SvJJeY/IloyVk0WGSlxPXQwbSzqVVZfWl/YRxbQSREjQTcj6wR4neLKbQucVgwUtCQ1fg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB2930 Return-Path: ashraf.ali.s@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ashraf Ali S Regards, Ashraf Ali S Intel Technology India Pvt. Ltd.=A0 -----Original Message----- From: Singh, DeepakX =20 Sent: Tuesday, August 23, 2022 3:42 PM To: devel@edk2.groups.io Cc: Singh, DeepakX ; Ni, Ray ; C= haganty, Rangasai V ; Oram, Isaac W ; S, Ashraf Ali ; Pir, Ovais F Subject: [PATCH] IntelSiliconPkg: Fix DEBUG macros having incorrect number = of arguments REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4027 Signed-off-by: Deepak Singh Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Isaac Oram Cc: Ashraf Ali S Cc: Ovais F Pir --- .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +- .../Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDev= iceSecurityDxe/IntelPciDeviceSecurityDxe.c b/Silicon/Intel/IntelSiliconPkg/= Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c index aa2bf14fa8..7a70dc7aea 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecu= rityDxe/IntelPciDeviceSecurityDxe.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecu= rityDxe/IntelPciDeviceSecurityDxe.c @@ -488,7 +488,7 @@ DoMeasurementsFromDigestRegister ( DEBUG((DEBUG_INFO, "\n")); } =20 - DEBUG((DEBUG_INFO, "ExtendDigestRegister...\n", ExtendDigestRegister))= ; + DEBUG((DEBUG_INFO, "ExtendDigestRegister...\n")); ExtendDigestRegister (PciIo, DeviceSecurityPolicy, TcgAlgId, DigestSel= , Digest, DeviceSecurityState); } } diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c= b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c index c7a56cf571..ef1737b1b6 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/VtdReg.c @@ -642,7 +642,7 @@ DumpVtdVerRegs ( IN VTD_VER_REG *VerReg ) { - DEBUG ((DEBUG_INFO, " VerReg:\n", VerReg->Uint32)); + DEBUG ((DEBUG_INFO, " VerReg - 0x%x\n", VerReg->Uint32)); DEBUG ((DEBUG_INFO, " Major - 0x%x\n", VerReg->Bits.Major)); DEBUG ((DEBUG_INFO, " Minor - 0x%x\n", VerReg->Bits.Minor)); } @@ -657,7 +657,7 @@ DumpVtdCapRegs ( IN VTD_CAP_REG *CapReg ) { - DEBUG((DEBUG_INFO, " CapReg:\n", CapReg->Uint64)); + DEBUG((DEBUG_INFO, " CapReg - 0x%x\n", CapReg->Uint64)); DEBUG((DEBUG_INFO, " ND - 0x%x\n", CapReg->Bits.ND)); DEBUG((DEBUG_INFO, " AFL - 0x%x\n", CapReg->Bits.AFL)); DEBUG((DEBUG_INFO, " RWBF - 0x%x\n", CapReg->Bits.RWBF)); @@ -688,7 +688,7 @@ DumpVtdECapRegs ( IN VTD_ECAP_REG *ECapReg ) { - DEBUG((DEBUG_INFO, " ECapReg:\n", ECapReg->Uint64)); + DEBUG((DEBUG_INFO, " ECapReg - 0x%x\n", ECapReg->Uint64)); DEBUG((DEBUG_INFO, " C - 0x%x\n", ECapReg->Bits.C)); DEBUG((DEBUG_INFO, " QI - 0x%x\n", ECapReg->Bits.QI)); DEBUG((DEBUG_INFO, " DT - 0x%x\n", ECapReg->Bits.DT)); --=20 2.30.2.windows.1