From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0DFC474003A for ; Mon, 11 Mar 2024 11:31:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=lyXTwv+Yhu8I2SMzIemAnVQd5z7ATbYp918ZLtfOXuc=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710156673; v=1; b=py4Vm75JY+9GKE7T3cymBTS6MlK4l14bk+1q0W76uuhmu1c8ZQ3dPB08rENtP8DJzaMI6Krr n30AC+fDAhQqGN3RljxFqcuhAP42EWgfNfl7x26w3F681dZwYCkeaKHiAG6ZNYFZH1RiQiDVt7Q Xfi/BeVKINv7cmDH8qB/31/j+X2L3S3roBZB3KFLfnM28W/31VmktsnNdY+GFDUFdaw6I8SpEmP 0RZqCzkJWpNI//CjKopWXGrjPa/OiTKneh9GKR2XF7oVfXCyZpKm/uwFGtj/n702sWT99HqU/It KAn79e9F827RGGOV5y+Zrh2Lmj3kb7PEieVO8trQ3hoCg== X-Received: by 127.0.0.2 with SMTP id msTBYY7687511x1lBMOJML4Y; Mon, 11 Mar 2024 04:31:13 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mx.groups.io with SMTP id smtpd.web10.60380.1710156673103558388 for ; Mon, 11 Mar 2024 04:31:13 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,11009"; a="16213980" X-IronPort-AV: E=Sophos;i="6.07,116,1708416000"; d="scan'208";a="16213980" X-Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2024 04:31:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,116,1708416000"; d="scan'208";a="11221850" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Mar 2024 04:31:12 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 11 Mar 2024 04:31:12 -0700 X-Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 11 Mar 2024 04:31:11 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 11 Mar 2024 04:31:11 -0700 X-Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 11 Mar 2024 04:31:11 -0700 X-Received: from DM4PR11MB5280.namprd11.prod.outlook.com (2603:10b6:5:38b::18) by MW3PR11MB4699.namprd11.prod.outlook.com (2603:10b6:303:54::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.17; Mon, 11 Mar 2024 11:31:09 +0000 X-Received: from DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::507d:aee0:b06b:77a5]) by DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::507d:aee0:b06b:77a5%5]) with mapi id 15.20.7386.015; Mon, 11 Mar 2024 11:31:08 +0000 From: "Ashraf Ali S" To: "devel@edk2.groups.io" , "Chen, Christine" CC: Rebecca Cran , Liming Gao , "Feng, Bob C" , "Chaganty, Rangasai V" Subject: Re: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while parsing FMMTConfig.ini Thread-Topic: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while parsing FMMTConfig.ini Thread-Index: AQHaaiylt9r5pEVr2EuFhPJAQJDAgrEyPaAAgAA9PAA= Date: Mon, 11 Mar 2024 04:31:13 -0700 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5280:EE_|MW3PR11MB4699:EE_ x-ms-office365-filtering-correlation-id: de5b144a-f123-412e-0ab0-08dc41bebf2b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 1sTfIZirWrHOunR7mSpxGqhXtSz/XLrGnYFVbe9Ftuh8UvTA/t4X7ErpZkl+pAx2Lokvj16LIbLuBIXcL/mkuVV8dY9caqZ6FbCZYJejrrUE+EdbLZS9rmj3aOF9l+6yfI/p3ExD21rFL184+XfeS41SNcmskj7AioUdeKyK87IANZGaGm/qOW6rZ8U9MgW1y6e+XOvFvpPN4L5lFSXsdnplmzLL54mHV8FyT52SSZf/81VcvgtQOHnPkVdp9xefxDO4afLmtM0upvnURxdzxJhHfI4SW4qei+GKVFp+y9E6DX2NbxBusDRA7CBpH5MjhGwXpLKjIdJ00f4hN5QXfvyq4qiN+ztE9H5RQfE1UEjkYtMIGBKpEous0ZX7Vb2j0nwji84dxJoAY30fzwtFw3xdT0CoBXUGWi9hFxZmFR1yXsca75ooLIYnZnidGHUR1MOCQeUfLUElWSXsVBUI6ibLv+Ak5y8MVADl1mC+e79dqbMrOyZy2NFMhNtYkq2SicZgeSOWRHawiH/D2cmnmoWZnGXLulatDj+VJ9WB2bjoD4Kn+vOoeexh6m3GHfcK+I7J8Xfmy1QN275+lxvdixTZAGVsHYhh0t0OoIkLd7CnQj6ualkLL6sbM/bex+UdvIl5QXGDk92giYAbgoUBNmnmMbUOiK6jCrBxVs+KqsQ= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?G1mEwKOB/ifFrGu2FgZu5kWe/cOCURhLwobEO69X0PPQlAu8ec0yJtkb/M0j?= =?us-ascii?Q?llTMAOlVdFIvIrT3eleCj/Nq4kmvr88r+M1UUuzr46i8d99FTcFDnsgCE/oT?= =?us-ascii?Q?zTEWFojNoi4w+i+zJCNWGq4yP1/QYao412FwxSTmbmyMT6KYOrqkMA/1Br3p?= =?us-ascii?Q?7AOfhmYAZcPXeBHftmfCL7/WOKhFjT+h6BQTZPiJ8hE/zsdob4Ma4xfoumcJ?= =?us-ascii?Q?hzFaKV7C2CLL6Cb5JTX0IMMfEhgTb7u9Y00hMrDjqT1uHSCAYekzodWXk0kw?= =?us-ascii?Q?VzklAWXB+puSPV6QHMmr2t1N3RRP0kBXJQrYxVqlTXCQBYBENNmqA+0yWWM3?= =?us-ascii?Q?o1MyT+I6r23ugPK/CyRsfWmxpEKL/5SX1wZu8+qgEjgss2H+mbZPRFtAoiKm?= =?us-ascii?Q?7MjcWoPbBgAJZal11ZUWe9XnD/4J2/eh7to8ixpdLUg/5Ga7YCVlImwmYs9v?= =?us-ascii?Q?cGPKt/IHJg/D5SbRB+QYoFbm4loorMVaKj2w4l+k1KVoFW9lgOaWZbn3yye2?= =?us-ascii?Q?4xjI0r2kJcMZ7ylZpIm6La/7DAuY153Xu0fzj1K8V2xPinsxY8y7lr8mi/f8?= =?us-ascii?Q?Se+rjYQ1ue0Hu9E8zgZRqNY9E7k5N6yNT+ItLZ9ngn6lxmTdNqnlmcJaOU1g?= =?us-ascii?Q?MC/fjZWW+Zk9meby3IMZDO11xjyUFasEcK/KXZ7Y0TGfZEm15mjeoELNp+GI?= =?us-ascii?Q?FacU7Tuqu5NvqQoO+IS6+nlxb7KBDrchYTNBS8AxeC9ozIVnQCZRzw1xEgZ9?= =?us-ascii?Q?GbeGEsAC3hsZLg+PyJkfAj+caZ9sIYrG3uGU9IBQQQWYXXFj08eW+4A/rnSl?= =?us-ascii?Q?mZLrBYw2ETVUOlW1DL+Jzr202xRmy9B67Imud2cztE0LF2d5s+Zk6cesNIOs?= =?us-ascii?Q?FCbLoSCcvCLZSsYtPLAlxuihPl4ZinBpxeMdeFT5KeIcrv8fbpE/npGTaO/L?= =?us-ascii?Q?I6lJEO8xVpuQYHAxiNxtadnbphF7eizYuIOGD8ACCv0VRLyv/vWVRKJ3i4Wm?= =?us-ascii?Q?RrQ9UKTTjp4amTM0l5lq0H8qY7aIoMGRQ79ZVyHZCVAu1VuIwYC0yS7oHHGS?= =?us-ascii?Q?JMD2e/iOyiAyjDlpCqShRX8CvWZRWvx8Ib4HWGBqomjAYP2i38SXPRzqP+bD?= =?us-ascii?Q?R9wSukGChyMyn6SUenqAUBtwCTazPq9aRDGfJfm8997pncTXxoAaqlwLJisk?= =?us-ascii?Q?CKbUIz+CHNUNpmT/BX9M7lj8ab6hh8klI9sT9g8i31sTGlnNMvZ8d/sBJyUu?= =?us-ascii?Q?E3pCOoJBpv6j8+OThXxcRnpZbgilnf8MQzjWcZWnZ92sz3rXhHTqbEucMFNJ?= =?us-ascii?Q?WqGCou/ceMdwe/3IuLLucgJU/q1vgrZTG7U3QePRecSj+wxeBwhlr/Qijbll?= =?us-ascii?Q?yF3crRsYTPsISbN6IFMHY22OjEheo5DTLiFoW116hTM9CdizUNVNuslAesSP?= =?us-ascii?Q?XalW5Dc0nFZpNPK8hTjmX4PfqDlaOU56um1rvmCugJDqQHMmUdV+9+JYU9yi?= =?us-ascii?Q?MMsb5MZmNnWhTCDpFrf+BAIK9bhwnb37Nc2H2X2ufSHa4DF8g2C80us4iZlt?= =?us-ascii?Q?Ay8AO4bps5wYFqD6iNuwFL8OS514Vcm7igFBa0ZC?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5280.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de5b144a-f123-412e-0ab0-08dc41bebf2b X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2024 11:31:08.6579 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4AKdfc7BBfBgLceauATZ3MGeRTVHY4LmCAGPOMNH2olLNxSW/QwpEyIac94/rwecr8C3sSvCR7hSsvqLqpX+8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4699 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ashraf.ali.s@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: NRnQVwVYzXy4QdTNhqEpsNLcx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=py4Vm75J; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks for the review. I have triggered the PR under basetools : https://github.com/tianocore/edk2= -basetools/pull/122 Thanks., S, Ashraf Ali -----Original Message----- From: devel@edk2.groups.io On Behalf Of Yuwei Chen Sent: Monday, March 11, 2024 1:22 PM To: S, Ashraf Ali ; devel@edk2.groups.io Cc: Rebecca Cran ; Liming Gao = ; Feng, Bob C ; Chaganty, Rangasai V Subject: Re: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while pa= rsing FMMTConfig.ini Ali, please also create PR in BaseTools repo. Reviewed-by: Yuwei Chen > -----Original Message----- > From: S, Ashraf Ali > Sent: Wednesday, February 28, 2024 5:57 PM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Rebecca Cran=20 > ; Liming Gao ; Feng, Bob=20 > C ; Chen, Christine ;=20 > Chaganty, Rangasai V > Subject: [PATCH] BaseTools: FMMT Skip empty Lines while parsing=20 > FMMTConfig.ini >=20 > When the FMMTConf.ini file has empty lines then it used to throw=20 > errors GuidTool load error!, this patch is to skip checking for empty=20 > lines in the ini file >=20 > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Bob Feng > Cc: Yuwei Chen > Cc: Chen Christine > Cc: Chaganty Rangasai V >=20 > Signed-off-by: Ashraf Ali > --- > BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py > b/BaseTools/Source/Python/FMMT/core/GuidTools.py > index f6bdeffa50..f9cfd4ead0 100644 > --- a/BaseTools/Source/Python/FMMT/core/GuidTools.py > +++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py > @@ -153,7 +153,7 @@ class GUIDTools: > config_data =3D fd.readlines() > for line in config_data: > try: > - if not line.startswith("#"): > + if not line.startswith("#") and line.strip(): > guid, short_name, command =3D line.split() > new_format_guid =3D > struct2stream(ModifyGuidFormat(guid.strip())) > self.tooldef[new_format_guid] =3D GUIDTool( > -- > 2.42.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116611): https://edk2.groups.io/g/devel/message/116611 Mute This Topic: https://groups.io/mt/104620514/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-