From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 218A6D804B7 for ; Thu, 8 Feb 2024 05:49:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=rbvCZslgk7Y7Dy/jC0a6OqwoqYeGMHhPIlyw5MVPkaU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707371385; v=1; b=m4okkWS6C+kgfCIf8IQs6on6xL8oZvZQ5kKiFaxGD2yiLP5yERxNSeKdBaRHAgdv1zxQPJ1V oSTqZY52SvmRt/LAvf6aSVff3VYVqKQqMrld587f6FvcD4AZq16JW64YfQHiCN4N+tPA/ptjaEp 8efTOHeC67oGp5U9qfhyQdlc= X-Received: by 127.0.0.2 with SMTP id w58sYY7687511x5Ev6iRO4ha; Wed, 07 Feb 2024 21:49:45 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by mx.groups.io with SMTP id smtpd.web11.12067.1707371384663224447 for ; Wed, 07 Feb 2024 21:49:44 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10977"; a="1049757" X-IronPort-AV: E=Sophos;i="6.05,252,1701158400"; d="scan'208";a="1049757" X-Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2024 21:49:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,252,1701158400"; d="scan'208";a="1848703" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Feb 2024 21:49:44 -0800 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 7 Feb 2024 21:49:43 -0800 X-Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 7 Feb 2024 21:49:43 -0800 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 7 Feb 2024 21:49:43 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 7 Feb 2024 21:49:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hqlS6P4JhpgQ6W8APGxfkVND0B8g7okpBiXZJClH2M8QsMMcSSdzgu0aVLVBzKthHUM49bV77J52eC28NmhPhXBHEYQkHVpTpQs+1agg7c5ayDxm0Tdxf2GbeuHYYQ2IIpx2H7rJes75XkeSEuyTD4dHXXxCCAKUILnIpQ05H1ISV70NZFTJ3MrvystImst8lPNMX/wIE5vxV/y1WS542JGU5egonywz629B156HwliphflRz1se+FJb4LV+7BCC4t1gBOAxOnHdXk781nLuqm9UTd94Gz4R9xSMqr0ueZ9bt8ty7nthvuzHeWJZ8Bx7ud0rMWQ/zAlXHxIZcJRqfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KOPvIjhxDGCyIhT5Hk4RfnJK+kb+sYZN5v8G/hnCflQ=; b=WztL5NAhJ6D+c0bjDmoLXCbYXzS4cq3AUD6PG1+7Z6KYPm/ItucMn3R4xx8KtffJOB1fgAKZwv+E7JGKXZOtxB1F9MdWWyCvjAUuHOq23IDktaMVna7nYP25HdJ4Fq6XOcI4d/SjUJI+syYa7WVHYiNaqiOxcZyO8UmffhX2W3VGQV6D1aWoE6iS+w1uZz6R394YphJeSwF8XpwageNl6YiK2wYvgOV35GqhfOccf8asP2p9KodjwDdiog0Tgdhgfkcg0DXf3m2fbphrN5jYNJj9Y0IdfotkRc8+oC//0O5MpWiQ+bGTbAByAmfY0MvQ9SafvVi0ril+h4qWLIAknQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from DM4PR11MB5280.namprd11.prod.outlook.com (2603:10b6:5:38b::18) by MN0PR11MB6112.namprd11.prod.outlook.com (2603:10b6:208:3cc::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36; Thu, 8 Feb 2024 05:49:41 +0000 X-Received: from DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::13e7:7c59:f658:63ba]) by DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::13e7:7c59:f658:63ba%5]) with mapi id 15.20.7249.039; Thu, 8 Feb 2024 05:49:40 +0000 From: "Ashraf Ali S" To: "Feng, Bob C" , "Chan, Amy" , "Chen, Christine" , "devel@edk2.groups.io" CC: Rebecca Cran , "Gao, Liming" , "Chaganty, Rangasai V" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId from allskuset Thread-Topic: [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId from allskuset Thread-Index: AQHaN0b+8o9rueGEpU+i0x9HUIB8Q7DPJOiAgAA5LYCAItTpgIAOAoQQ Date: Thu, 8 Feb 2024 05:49:40 +0000 Message-ID: References: <2fcb6a95d99dffa093011850548712054ef7e813.1703518030.git.ashraf.ali.s@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5280:EE_|MN0PR11MB6112:EE_ x-ms-office365-filtering-correlation-id: 8229de5f-7913-4660-d786-08dc2869be11 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: DF2llj5QYBWq0HpkAoObM13NpQXEaKEOFkE/KOtCvaUZb1a2RQHFgmzgKHR+/AHJ+sr6+hHV+ayGHbzksEnhQ9eb1euvsKbEgvCw+JVQZNxkov5ueDar9jjdqWnLhzLaSp5l/DCcFDLvriIF6/IGd0uhqb44dNkkmtjNUI6ka6Hu8T8mbWuT7YH03yjBRJcH1g0rhHbRUNOuTeYhZ+9GrzAIWRsmb2PnaoQvUywn6nyk9p3OhS0wFNnhpdNO9NbvnB4VW7dPHLibokuUBvlA9kKFTp/JseK0bxA0AIMwWjEeHVXkbDCcA4nsbSI9KeZm4IAf74Cv2LHdlgVGZI5Rzk0USSU+8jLZMtM6x6l4u7wK18P/F/H/P64cIFADRQiUKk9UX9sKMAsBAF/INcseXunjCZDQKuq44vGQPuwsunTUXn/Rbv0YCNdLiX+ASZ1jLBSTlrBrwG7P1vQRuwoe8rG1j+8ifPr0t084VSpUUXqtb1fPYCwyfdxzM0rE1eYZU2XOB+ZYUuF7ymFCs2IoOhIJI01nMw8yyJ+TlWqNif0glwixac7u3evjWQGon5fj/k3OeOcOprvCgiyX5pgZtGmeNpiUoxP72jg2OVUFGSs= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9I+on5KdLO5DZcm8BC+1Ymtr2sCxeC5q2Nu7lgiSd/XSa63bh+QLPrpWf13a?= =?us-ascii?Q?9WzVbLXjxQJ6WFCf0X2GTzz6P2Cy6Bp7Gaupy2BIeD0+zZQKvcluamk8WUlq?= =?us-ascii?Q?ZYgKtfHejTo9sEwhVtfKsuTQxpVrwVoiYu4/PEJaq6jZYKU0cqJ0n0FpecvK?= =?us-ascii?Q?D2p3rIusOznxqKDKul2YfnSwbwq5ghzgdnLvCjaFt+LztwUb2Asf1WvBpFnk?= =?us-ascii?Q?Gw3FxFge4TeWa5585OkO+l7vVqxcGi9TWeWHDsplPox0gKQrwy6JnoYjqnQ5?= =?us-ascii?Q?FG1u9mHlkB0maDOSDEiiNOBTm/Zm0uQCGP32m+N4zoS67Ki1/pAc8uwrM+6B?= =?us-ascii?Q?fIyNIB9Vqk9Hc1shoYk2V0Dtaw0GJLDhHelRI9t6L2MXH4HzBKK1TgchR/wZ?= =?us-ascii?Q?zTlBzcawfSPUelNNggnfpvPxjGciesb7/ZUl6dQPrxrbbstxhJF8SQeIsD3w?= =?us-ascii?Q?aMmQhNnhdrA9Uqn767bciWlCGpl3APRANWpqDFvRPkuPm1S88/bcZG5H0JR4?= =?us-ascii?Q?Nk23XamZYe1xIR8w1GLBKQSCdfbsgrEjsZIQ3mWJ1oCec0NxsMdPDXkRvHlJ?= =?us-ascii?Q?gL6fjUhntUVteQ+uyEYiDXqVXoyQqo6uV9qNczG+CQxy+F4IRaG4TZA2vIS+?= =?us-ascii?Q?KKwU+kmoW9W2R46pjzr9Zfl2HznKGpJfMIIfw2KdYafJPhzBwaqH9jW6aMwd?= =?us-ascii?Q?M+Z+ELRw8CxpqQ7hR+O/JcnRUcDVY3QVv24wusqlV5SmlX3FXWToouL4f3lW?= =?us-ascii?Q?eaeOt39fyScomKeMMaVH0Aspw2NwB0YuvjhYOUdirGS62F7eUKB3X7t5nGHs?= =?us-ascii?Q?EB4yU3lkdxSYnmAEH2YGXa++1/yr3ZLJ+VcWOzlEIUN3nh95U/Fu8Y6VMyq6?= =?us-ascii?Q?8gK+/pd/T8iCoq2xU1A7NOg6xYi6qD9TwGhTddC/FW2N3sTl5RGsE+x1+Z+y?= =?us-ascii?Q?8D0ApGUIz0OCtY6+eKezPKbBOoxJRZWaeH2VZ5LbgDBtj2nA4g9ztD9aAbKq?= =?us-ascii?Q?C4j8E3M/zmO3CLYXYunPFPOs7AVAV1+53L1ehxThgRSBy5NPNOVkgQDrRaEX?= =?us-ascii?Q?o9AIvlgMDYz62jffJaoTyU3jIPCMmKo6ysn7J3KhB71IIt4uel6U3p4OzB5a?= =?us-ascii?Q?GYKh6krTAsoVf2WpL4AKvSIl2pvX4/Zq0HHbxDMBqxnmUqQD1EKBYAUkmBLM?= =?us-ascii?Q?EWEro79dzummxjqR03Xx2xF5/nUBYqXK/NOKOexSKSwc9JNaE9Wn0zeVQLdB?= =?us-ascii?Q?L+aWoUtY6IoOnLwk/HjEpdroqgZxeb92J+N5cjMQZaVyUqj5e1YIi0yLyxPL?= =?us-ascii?Q?0GNPtA1vo2SSS98xlG8jGHp56KNUeN+NoF0wlumc8mr6qI+J+i/2UqjqM87T?= =?us-ascii?Q?ConmUavpPi/pi8b98lNhmUcBRiVkqRSbs6u3PTucssl7Sv7sSFlTiH5W8CHP?= =?us-ascii?Q?9+QDARerTi7iGlRPQz3FKuu1ORP4SCczCU85DwWm4UqKl49GD/HBbzZ3wfYp?= =?us-ascii?Q?8wGkmKg8K1CupC/7H417x9Xi0yol4fZXv4tGkVMqVdtf/2ppW+mayasZoN9+?= =?us-ascii?Q?5Kl4F3UlehlZX2YMdhFEMqpUtox0jwUK4boCWo7z?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5280.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8229de5f-7913-4660-d786-08dc2869be11 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2024 05:49:40.4797 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HNk9SenDi0j4i4Zpx06ifMTPrWiizwuljpchL78yIQg7Wxj2GIsR+n6Qgk7RzmbnKEVQ79S7UYGTjgTFoGhIoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6112 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ashraf.ali.s@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: qLwE0qzSUor7IjhePO3WePvmx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=m4okkWS6; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Is this patch merged! PR under base-tools repo : https://github.com/tianocore/edk2-basetools/pull= /112 Builds are failing, looks like it's not due to these changes. Thanks., S, Ashraf Ali -----Original Message----- From: Feng, Bob C =20 Sent: Tuesday, January 30, 2024 1:19 PM To: Chan, Amy ; Chen, Christine ;= S, Ashraf Ali ; devel@edk2.groups.io Cc: Rebecca Cran ; Gao, Liming ; Chaganty, Rangasai V Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId = from allskuset Reviewed-by: Bob Feng -----Original Message----- From: Chan, Amy Sent: Monday, January 8, 2024 11:54 AM To: Chen, Christine ; S, Ashraf Ali ; devel@edk2.groups.io Cc: Rebecca Cran ; Gao, Liming ; Feng, Bob C ; Chaganty, Rangasai V Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId = from allskuset Reviewed-by: Amy Chan > -----Original Message----- > From: Chen, Christine > Sent: Monday, January 8, 2024 8:29 AM > To: S, Ashraf Ali ; devel@edk2.groups.io > Cc: Rebecca Cran ; Gao, Liming=20 > ; Feng, Bob C ; Chan,=20 > Amy ; Chaganty, Rangasai V=20 > > Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName and=20 > SkuId from allskuset >=20 > Reviewed-by: Yuwei Chen >=20 > > -----Original Message----- > > From: S, Ashraf Ali > > Sent: Monday, December 25, 2023 11:28 PM > > To: devel@edk2.groups.io > > Cc: S, Ashraf Ali ; Chen, Christine=20 > > ; Rebecca Cran ; Gao, > Liming > > ; Feng, Bob C ;=20 > > Chan, Amy ; Chaganty, Rangasai V=20 > > > > Subject: [PATCH] BaseTools: Remove Duplicate sets of SkuName and=20 > > SkuId from allskuset > > > > Currently when the platform has many SKUs then allskuset will be=20 > > having so many duplicate. and while parsing the allskuset will take=20 > > longer time while assing Pcd.SkuInfoList. > > This patch is to eliminate those duplicate entires to reduce the=20 > > build time > > > > Cc: Yuwei Chen > > Cc: Rebecca Cran > > Cc: Liming Gao > > Cc: Bob Feng > > Cc: Amy Chan > > Cc: Sai Chaganty > > Signed-off-by: Ashraf Ali S > > --- > > BaseTools/Source/Python/AutoGen/PlatformAutoGen.py | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > index 592d4824a4..dac81454a9 100644 > > --- a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > +++ b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > @@ -707,6 +707,8 @@ class PlatformAutoGen(AutoGen): > > self._DynamicPcdList.extend(list(OtherPcdArray)) > > self._DynamicPcdList.sort() > > allskuset =3D [(SkuName, Sku.SkuId) for pcd in=20 > > self._DynamicPcdList for (SkuName, Sku) in pcd.SkuInfoList.items()] > > + # Remove duplicate sets in the list > > + allskuset =3D list(set(allskuset)) > > for pcd in self._DynamicPcdList: > > if len(pcd.SkuInfoList) =3D=3D 1: > > for (SkuName, SkuId) in allskuset: > > -- > > 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115264): https://edk2.groups.io/g/devel/message/115264 Mute This Topic: https://groups.io/mt/103360241/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-