From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 21DC6740032 for ; Sun, 24 Mar 2024 10:01:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=W5yS9S7717E47Cd0cbWoCUpy+mFcYpo4Jy/9xwWxGIA=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711274501; v=1; b=ko2IZz93cXbgKm2gOnUB87kUUUohXmPDkNK8O2HfTfeaexHjIs0aZLEtRbvErsr1udAaK4dR XKAymVFoCjjIG+SxXIcmiQmFNrXNDBObBgsQ4yhn9d6VIg7jJkMc1aLWGJVQdQFkkJeDnVbHlV0 QC1hdxpuNSD9kWNvJ/H5V+0MXY6qrtVzuZsDv953+fk+187yCqTQlDjU0oafX6BuxRIpq7O1wTk 7AKA1YXUtxTUxxaDiqG+8xFkuqG59BjuLWWpWa/0ImLj3FLaBsYIeU0RVxrrKNu9LvUvU3gG8Sg 2d9rZq+dqN3sFlyhRHcIMhBz759Xqaxrtzmca1O2ikNFA== X-Received: by 127.0.0.2 with SMTP id 9AMvYY7687511x3BZyCWtBnj; Sun, 24 Mar 2024 03:01:41 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mx.groups.io with SMTP id smtpd.web10.26331.1711274500629802459 for ; Sun, 24 Mar 2024 03:01:40 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,11022"; a="23765622" X-IronPort-AV: E=Sophos;i="6.07,151,1708416000"; d="scan'208";a="23765622" X-Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2024 03:01:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,151,1708416000"; d="scan'208";a="15358251" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Mar 2024 03:01:40 -0700 X-Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 24 Mar 2024 03:01:39 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 24 Mar 2024 03:01:39 -0700 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 24 Mar 2024 03:01:39 -0700 X-Received: from DM4PR11MB5280.namprd11.prod.outlook.com (2603:10b6:5:38b::18) by CH3PR11MB8186.namprd11.prod.outlook.com (2603:10b6:610:15a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.28; Sun, 24 Mar 2024 10:01:38 +0000 X-Received: from DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::507d:aee0:b06b:77a5]) by DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::507d:aee0:b06b:77a5%5]) with mapi id 15.20.7409.028; Sun, 24 Mar 2024 10:01:37 +0000 From: "Ashraf Ali S" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Duggapu, Chinni B" , "Zeng, Star" , "Kuo, Ted" , "Mohapatra, Susovan" Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg/Tools: Let PatchFv support to get Image Base. Thread-Topic: [PATCH] IntelFsp2Pkg/Tools: Let PatchFv support to get Image Base. Thread-Index: AQHaeRPpdcA7Y7FoVEKPA9N7yFl4XbFGsldg Date: Sun, 24 Mar 2024 10:01:37 +0000 Message-ID: References: <20240318090836.361-1-zhiguang.liu@intel.com> In-Reply-To: <20240318090836.361-1-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5280:EE_|CH3PR11MB8186:EE_ x-ms-office365-filtering-correlation-id: 3156af61-0451-44e2-8977-08dc4be96540 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 25A+TSPb29vwh5Yqpjd6DRxhJ++K4+HT25TnFyEz4Iq6Rh4D2Fq5nk2JDqB9MzF7mXK2VvMY4VDprU/aSZolCWNy14/yw+ax6dnepTMK360VaxIxnWOrLMu9gS5tHQGYfZByWXuCwIxxS0G2kQbFzHN6QAXqVkpXayFyTwGSSEyQuD/ZCIbr391w2ai8am09PvmuUAzeaX5y/HFfKtpdPE0JMDDFMLtOr6Z9vlzNIt9tJsnOshVPZrh7KasBcrjLjOhCs/N8ffdKyPD6OwA6dNz7MjJNziILj+h9BjfxdUMvOQ2r5pgs3qu/5AAtvHotgy9DuSne5audmgeWI9uEaQEXrLVjkIUdxgUMdmPbE0q+Tubwl10mguHLkuMqn5HE4qW0qqF2fRWMb+nJMiMrT1QPGcqp320oE5chaMx4eVr8uQgvehCMjAz0CbnMdwZ8tphnfo8mfEKQD0d8rShtmyc/5CByPCi9w66UsnK7jHLM+3HkJRNmL7js1eG38YGXieDVBjaPWMYooVMXXd9cqy6jEBOgOE03QPnt59E6sOSClqqpM0GyiLKpskQoMsRw1FvtxuotKc/1rC26fsn4Dkwilog9GF0xwP/1bwxW6c0jQOj1KiesIIGiPeQAOL4oHA5VluolKRmdU0eN/kiLj0Yhd/CzV5jLbZSEIFoxJ8hZsBljH914rh1HcFrJ7WBTIqocDDX+p7XvxYhU+wRMvGFZnrrOMmHLjMfx9+alkxQ= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vqK8kL7SiBDHVtM9OIyciScKT1yrE9vPIzVCOSfQOx3OquhvN2vsgk4ycUi0?= =?us-ascii?Q?Scdn7IiTneM/q22Xh/dw5WMXzh2VpUoefYyfxiTWIO4LumtAPfFYzBeQwXGA?= =?us-ascii?Q?Y5XlNabiYUQcSp3baRYKeFpJ5bGSRMK4ZrQHYGldHXhcDxrGINOPi1XhdEUR?= =?us-ascii?Q?GZAG7FN/mG4Xj4BqlUXqac+MpjnGyBpF59nAwDz+cFMN8AgMfSCSWE6lEJgx?= =?us-ascii?Q?hDqAwyYliA6soP5S8hlsqvureMSHWYBFhGSkaOMdZxDlWe+zb5G+sZToDqtl?= =?us-ascii?Q?eIXdf8T8YYklv08nhnODJPQFl/u1sWQ/JeF78i3Ip7z72Mpwey6itX4zZ1uD?= =?us-ascii?Q?bEt7rit3CO8VTyB/vaYhU8tIhRr8o4FkrSL6nsJkCI+z0A9ARgi3BiWpWeVg?= =?us-ascii?Q?3/9G2bcuV/tzMbUPBtg05+OK6QSPInjqnuvZkjUEdRPpGyC82DwPlOb4vSDG?= =?us-ascii?Q?v6KArTRH75a7tjLGI6HLq1oJuOwMOG7cx0kVhXEilK1SxJxTsHRIeGRRl8ut?= =?us-ascii?Q?51shgNkDYgVhCUNIfPd6BnPNITMNO/2LoJREzYK3muTLA90Vh15GvE8E3PoC?= =?us-ascii?Q?w4KfQZLsgNHRS1KiUUuGmLsk3HUikay37kSbhyVkmxN5ceZNr39yYTeDZ4GH?= =?us-ascii?Q?0fwWC6IkCxvsFzMbI7rGEUQOYNm0u6vHcspG9TGUPYmKKZ/2DEHarRKOY7AW?= =?us-ascii?Q?vMXeUlzaxGDnnaJ7crC3oWijZo8Z6tbtO35nPaqR+LiMHifEWRBiajWCWz/B?= =?us-ascii?Q?wS/5FvwpGU9FM+dK+GfM+yQTB28V8Igw5D6pI+NZP52NmlT9XuMF/WFkqXqI?= =?us-ascii?Q?EkUwNBl3h21XQesXKcYxG+bOVyhq+3CvLkCbaS+CxR+2pmkQIFJ3BKELAR1Z?= =?us-ascii?Q?ogmeWWcX1cX/p4s6iaKbjytXexWeHTQg55I9MfSlasV5rff5/6E6FwiINaJC?= =?us-ascii?Q?RU+9wMhuRq35sIjTW94qNyc3IfIazshCYd1shRuk8+ACRxRpfbFMvtD8wJxW?= =?us-ascii?Q?qOg/sB8JSQ4zy3eXkWC1oI9uYajObEwRHx1w6pq9h3w6kHsMx1LXtOSB38Ey?= =?us-ascii?Q?zNXTRTTYaeMECREbf0A1a1gRCLHKXMJKd0Ws+Z405WGG0NXDxOXQjY8hGUpf?= =?us-ascii?Q?FFFpoOgcu4IdsB4pyfEYu83oM6aqfCPyYxCZQgit5DNxT1ZiaK/ujJWI9DiO?= =?us-ascii?Q?A0XMs2N4LUzEvziheDQJjlEJPUgkFyRRf5AVrWND+Wgr4tqi7tPKFBgLO2LM?= =?us-ascii?Q?i6tAoyFpZ1NX7+Jql/ilZwgMeyDJvjqTRZlL0NauQAuu6J54mJFCwzGaoMBb?= =?us-ascii?Q?LZ7PDnQBGya0MOM9M6oAtLWdPfK/7symGucjM30/+edoLoRIu0P3psldkOOz?= =?us-ascii?Q?QG8B9hkE82B4RBtD1/QU0XFtR7X+4l90cabayKeWBL8PvUoZtuEnY3LVdE7q?= =?us-ascii?Q?+Z1XWiBXDx8yzi6v0yxcWb4ROkMGMpZ8FWgmgPHKWdnjiRyF0/O7qArsh6BD?= =?us-ascii?Q?ZSyh9CQ1Jtzi9b3yDhLTyZdfZnK22pb1djnIUhfp2KNoc8BcyONqB1WWL+IN?= =?us-ascii?Q?i91FOwB8qd9MwhBcm88pyFcAtHIKHkuSMcH0lGrw?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5280.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3156af61-0451-44e2-8977-08dc4be96540 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2024 10:01:37.7647 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GgC6vu3DGm1RNKJRtPnJk0Qsr95fnB8lQ6WtF0bRVY+hVAr45sV3q5xPIqRirYjDXvb2seuNv46CsD+lrjdULA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8186 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 24 Mar 2024 03:01:40 -0700 Reply-To: devel@edk2.groups.io,ashraf.ali.s@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: kahPfYOVGDQVI7l8QGbwegQPx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=ko2IZz93; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: S, Ashraf Ali Thanks., S, Ashraf Ali -----Original Message----- From: Liu, Zhiguang =20 Sent: Monday, March 18, 2024 2:39 PM To: devel@edk2.groups.io Cc: Liu, Zhiguang ; Chiu, Chasel ; Desimone, Nathaniel L ; Duggapu, Chi= nni B ; Zeng, Star ; Kuo, = Ted ; S, Ashraf Ali ; Mohapatra,= Susovan Subject: [PATCH] IntelFsp2Pkg/Tools: Let PatchFv support to get Image Base. Now, the value params of PatchFv support below value getting from map file: ModuleName:FunctionName ModuleName:GlobalVariableName ModuleGuid:Offset This patch add a new type ModuleName:KeyWord KeyWord now supports "BASE", i= ndicating the address of the Image base. For example, ModuleName:BASE will be the address of the Image base. This will simplify the flow when user want to patch the Image base in the b= inary. In the future, we can let the KeyWord support more based on future usage. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Duggapu Chinni B Cc: Star Zeng Cc: Ted Kuo Cc: Ashraf Ali S Cc: Susovan Mohapatra Signed-off-by: Zhiguang Liu --- IntelFsp2Pkg/Tools/PatchFv.py | 1 + IntelFsp2Pkg/Tools/UserManuals/PatchFvUserManual.md | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/IntelFsp2Pkg/Tools/PatchFv.py b/IntelFsp2Pkg/Tools/PatchFv.py = index 73ab877c71..0cab73255d 100644 --- a/IntelFsp2Pkg/Tools/PatchFv.py +++ b/IntelFsp2Pkg/Tools/PatchFv.py @@ -384,6 +384,7 @@ class Symbols: if len(modName) =3D=3D 36: modName =3D self.dictGuidNameXref[modName.upper()] self.dictModBase['%s:BASE' % modName] =3D int (match.= group(2), 16) + self.dictSymbolAddress['%s:BASE' % modName] =3D=20 + match.group(2) self.dictModBase['%s:ENTRY' % modName] =3D int (match.= group(3), 16) #(GUID=3D86D70125-BAA3-4296-A62F-602BEBBB9081 .textbaseadd= ress=3D0x00fffb4398 .databaseaddress=3D0x00fffb4178) match =3D re.match("\(GUID=3D([A-Z0-9\-]+)\s+\.textbaseadd= ress=3D(0x[0-9a-fA-F]+)\s+\.databaseaddress=3D(0x[0-9a-fA-F]+)\)", rptLine)= diff --git a/IntelFsp2Pkg/Tools/UserManuals/PatchFvUserManual.md b/IntelFs= p2Pkg/Tools/UserManuals/PatchFvUserManual.md index 205ad57773..b59e82c872 100644 --- a/IntelFsp2Pkg/Tools/UserManuals/PatchFvUserManual.md +++ b/IntelFsp2Pkg/Tools/UserManuals/PatchFvUserManual.md @@ -89,9 +89,10 @@ The entire argument includes the quote marks like in the= example argument below: | 0x000000BC | 0xFFFFFFA2 | 188 | -94 = | =20 ``` -ModuleName:FunctionName | ModuleName:GlobalVariableName +ModuleName:FunctionName | ModuleName:GlobalVariableName |=20 +ModuleName:KeyWord ModuleGuid:Offset ``` +Note: KeyWord only supports "BASE" now, indicating the address of the PE I= mage base. =20 ### Operators: =20 -- 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117070): https://edk2.groups.io/g/devel/message/117070 Mute This Topic: https://groups.io/mt/104999188/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-