From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.14045.1686318939529822918 for ; Fri, 09 Jun 2023 06:55:39 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Mcjx2LWU; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ashraf.ali.s@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686318939; x=1717854939; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+qCDmGKREayg7nPjua3YCBhD85RNo9gpx7feWEu+8iY=; b=Mcjx2LWUhcVWvCk8+rv4XrWlVZCEYux7uUjpt2pDkKS2FGXymm6X+Ijg O2tEiBraef2LHl8rHa+MyEaQTQn+bjYJ/2p90mxIMMJM6ywotZz2TENZP Sk3IV1LurQ4fURWO3DJaF/f4J8kpg87Joi/bqiURuj2SVnVZRVb5UyHZA cs3HniOFDHWILggi9hIhB+gzx7ziCuNXXzdvGnzq+jCeNTKlibRD37KSV FxIoR0PwoRExNrI5MAUHJUVJWXGQcJzmZseJz3BxSFFYzHassWs+hVL0Q IrsV8orArfAE9oi3j+Ione51uCrhhXIZxGoYZreau6Pk2ePvlmYMVYarM A==; X-IronPort-AV: E=McAfee;i="6600,9927,10736"; a="347247821" X-IronPort-AV: E=Sophos;i="6.00,229,1681196400"; d="scan'208";a="347247821" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2023 06:55:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10736"; a="854748099" X-IronPort-AV: E=Sophos;i="6.00,229,1681196400"; d="scan'208";a="854748099" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga001.fm.intel.com with ESMTP; 09 Jun 2023 06:55:38 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 9 Jun 2023 06:55:37 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Fri, 9 Jun 2023 06:55:37 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.48) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Fri, 9 Jun 2023 06:55:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QTWZpo4+ZjDG63xu+Noqa5zHWbe7pMYrePkoV/Crns5Q1OdkEjsu74I7EK1zH/QyiUYMWaxUdx+mx4ATfFj7Ag6ESsgQvxMKCgLHaMAoypy3eiM7L7lvc8siV3jBCewnC7y09tHWXm5lK824zQDxoJw+Wk6G1nmESdETv4wC3huQYgsy3+pAKQfoBiT4OQsXkH3Hyu7bem/j1R6RjGalRSi9hqNPoeFb+MqIhtTb6vOuRqhdAz1XNtPlFG3PbAQgr/oTIse0UwhSEbvat1uWppHeg+vI1miXtzQN2fAjRdD2bCu2ZAYlkz8+vXPc1MkDz63dw2djoM36ywZ1SyfTgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wlOL56stTXiCZFJQdW9eIpY+FKSvkRfRkHTbPXMP4nU=; b=VQUynbcHkRfocal7mGyenpK0op/5I+30V7BKOKJyK0kYCfWEODvFmmTRkLCFm3P1ctXiaG11oO1U/oB6J5yitm6wlbmrb9vOSrYayhC7LOEEBqtlYV/stBGITMeNetxDP9EoDbuVkhhOD1l59zngLDBE/0MwryGKLnrBkG5JwqHl7RifrBu7rZRSbgKw8eWQ6tqrSlilupFKhyVWAV4OtZZyJMU/4+OmsqmgBfBPMwXH4zEevjw1K5HsKnB6q2XP/WchmLqLQLmdCjqGxpvufz5gXHP57xi4CIS73x+yznO7VK2Y8BTCY1ijmoSao2MRnhbeQeo9BF5FKnzmgTdabQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5280.namprd11.prod.outlook.com (2603:10b6:5:38b::18) by SJ0PR11MB5680.namprd11.prod.outlook.com (2603:10b6:a03:305::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Fri, 9 Jun 2023 13:55:37 +0000 Received: from DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::32d0:b03a:e6ea:b7cd]) by DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::32d0:b03a:e6ea:b7cd%4]) with mapi id 15.20.6455.030; Fri, 9 Jun 2023 13:55:36 +0000 From: "Ashraf Ali S" To: "Aishwarya, KurugoduMelmatamX" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Duggapu, Chinni B" , "Chen, Gang C" , "Zeng, Star" , "Kuo, Ted" , "Mohapatra, Susovan" Subject: Re: [PATCH] Get HobListPtr before calling the Multiphase FSPS Thread-Topic: [PATCH] Get HobListPtr before calling the Multiphase FSPS Thread-Index: AQHZmtfgzH6jV7HrG0SKMDtDt2xNG6+CfmKg Date: Fri, 9 Jun 2023 13:55:36 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5280:EE_|SJ0PR11MB5680:EE_ x-ms-office365-filtering-correlation-id: 38e62705-e040-4c0d-dd18-08db68f133bd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /NIXSfJV7XCj1d7QoyrXMVCEbd52I9Ny60OlDqK1G+VKwYL4oUYD4Y9bB9jkzEd2Hf4Kk8KXyk8eatLiU68WajhH2EV/hdBy0koEZnT9o5BVMqwPXRxmtrwiO6Uc1WStdAsgGAOc7JlvVajYai1OCzfam4qWXF3Wc3w8axxAEMjVAuu3xntmWS7XU9yo9FILdkDSycXlrVHIpePvEtOsmIk4XS+89pY/Dv9s38wv3scHkQ5mkzJgfRB2lrl2KhkEJoZXheQcOwlaK+baevRLYX9cpy9KuJvSjOKLXhQ1QjmkbVXEqG1V1/sRZ5wPS3/NPGlU6dD6NjmDE92XKyC9UdgJnSrXAZq/6IgNPax092xg863vSygIg+6/0sjrMtFX8a1bpmR03r/RKSfbZMWbkj3CAeWNyRfj0CY6q+gaGWH5MkSAk7xrSmxRl2gxL0ElhG6RVkZ9rCE9lFYTC5pj5OIo7ar03ykseOjU2sE6bajTuV+JTkmiA8zWnDTLYpBtdMwLwZh08+DIzhhdM6gu2QJvAO/0O3hBrVGabm6TT1iCn4RYUIn7pLUh1gTRIPvoI0rNeUXAEsklUNQKT9YKSygBEqnprdAYs1KaQBlRhPQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5280.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(39860400002)(396003)(346002)(136003)(376002)(451199021)(966005)(53546011)(7696005)(71200400001)(82960400001)(186003)(83380400001)(33656002)(86362001)(38100700002)(122000001)(38070700005)(9686003)(6506007)(107886003)(8676002)(55016003)(54906003)(110136005)(316002)(76116006)(66556008)(8936002)(66946007)(66476007)(64756008)(4326008)(66446008)(5660300002)(52536014)(41300700001)(2906002)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aMDTubB7TDmNmLeIivS9hZEBJrv+1PRSiH9g1sRLoCrGA+oc+MED9q2bwxJ3?= =?us-ascii?Q?ip4K9PT7m2S3RuJHI0rQuiaR2YPjfcAzLSXidjjxQKfBqgbJqg0CXjmIlI+K?= =?us-ascii?Q?AuvdUB9t+DE/qknWyak4VaaRSeZI2Tc5N1JZDw5i3jkIkjLmDEEEPihEuhx1?= =?us-ascii?Q?pzjdQQqv6TxO0xH2qRdeb0yprnlXvjYWRptPkK+SRDO+A1ZRrz3vtIfIKPMZ?= =?us-ascii?Q?PGK0yscXbvH8OJpQkJDuNKf96+QAqrw2n2ZQsvT811uNeUhZvEcxwYdT8kJh?= =?us-ascii?Q?UdGAs9RbNCHdnSBgjQcUHGM4LrBWSV6Kz714Sb8XgoiCbYVKdwqNOvFGa5so?= =?us-ascii?Q?bNWRF6gmrmCqpLqYfrJScf57Y5kZfMlKpmCOnPCsEIpohZJXhOPBwHPADW/R?= =?us-ascii?Q?QX7ptxYO0LQ5sempJX9mr1QOY6qoP9NbQ3P3r28wxhr0Ns9dGubFbIXwWhmU?= =?us-ascii?Q?SAH4wgxV6Hyir+18gFITbyvcHXnr8mYvjIOOA1bj4S+Ax49/qebE7rE1Z4cR?= =?us-ascii?Q?zmFOSHTGSqV/HH6fu/SU53JeUwimt59dFrl0vOYza89ZBf5eNH/T8yoqttEz?= =?us-ascii?Q?jm+t3AcouExe8taOUuyZM2CH0pOfEZlQp2Ur5qwu2wdzIoLd9CGQonQnynMV?= =?us-ascii?Q?5JONd3iQVfAL0i6TyK2H2uZlts5ArGcCdeqszLC0BtU7FEYcNn9BW6aZitB0?= =?us-ascii?Q?fnydcDV+DkMqDuXGGSvNm0v9wttzoQQiXdytBBWWcEU5NjsAx0ZcRyZMbNAT?= =?us-ascii?Q?jhc92c6zG9Ktpf/o8wGdcurg5DQx6060rGUyOwrxGL9uJJnulgky6dQ0ABgI?= =?us-ascii?Q?YDPZks+EOjIig5BwGVmQqy5+zRQCXZIHQQTH1esRrO+qoVx8PcvRfAfUN3Eh?= =?us-ascii?Q?1mfKUdcR6aUmBHdaSm4Axx5u3qsvT+/Y9E2ZYyh4zwYiLt+M3OJKZOoHhaLZ?= =?us-ascii?Q?UJ9P2cJUgIBwo0YamFX6xviR0erWQTlIHDFdxxqwSYqrCmeRaCR+SFioD87m?= =?us-ascii?Q?TIGOZ0kvPlsaXMx8OC1ivwCIdOCbj8adlJ/vOXZJxj2lMVUBCHgo/9fUMlWT?= =?us-ascii?Q?pFlO2Z8VZ8IahVTcsZkBtsotbwoQG1G+k9IhCiDRPG5nAsjPPFM4gP9CwnnW?= =?us-ascii?Q?lAsMlR1395QVm01DXy+rN4xGHwetJlUglcwduXi9rEGK8aGyZMN9I/NNdiHA?= =?us-ascii?Q?V/tPaYPrz00cSJ3PYCiX3kY/TQGr3Hgn054JkYra9Ro010ISs8KPtogzwyxg?= =?us-ascii?Q?Bx2Zsha/xsp/oChiWiw8MwoyaJsyXD5GOUa/IRRjJu+bR/jeD0kea3jM7/zY?= =?us-ascii?Q?XhOCq0W3afEB3lhPfiL9PDchCrHObMBk0kzcaTtF3PoFiHoJSRjRKNQgnPG1?= =?us-ascii?Q?GlYr6dftxguyX5ecCna3fKeHfRVbVWN/89t/HCwlLdnVWb+d8c6zZHH22bB0?= =?us-ascii?Q?YabQ0dwyooX3BfxroOmWpYYaxJQx0qvPBpZ+RUlwbxTA7k11SNyurDgKCevW?= =?us-ascii?Q?E3uj1LgLjUVMYot3YC/IZQSqxAOi12rh6nobWZSOwWjSAxKcoWpS9xzrb3lp?= =?us-ascii?Q?J9r7XKHCndk2U5FlW3g=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5280.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38e62705-e040-4c0d-dd18-08db68f133bd X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2023 13:55:36.7368 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6ggnjhjLGuTuRVQGxhGZdgSbwYvAolt6QKg9Hj4IzgvjE0hUmqmAByw7TqBhMVDKgTrYrYxKa55f7VKa6tz+Xg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5680 Return-Path: ashraf.ali.s@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ashraf Ali S -----Original Message----- From: Aishwarya, KurugoduMelmatamX = =20 Sent: Friday, June 9, 2023 7:10 PM To: devel@edk2.groups.io Cc: Aishwarya, KurugoduMelmatamX ; C= hiu, Chasel ; Desimone, Nathaniel L ; Duggapu, Chinni B ; Chen, Gan= g C ; Zeng, Star ; Kuo, Ted ; S, Ashraf Ali ; Mohapatra, Susova= n Subject: [PATCH] Get HobListPtr before calling the Multiphase FSPS REF : https://bugzilla.tianocore.org/show_bug.cgi?id=3D4480 In the FspsWrapperPeim, before calling FspWrapperVariableRequestHandler and= FspWrapperMultiPhaseHandler ,FspHobListPtr should be available so that BL = will be able to get the correct FspHobListPtr value Signed-off-by: kurugodx Cc: Chasel Chiu Cc: Nate DeSimone Cc: Duggapu Chinni B Cc: Chen Gang C Cc: Star Zeng Cc: Ted Kuo Cc: Ashraf Ali S Cc: Susovan Mohapatra --- .../FspsWrapperPeim/FspsWrapperPeim.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelF= sp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c index 08fe0fdb7e..1d4dd60577 100644 --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c @@ -336,6 +336,14 @@ PeiMemoryDiscoveredNotify ( =20 DEBUG ((DEBUG_INFO, "FspSiliconInit status: %r\n", Status)); =20 + // + // Get FspHobList + // + GuidHob =3D GetFirstGuidHob (&gFspHobGuid); ASSERT (GuidHob !=3D NULL);= =20 + FspHobListPtr =3D *(VOID **)GET_GUID_HOB_DATA (GuidHob); DEBUG=20 + ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr)); + if (Status =3D=3D FSP_STATUS_VARIABLE_REQUEST) { // // call to Variable request handler @@ -356,13 +364,6 @@ PeiMemoryDisc= overedNotify ( DEBUG ((DEBUG_ERROR, "ERROR - TestFspSiliconInitApiOutput () fail, Sta= tus =3D %r\n", Status)); } =20 - // - // Now FspHobList complete, process it - // - GuidHob =3D GetFirstGuidHob (&gFspHobGuid); - ASSERT (GuidHob !=3D NULL); - FspHobListPtr =3D *(VOID **)GET_GUID_HOB_DATA (GuidHob); - DEBUG ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr)); PostFspsHobProcess (FspHobListPtr); =20 // -- 2.41.0.windows.1