From: "Ashraf Ali S" <ashraf.ali.s@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"S, Ashraf Ali" <ashraf.ali.s@intel.com>,
"Chen, Christine" <yuwei.chen@intel.com>,
"Rebecca Cran" <rebecca@bsdio.com>,
Liming Gao <gaoliming@byosoft.com.cn>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>,
"Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>
Subject: Re: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while parsing FMMTConfig.ini
Date: Wed, 17 Apr 2024 08:36:10 +0000 [thread overview]
Message-ID: <DM4PR11MB52806DE905D4D80D8D853E01D70F2@DM4PR11MB5280.namprd11.prod.outlook.com> (raw)
In-Reply-To: <17BBB26EFE5BAF9A.17779@groups.io>
Hi @Liming Gao @Rebecca Cran
Is this patch already pushed? As its been already reviewed.
Thanks.,
S, Ashraf Ali
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ashraf Ali S
Sent: Monday, March 11, 2024 5:01 PM
To: devel@edk2.groups.io; Chen, Christine <yuwei.chen@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>; Liming Gao <gaoliming@byosoft.com.cn>; Feng, Bob C <bob.c.feng@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Subject: Re: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while parsing FMMTConfig.ini
Thanks for the review.
I have triggered the PR under basetools : https://github.com/tianocore/edk2-basetools/pull/122
Thanks.,
S, Ashraf Ali
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yuwei Chen
Sent: Monday, March 11, 2024 1:22 PM
To: S, Ashraf Ali <ashraf.ali.s@intel.com>; devel@edk2.groups.io
Cc: Rebecca Cran <rebecca@bsdio.com>; Liming Gao <gaoliming@byosoft.com.cn>; Feng, Bob C <bob.c.feng@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Subject: Re: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while parsing FMMTConfig.ini
Ali, please also create PR in BaseTools repo.
Reviewed-by: Yuwei Chen <yuwei.chen@intel.com>
> -----Original Message-----
> From: S, Ashraf Ali <ashraf.ali.s@intel.com>
> Sent: Wednesday, February 28, 2024 5:57 PM
> To: devel@edk2.groups.io
> Cc: S, Ashraf Ali <ashraf.ali.s@intel.com>; Rebecca Cran
> <rebecca@bsdio.com>; Liming Gao <gaoliming@byosoft.com.cn>; Feng, Bob
> C <bob.c.feng@intel.com>; Chen, Christine <yuwei.chen@intel.com>;
> Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
> Subject: [PATCH] BaseTools: FMMT Skip empty Lines while parsing
> FMMTConfig.ini
>
> When the FMMTConf.ini file has empty lines then it used to throw
> errors GuidTool load error!, this patch is to skip checking for empty
> lines in the ini file
>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Cc: Chen Christine <yuwei.chen@intel.com>
> Cc: Chaganty Rangasai V <rangasai.v.chaganty@intel.com>
>
> Signed-off-by: Ashraf Ali <ashraf.ali.s@intel.com>
> ---
> BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py
> b/BaseTools/Source/Python/FMMT/core/GuidTools.py
> index f6bdeffa50..f9cfd4ead0 100644
> --- a/BaseTools/Source/Python/FMMT/core/GuidTools.py
> +++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py
> @@ -153,7 +153,7 @@ class GUIDTools:
> config_data = fd.readlines()
> for line in config_data:
> try:
> - if not line.startswith("#"):
> + if not line.startswith("#") and line.strip():
> guid, short_name, command = line.split()
> new_format_guid =
> struct2stream(ModifyGuidFormat(guid.strip()))
> self.tooldef[new_format_guid] = GUIDTool(
> --
> 2.42.0.windows.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117910): https://edk2.groups.io/g/devel/message/117910
Mute This Topic: https://groups.io/mt/104620514/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-04-17 8:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 9:57 [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while parsing FMMTConfig.ini Ashraf Ali S
2024-03-11 7:52 ` Yuwei Chen
2024-03-11 11:31 ` Ashraf Ali S
[not found] ` <17BBB26EFE5BAF9A.17779@groups.io>
2024-04-17 8:36 ` Ashraf Ali S [this message]
2024-04-17 12:34 ` 回复: " gaoliming via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB52806DE905D4D80D8D853E01D70F2@DM4PR11MB5280.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox