From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 90662740038 for ; Wed, 17 Apr 2024 08:36:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=UX+FFGH7tOBdzGrU83+fEosi3Xas/KzF7ngaK+77jbM=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713342984; v=1; b=jVqTTH07tXkNxjFVH917AK9qdYkq2Y1ZTWO9UHtqin7hyDkH4fDyYqlEgEOkq4LFiZb9spZl AQoxv3bKzdYBTmSyLFuuOPIJHmzGLQYxyoi8P/UKbrEi5yDglyLqJ2gw/oyoXywC6EnXN98NbnT p1pliUd9lUyy2JjSAq4WZIR1KngMIUaU4Q2PmeJ1slcrhxet4X0V0UoBEoR7/nJJfAPG8WoW8fl PETXKiZZLsI9HtgwFt00VAOcPzLw75pP9+5oEitcI4P/CJzCOAOAZqyV4AJedzEzGjPYYat5WHB 1ndoNH1NXClQq04RqrK//hZD0n0UaoMvW8NiQeCg7I1Dg== X-Received: by 127.0.0.2 with SMTP id 4Q90YY7687511xwO3VJMU7np; Wed, 17 Apr 2024 01:36:24 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mx.groups.io with SMTP id smtpd.web11.7967.1713342979130511419 for ; Wed, 17 Apr 2024 01:36:19 -0700 X-CSE-ConnectionGUID: NHELBfR4QHS9wcEOetgxQQ== X-CSE-MsgGUID: Xrg77xDFTLyEidZiug+Mww== X-IronPort-AV: E=McAfee;i="6600,9927,11046"; a="11764921" X-IronPort-AV: E=Sophos;i="6.07,208,1708416000"; d="scan'208";a="11764921" X-Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2024 01:36:19 -0700 X-CSE-ConnectionGUID: EBgXBv9kTx2HP3hE5ae6Ng== X-CSE-MsgGUID: wv6utdelR2G3HCGAm6JtrQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,208,1708416000"; d="scan'208";a="22624209" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Apr 2024 01:36:18 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 17 Apr 2024 01:36:17 -0700 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 17 Apr 2024 01:36:17 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 17 Apr 2024 01:36:17 -0700 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 17 Apr 2024 01:36:17 -0700 X-Received: from DM4PR11MB5280.namprd11.prod.outlook.com (2603:10b6:5:38b::18) by CH3PR11MB8436.namprd11.prod.outlook.com (2603:10b6:610:173::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.26; Wed, 17 Apr 2024 08:36:10 +0000 X-Received: from DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::507d:aee0:b06b:77a5]) by DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::507d:aee0:b06b:77a5%5]) with mapi id 15.20.7472.027; Wed, 17 Apr 2024 08:36:10 +0000 From: "Ashraf Ali S" To: "devel@edk2.groups.io" , "S, Ashraf Ali" , "Chen, Christine" , "Rebecca Cran" , Liming Gao CC: "Feng, Bob C" , "Chaganty, Rangasai V" Subject: Re: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while parsing FMMTConfig.ini Thread-Topic: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while parsing FMMTConfig.ini Thread-Index: AQHaaiylt9r5pEVr2EuFhPJAQJDAgrEyPaAAgAA9PACAOfUcUA== Date: Wed, 17 Apr 2024 08:36:10 +0000 Message-ID: References: <17BBB26EFE5BAF9A.17779@groups.io> In-Reply-To: <17BBB26EFE5BAF9A.17779@groups.io> Accept-Language: en-US X-Mentions: rebecca@bsdio.com,gaoliming@byosoft.com.cn X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5280:EE_|CH3PR11MB8436:EE_ x-ms-office365-filtering-correlation-id: cc677ff4-e5b2-438e-8cda-08dc5eb96f04 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 5r0anYhLcA10/MUG0X79gL16DxjZYFI0dh+fHWiy7bTQDupcDtXc0J4lLKvGeDQOKzqrXLZD5kKi+lP+Iu6KlvqSNeaIxzbIzY9M7iN7vW9fUrM3ZWJMsUzZA7+FCefPCOLcza6PijC7/bc/N14HNPOVALxJednf+gLF3DWSgQZcSAq77dSxPRHlO9vlsVKudJNEl+OrgLNWTfS53JQIwiCO6VErP1DEAGxefBGHQSG1BZPM07UQyj97eXF3iPnrLAQI31JCssj++rKRzkv8aI0FQZpNS5WmniuSA0/f9dpuGu9Lvv5FwABBcG0Rl0E5mLAYTw+rFAdSqWltHCxk8E7VSOy7nGWYEVb1q6RjlQa+4G7AEsIVfQV/5W7nkGadg7K3jo8BowmmUt4zr8iGvwHsaWXi5Z3q8MxXNULo1ty0Kp2DsfO1pW1NxF2iaapkeFtO6BQ3raRarCgAU+DkEYONuinKX86bMAZwt5osLW7BAg8uBcyBQ3GX4s1nq88rFf9iIcy23AWYcD2juS8lkVuehAxXfGn2e4mrJaq6T+ngYphEUsbEtFXKlQnBhyVbbPdcYs0MJyQyhapWvRutmrIohlzwIUfP/VO7UJtimUtZqbobqCTaEakybfribfwWidD3whAFl9LLlG+PUvSxkHjejAtgSVPeRc6gAkIikzKWo0PpGnrwyyHTsgWhMAjxemw6ELAPgyfKIdXiT4oh58RxGLCfu2tOpx3fn7YihXg= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Qo73JFw8EimGEY78eMdkdkYcUCpyT/BTgV6qO/0UxYHNQcTXlM0uRAQ604UB?= =?us-ascii?Q?u9EbWWYaov7azu0B4Nlrcqn31eBksc/sNnEWbHvHXE4dPd+pvTCQ59EKS9GA?= =?us-ascii?Q?Z+aK4ZaLe4XyZ7hpG4d7c/bFUcadKZ25qUvaqLE4cn6+dJeeVlG3GL+bIBlE?= =?us-ascii?Q?d4zfvGn34Em8Lmt/gKN7RdZSnrTVEzCsD1D1K6GbznTF18KMIYCinoXOjDB7?= =?us-ascii?Q?pTuZYM9nHQkRIxNe7dhw5ezSpvJYbpmDMpXT7ednR5IGuRyCK/NPZ/yHG53Z?= =?us-ascii?Q?DSIHaH+1VZlekqmOG73BSXdAEaniD98UbEtCS2qKbimTl1a+zqhoPYOGy5Yi?= =?us-ascii?Q?vFtAEi9uQMKjg0cNNtMLt0N7spMdJXp94pvfDrSDx4Lp9gQCwkAQ5XtjC+5v?= =?us-ascii?Q?N/IKwPHLWMm05yEL5oKkJU/W2komV5aMiVtqC58iZHSLWYKLbAnqsHOFnhg/?= =?us-ascii?Q?iWDFK8Rgv7ftqFCxpcK0GBIDoXI/txT6OITvyBITbUDegkBYdsMziMXhRVC4?= =?us-ascii?Q?1CDKurZHeaKHTmc5/Ksg1khiPWEc51gYIomTibMGVhj5V2DDYEhMM5Rwz3J2?= =?us-ascii?Q?DrfM0xG8XEwLXznJ1R6HYbW+eW/iHvXva/EbPeKj2/LHf8VKugDqQt/K0FlR?= =?us-ascii?Q?HT/5S1ldyi3JJ8/vtjptMAj4jxuBSDn80+BE12YzoWGLUsPdeiZCCU6vGLTE?= =?us-ascii?Q?w95vPnauVgWMbWRha/kSS/TJQPZz4PFmMh1fXoFWKL7lb0qtD4fypj9Jsuhq?= =?us-ascii?Q?KCN9OknmhNGo/DV7efYqpktYIqdV5tB7GSuyO1PqyGC6TjkN90D8wretyLVr?= =?us-ascii?Q?qzCoES2yD4mSBCj4EsLeDE6nOWlzmj2Vz3DHP9+/yihVnFqtf3kKtTDpVx4C?= =?us-ascii?Q?CH0QxzNTZypBL7gqZEcTzkqL8oiPSUKq+M4kQl9ZsC+2Yimc9RLpc+7OqjOX?= =?us-ascii?Q?esrum/zq6REbNDbyGLNUM5hzPYcWIIobiQn7FzqceMHe8Y0r3YyUby2MuKEo?= =?us-ascii?Q?Bu12uzFYfDTwvlA2YSYsQXnpIfJj0Mf746IJdrLu0lWY0ZqQr1HPApFgJ+rd?= =?us-ascii?Q?1rpOEwdikDWytHIPDWZL3IlOPaJUf4byFbKDZXiZ8a+08UKltssRjIudJ6Yt?= =?us-ascii?Q?Y7tiWXJGxlm7dKhmkBGNjV+mnPLKk/vWZsMKY4w9nC9KDxItE8ARqfGq7JWR?= =?us-ascii?Q?+MUImYvMX29pmWUm4N2+IwS/Mst16T61wFt3eompmo0WxQMNzisudjAkRegT?= =?us-ascii?Q?OF0+MTtvXsiihQfHlBddP+APDLy536uFEoi9IHdebTTimJQfwHUiTTb2IyGw?= =?us-ascii?Q?5ZMLOSvKnfWiUZ10FLmteWIcUzM+SFF27YWWl93gTXGcEUSbY6CGszAn/11F?= =?us-ascii?Q?f8zRQ/6W1E2VsYs+PaXa2BAQRmSdWmg9bxepcNC59Ot/YtaJUOcR1YU7TJ7L?= =?us-ascii?Q?1MOFuLvYe3glsrofE0dZk4oYfI5SS2SvHM0gSL+mdW7Rd/pE0LqEOGza4LXl?= =?us-ascii?Q?ENm9+svlo7gmmopYZWiZwPWEU6OEL/dRDc24XStRRNCrm1CzgIdiyRtv8cY0?= =?us-ascii?Q?7MdnxEZJG+/W/tQrJ7S6O8o5YKPblK/MZxQpK/A6?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5280.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc677ff4-e5b2-438e-8cda-08dc5eb96f04 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2024 08:36:10.4100 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uWZsMR9dXcuY83BXrbzJ4yxrObraltkt0LcpUXLPR4Pgtwy6pBFEVgNegHKkYGCCq/Wn8zqGXjsAfgD+MAAKCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8436 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 17 Apr 2024 01:36:19 -0700 Resent-From: ashraf.ali.s@intel.com Reply-To: devel@edk2.groups.io,ashraf.ali.s@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: pTsQv6AsgKhD9mWNzSsHK78zx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=jVqTTH07; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io Hi @Liming Gao @Rebecca Cran Is this patch already pushed? As its been already reviewed. Thanks., S, Ashraf Ali -----Original Message----- From: devel@edk2.groups.io On Behalf Of Ashraf Ali S Sent: Monday, March 11, 2024 5:01 PM To: devel@edk2.groups.io; Chen, Christine Cc: Rebecca Cran ; Liming Gao = ; Feng, Bob C ; Chaganty, Rangasai V Subject: Re: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while pa= rsing FMMTConfig.ini Thanks for the review. I have triggered the PR under basetools : https://github.com/tianocore/edk2= -basetools/pull/122 Thanks., S, Ashraf Ali -----Original Message----- From: devel@edk2.groups.io On Behalf Of Yuwei Chen Sent: Monday, March 11, 2024 1:22 PM To: S, Ashraf Ali ; devel@edk2.groups.io Cc: Rebecca Cran ; Liming Gao = ; Feng, Bob C ; Chaganty, Rangasai V Subject: Re: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while pa= rsing FMMTConfig.ini Ali, please also create PR in BaseTools repo. Reviewed-by: Yuwei Chen > -----Original Message----- > From: S, Ashraf Ali > Sent: Wednesday, February 28, 2024 5:57 PM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Rebecca Cran=20 > ; Liming Gao ; Feng, Bob=20 > C ; Chen, Christine ;=20 > Chaganty, Rangasai V > Subject: [PATCH] BaseTools: FMMT Skip empty Lines while parsing=20 > FMMTConfig.ini >=20 > When the FMMTConf.ini file has empty lines then it used to throw=20 > errors GuidTool load error!, this patch is to skip checking for empty=20 > lines in the ini file >=20 > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Bob Feng > Cc: Yuwei Chen > Cc: Chen Christine > Cc: Chaganty Rangasai V >=20 > Signed-off-by: Ashraf Ali > --- > BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py > b/BaseTools/Source/Python/FMMT/core/GuidTools.py > index f6bdeffa50..f9cfd4ead0 100644 > --- a/BaseTools/Source/Python/FMMT/core/GuidTools.py > +++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py > @@ -153,7 +153,7 @@ class GUIDTools: > config_data =3D fd.readlines() > for line in config_data: > try: > - if not line.startswith("#"): > + if not line.startswith("#") and line.strip(): > guid, short_name, command =3D line.split() > new_format_guid =3D > struct2stream(ModifyGuidFormat(guid.strip())) > self.tooldef[new_format_guid] =3D GUIDTool( > -- > 2.42.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117910): https://edk2.groups.io/g/devel/message/117910 Mute This Topic: https://groups.io/mt/104620514/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-