From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D569C7803CD for ; Fri, 1 Dec 2023 06:26:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=TFx5LxyEbiiztjLlEhhbcgsMMg703v2nniWcz5c+K0k=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701411973; v=1; b=QWlB69FLbx7lEh5aerWHAL+zxl8g5SaechkHqNpXY1x8XafwNv/5UGsQ6UWN2DsCvNZwbxU5 XNcGe+xZo7vFGuOCAs2gesxBrRFPkhCRkCwNiHNtrK6Gmmh4ns8BzS4OgVSetn34cUoxWrGglO+ piWNG9E83IZPNYvVCeEntlxc= X-Received: by 127.0.0.2 with SMTP id ynuvYY7687511xeCIxhbU45a; Thu, 30 Nov 2023 22:26:13 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mx.groups.io with SMTP id smtpd.web11.17061.1701411972743652420 for ; Thu, 30 Nov 2023 22:26:13 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="6690613" X-IronPort-AV: E=Sophos;i="6.04,241,1695711600"; d="scan'208";a="6690613" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2023 22:26:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="769570255" X-IronPort-AV: E=Sophos;i="6.04,241,1695711600"; d="scan'208";a="769570255" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Nov 2023 22:26:12 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 30 Nov 2023 22:26:11 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 30 Nov 2023 22:26:11 -0800 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 30 Nov 2023 22:26:11 -0800 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 30 Nov 2023 22:26:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CX4UEK++J9kd5CmWOvSWKmBvMgljkmw5mi1v8G93yuog26Nf3fM76Drz8kpwsCj24xhWOPiMsdPCyB3BqO8xW0xAJCNlK5qwbK7F89Opkjl3FOFZKs2pAOr7ek1Gv4F403FsWA8/Cx4wDWapz23ehxQ4AnCDI4j+UhY/DwXHdWYYw/BqHwMywdPGLwHHXi5doN5dcBlvN8wlpLoBu0QaanbdW3GAAlMcyalCiPQlbpcjoVvJ2mgl0eFDvX+E3xg891ERvY9oYJTBRpPKf2/euD4GgcTciyHWq0T3ZeEW1OGsZy8I+38+E7zO5h9tQ7uGCtlwEJYImIFAboBcJLiH7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OgOs4Vh/AH39ca2C4h2ktcZSTx+kvfYuOZVs5G+KBxU=; b=JbvNNET1mXFfL0QcN7Ny5T30MzL6dGSJ4QzJbvYZToeaAsk/zVSasBqu2k9zNhBTLxqZGyQTF9/gJiMiSfgzOq9zCGOi0wSxM63ylIf8z5ds+fCs4KKaPrqrSMTF2aTj61wWUfjgnpI8OtQJnUwvsMSudj0wgDBNiCsgrV/MgoCVmjwIeQsKeLLSENyKNMK4nDwPL2AsElP6n91vrvuLlKxHGzeIzIcAuHXuD3uMeuDTavKjg4Ml9Np3isUveyWQQHtPFzxsh7d5XlmpcupYWhb5b8CO/r4Ccv0LytnqI31zV8Ltq5LzObE2IhB4F+/O0rfDunCNVxXlZpcs2oeyiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from DM4PR11MB5280.namprd11.prod.outlook.com (2603:10b6:5:38b::18) by CH3PR11MB8138.namprd11.prod.outlook.com (2603:10b6:610:158::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.27; Fri, 1 Dec 2023 06:26:07 +0000 X-Received: from DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::611a:44ea:244a:3885]) by DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::611a:44ea:244a:3885%5]) with mapi id 15.20.7046.027; Fri, 1 Dec 2023 06:26:06 +0000 From: "Ashraf Ali S" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Kumar, Rahul R" , "West, Catharine" , "V, Sangeetha" Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/ResetVector: Option for 1G Page Table Size increase Thread-Topic: [PATCH] UefiCpuPkg/ResetVector: Option for 1G Page Table Size increase Thread-Index: AQHaI7OgOrqEcX0MbU2Ki4lt9R3BZbCT5vcAgAANx/A= Date: Fri, 1 Dec 2023 06:26:06 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5280:EE_|CH3PR11MB8138:EE_ x-ms-office365-filtering-correlation-id: 5891b32b-df85-463f-9152-08dbf2366657 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: nqK5MMcvgyuf4inJH/NgmxX+qq1+rSxeeR2ALeq/ZK9WavND0bzKd33ir0EDIsQOI28YaPwLpA/Fbc8DRq0QHBzo6qZhR2g8h9jCzhcclufN2eR3/sTlu5KHBehq8R7ravDAmQR4ga33RkRogp36tkwQ8/ZWFL+SAI/ISMCS+v5XZif+gKyECk6xYTbxVpeZ46tNX241r8kYBEkjDVnilchl/SzR02SpzG2N9Z9v/2TsWWYtM94ghXSj7dyKjaqoBavS5G2Eb5rqKMnsLn5iwAU+aI0UHiZE+/BFPiVVccY4OIYC7Emi4pPr9mXHooh90vpN/h6mn1cQTXZ+6hvZEqQW9C+yMc4gALAP1HuIcWAsjOi+NNjjH9lx5nH1pBUT+E0sTNcDnHNIlUshz/pwk8r8j/QaPRp26FyL1OTef6nwqY88nOzcC+2/RpKZbu+1nXF++A+mDZN1kEjfiX+6LpZwrDqoLnJg34ylftb26Gipcw1CrjM3JwguQvBe7wdtZfZcTH8ME+JSQBVQA405bs68a7asLTOW/q2xsL4vCYadHbS+b8iOQf91Iw7I5Itx/1tkt1zI+FXbexc6So7Vb3mCoQNy+Wk1bMnBPrfF2YbDAx1pa5sWwssoEDY/gLx9 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qGAixSxZxKqQb2ixX/7jtLOM5InekKMnsY83NvDHwDpQ85pu7p3/eAnwqo42?= =?us-ascii?Q?bBtXqcooMUpGzTWippYfsVE5JYy0CAAyydwRx5TzN9Jsg50rtaOPIG7T31gf?= =?us-ascii?Q?wOJvoG7kaAvdI6TU3mft1SDL4FgS1KeRMC/6RUDNSSUIH5vx3IZS+s8dyZLN?= =?us-ascii?Q?juQedH3I2/FEVL5hENE3OugaXJx6FPlFjiFo/hKNx27p14DviJnmOl35fAVC?= =?us-ascii?Q?N88SzBUaiCWIserv8EsajTv2AYEbMt5dxqt4Fm4iKJoYaYBjFHoe7WHF3i0W?= =?us-ascii?Q?SfcYYVpmf5NF01wagxeVWRfYDHIj3KXL2P9iunqMvdFAzPbwWTYkOh2TJuwB?= =?us-ascii?Q?809bO1gWJBy6/jj8Yl4jlAFOeG+M3dEZ6E3d+IuxmByQ4olYDUAT9LZRxpkL?= =?us-ascii?Q?I4HffATKFzu3pEZjkYfI/8yF6P42PcbT+KWRMA9zPrHzmXbHEy+hhM603kEh?= =?us-ascii?Q?hv6o2WfVAWeRdXHSGgo1ttKJdiL3chW8GQ2qcgFAlhA3r/7H0T4isnCtvDEJ?= =?us-ascii?Q?WyOSWUawuCQQYY2gWeI6bHeGac+aAA3/MVyaY7FjgEGLFv+18/w2wVGrB8sW?= =?us-ascii?Q?TBM30zYFf7Lq1dUZ/Mq8X2ObJ4q7D0Dno96d8/DabFECpQUP27YZBgqB92qw?= =?us-ascii?Q?YiYg6JRBpE8S54bPYi0yXl+lcRA6tjEfNQobZeCqBJnWOH0wXK/YxYwaAgzn?= =?us-ascii?Q?LmcXJbVldmaIq1Y7yPwU859yMLgcQFMbijpfkpq1lVZsnhjtWdWMIlOYVqEu?= =?us-ascii?Q?DTvB3OOEKCrTHk3C4xGVoytqv3qyKXSsVd/uB1aDZ99TwlCavROGuiqVxhDn?= =?us-ascii?Q?/cGGAmc1lnxLpvr1Bx8ayXuqhHAQzpmUgNi9/Ga0sRR01ZUUrZaMbNnqAYP+?= =?us-ascii?Q?M+fH/6uSmA1HryO7J6pgxeXzTr8/LAtbc32hsNC0MVROL4pOS4MpQqIl7zzI?= =?us-ascii?Q?pAw4Y5AN2e8hDiqZNEbaQSqISyLmwkwtbD7X1VWFZXLEH2h7KAfnT6qV20AV?= =?us-ascii?Q?i2BfvrmBvcMiLNK82R1tuVfBu3wq9Lj4Cu0Q9bJ4uw2d7Zp3CAk/nA5r/Nhr?= =?us-ascii?Q?DXwgUgoTudV2URaYTJJkl5gJX2NdqBSFwvgn/KVBw6wvNvJqA6IXn3El6PDF?= =?us-ascii?Q?MkPS6aWYJ86ztFQYb8QHbb2vnT84i8vMsMJKRLMtEZaGGHnbc2iFO8S4xmeR?= =?us-ascii?Q?BL1I0jiPyTx4Sdu7FfQYF9mHjU97FGvpW7qQiKGUHHAQfcQC2cpKMlNBBiNH?= =?us-ascii?Q?fk4neMMVta+80iMuZE7izt1ZbXp+TuBQqYHfXD1VeBUhkq9HUfzkAIvFeDFL?= =?us-ascii?Q?crWIdrqy6wVJ5CblJg+WZtgBCr1oZOuThotEkEXh6IOLo0qSzByTT96f6WXm?= =?us-ascii?Q?jOkQjrHj4HGaki3A5QtJpLAND1obailjv+CyiWNDJfgDmeuhejDSZmfpm/fR?= =?us-ascii?Q?Uq4zEdmGQPFpkchInYU+KIOM6hv3o1Azh8ZuEvuJKVoVvlc3IqUB5ZEF05su?= =?us-ascii?Q?BSv4kmX1GWbBWrD8PHaEubZ2AujVAIDI0rapNXXvYuxsbukO9/HIH6xQynQu?= =?us-ascii?Q?N9G1hD0bSX7EVlpJbM1q6lgyJQtFd+2TohnqrnNv?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5280.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5891b32b-df85-463f-9152-08dbf2366657 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2023 06:26:06.1723 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2MMJEVsN6XQUZR5QLVyHdEX+1GCWgzYkQibWhy7ZFVEIGHpk7F/CdAkCMwRV6SNqIivrdzS3afhLI82aJpdtHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8138 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ashraf.ali.s@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1940UbiBZpZM6Lt5TPqLWMPAx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=QWlB69FL; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi., Ray Yes, I agree. But if any device which needs to map above 512GB in Pre Memor= y (Early PreMem).=20 if any device mapped any device below 512GB. And if the DRAM has 512GB then= it would create a conflict. So we are not changing the default page table size, keeping 512GB only. So = that it will give room to decide the reset vector size based on the platfor= m needs. Sizes mentioned below: 512GB - 16KB 1TB - 20KB 2TB - 28KB Thanks., S, Ashraf Ali -----Original Message----- From: Ni, Ray =20 Sent: Friday, December 1, 2023 10:58 AM To: S, Ashraf Ali ; devel@edk2.groups.io Cc: Kumar, Rahul R ; West, Catharine ; V, Sangeetha Subject: RE: [PATCH] UefiCpuPkg/ResetVector: Option for 1G Page Table Size = increase Ashraf, When we implement the reset vector, we assume that 512GB page table occupie= s minimal flash size and also sufficient for XIP code. Any code that wants more page table coverage should create a new page table= , either in the temporary ram (when physical mem is not ready) or in physic= al ram. Why does this patch increase the default 512 GB coverage? Thanks, Ray > -----Original Message----- > From: S, Ashraf Ali > Sent: Friday, December 1, 2023 1:35 AM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Kumar, Rahul R=20 > ; Ni, Ray ; West, Catharine=20 > ; V, Sangeetha > Subject: [PATCH] UefiCpuPkg/ResetVector: Option for 1G Page Table Size=20 > increase >=20 > Currently 1G Page table is restricted 512GB. this patch can help to=20 > increase the page table size based on the input. default will be 512GB=20 > build option PAGE_TABLE_1G_SIZE is used to increase the page table=20 > size >=20 > Cc: Rahul Kumar > Cc: Ray Ni > Cc: Catharine West > Cc: V Sangeetha > Signed-off-by: Ashraf Ali S > --- > UefiCpuPkg/ResetVector/Vtf0/ReadMe.txt | 4 ++-- > UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf | 2 ++ > UefiCpuPkg/ResetVector/Vtf0/X64/PageTables.asm | 13 +++++++++++-- > 3 files changed, 15 insertions(+), 4 deletions(-) >=20 > diff --git a/UefiCpuPkg/ResetVector/Vtf0/ReadMe.txt > b/UefiCpuPkg/ResetVector/Vtf0/ReadMe.txt > index 4fcb15c3b1..4d153fc1a7 100644 > --- a/UefiCpuPkg/ResetVector/Vtf0/ReadMe.txt > +++ b/UefiCpuPkg/ResetVector/Vtf0/ReadMe.txt > @@ -1,10 +1,10 @@ >=20 > =3D=3D=3D HOW TO USE VTF0 =3D=3D=3D > Add this line to your DSC [Components.IA32] or [Components.X64] section: > - UefiCpuPkg/ResetVector/Vtf0/ResetVector.inf > + UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf >=20 > Add this line to your FDF FV section: > - INF RuleOverride=3DRESET_VECTOR > UefiCpuPkg/ResetVector/Vtf0/ResetVector.inf > + INF RuleOverride=3DRESET_VECTOR UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf >=20 > In your FDF FFS file rules sections add: > [Rule.Common.SEC.RESET_VECTOR] > diff --git a/UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf > b/UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf > index 6b406163db..96106a4b11 100644 > --- a/UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf > +++ b/UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf > @@ -53,5 +53,7 @@ > # -DARCH_X64, -DARCH_IA32 > # * for using 1G page table: > # -DPAGE_TABLE_1G > +# * for incresing the 1G page table size (Size in GBs): > +# -DPAGE_TABLE_1G_SIZE=3D1024 > # * for different debug channels: > # -DDEBUG_SERIAL, -DDEBUG_PORT80, or not specify any debug channel > diff --git a/UefiCpuPkg/ResetVector/Vtf0/X64/PageTables.asm > b/UefiCpuPkg/ResetVector/Vtf0/X64/PageTables.asm > index 7960b141be..b080dc5296 100644 > --- a/UefiCpuPkg/ResetVector/Vtf0/X64/PageTables.asm > +++ b/UefiCpuPkg/ResetVector/Vtf0/X64/PageTables.asm > @@ -1,7 +1,7 @@ > =20 > ;--------------------------------------------------------------------- > --------- > ; @file > ; Emits Page Tables for 1:1 mapping. > -; If using 1G page table, map addresses 0 - 0x8000000000 (512GB), > +; If using 1G page table, map addresses 0 - 0x8000000000 (512GB, Size=20 > +can > be increse via PAGE_TABLE_1G_SIZE), > ; else, map addresses 0 - 0x100000000 (4GB) ; ; Copyright (c) 2021=20 > - 2023, Intel Corporation. All rights reserved.
> @@ -39,6 +39,15 @@ BITS 64 > %define PAGE_PDPTE_1GB(x) ((x << 30) + PAGE_BLE_ATTR) %define=20 > PAGE_PDE_2MB(x) ((x << 21) + PAGE_BLE_ATTR) >=20 > +%ifdef PAGE_TABLE_1G_SIZE > + %define PAGE_PDPTE_1GB_SIZE PAGE_TABLE_1G_SIZE %else > + ; > + ; Default 512GB of 1G Page Table > + ; > + %define PAGE_PDPTE_1GB_SIZE 512 > +%endif > + > ALIGN 16 >=20 > %ifdef PAGE_TABLE_1G > @@ -47,7 +56,7 @@ Pdp: > ; Page-directory pointer table (512 * 1GB entries =3D> 512GB) > ; > %assign i 0 > - %rep 512 > + %rep PAGE_PDPTE_1GB_SIZE > DQ PAGE_PDPTE_1GB(i) > %assign i i+1 > %endrep > -- > 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111971): https://edk2.groups.io/g/devel/message/111971 Mute This Topic: https://groups.io/mt/102898657/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-