Re: [PATCH v2 2/2] UefiCpuPkg: ResetVector Tool additional debug prints

["Ashraf Ali S" <ashraf.ali.s@intel.com>]

Hi.,

Is this Patch Uploaded in GitHub?

Regards,
Ashraf Ali S
Intel Technology India Pvt. Ltd. 

-----Original Message-----
From: Ni, Ray <ray.ni@intel.com> 
Sent: Tuesday, July 27, 2021 10:42 AM
To: S, Ashraf Ali <ashraf.ali.s@intel.com>; devel@edk2.groups.io
Cc: Kumar, Rahul1 <rahul1.kumar@intel.com>; De, Debkumar <debkumar.de@intel.com>; Han, Harry <harry.han@intel.com>; West, Catharine <catharine.west@intel.com>; V, Sangeetha <sangeetha.v@intel.com>
Subject: RE: [PATCH v2 2/2] UefiCpuPkg: ResetVector Tool additional debug prints

Reviewed-by: Ray Ni <ray.ni@Intel.com>

> -----Original Message-----
> From: S, Ashraf Ali <ashraf.ali.s@intel.com>
> Sent: Friday, July 23, 2021 4:40 PM
> To: devel@edk2.groups.io
> Cc: S, Ashraf Ali <ashraf.ali.s@intel.com>; Ni, Ray 
> <ray.ni@intel.com>; Kumar, Rahul1 <rahul1.kumar@intel.com>; De, 
> Debkumar <debkumar.de@intel.com>; Han, Harry <harry.han@intel.com>; 
> West, Catharine <catharine.west@intel.com>; V, Sangeetha 
> <sangeetha.v@intel.com>
> Subject: [PATCH v2 2/2] UefiCpuPkg: ResetVector Tool additional debug 
> prints
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3506
> 
> Before executing the nasm command, added print statement to know what 
> commands are executing.
> before printing the output file need check the status of command which 
> is executed. if the status is 0 then only print the output file name.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Cc: Debkumar De <debkumar.de@intel.com>
> Cc: Harry Han <harry.han@intel.com>
> Cc: Catharine West <catharine.west@intel.com>
> Cc: Sangeetha V <sangeetha.v@intel.com>
> Signed-off-by: Ashraf Ali S <ashraf.ali.s@intel.com>
> ---
>  UefiCpuPkg/ResetVector/Vtf0/Build.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/UefiCpuPkg/ResetVector/Vtf0/Build.py 
> b/UefiCpuPkg/ResetVector/Vtf0/Build.py
> index 55f4edd87b..b791d32762 100644
> --- a/UefiCpuPkg/ResetVector/Vtf0/Build.py
> +++ b/UefiCpuPkg/ResetVector/Vtf0/Build.py
> @@ -32,9 +32,12 @@ for arch in ('ia32', 'x64'):
>              '-o', output,
>              'Vtf0.nasmb',
>              )
> +        print(f"Command : {' '.join(commandLine)}")
>          ret = RunCommand(commandLine)
> +        if ret != 0:
> +            print(f"something went wrong while executing {commandLine[-1]}")
> +            sys.exit()
>          print('\tASM\t' + output)
> -        if ret != 0: sys.exit(ret)
> 
>          commandLine = (
>              'python',
> --
> 2.30.2.windows.1